Age | Commit message (Collapse) | Author |
|
TBR=dsinclair@chromium.org
BUG=chromium:605491
Original Review: https://codereview.chromium.org/1910143002
Review URL: https://codereview.chromium.org/1915053006 .
|
|
BUG=591137
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1769183002 .
(cherry picked from commit 258f19f26b3ccfc6b64429111a4a11bdc64be131)
Review URL: https://codereview.chromium.org/1869233002 .
|
|
This reverts commit 1a35d55dd6b0d1ea1918e2d6a6c25faf599ba168.
Prevent handles from being destructed after v8 is gone.
BUG=pdfium:419,600777
Original Review URL: https://codereview.chromium.org/1761073006 .
(cherry picked from commit 297b515e3d53095e36991480a194b54ce887757b)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1861813002 .
|
|
is destroyed.""
Fix the destruction order.
This reverts commit 129a60ec2d4d98ed953beaca629c99a52fb7e9b0.
BUG=594120
Original Review URL: https://codereview.chromium.org/1831723004 .
(cherry picked from commit 9967cc5861fbff894eed8fca40e1e5ed524b04c6)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1860133002 .
|
|
Fix an incorrect unit test result.
This reverts commit 2df269c52741c12d63300cee806e96ae5d0b038f.
TBR=tsepez@chromium.org
Original Review URL: https://codereview.chromium.org/1803043002 .
(cherry picked from commit 3cc180234c14639d408003c8180ba2963f0ea665)
Review URL: https://codereview.chromium.org/1816183002 .
|
|
Original Review URL: https://codereview.chromium.org/1763443003 .
(cherry picked from commit f3e3af606958855c9345dd3aba13e75f0b879193)
TBR=dsinclair@chromium.org, ochang@chromium.org
BUG=pdfium:424
BUG=592730
Review URL: https://codereview.chromium.org/1775933003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1740103002 .
|
|
They buy us nothing and obfuscate the logic.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740223002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1725303003 .
|
|
Do some cleanups along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1732223002 .
|
|
This does not appear to ever be defined. There are a few methods which end up
being empty after this change, removed those and their callers as well.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1736133002 .
|
|
Remove the define and the #ifdef checks.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1741543002 .
|
|
The fde_memory.h include wasn't needed. This CL converts the
FDE_NewWith and FDE_DeleteWith calls to their FXTARGET_
counterparts.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736053002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740863002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1740643002 .
|
|
Fix misc issues along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1739623002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735353002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1735333002 .
|
|
And other nearby dead code.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1740613002 .
|
|
Get rid of types; use virutal functions instead of type based checking;
remove unused functions; change casts; simplify load()/UnicodeFromCharCode()/CharCodeFromUnicode() calling.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1729823004 .
|
|
Add default ctor so we don't have to zero these out.
Also, make CFX_VTemplate simpler.
Also, remove the Set() method in favor of assignment.
Also, remove CFX_FloatPoint define.
Also, remove unused (and wrong) CFX_VTemplate methods.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733523003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740783002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740633004 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1738983002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735833003 .
|
|
Also fix IWYU in various fxbarcode headers.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1734823002 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1734593004 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1729983002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1726373002 .
|
|
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1725133004 .
|
|
Missed one remaining use of FGAS_LPCFONTUSB.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735623003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735663002 .
|
|
mac. Now the minimal version is 10.10.
This reverts commit ad8dfc5fe0b5d726632b71919426c1efeb33c567.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735653002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730893003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1731483004 .
|
|
These are in third_party libraries so should be fixed upstream. Silencing the
warning in our build.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1734663002 .
|
|
Two files become completely empty and are deleted.
Oddly, they never appeared in gyp/gn files.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1724303002 .
|
|
This header just includes other headers, remove file and callsites.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1734683002 .
|
|
This Cl changes the definition of FX_WORD and FX_DWORD to use the stdint
types. This will allow changing the uses on a directory basis to the
stdint types.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1727203002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733693002 .
|
|
Renaming these files will allow them to be picked up by git cl format and the
linter.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733653002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1724193005 .
|
|
This CL enables several of the diabled whitelist/* lint checks.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730553002 .
|
|
Also remove another CFX_ArrayTemplate usage.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730753002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730713002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1725033002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1725673002 .
|
|
BUG=
R=thakis@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1680943003 .
|
|
This is a wrapper which does (a) * (b) / (c). Inline the operations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1726893002 .
|
|
This is just a wrapper for (a) / (b). Inline the divide.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1727793002 .
|