summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-03-04Re-land "Only place primitive objects on the V8 global template."Tom Sepez
This reverts commit 1a35d55dd6b0d1ea1918e2d6a6c25faf599ba168. Prevent handles from being destructed after v8 is gone. BUG=pdfium:419 R=ochang@chromium.org Review URL: https://codereview.chromium.org/1761073006 .
2016-03-04Try again to suppress mac warnings.Tom Sepez
TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1766043002 .
2016-03-04Remove V8_DEPRECATION_WARNINGS for mac/xfaTom Sepez
TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1768693002 .
2016-03-04Revert "Only place primitive objects on the V8 global template."Tom Sepez
This reverts commit 3e44a7bd2b60ace1ee8bc8f48c709056f65c3dc1. R=ochang@chromium.org TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1767793002 .
2016-03-04Only place primitive objects on the V8 global template.Tom Sepez
Kill some crummy comments along the way. BUG=pdfium:419 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1759893002 .
2016-03-04Try again to suppress mac deprecation warnings.Tom Sepez
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1770473002 .
2016-03-04Suppress same windows warnings in xfa.gypTom Sepez
See https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/178070/steps/compile%20%28with%20patch%29/logs/stdio R=ochang@chromium.org Review URL: https://codereview.chromium.org/1770453002 .
2016-03-04Small change to enable skia-backed version of pdfium.Cary Clark
This only directs paths to use Skia. Text and bitmaps still use antigrain. Clipping is disabled -- still figuring out pdfium's model for saving and restoring clips. Deleting the Skia canvas is disabled -- there's some build problem where the pdfium and skia libraries are built with slightly different options that I haven't tracked down. This is also why for the moment SkDebugf is defined locally. With this patch and pdf_use_skia=1 a modestly complicated PDF draws (mostly) correctly with pdfium_test. R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair BUG= Review URL: https://codereview.chromium.org/1761453002 .
2016-03-04Fix deprecated ObjectTemplate::New() and TryCatch() warnings.Tom Sepez
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1762643003 .
2016-03-03Combine StrToInt methods.Dan Sinclair
This Cl combines the two StrToInt implementations. In doing so I had to add some more overrides to toDecimalDigit() and add a isDecimalDigit(). BUG=pdfium:423 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1757283002 .
2016-03-03Add option to GYP to use chromium clang plugins.Dan Sinclair
This CL will enable the chromium-style checks when building. It is currently disabled by default as there are a lot of warnings. I only added this to GYP because there is no standalone GN build, so I have no way to test. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1760213002 .
2016-03-03Fixup chromium-style warnings in fpdf_objects.hDan Sinclair
This CL fixes up chromium-style warnings in fpdf_object.h Specifically, the warnings fixed were: * Complex constructor has an inlined body. * Complex destructor has an inline body. * virtual methods with non-empty bodies shouldn't be declared inline. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1764793002 .
2016-03-03Suppress deprecation warnings for XFA.chromium/2667Tom Sepez
Temporary measure until FX fixes these (or I do). This is blocking rolling XFA into chrome. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1764503003 .
2016-03-03Remove other remaining use of std::list::size() from loop body.Tom Sepez
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1761993002 .
2016-03-03Fix infinite loop for bookmark searchWei Li
BUG=pdfium:420 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1757373002 .
2016-03-03Add JS tests for global const equality.Tom Sepez
Add these tests before fixing bug 419. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1761923002 .
2016-03-03Fix O(n^2) behaviour in parser.Tom Sepez
Despite what the c++11 spec says, std::list::size() is still O(n), not O(1). R=dsinclair@chromium.org, ochang@chromium.org Review URL: https://codereview.chromium.org/1763443003 .
2016-03-03Don't allow empty expression in CXFA_FMParse::ParseParenExpression.Oliver Chang
BUG=pdfium:404 R=jun_fang@foxitsoftware.com, tsepez@chromium.org Review URL: https://codereview.chromium.org/1742903002 .
2016-03-03Some cleanup for xfa_expression/xfa_simpleexpressionOliver Chang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1764473002 .
2016-03-03Fix parsing of object numbers > 16,777,216.Dan Sinclair
Currently, there is a check that an object number is <= 0x1000000. If that check fails, we end up putting the parser into a bad state and fail to load documents. The object does not need to be in the XRef table, or referenced from the document, just be in the document. This Cl removes the size check and updates the various atoi calls to use a uint32_t instead of an int32_t so we don't end up getting strange values when converting from a string. BUG=455199 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1755273002 .
2016-03-03Remove unnecessary codeZhiwei Lin
BUG=pdfium:421 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1758643002 .
2016-03-02Don't load GDI+ if GDI is disabled.chromium/2666Tom Sepez
This is to fix an issue when win32k lockdown is enabled on PDF content which can cause application crashes. If GDI is disabled then there's little benefit to loading the GDI+ library. BUG=583038 Patch by forshaw@ R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1748163006 .
2016-03-02Check that the names buffer is not empty before passing to GetNameFromTT.Tom Sepez
Due to implicit conversion if the names buffer is empty then nullptr will be passed to GetNameFromTT which blindly dereferences it leading to a NPD if an invalid font file is read. BUG=583037 Patch by forshaw@ R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1763493003 .
2016-03-02Rename png_ functions conflicting with chrome.Tom Sepez
Part of the work required to ship XFA with chrome. BUG=pdfium:396 R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1763493002 .
2016-03-02Remove unused CFX_GrowOnlyPool.dan sinclair
The CFX_GrowOnlyPool class is never used, removed. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1757043002 .
2016-03-01Remove implicit conversions and some cleanupWei Li
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1751753002 .
2016-03-01Fix and enable lint checks.Dan Sinclair
This CL fixes and enables: * readability/namespace * readability/multiline_string * readability/multiline_comment * readability/inheritance * readability/function * readability/braces R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1747123002 .
2016-03-01Replace FX_LPCRECT typedef with underlying typesTom Sepez
Helps with transparency. Also remove default args and use override consistently in the affected methods. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1751093002 .
2016-03-01Add myself to AUTHORS file.Dan Sinclair
I assumed there was a *@chromium.org entry in there, so never looked. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1754763002 .
2016-03-01This Cl adds some whitespace and other formatting while removing some braces ↵Dan Sinclair
and making bits of the code simpler. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1742273002 .
2016-03-01Remove _FX_WINAPI_PARTITION_DESKTOP_Dan Sinclair
This does not appear to ever be defined, remove. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1753723002 .
2016-03-01Remove FX_NUM_DOUBLEDan Sinclair
This is never defined in the current code base. Remove. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1751913002 .
2016-03-01Remove XFA_PARSE_HAS_LINEIDENTIFIERDan Sinclair
This flag is always defined, remove conditional code and flag. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1752503004 .
2016-03-01Remove _XFA_EMBDan Sinclair
The _XFA_EMB flag is never defined, remove conditionals. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1751033002 .
2016-03-01Cleanup some fsdk_common definesDan Sinclair
* FIELDFLAG_DONOTSPELLCHECK is defined on line 20. * 1 << 25 is used by FIELDFLAG_RICHTEXT already. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1745263002 .
2016-02-29Add CFX_FloatRect::ToFxRect().Tom Sepez
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1752543002 .
2016-02-29Remove fx_fpf.h and IWYUDan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1748803002 .
2016-02-29Pass rect by const reference in SetClip_Rect().Tom Sepez
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1745243002 .
2016-02-29Remove xfa_fm2js.h and IWYU.Dan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1745023003 .
2016-02-29Remove foxitlib.h and foxitxfa.h and IWYU.Dan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1746053003 .
2016-02-29Speculative fix for windows broken at d5e7b355b8c4.Tom Sepez
I'm guessing that |small| is #defined somewhere. TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1746243002 .
2016-02-29Fixup FX_RECT and FX_SMALL_RECT classes.Tom Sepez
Put these first, so later on more complicated classes can have constructors that take these as arguments. Add better constructors, and call appropriately. Also don't be afraid to return these from methods since RVO. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1745683002 .
2016-02-29Using size_t to silence warnings.Dan Sinclair
Change a couple int32_t's to size_t in order to fix warnings on OSX. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1747793002 .
2016-02-29Remove fgas_base.h and IWYUDan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1749703002 .
2016-02-29Remove _XFA_LAYOUTITEM_* defines.Dan Sinclair
The _XFA_LAYOUTITEM_ProcessCACHE_ define is always set and the _XFA_LAYOUTITEM_MAPCACHE_ define is never set. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1750623002 .
2016-02-29Remove #if 0 code.Dan Sinclair
This code is dead, remove it. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1746793002 .
2016-02-29Remove _FX_USEGASFONTMGR_ as it is always definedDan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1749793002 .
2016-02-29Remove #ifdef _FXEMB as it is not definedDan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1749783002 .
2016-02-29Remove wParentIndex from XFA_ELEMENTHIERARCHY.Dan Sinclair
This value is never set and never read. Removing it fixes a series of warnings when building on OSX as g_XFAElementPropertyIndex does not initialize the value. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1744893002 .
2016-02-29Add missing field initializers to g_PredefinedCMaps.Dan Sinclair
This CL adds some missing initializers for m_LeadingSegCount and m_LeadingSegs. This silences a series of warnings on OSX. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1744903002 .