summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-06-02Replace XFA_HWIDGET with IXFA_Widget*Tom Sepez
A second case of casting willy-nilly between unrelated structures to provide information hiding. Bad Idea. Remove dozens of casts in the process. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1155273002
2015-06-01Get test running scripts to detect and report common error, XFA.Bruce Dawson
testing/tools/run_corpus_tests.py assumes a debug build and will fail cryptically if only a release build is available. Arguably there shouldn't be a default because having one could lead to accidentally running a stale version, but that is probably too much of a change. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1150823003 Review URL: https://codereview.chromium.org/1158883005
2015-06-01Add missing comma to third_party.gyp, integrated to XFABruce Dawson
Original change by bungeman@chromium.org A reference to nonstd_unique_ptr.h was added with https://codereview.chromium.org/1091283002 but a comma is missing after it. This causes this string to be concatenated with the next, leading to broken sources. This went unnoticed by the build due to the fact that the affected sources are both headers, but they should be properly separated. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1156663006 Review URL: https://codereview.chromium.org/1156483006
2015-05-28Merge to XFA: Fix ALL the include guards.Tom Sepez
Original Review URL: https://codereview.chromium.org/1160443004 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1162013003
2015-05-27Replace XFA_HDOC with IXFA_Doc*Tom Sepez
There are better ways to provide information hiding than casting willy-nilly from an unrelated structure. Kill dozens of casts in the process. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1146153005
2015-05-27Merge to XFA: Remove rendundant ../include from paths.Tom Sepez
Original Review URL: https://codereview.chromium.org/1162453003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1154613005
2015-05-27Make CPDFXFA_App / IXFA_AppProvider sanerTom Sepez
Move interface comments from the implementation header to the interface header. Replace Create / Release functions with static methods. Replace dubious Release() methods with deletion via virtual dtor, also for IXFA_App and IXFA_FontMgr while we're at it. Untabify and fix (theoretically) illegal _CAP include guard definitions for fpdfxfa/ headers. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1153553003
2015-05-26Merge to XFA: Upgrade openjpeg to r3002JUN FANG
BUG=459215 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1160663002
2015-05-21Merge to XFA: Update copy of safe_math_impl.h to take a fix from upstream.Tom Sepez
Original Review URL: https://codereview.chromium.org/1126243007 BUG=488302 TBR=eroman@chromium.org Review URL: https://codereview.chromium.org/1153543003
2015-05-21Merge to XFA: Fix four annoying warnings.Tom Sepez
Original Review URL: https://codereview.chromium.org/1148353002 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1150103002
2015-05-21Merge to XFA: Fix an endless loop in CJBig2_HuffmanTable::parseFromCodedBufferJUN FANG
This issue is trigged by the conversion from unsigned int to signed int. A large unsigned int is converted to int. It's represented as a negative int which is used in the condition of while later. BUG=482639 R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1146913003
2015-05-20Merge to XFA: Integer overflow in CJBig2_Image::expandJUN FANG
1. New size should be larger than old size in JBig2_Realloc. 2. Arguments are integers but parameters are size_t in JBIG2_memset. After integer overflows, it will be presented as a huge unsigned number on 64 bits system. BUG=483981 R=brucedawson@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1148643002
2015-05-20Merge to XFA: Tidy public fpdfview.h and fpdf_flatten.h.Tom Sepez
Original Review URL: https://codereview.chromium.org/1139993003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1144973004
2015-05-20Merge to XFA: Remove FX_Alloc() null checks now that it can't return NULL.Tom Sepez
Original Review URL: https://codereview.chromium.org/1142713005 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1143663008
2015-05-20Fix compilation on xfa branch and turn on v8 deprecation warningsJochen Eisinger
R=vogelheim@chromium.org BUG= Review URL: https://codereview.chromium.org/1142293003
2015-05-19Merge to XFA: Fix Heap Overflow in CJBig2_Image::expandJUN FANG
Integer overflow in CJBig2_Image::expand. It causes the size of reallocated is not expected. BUG=483981 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1131023008
2015-05-18Merge to XFA: Cleanup if early return from ↵Tom Sepez
opj_j2k_copy_default_tcp_and_create_tcd(). Original Review URL: https://codereview.chromium.org/1138033007 BUG=486538 TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1142133002
2015-05-19Merge V8 API updates to xfa branchJochen Eisinger
Set pointers in internal fields directly instead of wrapping them Review URL: https://codereview.chromium.org/1139853003 Use phantom handles instead of weak handles Review URL: https://codereview.chromium.org/1129253004 Replace deprecated with non-deprecated V8 APIs Review URL: https://codereview.chromium.org/1126203010 Add myself to OWNERS file Review URL: https://codereview.chromium.org/1133333005 Replace v8::Handle with v8::Local and v8::Persistent with v8::Global Review URL: https://codereview.chromium.org/1138823004 TBR=tsepez@chromium.org BUG= Review URL: https://codereview.chromium.org/1140033004
2015-05-18Merge to XFA: Change FX_Alloc to FX_Try_Alloc in _JpegEncodeJUN FANG
This CL is used for: 1. keeping the same logic as before (the behaviour of FX_Alloc was changed for OOM). 2. fixing a potential integer overflow. BUG=N/A R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1126013006
2015-05-18Merge to XFA: Add safe FX_Alloc2D() macroTom Sepez
Original Review URL: https://codereview.chromium.org/1143663004 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1136673005
2015-05-15Merge to XFA: Abort on OOM by default in FX_Alloc().Tom Sepez
Original Review URL: https://codereview.chromium.org/1128043009 Original Review URL: https://codereview.chromium.org/1142463005 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1144683002
2015-05-15Merge to XFA: Fix leaks in embedder test's FlateEncode() usage and in ↵Lei Zhang
FlateEncode(). For FlateEncode(), error handling code leaked memory. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1144603002 (cherry picked from commit 1962d61b28df03284e3e5c6de6a19f397a066e68) Review URL: https://codereview.chromium.org/1125413008
2015-05-15Merge to XFA: Initialize members of CPDF_TextPageFind class.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1137933004 (cherry picked from commit acae9257203971ee1e34d8d7573b7ba9a50041af) BUG= Review URL: https://codereview.chromium.org/1135793003
2015-05-15Merge to XFA: Fix leaks in the embedder tests themselves.Lei Zhang
Also change EmbedderTest::TearDown() to match the destruction order in Chromium's PDF code. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1138143003 (cherry picked from commit 61ffad8df484ab9b3f7d2f5519ec470fbc023b88) Review URL: https://codereview.chromium.org/1138973004
2015-05-15Merge to XFA: Remove FX_NEW_VECTOR() macros.Tom Sepez
Original Review URL: https://codereview.chromium.org/1135273004 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1134003007
2015-05-15Merge to XFA: Fix potential UAF in ConcatInPlace.Tom Sepez
Original Review URL: https://codereview.chromium.org/1130763007 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1123333004
2015-05-14Merge to XFA: Make CFX_StringData be scoped by CFX_Bytestring and add methods.Tom Sepez
Original Review URL: https://codereview.chromium.org/1142533002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1135673003
2015-05-13Code alignment in issue 471991JUN FANG
BUG=471991 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1126273004
2015-05-13Fix integer overflow in conversion from float to integer.JUN FANG
BUG=471991 R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1141613002
2015-05-13Merge to XFA: Tidy public/ directory.Tom Sepez
Original Review URL: https://codereview.chromium.org/1128003005 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1140653004
2015-05-13Fix a global buffer overflow issue in ↵JUN FANG
CXFA_ItemLayoutProcessor::CalculatePositionedContainerPos BUG=471991 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1138993002
2015-05-13Merge to XFA: Fix comparison of CFX_ByteString and CFX_WideString.Tom Sepez
Original Review URL: https://codereview.chromium.org/1141763002 BUG=pdfium:160 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1140093003
2015-05-12Merge to XFA: Make (and verify) public/ files compile under C.Tom Sepez
The following files needed adjustment beyond a mechanical merge: fpdfsdk/src/fpdfview.cpp public/fpdf_formfill.h samples/pdfium_test.cc testing/embedder_test.cpp Original Review URL: https://codereview.chromium.org/1130843003 BUG=pdfium:158 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1137233002
2015-05-12Merge to XFA: Describe required properties of public/ files with a README.Tom Sepez
Original Review URL: https://codereview.chromium.org/1140833002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1128863005
2015-05-12Merge to XFA: Restore checked strlen conversions.Tom Sepez
Original Review URL: https://codereview.chromium.org/1133323003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1130903005
2015-05-12Merge to XFA: NEW public API for pdfwindow font manipulation.Tom Sepez
Original Review URL: https://codereview.chromium.org/1126283004 BUG=486818 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1137163002
2015-05-11Merge to XFA: Add owners file for PDFium.Tom Sepez
Original Review URL: https://codereview.chromium.org/1136533003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1139673006
2015-05-11Merge to XFA: Create top-level public/ header directory.Tom Sepez
Original Review URL: https://codereview.chromium.org/1135913002 BUG=pdfium:154 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1136703003
2015-05-08Merge to XFA: Fix a bunch of -Wunused-but-set-variable warnings.Lei Zhang
Also fix a few nits and other errors along the way. Review URL: https://codereview.chromium.org/1098583002 Review URL: https://codereview.chromium.org/1135713004 (cherry picked from commit f0a169e6fd5718995fa6ef8749c8d16cdad84985) (cherry picked from commit 470408c2ffe71e99cebad0d1d6887f1723f02cef) R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1133453006
2015-05-08Merge to XFA: Move function prototypes to new doc_utils.h fileTom Sepez
Original Review URL: https://codereview.chromium.org/1128193004 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1137783002
2015-05-08Merge to XFA: Fix compilation under chromium checkouts.Tom Sepez
Original Review URL: https://codereview.chromium.org/1132163002 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1128933004
2015-05-08Merge to XFA: Better error from pdfium_test when page too big to render.Tom Sepez
Original Review URL: https://codereview.chromium.org/1124423006 BUG=pdfium:114 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1137753003
2015-05-07Merge to XFA: Make CFX_StockFontArray more robust.Lei Zhang
- Check bounds when accessing array. - Remove potential memory leak. - Merge duplicate code. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1094763002 (cherry picked from commit ee2fe42f9bf3ac6afc4f05f79629a3e34179a2b9) Review URL: https://codereview.chromium.org/1128803003
2015-05-06Merge to XFA: Support arrays in nonstd::unique_ptr<>.Tom Sepez
Original Review URL: https://codereview.chromium.org/1130053003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1124353002
2015-05-06Merge to XFA:Remove FX_STRSIZE casts, use safe conversionsTom Sepez
Original Review URL: https://codereview.chromium.org/1124043003 BUG=pdfium:153 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1132443002
2015-05-06Merge to XFA: Fix a couple of divide by zero crashes in PNG/TIFF predictors.Lei Zhang
BUG=484002 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1124563002 (cherry picked from commit 6ab919ff310fb02bab8cf43d92a5553b11cbbb61) Review URL: https://codereview.chromium.org/1130903002
2015-05-06Merge to XFA: Replace FX_NEW with new, remote tests from fxcodecLei Zhang
Review URL: https://codereview.chromium.org/1084303002 (cherry picked from commit cfc1a654ef3e8b65bc447815d35932c185bf1422) R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1125363002
2015-05-06Merge to XFA: Replace FX_NEW with new, remove tests from fpdfapiLei Zhang
Very few places where a change is required, but remove FX_NEW to show they've been audited. Review URL: https://codereview.chromium.org/1075953004 (cherry picked from commit 5c357a5d3d873be6b0ab01d7bec82f79d0a09f0e) R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1125183006
2015-05-06Merge to XFA: Fix a regression with cut off images.Lei Zhang
This regressed in commit 3f41851 due to shadow variables. BUG=478164 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1101443004 (cherry picked from commit 97d10aff654e42c1b7c3d2abf33fbcf8d341799e) Review URL: https://codereview.chromium.org/1127163003
2015-05-06Merge to XFA: Fix fx_string.h compile error under chromium checkouts.Tom Sepez
Original Review URL: https://codereview.chromium.org/1127043004 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1131553005