Age | Commit message (Collapse) | Author |
|
One trivial conflict in fsdk_mgr.h
Review URL: https://codereview.chromium.org/1658853002 .
(cherry picked from commit 1654972e0c81f1841653f803903cc48b93f1738e)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1651313002 .
|
|
Use the gennum field in the m_ObjectInfo map instead.
BUG=pdfium:111
R=weili@chromium.org
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1654303002 .
(cherry picked from commit a620372c9e1d0ff825bcbe6620fe7e1b63c769c2)
Review URL: https://codereview.chromium.org/1653023004 .
|
|
Use the type field in the m_ObjectInfo map instead.
BUG=pdfium:111
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1650793002 .
(cherry picked from commit 93c196d868535f684007a7d3ed1f7146851a0ab9)
Review URL: https://codereview.chromium.org/1652083004 .
|
|
Original Review URL: https://codereview.chromium.org/1652613002 .
(cherry picked from commit 0841b0f37678ba4962247f5636e9390718fc027e)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1657663003 .
|
|
Original Review URL: https://codereview.chromium.org/1654523002 .
(cherry picked from commit 3859258ebe9e81e1f766b57e7f78c786ae4ed495)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1658753002 .
|
|
Review URL: https://codereview.chromium.org/1650623004 .
(cherry picked from commit 56d618ac9b4c82a9a350f21bbc6ec2ec6a95c8b0)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1657533004 .
|
|
- Generalise GetBits8()
- Get rid of C-style casts.
- Make CFX_DIBSource::SetDownSampleSize() non const. It's only overriden
once and called in one place and it doesn't make sense for it to be const.
- Get rid of a macro
- Make public member vars of CPDF_DIBSource private
- And others...
TBR=thestig@chromium.org
Original Review URL: https://codereview.chromium.org/1644403003 .
(cherry picked from commit 487935f662ba4711caf1c2c06873b676fd3fba3e)
Review URL: https://codereview.chromium.org/1649243002 .
|
|
Mainly use virtual functions to replace functions with switch statements.
Also remove a few unused functions and make some format changes.
BUG=pdfium:63
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634373003 .
(cherry picked from commit df1ab41e000069dda7bf21527308f3bf41e126ca)
Review URL: https://codereview.chromium.org/1650493003 .
|
|
- Remove dead code.
- Add more public methods and remove friends.
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1566133002 .
(cherry picked from commit 9e8185948f7631515951770ca8778f42cc9fd2fc)
Review URL: https://codereview.chromium.org/1649233002 .
|
|
Original Review URL: https://codereview.chromium.org/1645413002 .
(cherry picked from commit 6902db5cbaf0afb8f2cb4df325e1a4e7d6acd53f)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1648793006 .
|
|
Original Review URL: https://codereview.chromium.org/1652533002 .
(cherry picked from commit 1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1652543003 .
|
|
This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1644633003 .
(cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b)
Review URL: https://codereview.chromium.org/1648233002 .
|
|
BUG=581960
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1648283003 .
(cherry picked from commit b0b6373e685e0591fb47fe6cb90e767728241e7f)
Review URL: https://codereview.chromium.org/1650553003 .
|
|
Original Review URL: https://codereview.chromium.org/1641693003 .
(cherry picked from commit 66519af52b61ca158044651d0507d47efb364f87)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1639253008 .
|
|
BUG=pdfium:348
R=jochen@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1633083002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1647613003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1641963002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1640033002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636873004 .
|
|
kGray and such are much safer.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1638093002 .
|
|
Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634123004 .
|
|
Original Review URL: https://codereview.chromium.org/1635173003 .
(cherry picked from commit 0ec8bb4486ab315283f36d071be2ddc1b80998c3)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636133002 .
|
|
Contains additional XFA-specific changes.
Original Review URL: https://codereview.chromium.org/1632143002 .
(cherry picked from commit 66a9dc9dd65ed2b9c7ede448d046b770140f16d5)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636503006 .
|
|
BUG=pdfium:367
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1620813003 .
|
|
And a few other nits.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1635853002 .
|
|
Unfortunately, it is still used on the xfa/ side, so
exclude it only for non-xfa builds.
Original Review URL: https://codereview.chromium.org/1618273004 .
(cherry picked from commit c64e4007ee4561ec2ed3ce986191caf9b024ef55)
TBR=ochang@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1631863003 .
|
|
unused progressive enum
unused members m_bFileStream, m_dwWordPos
Remove PDFWORD_* types
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634683003 .
|
|
Its members are assigned to, but never used in any calculations
(besides for other members).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1630973002 .
|
|
Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.
Also, PDFPARSE_NOSTREAM is unused.
Then we can remove m_Flags from PARSE_CONTEXT.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1638493002 .
|
|
This is a regression from commit 90853cb.
BUG=pdfium:365
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1617043004 .
(cherry picked from commit 7671d304ca4d3aec658c0ac8d5eea4c64e23b144)
Review URL: https://codereview.chromium.org/1628643002 .
|
|
Original Review URL: https://codereview.chromium.org/1618693009 .
(cherry picked from commit c818b5fc6cca9a7e1a2851b30e8a34f652ab0ea9)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1629593002 .
|
|
Original Review URL: https://codereview.chromium.org/1620523002 .
(cherry picked from commit d5712ac571f3487fe3f74617fdab007a11a09052)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1624553004 .
|
|
Orignal Review URL: https://codereview.chromium.org/1612113003 .
(cherry picked from commit 9ebc84109d7d2f7b81f06f19e5db20888e026c3b)
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1612243002 .
|
|
Original Review URL: https://codereview.chromium.org/1601093009 .
(cherry picked from commit da9355139b5dce270be02af31db326d60f488e8c)
Trivial conflicts/changes in fpdfeditpage.cpp and fpdfxfa_page.cpp.
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1613823003 .
|
|
Original Review URL: https://codereview.chromium.org/1611193003 .
(cherry picked from commit ca6d98f4dfe7d4fc506b72c91f122f471a53c878)
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1613163003 .
|
|
Original Review URL: https://codereview.chromium.org/1610303002 .
(cherry picked from commit f409da4b8a3e6a3885605a47bed4f8798c4703b9)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611733002 .
|
|
Original Review URL: https://codereview.chromium.org/1580573002 .
(cherry picked from commit a505d9d3e13485e090e50d5d83f882fb707d3f48)
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1610163003 .
|
|
Original Review URL: https://codereview.chromium.org/1580493002 .
(cherry picked from commit 2a312f90dbf5da8b930dee814db786965792961a)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611683002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1573243003 .
|
|
Small tidying.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1601023004 .
|
|
Original Review URL: https://codereview.chromium.org/1586203006 .
(cherry picked from commit f13d510cf267c27f4c123494de67670ec201cedc)
BUG=pdfium:361
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1603173004 .
|
|
BUG=pdfium:354
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1580773002 .
|
|
BUG=pdfium:350
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1608593003 .
|
|
BUG=pdfium:332
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1539193003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1581823002 .
|
|
TBR=weili@chromium.org
Original Review URL: https://codereview.chromium.org/1602323002 .
(cherry picked from commit b196c7bebad66c9938d2705ccf64961bcdd774e2)
Review URL: https://codereview.chromium.org/1607473008 .
|
|
Review URL: https://codereview.chromium.org/1607923004 .
(cherry picked from commit d40e189ba1ab515ef9b3df7928e215be150df336)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1607113002 .
|
|
This is to avoid a compilation warning.
R=thakis@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1607053003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1581393011 .
(cherry picked from commit a41312c3237c4262ffbc2fa4375e4cbf59008f9a)
Review URL: https://codereview.chromium.org/1605163002 .
|
|
There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first.
BUG=pdfium:355
TBR=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1585533002 .
(cherry picked from commit 90853cb1dfd1bf3803ec21cfae3e93948137be61)
Review URL: https://codereview.chromium.org/1602103004 .
|