Age | Commit message (Collapse) | Author |
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1505353009 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1513393004 .
|
|
BUG=none
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512283002 .
|
|
BUG=pdfium:261
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1500313002 .
|
|
BUG=pdfium:324
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1507683010 .
|
|
Also clean up while we're here.
BUG=557223
TBR=tsepez@chromium.org
Original Review URL: https://codereview.chromium.org/1512833008 .
(cherry picked from commit 08750d0400f1635ac33c3234cb11b192f31a1eeb)
Review URL: https://codereview.chromium.org/1521473003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1512423003 .
|
|
Original Review URL: https://codereview.chromium.org/1520643002 .
(cherry picked from commit 7db2a535f163e7ce5995da12161ebd0214f0f75a)
Original Review URL: https://codereview.chromium.org/1511413008 .
(cherry picked from commit 168cfb7ee0f2abbd2bddb7e7d8b430a6d8c6c120)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1515613006 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508883003 .
|
|
BUG=pdfium:299
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520443002 .
(cherry picked from commit 94edf0c37d1ee6a03697375b9e227071ff2ee69d)
Review URL: https://codereview.chromium.org/1517653003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1507043004 .
(cherry picked from commit d9324d8f7345d4546c06c4a9d6cd497b0f7f3ad2)
Review URL: https://codereview.chromium.org/1512203003 .
|
|
BUG=pdfium:298
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
(cherry picked from commit 93181f9a20db7ac706bb9405750303db93762a5b)
Review URL: https://codereview.chromium.org/1514783002 .
|
|
BUG=pdfium:306
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1506423002 .
|
|
BUG=452793,561478
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512873002 .
|
|
Original Review URL: https://codereview.chromium.org/1518593002 .
(cherry picked from commit 035359cd8ddb555fa33b6133db4fd405e4660712)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1513103002 .
|
|
The proper way to "wide-stringify" a parameter is by L###arg,
not L"## arg ##", which does no replacement. Also remove dubious
CloneToEvent() method, and make the proper event in the one place
it is called.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1510493005 .
|
|
Re-introduce create methods that actually create the
corresponding impl so we don't have ifaces without impls.
Remove per-subclass Initialize() methods.
Remove unused ctors.
BUG=pdfium:282
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1453473002 .
|
|
Original Review URL: https://codereview.chromium.org/1510353003 .
(cherry picked from commit 0c92bed7ade20fe193dce0a481dad48e1be41622)
TBR=dpranke@chromium.org
BUG=559766
Review URL: https://codereview.chromium.org/1505993008 .
|
|
The no nominmax config was lost when moving from master.
Fix a few other small differences along the way, and fully
conditionalize the build of tiff.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1514633002 .
|
|
Revert "Fix embedder test failures introduced by commit c70b19aad245"
This reverts commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb.
Revert "Fix invalid buffer length set in CFX_WideString::UTF16LE_Encode()"
This reverts commit c70b19aad245fb1ed39bf8c264d991555f4c5a58.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1516643002 .
|
|
This reverts commit 5e4f290e939ded90a518ff8eab1db59930655e11.
BUG=
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1502063005 .
|
|
Allows "all" to include pdfium:* once again, since targets
that don't exist except under xfa are hidden.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1502343007 .
|
|
Hide the existence of the xfa libraries from GN when the feature
is not enabled. GN may try to build them otherwise when trying to
build "everything" even though nothing depends on them.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508243002 .
|
|
This allows standalone pdfium builds to build with XFA, but
makes a chromium checkout revert to non-xfa even on this
branch. GN implies a chromium checkout at the moment, so
disable XFA there, too.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508003003 .
|
|
Broken at 487d1a9/a0217b6.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1504413002 .
|
|
BUG=pdfium:282
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1509203002 .
|
|
The root cause is that FXFONT_SUBST_EXACT is wrongly
set even no any subset font was found. It causes
m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load().
BUG=534945
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1502083002 .
Review URL: https://codereview.chromium.org/1504263002 .
|
|
This reverts commit 6fa20c60c6ed551af55bfc879668eaac5c237805.
Reason for revert: broke tests
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1507893002 .
|
|
This matches the 3-level parallel hierarchy convention
used elsewhere in FWL. Remove dead code along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1503503003 .
|
|
Uncovered bad casts in a couple of places, replaced with
correct objects.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1503583003 .
|
|
Loosen a check for earlier version of PDF files. When the bytes with
specified length are followed by 'endstream' keyword, even if there is
no EOL marker before the keyword, it signals the end of stream.
BUG=551258
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1499433002 .
(cherry picked from commit 0ff66089c87ab6e3adaaff0ec69728ce7a8d8299)
Review URL: https://codereview.chromium.org/1504723002 .
|
|
R=tsepez@chromium.org
TBR=tsepez@chromium.org
BUG=566179
Original Review URL: https://codereview.chromium.org/1504513002 .
(cherry picked from commit 2d16308298f236ae81aa11a53f2d4e25b502dfac)
Review URL: https://codereview.chromium.org/1501123002 .
|
|
In the process, found two CFWL_ classes that didn't inherit
from the virtual inteface they were allegedly supporting.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1499853003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1500023003 .
|
|
Remove some dead code.
Add missing consts.
Convert some integer expressions to bools for return.
Remove expression (with bad cast) that can't happen.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1496323004 .
|
|
Remove dead code along the way.
BUG=pdfium:300
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1490093006 .
|
|
Add () to suppress gcc-style error about assignment in conditionals.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1491403002 .
|
|
These hide early returns from the casual reader, hide
the inversion of the condition under test from the reader,
prevent the folding of conditions into a single statement,
and take up more characters than the if() itself.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1494683002 .
|
|
Remove duplicate code from 10 places.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1486283002 .
|
|
corpus tests with Dr. Memory
TBR=thestig@chromium.org
BUG=pdfium:238
Review URL: https://codereview.chromium.org/1486413005 .
(cherry picked from commit be3ad4b56b38221b40e2a1f0ee56e371738a752a)
Review URL: https://codereview.chromium.org/1495443005 .
|
|
BUG=pdfium:294
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1487573002 .
|
|
BUG=pdfium:293
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1486583002 .
|
|
BUG=pdfium:295
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1482253002 .
|
|
RebuildCrossRef function returns false when we can not find file trailer
or any indirect object. This serves as a basic file format checking.
BUG=pdfium:215
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1476163002 .
(cherry picked from commit f14da1d58e8e12633c7a47e6efd5ffe43bb37b4b)
Review URL: https://codereview.chromium.org/1486383002 .
|
|
It's part of the CFWL_*Imp hierarchy, and hence should be
named CFWL_CustomImp. CFWL_Custom would belong to a differnt
hierarchy according to naming conventions.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1491723002 .
|
|
BUG=pdfium:291
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1487553003 .
|
|
BUG=pdfium:292
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1486573002 .
|
|
BUG=pdfium:281
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1481503002 .
|
|
This first pass is GYP-only, will do GN in the next CL.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1480403002 .
|