Age | Commit message (Collapse) | Author |
|
BUG=pdfium:281
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1481503002 .
|
|
This first pass is GYP-only, will do GN in the next CL.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1480403002 .
|
|
-- label matching #endifs
-- prefer #ifdef over #ifndef
-- consolidate some blocks.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1484843002 .
|
|
R=tsepez@chromium.org
BUG=PDFium:238
Review URL: https://codereview.chromium.org/1471073011 .
(cherry picked from commit 7e413d168beba325078aa4b484729ad22919a2c3)
Review URL: https://codereview.chromium.org/1482953003 .
|
|
This CL includes the following changes:
1. Add return value for InitFont(). It can indicate a failure
in the initialization of non-standard fonts.
2. Change NULL to nullptr.
3. Rewrite several pointer checking.
BUG=pdfium:279, pdfium:286
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1465423002 .
|
|
BUG=pdfium:289
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1472383003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477583002 .
|
|
Review URL: https://codereview.chromium.org/1465183009 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477663003 .
|
|
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477983002 .
|
|
Precursor to https://codereview.chromium.org/1477583002/
Also:
whitespace in fxjs_v8.h
Merge where possible.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1472363003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1471323004 .
|
|
Review URL: https://codereview.chromium.org/1468423004 .
(cherry picked from commit 628f7053cc646c58c61add247c75bc65ac135327)
BUG=561184
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1473943002 .
|
|
Visual Studio sometimes uses new instead of new[] for array allocation,
which causes Dr. Memory report invalid-heap-arg errors.
Suppress such errors since it is not developers' problems.
TBR=tsepez@chromium.org
BUG=pdfium:287
Review URL: https://codereview.chromium.org/1473913002 .
(cherry picked from commit 1fb4bc47e216c9caebdf7bc8479d45285ee7693b)
Review URL: https://codereview.chromium.org/1475023003 .
|
|
- remove redundant alloc in fx_codec_jpx_unittest.cpp
- free memory allocated by HexDecode calls in fpdf_parser_decode_unittest.cpp
BUG=PDFium:239
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1467183006 .
(cherry picked from commit 6c2d736011c09266015d3e2a0b9c08aeba1bbf31)
Review URL: https://codereview.chromium.org/1477833002 .
|
|
Increase ref number of pStyle when it's being used. In this way,
it won't be released when it's being used.
BUG=pdfium:267
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1468123003 .
|
|
BUG=pdfium:275
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1443603002.
Review URL: https://codereview.chromium.org/1477693002 .
|
|
BUG=pdfium:275
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1443603002 .
|
|
The incorrect page index may cause a crasher in the following
procedure.
BUG=pdfium:285
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1466423004 .
|
|
BUG=pdfium:276
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1438333005 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1473053003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1476683002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1474663004 .
|
|
buildbots
- update pdfium_tests.py to setup Dr. Memory so it can be used directly without
pdfium_tests.bat on buildbots
R=thestig@chromium.org
BUG=PDFium:238
Review URL: https://codereview.chromium.org/1478453002 .
(cherry picked from commit abea9d857e8e197d0095940f882b0db6a785d825)
Review URL: https://codereview.chromium.org/1467183005 .
|
|
Also change the copy ctor to take a const ref.
BUG=560520
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1472113002 .
(cherry picked from commit d03bc01003ae2603dafdc07b901ffef0a509a2b9)
Review URL: https://codereview.chromium.org/1478473002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1469413002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477483002 .
|
|
See the comment in fsdk_define.h. Also tidy up a bit,
and remove dead DeletePages(). This should help us
match master more closely (given corresponding changes
on the master side).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1473503002 .
|
|
In FPDF_GetPageCount(), 'document' is converted to a non-XFA
document pointer (CPDF_Document*). So it only returns non-XFA
or static XFA page count. If XFA files include dynamic XFA fields
on some pages, the returned value doesn't reflect these pages.
BUG=pdfium:278
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1442753005 .
|
|
- widening suppression for DrM-i#471
TBR=thestig@chromium.org
BUG=pdfium:238
Review URL: https://codereview.chromium.org/1467373003 .
(cherry picked from commit 3b1bd5cbbcc1a606275fe98e813a37531572f374)
Review URL: https://codereview.chromium.org/1465373002 .
|
|
- add DrMemoryWrapper in common.py to adjust Dr. Memory wrapper
- add --wrapper option to run_*_tests.py for Dr. Mempry wrapper
- update run_*_tests.py to handle Dr. Memory wrapper
- add TestPDFiumTest in pdfium_tests.py to support run_*_tests.py
- remove ValgrindTool in valgrind_tests.py
R=thestig@chromium.org
BUG=pdfium:238
Review URL: https://codereview.chromium.org/1464453003 .
(cherry picked from commit 36476923ae5eb8e9283e605f3c85ee8811c86014)
Review URL: https://codereview.chromium.org/1465333002 .
|
|
IFXA_LayoutPage now a pure virtual interface, with its
code moving to CXFA_ContainerLayoutItem's implementaton
of it.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1466103002 .
|
|
Bumping this one line from 6 to 7 in XFA saves a bunch of diffs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458363005 .
(cherry picked from commit 7711b60efc62db14748711727560367d948745f1)
BUG=
Review URL: https://codereview.chromium.org/1470563002 .
|
|
Original Review URL: https://codereview.chromium.org/1467653002 .
(cherry picked from commit 54bc568bb41c5c258e95c24ef9d7355dcdc20f9e)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1466743003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1466033002 .
(cherry picked from commit faab0f0add8317a7f95a8477e77bae716a10e977)
Review URL: https://codereview.chromium.org/1470553002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1463173003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1463973002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1463703002 .
|
|
Pull Jochen's fix before it is forgotten.
Original Review URL: https://codereview.chromium.org/1462313002 .
(cherry picked from commit 3ccd36892fe826e8f2ed8dde0819756ae3546733)
TBR=jochen@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1470443002 .
|
|
There will be significant differences, but these are the minor
ones. I removed a comment that doesn't seem to add a lot of value.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1465723002 .
|
|
Instead of casting to the unrelated IFWL_WidgetDelegate class
and hoping that its vtables line up, make CFWL_WidgetImpDelegate
inherit from it. We can then remove a lot of casting, even during
delete given that it has a virtual dtor.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1458173002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1460293002 .
|
|
Original Review URL: https://codereview.chromium.org/1459243002 .
(cherry picked from commit 6fc00fafcbac1fd5edd767fe2d4a8e4a9ef52806)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1461703008 .
|
|
This matches the type of the corresponding |CFX_DIBSource::m_Pitch|,
where integer overflow is checked for FX_DWORD. This change is
propagated to many other places.
Also, check for integer overflow in |CCodec_RLScanlineDecoder::Create|
during the calculation of |m_Pitch| since it aligns to 4 bytes while
overflow was was previously checked without this alignment.
TBR=tsepez@chromium.org
BUG=555784
Review URL: https://codereview.chromium.org/1460033002 .
(cherry picked from commit e7950df70a2fd658f466751b29483436cb31e829)
Review URL: https://codereview.chromium.org/1461363002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1465663002 .
|
|
This week's version. Mostly whitespace, but takes the
master version of core/src/fxge/ge/fx_ge_text.cpp
verbatim.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1462923004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1458633004 .
(cherry picked from commit 0c8e6c1f39f20985a3efb17292e46c476194183a)
Review URL: https://codereview.chromium.org/1461693005 .
|
|
Using Chromium's clang + build options, there's more override warnings.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1453643002 .
(cherry picked from commit 126ba519bdd489ec6c285d1410dcae773e8ef673)
Review URL: https://codereview.chromium.org/1458373002 .
|
|
If jpeg_read_scanlines() ends up calling the error callback, we longjmp
into some undefined state.
BUG=558840
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1463563003 .
(cherry picked from commit 06e33aec03f13c76d9eff5c09cb03e142b0c5ef1)
Review URL: https://codereview.chromium.org/1462253004 .
|
|
Remove default argument in remaining variants.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1453373006 .
|