summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-02-23Remove FXSYS_Div.Dan Sinclair
This is just a wrapper for (a) / (b). Inline the divide. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1727793002 .
2016-02-23openjpeg: Prevent bad cast in opj_j2k_update_image_dataOliver Chang
R=tsepez@chromium.org BUG=587227 Review URL: https://codereview.chromium.org/1726843002 .
2016-02-23Remove FXSYS_Mul.Dan Sinclair
This define just multiples the two parameters together. Inline the *'s. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1729613003 .
2016-02-23Remove more _CAPS namesTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1726803002 .
2016-02-23Remove uses of this->foo.Lei Zhang
R=weili@chromium.org Review URL: https://codereview.chromium.org/1722913002 .
2016-02-23Remove many _CAPS structure names.Tom Sepez
They're technically not allowed because they are reserved for the preprocessor. Also get rid of LPC* typedefs along the way. Also provide a header for a data file containing many instance of these found along the way. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1722873002 .
2016-02-23Remove _FDE_BLOCK_BUFFER as it's always defined.Dan Sinclair
This CL cleans up the code enabled and disabled by _FDE_BLOCK_BUFFER. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1724793002 .
2016-02-23Remove _FDEPLUS define.Dan Sinclair
We never define _FDEPLUS so all the #ifndef checks can be removed as they will always be true. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1723693005 .
2016-02-23XFA build fix.Dan Sinclair
We need to pull in the fgas_base.h file before looking at the _FX_OS_ checks otherwise they become true and windows XFA build fails. TBR=tsepez@chromium.org BUG=pdfium:65 Review URL: https://codereview.chromium.org/1725843002 .
2016-02-23Sort includes in xfa/.Dan Sinclair
This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU errors that have been fixed to make things compile again. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1722803002 .
2016-02-22FPDFPage_HasFormFieldAtPoint should not crash for nullptr pages.Lei Zhang
BUG=pdfium:401 R=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1713833003 .
2016-02-22Remove foo != NULL outside of xfa/Lei Zhang
Most of these are from the XFA branch. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1720043003 .
2016-02-22Change presubmit lint check to a blacklist.dan sinclair
This CL changes the possible lint flags to a blacklist which can be burned down. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1725573003 .
2016-02-23Resolve heap-use-after-free in CFX_WideString::~CFX_WideString()Jun Fang
BUG=pdfium:402 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1719803002 .
2016-02-22refactor CPDF_PageObject and subclassesWei Li
Use virtual functions to replace type based logic; remove unused functions; disable default copy constructor/assign operator. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1720003003 .
2016-02-23Fix a crasher in CXFA_ItemLayoutProcessor::DoLayoutTableContainer()Jun Fang
BUG=pdfium:408 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1719863002 .
2016-02-23Fix a crasher in CXFA_LayoutPageMgr::GetAvailHeight()Jun Fang
BUG=pdfium:407 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717243002 .
2016-02-23Fix a crasher in CFX_ArrayTemplate::GetAt()Jun Fang
BUG=pdfium:406 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1720743003 .
2016-02-22Really apply git cl format to BUILD.gnTom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1721983002 .
2016-02-22Switch from _DEBUG to NDEBUG.Lei Zhang
- NDEBUG is more widely used in Chromium - _DEBUG is not defined on Mac in Chromium - Leaving _DEBUG in for standalone debug builds for the benefit of third party libraries / Windows. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1721073004 .
2016-02-23Fix a crasher in ParsePostfixExpression()Jun Fang
BUG=pdfium:409 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1715363002 .
2016-02-22Fix return values in CFWL_FormImp::EndDoModal().Lei Zhang
Also remove unused variable in CFWL_FormImpDelegate::OnProcessMessage(). R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717383003 .
2016-02-22Fix remaining FX_memsets in windowsTom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1723693002 .
2016-02-22Remove unused stuff from fx_sys.hTom Sepez
Move FX_DOUBLE to fx_system.h to keep it with the others until we remove it. Having one memset/cpy wrapper is dubious, two are worse. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1724523002 .
2016-02-22Define NDEBUG for Release builds.Lei Zhang
Also fix -Wunused warnings as a result of this change. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717063002 .
2016-02-22Remove CFX_ThreadLock (its a no-op)Tom Sepez
We wouldn't want to imply that any of this is thread-safe ... R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1724483002 .
2016-02-22Remove unused fde_gdidevice files.Dan Sinclair
These are not included in the gyp or gn files so they won't be built. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1717403002 .
2016-02-22Expand XFA includes to be relative to pdfium/.Dan Sinclair
This Cl updates the includes in the XFA directory to be relative to the pdfium/ directory instead of the current directory. This does not sort the includes as that is a larger IWYU task that will be handled separately. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1723533002 .
2016-02-22Fixing include guards, and presubmit.Dan Sinclair
This update fixes all include guards so cpplint build/header_guard completes without error. A presubmit check is added to make sure the guards stay clean. BUG=pdfium:65 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1719083002 .
2016-02-19Tidy CFX_FixedBufGrow.Tom Sepez
Stop short of removing it since it looks like it may be used in some very hot paths. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1719543002 .
2016-02-19Remove IFX_BufferArchive.Tom Sepez
Merge it into CFX_FileBufferArchive, since both are in the same header file and it is the only subclass. Also, bTakeOver is always false, and the buf size is always 32K. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1712353002 .
2016-02-19Add a proper bounds check to XFA_FM_KeywordToStringOliver Chang
R=tsepez@chromium.org BUG=588200 Review URL: https://codereview.chromium.org/1718453003 .
2016-02-19Define _DEBUG for debug builds.Lei Zhang
Otherwise ASSERT() is useless. BUG=pdfium:136 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1712053003 .
2016-02-19Revert "Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.""Tom Sepez
This relands the CL at https://codereview.chromium.org/1710403002 Tests passed locally. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1717603003 .
2016-02-19Revert "Use safe arithmentic in CFX_BinaryBuf::ExpandBuf."Tom Sepez
This reverts commit 78353d5dbc0b0c9b2d6946005439a51efa7d108c. Reason for revert Failed tests. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1719493002 .
2016-02-19Get rid of CFX_CharMap instantiations.Lei Zhang
The only thing left are a couple of static methods. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1711273002 .
2016-02-19Hook up FFI_PageEvent.Lei Zhang
BUG=pdfium:401 R=jun_fang@foxitsoftware.com, tsepez@chromium.org Review URL: https://codereview.chromium.org/1712763003 .
2016-02-19Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.Tom Sepez
Always call ExpandBuf(), and if it returns, we know the subsequent calculations won't overflow. Also use std::unique_ptr, and fix unintentional copies thus detected by its suppressed copy ctor in fsdk_baseform.cpp Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData(). Also remove operator= in favor of using <<, for similarity with std::ostream and friends. Also move ByteStringC methods to CFX_ByteTextBuf sub-class. Also re-order members, may pack tighter on 64-bits. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1710403002 .
2016-02-19Move m_rgPendingNodes off of CFX_PtrList.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1712913002 .
2016-02-19Remove PageObject's m_Type and add As<Type> functionsWei Li
For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead. Also, add As<Type> functions to avoid casting all over the places. BUG=pdfium:397 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1709393002 .
2016-02-19Remove CFX_{Byte,Wide}String::ConvertFrom().Lei Zhang
Use/add CFX_{Byte,Wide}String::FromFoo() instead. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1711893003 .
2016-02-19Remove XFA_DATAMERGE_UPDATEBINDINGRELATIONS_DFSTom Sepez
Doing so removes another CFX_PtrList usage. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1716633002 .
2016-02-19fix crashed in FXJSE_Value_Setjinming_wang
BUG=pdfium:394 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1704813002 .
2016-02-19Fix a crasher in CXFA_Node::Script_Form_Recalculate()Jun Fang
BUG=pdfium:398 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1704343002 .
2016-02-19Fix a crasher in CFDE_TxtEdtDoRecord_Insert::CFDE_TxtEdtDoRecord_Insert()Jun Fang
If a widget is barcode, we should set the data length of barcode as the max length of input string. BUG=pdfium:372 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1703963003 .
2016-02-19Fix an assertion failure in CXFA_FWLTheme::Initialize()Jun Fang
The face names from font file stream may be different with the ones from chromium. Pdfium should save face names from chromium for font mapping when it works in sandbox environment. BUG=pdfium:392 BUG=pdfium:393 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1710753002 .
2016-02-18Remove useless CPDF_FontCharMap.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1715583002 .
2016-02-18Remove gotos in CJBig2_TRDProc.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1708413002 .
2016-02-18Clean up CPDF_FileSpec and add unit testsWei Li
Change implicit conversion to accessor function, remove unused function and unused parameter, add a couple checks for null pointers, and some cleanup. BUG=pdfium:247 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1703183002 .
2016-02-18Remove m_pDownloadCallback.Tom Sepez
Not only unused, but ugly-looking. Fix lint along the way. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1709313002 .
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-15 00:14:10 +0000