summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-20Clean up XFA code which causes warningsweili
This is part of efforts to bring XFA to chromium_code standard. The warnings are from unreachable code, or using potentially uninitialized variables, or using assignment within a condition. This change list only contains easy to fix cases. More cleanups will follow. BUG=pdfium:29 Review-Url: https://codereview.chromium.org/1998873002
2016-05-20Fix a bug on scrollbar's checking theme statesweili
The current switch statement will never execute any branch other than falling to default. The intention should be checking on the specific state bits. BUG=613623, 427616 Review-Url: https://codereview.chromium.org/2002643003
2016-05-20Use std::map in CXFA_ItemLayoutProcessortsepez
BUG= Review-Url: https://codereview.chromium.org/1999883002
2016-05-20Use std::map for CFX_GEFont::m_FontMappertsepez
Review-Url: https://codereview.chromium.org/2002673002
2016-05-20Fix unreachable code in fwl_comboboximp.cpptsepez
Althought this may change behaviour, I'm going to make the assumption that the intent expressed by the current code is what is desired, and that this is simply a case of not being able to count bits properly. BUG=613620,427616 Review-Url: https://codereview.chromium.org/1996303003
2016-05-20Use std::set to track uniqueness in xfa_script_layoutpseudomodel.cpptsepez
Review-Url: https://codereview.chromium.org/2001743002
2016-05-20Use std::map, std::unique_ptr in fwl_widgetmgrimp.htsepez
Review-Url: https://codereview.chromium.org/1998303002
2016-05-20Use std::map in CXFA_FontMgr and CXFA_PDFFontMgrtsepez
Review-Url: https://codereview.chromium.org/2005473002
2016-05-20Merge GetBits32() impls into one. Put it in fxcrt.thestig
Review-Url: https://codereview.chromium.org/1990153003
2016-05-20openjpeg: Prevent a buffer overflow in opj_j2k_read_SPCod_SPCoc.chromium/2747chromium/2746chromium/2745chromium/2744ochang
BUG=chromium:613160 Review-Url: https://codereview.chromium.org/2001663002
2016-05-19Use std::unordered_map for CFDE_CSSStyleSheet::m_StringCachetsepez
Get rid of some LPC typedefs while we're at it. Review-Url: https://codereview.chromium.org/1990363003
2016-05-19Work around sign compare error from commit be9b894.thestig
Review-Url: https://codereview.chromium.org/1989203007
2016-05-19Move fgas_sax into individual files in fde.dsinclair
This CL moves the fgas Sax parser into the fde/xml directory. This places the parse with the other XML parser in the system. Review-Url: https://codereview.chromium.org/1990003002
2016-05-19fgas/ code cleanup.dsinclair
This CL shuffles code around in the fgas/ headers, removes unused functions and adds anonymous namepaces for static methods and data. Review-Url: https://codereview.chromium.org/1992033002
2016-05-19Remove Release() from IFXCRT_FileAccess.tsepez
Remove some unused impls. Review-Url: https://codereview.chromium.org/1994323002
2016-05-19Fix the Skia build after 9b1a0ee.thestig
Review-Url: https://codereview.chromium.org/1996533004
2016-05-19Remove CFX_MapPtrToPtr in xfa_ffdocview.htsepez
Review-Url: https://codereview.chromium.org/1993313005
2016-05-19Remove Release() from CXFA_FM2JSContexttsepez
BUG= Review-Url: https://codereview.chromium.org/2000443002
2016-05-19Remove Release() from CPDFDOC_Environmenttsepez
It's never called. But looking at the comments in fpdf_formfill.h for the Release callback, it seems like it should always be called as part of the dtor. BUG= Review-Url: https://codereview.chromium.org/1995753004
2016-05-19Fix Undefined-shift in CPDF_SampledFunc::v_Init().thestig
Also fix a divide by zero in CPDF_SampledFunc. Do some cleanups too. BUG=596530,613032 Review-Url: https://codereview.chromium.org/1990843004
2016-05-19Fix a potential nullptr deref in CFX_MapPtrToPtr.thestig
And also in CFX_PtrList. BUG=596528 Review-Url: https://codereview.chromium.org/1991123002
2016-05-19Fix leak in CPDF_StreamContentParser::AddTextObject().thestig
... by using STL containers in more places. Remove dead / duplicate code as well. BUG=603904 Review-Url: https://codereview.chromium.org/1998583002
2016-05-19Remove CFX_DSPATemplate usage in CXFA_TextParserdsinclair
This CL changes the check to use std::binary_search instead of the custom lookup method. The tag validation has been split out to a separate method with unit tests added. Review-Url: https://codereview.chromium.org/1996623002
2016-05-19Expand some typedefs to the original typesdsinclair
Sevearal typedefs are only used once or twice. Expand and remove the typedef. Review-Url: https://codereview.chromium.org/1995033002
2016-05-19Correctly check for overflow in FX_atonum.dsinclair
Instead of the existing method, use the CheckedNumeric class to check for overflow during conversion. BUG=chromium:596526 Review-Url: https://codereview.chromium.org/1992023003
2016-05-19Fix memory leaks in pdfium_test.thestig
BUG=603903 Review-Url: https://codereview.chromium.org/1994113002
2016-05-19Cleanup unused fgas/ code.dsinclair
Purely code removal. Review-Url: https://codereview.chromium.org/1991143003
2016-05-19Remove Release() from CFX_StreamImp, rename to IFX_StreamImptsepez
Review-Url: https://codereview.chromium.org/1998453002
2016-05-19Fix a memory leak in opj_jp2_read_ihdr().thestig
BUG=603895 Review-Url: https://codereview.chromium.org/1992893003
2016-05-19Remove Release() from CXFA_WidgetLayoutDatatsepez
Use unique_ptrs. Review-Url: https://codereview.chromium.org/1990033002
2016-05-19Remove agg from skia buildcaryclark
This removes the last vestiges of antigrain from a Skia-specific build. R=dsinclair@chromium.org,tsepez@chromium.org,thestig@chromium.org,reed@google.com Review-Url: https://codereview.chromium.org/1998623002
2016-05-19Clean up CFX_RenderDevice::DrawNormalText().thestig
Review-Url: https://codereview.chromium.org/1990583002
2016-05-18Remove Release() from CFX_TxtBreaktsepez
Review-Url: https://codereview.chromium.org/1988393002
2016-05-18Remove Release() from CFDE_TxtEdit* classestsepez
Review-Url: https://codereview.chromium.org/1987223003
2016-05-18Remove Release() from CXFA_FWLThemetsepez
Cleanup virtual overrides along the way. Add final to other class deriving from pure virtual interface. Review-Url: https://codereview.chromium.org/1988373002
2016-05-18Remove Release() from CXFA_ScriptContexttsepez
Review-Url: https://codereview.chromium.org/1988263002
2016-05-18Cleanup XFA_HASHCODE usage.dsinclair
This CL cleans up several uses of XFA_HASHCODE. The defines have been converted into an enum. For the SavePackage call the type is now used as the param instead of a string. The callers pass in the correct type instead of doing an internal conversion. The GetXFAObject accepting a string was removed as it was unused. The other variant was changed to accept the XFA_HashCode type instead of uint32_t. GetPackageData was removed as it is unused. Review-Url: https://codereview.chromium.org/1989313002
2016-05-18Remove Release() from CFX_SAXReadertsepez
Review-Url: https://codereview.chromium.org/1991993002
2016-05-18Remove Release() from CXFA_RenderContexttsepez
Review-Url: https://codereview.chromium.org/1994733002
2016-05-18Remove Release() from CXFA_WidgetAccIteratortsepez
Review-Url: https://codereview.chromium.org/1990793004
2016-05-18Remove Release() from CXFA_ChecksumContexttsepez
Review-Url: https://codereview.chromium.org/1991913002
2016-05-18Split xfa/fee files into individual class files.dsinclair
This CL splits the xfa/fee files into individual class files and moves them into the xfa/fde directory where they belong. Review-Url: https://codereview.chromium.org/1994693002
2016-05-18Use std::vector in CPDF_StructTreeImpltsepez
Allows use of CFX_RetainPtrs in place of explicit refcounting. Review-Url: https://codereview.chromium.org/1985253002
2016-05-18Remove c_str() from widestring checksum variant.tsepez
Brings it back in line with bytestring version. Review-Url: https://codereview.chromium.org/1985223002
2016-05-18Pass objects instead of strings for undo/redo records.dsinclair
Currently the Undo/Redo records are serialized as byte strings and stored into a CFX_ByteStringArray. They are deserialized when used. This CL removes the serialization and stores the objects in a deque of unique pointers. Review-Url: https://codereview.chromium.org/1980293004
2016-05-17Remove some CFX_ArrayTemplate<> usage from fxjsetsepez
Allows use of otherwise incompatible unique_ptrs. Review-Url: https://codereview.chromium.org/1992513002
2016-05-17Replace XFA_N with valuedsinclair
The XFA_N define doesn't add anything over just using the value, replaced. The static arrays and method have been moved to an anonymous namespace. Review-Url: https://codereview.chromium.org/1992453002
2016-05-17Remove Release() from IFX_CharIter, use unique_ptrs.chromium/2742chromium/2741tsepez
Review-Url: https://codereview.chromium.org/1986373002
2016-05-17Don't use LCD antialiasing if Fontconfig doesn't support hintingthomasanderson
Some Freetype implementations (like the one packaged with Fedora) do not support hinting due to patents 6219025, 6239783, 6307566, 6225973, 6243070, 6393145, 6421054, 6282327, and 6624828; the latest one expires 10/7/19. This makes LCD antialiasing very ugly, so we instead fall back on NORMAL antialiasing. A before/after on Fedora: https://bugs.chromium.org/p/chromium/issues/detail?id=479400#c31 BUG=479400 Review-Url: https://codereview.chromium.org/1982263004
2016-05-17Rename CPDF_Struct{Element,Tree} to IPDF_tsepez
After all, what good is a naming convention unless you're going to blindly adhere to it? Review-Url: https://codereview.chromium.org/1981403002
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-11 21:59:53 +0000