summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-11-04Merge to XFA: Make checkdeps --resolve-dotdot succeed.Lei Zhang
This is just a straight-forward, partial merge. It does not actually make checkdeps succeed. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1419373005 . (cherry picked from commit 79f5a32175293620abe456554e10efb7c3f4e7c6) Review URL: https://codereview.chromium.org/1409153007 .
2015-11-04Merge to XFA: Enforce input and output dimensionalities for CPDF_StitchFunc.Oliver Chang
Also cleans up some places in the relevant functions since we're here. BUG=551460 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1421783004 . Clean merge. (cherry picked from commit 4f85605cbc652a17bc833f883186e0a68af6006d) Review URL: https://codereview.chromium.org/1405383009 .
2015-11-04XFA: make JS_Define.h match masterTom Sepez
Remove parameter names in template specialization. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1416623004 .
2015-11-04Merge to XFA: Remove state from RebuildCrossRef state-machine.Dan Sinclair
The state '12' is only used once. This CL folds the contents of state 12 back into the place where we set our state to 12. This works because all state 12 does is decrement the loop counter so we process the same character again and move us to state 0. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1430643007 . (cherry picked from commit 395fbedc65e1261f1fb9189205501f4856235290) Review URL: https://codereview.chromium.org/1414033010 .
2015-11-04Merge to XFA: Cleanup after syncing CPDFSDK_BAAnnotDan Sinclair
This cleans up various things after syncing BAAnnot to master. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1418043007 . (cherry picked from commit 110650e68e519e8cf14fe1119b77cf3309ed2d0b) Review URL: https://codereview.chromium.org/1415933007 .
2015-11-04Merge to XFA: Make built-in font table slightly saner.Tom Sepez
Original Review URL: https://codereview.chromium.org/1409243012 . (cherry picked from commit 0142f017d03df17fac98b586487cae23b6be05a6) R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1429183002 .
2015-11-03Remove unused variablesJun Fang
BUG=pdfium:261 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1413343003 .
2015-11-03Merge to XFA: Remove CFontFileFaceInfo.Tom Sepez
Original Review URL: https://codereview.chromium.org/1412243015 . (cherry picked from commit cbd6bba62777131e39e3c4fd2d0028b472fb94c9) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1416953005 .
2015-11-03Merge to XFA: Add support for building with goma.Oliver Chang
TBR=thestig@chromium.org clean merge. Review URL: https://codereview.chromium.org/1428093004 . (cherry picked from commit e35b445bee90390ea09f334cbff4a6220537bbda) Review URL: https://codereview.chromium.org/1418453007 .
2015-11-03Merge to XFA: Add format width and precision tests.Dan Sinclair
This CL adds tests for the numeric conversion done when calculating the format percision and width fields. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1411973005 . (cherry picked from commit c9e76c09b9e7901823ac52a3705da235bd2abe24) Review URL: https://codereview.chromium.org/1421813008 .
2015-11-03Merge to XFA: Add test for CPDF_SyntaxParser::ReadHexString.Dan Sinclair
This CL adds tests for the ReadHexString method of the syntax parser. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1433503002 . (cherry picked from commit 71ad9a0028a183605fba734c48b4756d6caa7754) Review URL: https://codereview.chromium.org/1424923007 .
2015-11-03Merge to XFA: Revert "One test runner to rule them all."Dan Sinclair
This reverts commit a1215ba51a235fb7abcb995f0e768ea0176d9275. Revert "Return result of the test runner." This reverts commit d1579c9b92b7f9c1d9e0fac1ecb8e3cb23875fca. Reverting the new test_runner code as there appears to be something string happening on the non-Linux boxes on XFA. It looks like it ran the font_size test twice, once with the .in and once with the .pdf. The .in was suppressed, the .pdf faild and wasn't suppressed. Rendering PDF file /Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf. Rendered 1 pages. Skipped 0 bad pages. Checking /Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf.0.png FAILURE: font_size.in; Command '['/Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/pdfium_diff', '/Volumes/data/b/build/slave/mac_xfa/build/pdfium/testing/resources/pixel/font_size_expected.pdf.0.png', '/Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf.0.png']' returned non-zero exit status 1 font_size.in is suppressed, found in SUPPRESSIONS_mac file Rendering PDF file /Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf. Rendered 1 pages. Skipped 0 bad pages. Checking /Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf.0.png FAILURE: font_size.pdf; Command '['/Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/pdfium_diff', '/Volumes/data/b/build/slave/mac_xfa/build/pdfium/testing/resources/pixel/font_size_expected.pdf.0.png', '/Volumes/data/b/build/slave/mac_xfa/build/pdfium/out/Debug/gen/pdfium/testing/pixel/font_size.pdf.0.png']' returned non-zero exit status 1 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1410743008 . (cherry picked from commit e067f7bab4317704de27917c1befa8f57a0e78d7) Review URL: https://codereview.chromium.org/1421133005 .
2015-11-03Merge to XFA: Return result of the test runner.Dan Sinclair
We need to actually return the result of the test runner.... TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1413863011 . (cherry picked from commit d1579c9b92b7f9c1d9e0fac1ecb8e3cb23875fca) Review URL: https://codereview.chromium.org/1419953009 .
2015-11-03Merge to XFA: One test runner to rule them all.Dan Sinclair
This CL takes the three test runners (corpus, javascript, pixel) and combines the code into a single test_runner file. Each of the individual runners still exists and calls the test runner with their data directory. With this change, the pixel and javascript test will now run in parallel if multiple processors are available. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1430623006 . (cherry picked from commit a1215ba51a235fb7abcb995f0e768ea0176d9275) Review URL: https://codereview.chromium.org/1411553010 .
2015-11-02Merge to XFA: Roll DEPS for v8 to 88b764d. Regular weekly roll.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1421353007 . (cherry picked from commit 4c4dd28fb1d3ba27d29571297cdf523e2f8e724c) Review URL: https://codereview.chromium.org/1427273002 .
2015-11-02Merge to XFA: Check fread() return values in CFX_FolderFontInfo::GetFontData().Lei Zhang
Check fseek() return values too. BUG=549998 TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1419793003 . (cherry picked from commit 99818557c8ed64d00fcc23a1e87e1ebf41ed5e85) Review URL: https://codereview.chromium.org/1426263002 .
2015-11-02Merget to XFA: Add test for CPDF_StreamParser::ReadHexString.Dan Sinclair
This CL adds a unit test for the ReadHexString method. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1408213008 . (cherry picked from commit c89c6195373b63e99b9cd432c5a181bfb3ad8dbe) Review URL: https://codereview.chromium.org/1417713003 .
2015-11-02XFA: Simplify CPDFSDK_PageView::PageView_OnDraw().Lei Zhang
The clip parameter is never NULL. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1417983006 .
2015-11-02Merge to XFA: Add tests for CMap_GetCode and CMap_GetCodeRange.Dan Sinclair
This CL adds tests for the CMap_GetCode and CMap_GetCodeRange methods. To do so, it moves the methods to be static private members of CPDF_CMapParser and makes the test class a friend. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1414013005 . (cherry picked from commit afca65ac019d2ad4cb8ac8f585809cc1a519ac2b) Review URL: https://codereview.chromium.org/1429943002 .
2015-11-02Merge to XFA: Add a test for the HexDecode method.Dan Sinclair
I moved the declaration to be public, instead of having it implicit in one file and defined in a seperate cpp file. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1410873009 . (cherry picked from commit e948a4ee08b78e27da37bc12244fa1b66d927dc7) Review URL: https://codereview.chromium.org/1432513002 .
2015-11-02Merge to XFA: Remove _FPDF_ByteStringFromHex as it is unusedDan Sinclair
There are no uses of this method, I also checked the XFA branch and there don't appear to be any uses there either. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1427913006 . (cherry picked from commit e65be3a55628294d0f45da456d856b4539f0cb15) Review URL: https://codereview.chromium.org/1415023005 .
2015-11-02Merge to XFA: Add test for StringToCode and StringToWideStringDan Sinclair
This CL adds a test case for the StringToCode and StringToWideString methods in fpdf_font.cpp. In order to do so, it moves the methods to be private methods of CPDF_ToUnicodeMap and make the tests friends of the class. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1428593005 . (cherry picked from commit 52b0b525dca3d982a04b77fa6d0913aff1e5fd9c) Review URL: https://codereview.chromium.org/1425233004 .
2015-11-02Fix XFA compilation noise, part 1.Tom Sepez
Mainly: volatile/override/method shadowing. unused variables. intialization list init order. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1422113003 .
2015-10-30Merge to XFA: Clean up CPDF_AnnotList.Lei Zhang
- Remove dead code - Stop using CFX_PtrArray - Mark more things const - Fix style nits TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1425093003 . (cherry picked from commit c88c42f317c0e94c4c7b98949bfe1a495aef07a9) Review URL: https://codereview.chromium.org/1430803003 .
2015-10-30Merge to XFA: Move a unique_ptr initialisation out of the initialisation ↵Oliver Chang
list in fsdk_mgr.cpp TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1407103006 . (cherry picked from commit ef26566853fcd014f4b5c4944e480db75afc6729) Review URL: https://codereview.chromium.org/1412793013 .
2015-10-30Merge to XFA: Convert a bunch of raw pointers in fsdk_mgr to unique_ptrs.Oliver Chang
Conflicts in both files. R=tsepez@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1425233002 . (cherry picked from commit 34c509e0e0fbd64d4380f130c48434b07f60b69e) Review URL: https://codereview.chromium.org/1421983008 .
2015-10-30Merge to XFA: Remove external jpeg provider interface.Tom Sepez
(cherry picked from commit 3d59bd9d66d01eb39c30742bce67fa0376cb4ea8) Review URL: https://codereview.chromium.org/1407903005 . Conflicts: core/include/fxcodec/fx_codec_provider.h core/src/fxcodec/codec/codec_int.h core/src/fxcodec/codec/fx_codec_jpeg.cpp R=thestig@chromium.org Review URL: https://codereview.chromium.org/1412713009 .
2015-10-30Merge to XFA: linux: Remove unneeded -L flags from static library targets.Lei Zhang
-L isn't used for creating static libraries. This flag isn't present on non-Linux or in the gn file either. TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1425213003 . (cherry picked from commit b0337e68fb84c807e0d898aecaad0074444d62e0) Review URL: https://codereview.chromium.org/1432453002 .
2015-10-30Merge to XFA: CPDFDoc_Environment::GetAnnotHandlerMgr() never returns nullptr.Lei Zhang
Remove checks for its return value. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1424233003 . (cherry picked from commit 0bafcbed84d2f1d7e17cd1adfd15a2a019756ee4) Review URL: https://codereview.chromium.org/1412093010 .
2015-10-30Merge to XFA: Fix incorrect CPDFSDK_PageView::CountAnnots(). (try 2)Lei Zhang
The original XFA version was correct, and the master version here is wrong. The two versions are now in sync, but incorrect. So we need to fix this here and then merge to XFA again. Also fix what are now incorrect uses of CountAnnots() and do some cleanups. BUG=543049 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1413973011 . (cherry picked from commit c91d5c276b6b986f645d34a0e583fbe4f73e74bc) Review URL: https://codereview.chromium.org/1422503012 .
2015-10-30XFA: Remove dead code in CBC_BufferedImageLuminanceSource and friends.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1422713007 .
2015-10-30XFA: Remove null CFX_DIBAttribute default argument.Tom Sepez
Add some consts and overrides along the way. Group some statics together. Tidy some unused vars. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1411683005 .
2015-10-30Merge to XFA: Add standard "Must be after no_chromium_code" comment in GN files.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1411563004 . (cherry picked from commit 4793f674f29be8bf06a60672032e2e2df5164c8c) Review URL: https://codereview.chromium.org/1415573006 .
2015-10-30Merge to XFA: Rip out the KillFocusAnnot call from CPDFSDK_PageView's destructorOliver Chang
Previously, blur event actions could potentially touch deleted PageViews as CPDFSDK_Document deletes the PageViews one by one. This also fixes a related issue: CPDFSDK_Document::SetFocusAnnot no longer does anything if the document is being destroyed. Otherwise, it eventually tries to use m_pEnv->GetSDKDocument() at which point has already been set to NULL by FPDFDOC_ExitFormFillEnvironment. TBR=tsepez@chromium.org BUG=512445 Clean merge. Review URL: https://codereview.chromium.org/1414353007 . (cherry picked from commit a548b1d3e2444f256bcbf6c2fa2165798e33ba8d) Review URL: https://codereview.chromium.org/1423343004 .
2015-10-30XFA: Remove unused classes from fpdf_serialTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1423343002 .
2015-10-30XFA: bring fx_codec_fax in-line with masterTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1419473006 .
2015-10-30XFA: Take CTTFontDesc::ReleaseFace() changes from master.Tom Sepez
Return true if object destroyed. Also get rid of FXFT_Done_Face() call not present on master. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1426103002 .
2015-10-30XFA: remove unused GdiCombineMode2Gdip() [windows]Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1428713004 .
2015-10-30XFA: Restore early return if no FPDF_Page in FORM_DoPageAAction()Tom Sepez
Present in original XFA code drop. BUG=pdfium:259 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1425223002 .
2015-10-30Fix segv in CFX_BaseArray::~CFX_BaseArrayTom Sepez
One can't blatantly memset() a class to zero if its parent contains a vtable. Fix some IWYU along the way. Kill some casts along the way. BUG=pdfium:259 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1416943007 .
2015-10-30XFA: Segv in CFXJSE_RuntimeData::Get()Tom Sepez
Crash occurs when JS is first entered from the FXJSE_ side, instead of the FXJS_ side. Added initializaton call to FXJSE_. BUG=pdfium:259 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1406253007 .
2015-10-29XFA: Manual merge of Clean up IFX_BidiCharLei Zhang
- Replace IFX_BidiChar with just CFX_BidiChar - Document implementation - Change out parameters to pointers - Remove dead code - Add an enum for bidi directions - Move several externs to a header - Add unit tests Original CL: https://codereview.chromium.org/1197643002 This version does not remove fx_arb.h and fx_arabic.h, as there is code on the XFA branch that still uses parts of it. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1423103002 .
2015-10-29Remove register keyword from xfa filesTom Sepez
These are generating compilation warnings. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1411653003 .
2015-10-29XFA: remove unsafe exif parsing codeTom Sepez
Fortunately, this could only be called with a null buffer, so none of unchecked lengths could be used. The remaining use of the CFX_/IFX_DIBAttributeEx class is as a table, so put one directly in the CFX_DIBAttribute. Fix a "register" warning along the way. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1425983002 .
2015-10-29XFA: Remove unused _JpegLoadIccProfile()Tom Sepez
In turn, remove now unused _JpegIsIccMarker(). R=thestig@chromium.org Review URL: https://codereview.chromium.org/1418653008 .
2015-10-29Merge to XFA: Remove linearized path print statementsDan Sinclair
This CL makes the pdfium_test app a little less chatty by removing the print statements around linearized paths. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1415333007 . (cherry picked from commit 0bbb2d855b938c7dda3dd56baf7131b1861ae850) Review URL: https://codereview.chromium.org/1415373003 .
2015-10-28Merge to XFA: Add PDFCharIsLineEnding helperDan Sinclair
This CL adds a helper to check if a given character is a \n or \r. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1418073006 . (cherry picked from commit 4b38229b004b7b6493cb4c4507df450adc6085f6) Review URL: https://codereview.chromium.org/1428763002 .
2015-10-28Merge to XFA: Allow running individual tests.Dan Sinclair
This CL adds the ability to run a given test from the corpus, javascript and pixel test runners. The filename to provide is relative to the testing directory in question. Because the directories for javascript and pixel are flat you just provide the filename (it will rewrite the .pdf to .in if .pdf is provided). For corpus tests you have to provide the path from the corpus directory. Development/pdfium/pdfium % ./testing/tools/run_javascript_tests.py apply.pdf Rendering PDF file /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/javascript/apply.pdf. Non-linearized path... Rendered 1 pages. Skipped 0 bad pages. Development/pdfium/pdfium % ./testing/tools/run_pixel_tests.py bug_524043_1.pdf Rendering PDF file /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/pixel/bug_524043_1.pdf. Linearized path... Rendered 1 pages. Skipped 0 bad pages. Checking /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/pixel/bug_524043_1.pdf.0.png diff: 0.00% passed Development/pdfium/pdfium % ./testing/tools/run_corpus_tests.py third_party/tcpdf/example_065.pdf Rendering PDF file /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/corpus/example_065.pdf. Non-linearized path... Rendered 1 pages. Skipped 0 bad pages. Checking /Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/corpus/example_065.pdf.0.png diff: 0.14% failed FAILURE: example_065.pdf; Command '['/Development/pdfium/pdfium/out/Debug/pdfium_diff', '/Development/pdfium/pdfium/testing/corpus/third_party/tcpdf/example_065_expected.pdf.0.png', '/Development/pdfium/pdfium/out/Debug/gen/pdfium/testing/corpus/example_065.pdf.0.png']' returned non-zero exit status 1 Summary of Failures: /Development/pdfium/pdfium/testing/corpus/third_party/tcpdf/example_065.pdf TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1407913005 . (cherry picked from commit da6254ff78553773b7bb637ee1e3f5111c083c74) Review URL: https://codereview.chromium.org/1423523005 .
2015-10-28Merge to XFA: Revert "Add test case for parsing endobj keywords."Dan Sinclair
This reverts commit 5bd88ec07e79215400777f3095c6843e0627cade. (cherry picked from commit 97dd3fec106ac8a945e03ed1509af0a8b73da993) R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1430533003 .
2015-10-28Merge to XFA: Add a NULL check in pdf_page_colors.cppOliver Chang
TBR=thestig@chromium.org BUG=548714 Clean merge. Review URL: https://codereview.chromium.org/1430653002 . (cherry picked from commit 55ed2880e9d19e79717063b117aa5eee40dd454b) Review URL: https://codereview.chromium.org/1428643005 .
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-05 01:24:07 +0000