Age | Commit message (Collapse) | Author |
|
Remove unused member functions and simplify calls to find tag parameters.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1681403007 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701123002 .
|
|
Also disables mac build. libfuzzers are only built on Linux.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1703623002 .
|
|
GN source_sets are added so that the fuzzers can be built from
//testing/libfuzzer in a Chromium checkout.
GYP targets are also added to make sure these always build properly on
our waterfall. These don't actually build the proper libfuzzers, but
build the target fuzz function with a driver main() since the actual
build process is quite complicated.
R=tsepez@chromium.org, thestig@chromium.org
BUG=587126
Review URL: https://codereview.chromium.org/1701103002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1707433002 .
|
|
Migrating this off of CFX_PrtList depends on first making
this saner. The tricky part is checking whether new
objects have been added to a partially-parsed layer. The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.
Fold together some duplicated blocks along the way.
Remove unused EstimateProgress() method.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1699443002 .
|
|
When there is no dictionary for marked content, it potientially may cause crash. But it is not happening now since 1) we now check for the returned dict parameter 2) the alloc function in pdfium does zero initialization.
BUG=pdfium:67
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1695633004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1686153004 .
|
|
One less Bezier.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1692413002 .
|
|
Bin the min, bin the min, bin the min, bin the min, bin
the min, bin the min, bin the min, bin the min, bin the
min, bin the min, bin the min, bin the min, bin the min.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1693913003 .
|
|
Replace array of heterogenous ints with array of struct.
Create a class for traversing a string.
Flip array when R2L and process with forward iterator always.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1682983002 .
|
|
- NormalizeString() has 1 caller:
- CTextBaseLine::WriteOutput(), which has only 1 caller:
- CTextPage::WriteOutput(), which has only 1 caller:
- PDF_GetPageText_Unicode(), which has only 1 caller:
- PDF_GetPageText(), which has no callers.
Removing this also makes CheckRotate(), NormalizeCompositeChar(),
and CTextPage unused.
Removing those makes CTextBaseline() unused.
Removing that makes txtproc.h unused.
PDF_GetTextStream_Unicode also unused.
... and so on until entire files can be removed.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1689843002 .
|
|
The m_Operators array represents a heterogeneous instruction
stream, so leave it as a void* for now.
R=thestig@chromium.org, thestig@chromimum.org
Review URL: https://codereview.chromium.org/1676413002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1666663004 .
|
|
The routines that would return them always return NULL. Some
path, however, didn't previously check for NULL. Those must
have been bugs; treat such cases as unreachable.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1679103002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1676913004 .
|
|
The existing code (added in https://codereview.chromium.org/1650793002/)
changes the state of a copy of the object.
Original CL: https://codereview.chromium.org/1679783002/
Original Author: hashimoto@chromium.org
R=hashimoto@chromium.org
Review URL: https://codereview.chromium.org/1681863002 .
|
|
TBR=thakis@chromium.org
BUG=585261
Review URL: https://codereview.chromium.org/1683523002 .
|
|
R=thakis@chromium.org
BUG=585261
Review URL: https://codereview.chromium.org/1679843003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1680923002 .
|
|
Remove CFX_PtrArray filelist.
Promote ScopedFileStream to .h file and use it.
Fix _CAPS names, bool returns, and put in anonymous namespace.
FX_CreateMemoryStream() can't return null, so remove checks.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1672153002 .
|
|
Also, use full path to include "text_int.h", as there are
two of them; I suspect that fpdf_text_search was including
the wrong one as the compiler didn't complain about a
signature mismatch I had overlooked.
In fact, rename the fxge file to avoid collision completely.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1679743003 .
|
|
Fix IWYU in stl_util.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1672283002 .
|
|
BUG=pdfium:386
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1680463002 .
|
|
BUG=pdfium:380
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1674453004 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1671843002 .
|
|
R=tsepez@chromium.org
BUG=584223
Review URL: https://codereview.chromium.org/1672163002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1671113002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1671213002 .
|
|
patch from issue 1665243003 at patchset 1 (http://crrev.com/1665243003#ps1)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1669313002 .
|
|
The downsampler was not sampling correctly from 16-bit images, resulting
in using the RRG bytes (of the RRGGBB 16-bit pixel) for RGB in the 8-bit
output.
Original code review: https://codereview.chromium.org/1663983002/
Original author: ballbach@google.com
BUG=583804
R=ballbach@google.com
Review URL: https://codereview.chromium.org/1671833002 .
|
|
BUG=pdfium:385
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1668813002 .
Review URL: https://codereview.chromium.org/1669193002 .
|
|
BUG=pdfium:369
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1667643002 .
Review URL: https://codereview.chromium.org/1668283003 .
|
|
TBR=thestig@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1670843002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1669113002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1667333002 .
|
|
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1664543005 .
|
|
Original Review URL: https://codereview.chromium.org/1671473002 .
(cherry picked from commit cdac3446f26751ff5db4123d87710f8b4e15d11c)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1665273002 .
|
|
Removes another case of a void* array where the even elements
mean one thing and the odd elements mean another. And even
the odd elements aren't consistently typed -- leave for later.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1671473002 .
|
|
The static_casts<> are places where void* pointers are converted.
Fix these in a subsequent CL by using a properly typed container.
The const_casts<> are places where functions are missing "consts".
Fix these in a subsequent CL, too.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1668003003 .
|
|
BUG=pdfium:373
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1652873003 .
|
|
Remove implicit CXFA_Node* operator.
Add bool() operator.
Remove IsExistInXML() which duplicates bool operator.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1663313002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1665933003 .
|
|
Mark some ctors explicit.
Rename GetXFANode to GetXFAObject to match its return type,
since it is cast to node in many places.
BUG=pdfium:384
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1662063002 .
|
|
Original Review URL: https://codereview.chromium.org/1660633003 .
(cherry picked from commit e8ea737bf9ef95b406c74fc3b1120f3fa6c4e227)
Conflicts:
fpdfsdk/include/fsdk_baseform.h
fpdfsdk/src/fsdk_baseform.cpp
TBR=thestig@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1668483004 .
|
|
Avoid some const casts, unused return types, etc.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1660633003 .
|
|
Review URL: https://codereview.chromium.org/1660733002 .
(cherry picked from commit 7c87508ae4b8300caf97aebffae42ba2c7fd6e52)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1660103004 .
|
|
This was an obstacle to removing CFX_DWordArray; rather than
rote conversion of an array where the even elements mean one
thing and the odd elements another, make an array of pairs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1660733002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1661123002 .
|