summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-03-09Convert NULLs to nullptrs in fx_xml_parser.cppOliver Chang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1780703002 .
2016-03-09Cleanup some header includes.Dan Sinclair
Move some of the xfa/ includes in fpdfsdk from the header files to the .cpp files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1771353006 .
2016-03-09Structs shouldn't inherit from CFX_Target.Tom Sepez
There are some assumptions in the code that CAPS_NAMED structs are POD, and can be memcpy'd, malloc'd, etc. CFX_Target adds a virtual dtor, which is not what is desired for many of these, so resolve by making each a CAPS_Named class or by removing the inheritence. In the process XFA_TextPiece was found to be malloc'd despite having a ctor. Move this to |new|, noting that the object is never freed (and goes out of existence when the allocator's pool is destroyed). BUG=pdfium:432 R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1780753002 .
2016-03-09Cleanup the xfa/src/fdp directory.Dan Sinclair
This CL renames xfa/src/fdp to xfa/src/fde to better match all of the content (nothing mentions fdp other then the directory name). The inner src/ and include/ folders are collapsed up a level and xfa/src/fdp/src/fde is moved up to xfa/src/fde. Some of the header moves conflicted with existing headers. In that case, the existing header had the content moved into the .cpp file and we replaced the existing header with the one from include/. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1784543002 .
2016-03-09Fix build broken at ca78d9a52893Tom Sepez
Move time.h inclusion to new file. TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1778893003 .
2016-03-09Split off IPDF_SecurityHandler and CPDF_StandardSecurityHandler.Tom Sepez
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1781593003 .
2016-03-09Fix build broken at 8388037a5c58Tom Sepez
Missing explicit include of <vector> TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1783433004 .
2016-03-09Cleanup the xfa/src/fgas directory.Dan Sinclair
This CL moves the code from xfa/src/fgas/src up one level. It then takes the headers in xfa/src/fgas/include and moves them to their correct folder. The src/ and include/ directories are then removed. In some cases, when moving from include/ there was another header with the same name. Those headers were either folded together, or the content of the conflicting folder moved to an anonymous namespace in the cpp file as they were not used anywhere else. Files with duplicate names as core/src/crt were renamed to be fgas_ instead of fx_. (e.g. fgas_system.h, fgas_memory.h, fgas_stream.h) R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1776303002 .
2016-03-09Split off CPDF_Parser and CPDF_SimpleParser into .h/.cpp filesTom Sepez
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1773103003 .
2016-03-09Collapse xfa/src/fee directorieschromium/2674chromium/2673Dan Sinclair
This CL moves xfa/src/fee/src/fee up to xfa/src/fee and moves the xfa/src/fee/include files up to xfa/src/fee. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1778633003 .
2016-03-09Fix clang-cl build for pdf_enable_xfa=1Oliver Chang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1781683002 .
2016-03-09Fix build at 2f4232d.Oliver Chang
TBR=tsepez@chromium.org,thakis@chromium.org Review URL: https://codereview.chromium.org/1778893002 .
2016-03-09Support clang-cl build on Windows.Oliver Chang
R=thakis@chromium.org, tsepez@chromium.org BUG= Review URL: https://codereview.chromium.org/1774123005 .
2016-03-09Fix non-xfa builds.Dan Sinclair
Fixup some includes so we can still build non-xfa. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1781643002 .
2016-03-09Review and cleanup lint warnings.Dan Sinclair
This CL goes through the remaining list of list warnings and records why they are currently blacklisted, or fixes and enables them. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1773733002 .
2016-03-08Fix build at 310438fb97a2chromium/2672Tom Sepez
Missing include in fsdk_mgr.h TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1774303002 .
2016-03-08Split off CPDF_Document into its own .cpp/.h files.Tom Sepez
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1780503002 .
2016-03-08Re-land "Split CPDF_SyntaxParser into its own named .cpp/.h files."Tom Sepez
This reverts commit 06fae28d307fe051f0c7e890344cd487c2260910. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1775023003 .
2016-03-08Missing return, broken win build.Dan Sinclair
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1775913003 .
2016-03-08Revert "Split CPDF_SyntaxParser into its own named .cpp/.h files."Tom Sepez
This reverts commit d50095fb151688e119a7097aabce11e4b3d36244. Reason for revert: build broken. TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1774293002 .
2016-03-08Split CPDF_SyntaxParser into its own named .cpp/.h files.Tom Sepez
BUG= R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1774753002 .
2016-03-08Reland "Fix chromium-style errors."Dan Sinclair
This reverts commit 594912241cd7d409b5f58a48ccffdc1904d844b2. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1769273002 .
2016-03-08Move xfa/src/fxgraphics/src up one level.Dan Sinclair
This Cl moves the xfa/src/fxgraphics/src code up to the, previously empty, xfa/src/fxgraphics directory and removes xfa/src/fxgraphics/src. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1775733004 .
2016-03-08Remove xfa/src/fxjse/src and move code up a level.Dan Sinclair
This CL removes the xfa/src/fxjse/src and moves all of the .h and .cpp files up to the, previously empty, xfa/src/fxjse directory. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1776643002 .
2016-03-08Remove xfa/src/fxfa/src/common and xfa/src/fxfa/srcDan Sinclair
This Cl moves the code in xfa/src/fxfa/src/common to the diretory which contains the respective implementations and removes the xfa/src/fxfa/src/common directory. It them moves all of the code in xfa/src/fxfa/src up one level and removes the xfa/src/fxfa/src directory. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770073003 .
2016-03-08Fix build breakage at 69af2a34f211Tom Sepez
Fix typo in fx_fnt.h TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1777643002 .
2016-03-08FX_FONTDESCRIPTOR must be POD.Tom Sepez
Since it is malloc'd, memset, and such, and clang-cl notices this. Also delete unused function found by clang-cl. BUG=pdfium:429 R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1777573003 .
2016-03-08Update cast to fix lint warning.Dan Sinclair
The current cast confused runtime/casting. Update to use static_cast and enable the lint warning. BUG=pdfium:426 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770253003 .
2016-03-08Remove xfa/src/fwl/src and move code up a level.Dan Sinclair
This Cl moves the xfa/src/fwl/src code up to the previously empty parent directory and removes xfa/src/fwl/src. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770953004 .
2016-03-08Revert "Force GN build onto XFA (at next roll)."Tom Sepez
This reverts commit 051348757b75bd527d9a8bfffeaf5231b7c24449. Reason for revert: equivalent .gyp CL failed. TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1775983002 .
2016-03-08CXFA_TextParseContext::m_eDisplay is too smallTom Sepez
enum FDE_CSSDISPLAY contains about 20 values, which won't fit into 4 bits. Avoid packing and burn the memory, since I worry about the m_dwMatchedDelcs geting truncated, too. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1771193002 .
2016-03-08Move fx_agg_driver files up one levelDan Sinclair
The agg driver files are split into src/ and include/ directories. This CL moves the source files up one level and removes the src/ and include/ directories. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1773593007 .
2016-03-08Remove extraneous xfa/src/fwl/src include/ directories.Dan Sinclair
This CL collapses the xfa/src/fwl/src/core/include and xfa/src/fwl/src/basewidget/include up one level. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770273002 .
2016-03-07Completely de-virtualize CPDF_SyntaxParser.Tom Sepez
It isn't sub-classed. Making GetNextChar() non-virtual may save a virtual fn call per character if the compilers aren't able to do so themselves. Make members private, not protected. BUG= R=ochang@chromium.org Review URL: https://codereview.chromium.org/1772973002 .
2016-03-07Suppress C4201 for Windows build.Oliver Chang
warning C4201: nonstandard extension used : nameless struct/union R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1767263002 .
2016-03-07Revert "Fix chromium-style errors."Dan Sinclair
This reverts commit c582c0ddfea8ba01c8449ed7841cdb33c12e0a98. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1769263002 .
2016-03-07Fix chromium-style errors.Dan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1772543003 .
2016-03-07Force GN build onto XFA (at next roll).Tom Sepez
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1763913002 .
2016-03-07Fix a regression caused by 7cf13c9Wei Li
BUG=591137 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1769183002 .
2016-03-07Remove _FX_WINAPI_PARTITION_APP_Dan Sinclair
This does not appear to ever be defined, removed. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1773753002 .
2016-03-07Reland "Add option to GYP to use chromium clang plugins."Dan Sinclair
This reverts commit 5ad8474335798295a9c502999324635845d28ff7. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1772713002 .
2016-03-07Fix linux XFA build.Dan Sinclair
This patch is from jinming_wang@foxitsoftware.com. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770103002 .
2016-03-07Remove deprecated declarationsjinming_wang
Remove deprecated declarations BUG=pdfium:356 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1769833002 .
2016-03-04Add unit tests for FPDFBookmark_Find()Wei Li
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1761233002 .
2016-03-04Turn on -Werror for standalone builds.Tom Sepez
This required suppressing the non-virtual-dtor warning, since ICU isn't clean. Getting -Werror in exchange for that seems worthwhile. Chromium's builds are controlled by its own files, which already -Werror. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1765893003 .
2016-03-04Revert "Add option to GYP to use chromium clang plugins."chromium/2671chromium/2670chromium/2669chromium/2668Tom Sepez
This reverts commit 44beca7313284a60c21b4973d42f993b8c248ec9. Reason: broken build on chromium bots. R=ochang@chromium.org TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1766823002 .
2016-03-04Re-land "Only place primitive objects on the V8 global template."Tom Sepez
This reverts commit 1a35d55dd6b0d1ea1918e2d6a6c25faf599ba168. Prevent handles from being destructed after v8 is gone. BUG=pdfium:419 R=ochang@chromium.org Review URL: https://codereview.chromium.org/1761073006 .
2016-03-04Try again to suppress mac warnings.Tom Sepez
TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1766043002 .
2016-03-04Remove V8_DEPRECATION_WARNINGS for mac/xfaTom Sepez
TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1768693002 .
2016-03-04Revert "Only place primitive objects on the V8 global template."Tom Sepez
This reverts commit 3e44a7bd2b60ace1ee8bc8f48c709056f65c3dc1. R=ochang@chromium.org TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1767793002 .