summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-04-16XFA merge: Fix pdfium standalone to compile with VS 2015.Bruce Dawson
This change disables several warnings that fire frequently in pdfium and are not practical to fix at this time. Originally on https://codereview.chromium.org/1096463005 TBR=tsepez@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/1088943003
2015-04-15Merge to XFA: Fix offset outside bounds of constant string warningsJUN FANG
BUG=380476 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1061013003
2015-04-15Merge to XFA: Make FX_NEW throw on OOM.Tom Sepez
Original Review URL: https://codereview.chromium.org/1082253003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1061843005
2015-04-14Fix two new / free mismatchesTom Sepez
R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1085963002
2015-04-14Fix XFA compile under clangTom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1052873006
2015-04-14Merge to XFA: Kill CFX_Object.Tom Sepez
Not just a simple merge, but changes to remove CFX_Object from XFA. Original Review URL: https://codereview.chromium.org/1088733002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1087053002
2015-04-13Merge to XFA: Fix a heap overflow in CJBig2_Context::parseSymbolDictJUN FANG
BUG=476107 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1080893002
2015-04-11Merge to XFA: Fix compiling warnings on WindowsJun Fang
TBR=tsepez@chromium.org BUG=N/A Review URL: https://codereview.chromium.org/1081663002
2015-04-11Merge to XFA: Fix a heap buffer overflow issue in CPDF_CMap::GetNextCharJUN FANG
Add a check to make sure offset is less than the size of string in the function of GetNextChar(). BUG=471651 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1067073003
2015-04-10XFA port: Fix the noisiest variable shadowing warnings in pdfium.Bruce Dawson
Three functions in fx_coordinates.h account for 60% of the warnings when building with VS 2015, due to variable shadowing. Renaming the function parameters is safe, resolves the warnings, and reduces confusion. From https://codereview.chromium.org/1077083003 TBR=tsepez@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/1077283002
2015-04-10Merge to XFA: Better fix for snprintf non-termination on windows.Tom Sepez
TBR=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1073313003
2015-04-10Merge to XFA: Fix a stack overflow in CPDF_Parser::LoadCrossRefV5JUN FANG
A stack overflow was triggered by checked_cast due to invalid index in pdf files like 'Index[45 -1661]'. BUG=473400 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1054303005
2015-04-10Merge to XFA: Don't call FPDF_InitLibrary() in individual unit_tests.Tom Sepez
Original Review URL: https://codereview.chromium.org/1071343002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1079623002
2015-04-09Merge to XFA: Update DEPS to pull V8 from the new repository.Tom Sepez
Original Review URL: https://codereview.chromium.org/1059023003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1072213002
2015-04-09XFA port: Include windows.h instead of the MFC header afxres.hBruce Dawson
VS 2015 RC ships without afxres.h, so fpdfsdkdll.rc fails to compile. afxres.h is really intended for MFC apps so depending on it is a bad idea anyway, so I changed both references to windows.h. See http://stackoverflow.com/questions/1575559 for some other perspective on this. Ported from https://codereview.chromium.org/1078513002 TBR=tsepez@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/1073933002
2015-04-09Merge to XFA: testing utility combo patchTom Sepez
This pulls in the following CLs from master: Review URL: https://codereview.chromium.org/1072613003 Review URL: https://codereview.chromium.org/1058463004 Review URL: https://codereview.chromium.org/1057983003 Review URL: https://codereview.chromium.org/1036073002 Review URL: https://codereview.chromium.org/1031203003 Review URL: https://codereview.chromium.org/1029193002 Review URL: https://codereview.chromium.org/1016613004 Review URL: https://codereview.chromium.org/1026903002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1062163003
2015-04-09Merge to XFA: Fix ref to timezone variable - removed in VS 2015Bruce Dawson
It turns out that 'timezone' has been deprecated for a while. If deprecation messages are enabled then VS 2013 says this when 'timezone' is referenced: warning C4996: 'timezone': This function or variable may be unsafe. Consider using _get_timezone instead. Sometimes features stay deprecated for decades, but in this case 'timezone' is now gone. Merged from change https://codereview.chromium.org/1075673002 TBR=tsepez@chromium.org BUG=440500 Review URL: https://codereview.chromium.org/1077773002
2015-04-09Merge to XFA: Fix a global buffer overflow in ↵Jun Fang
GCPDF_CIDFont::_CharCodeFromUnicode There is not a code page (CP) used for converting unicode to mutli-bytes if the coding scheme is CID coding. Only return 0 if CID can't be retrieved. The difference on Windows and other platforms should be the function used for converting rather than others. BUG=466790 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1074653002
2015-04-08Merge to XFA: Fix IWYU in formfiller/ directory.Tom Sepez
Original Review URL: https://codereview.chromium.org/1066253002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1073563003
2015-04-08Merge to XFA: Use pdfium-specific tree closer for gating landingsTom Sepez
Original Review URL: https://codereview.chromium.org/1066413004 TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1071623002
2015-04-08FFL_MIN and FFL_MAX are pointless and stupid.Tom Sepez
Kill some nearby dead code while I'm at it. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1064283002
2015-04-07Merge to XFA: Fix a stack overflow issue caused by an invalid usage of snprintfJun Fang
BUG=469244 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1062983002
2015-04-07Merge to XFA: Fix IWYU in pdfwindow/ directory.Tom Sepez
This incorporates class vs. struct fix in 34f5fc0f2a18 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1063283002
2015-04-07Merge to XFA: Fix (nearly all) IWYU in fpdfskd/include/javascript/ headers.Tom Sepez
Original Review URL: https://codereview.chromium.org/1060133002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1065103002
2015-04-06Merge to XFA: Fix IWYU in fxcrt headers.Tom Sepez
Note: new includes for XFA Original Review URL: https://codereview.chromium.org/1064433005 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1062843003
2015-04-06Merge to XFA: fix missing semicolonsJUN FANG
TBR=tsepez@chromium.org BUG=N/A Review URL: https://codereview.chromium.org/1068513002
2015-04-06Merge to XFA: Fix a fatal error due to cloning a global document objectJUN FANG
BUG=454595 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1053373002
2015-04-03Merge to XFA: Update the path of header file to avoid a compiling error in ↵JUN FANG
chrome BUG=N/A R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1059233005
2015-04-03Merge to XFA: No-op change to poke the bots after being out of sequence.Tom Sepez
Adds a comment and changes some whitespace. TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1059373002
2015-04-03Merge to XFA: Fix a compiling error in fpdf_parser_parser_embeddertest.cppJun Fang
BUG=N/A R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1057383002
2015-04-03Merge to XFA: Add embedder test comparing with the last patch.JUN FANG
When there is a wrong keyword like '??ze' in the dictionary of the trailer, PDFium can't recognize it and aborts further parsing. After this change, PDFium continues even it can't get the right size at this moment. It will rebuild the cross reference table later since the size of the table is missing. BUG=459580 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1055323003
2015-04-02Merge to XFA: Fix uninitialized face in fx_ge_font.cppJUN FANG
MSAN reported this issue when I tried to reproduce 460936 in the last version of freetype on Linux. BUG=N/A R=thestig@chromium.org Review URL: https://codereview.chromium.org/1050333002
2015-04-01Merge to XFA: doc.external - Check direction of property access before ↵Tom Sepez
blindly getting. Original Review URL: https://codereview.chromium.org/1039063002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1056583002
2015-03-30Merge to XFA: Fix no text displayed issue when font embedded and font ↵JUN FANG
subsetting enabled BUG=465322 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1045553004
2015-03-20Merge to XFA: Fix missing include for std::minTom Sepez
Original Review URL: https://codereview.chromium.org/1026843002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1025753002
2015-03-19Merge to XFA: Fix subtle issues in opj_skip_from_memory and add unit tests.Tom Sepez
Original Review URL: https://codereview.chromium.org/1016203002 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1027443002
2015-03-17Merge to XFA: Return OS status code from python test driver scripts.Tom Sepez
Original Review URL: https://codereview.chromium.org/1014083003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1011243002
2015-03-16Merge to XFA: Pull our new test case repository via deps.Tom Sepez
Original Review URL: https://codereview.chromium.org/1010833003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1010973002
2015-03-16Merge to XFA: Speculative fix for breakage in pdfum DEPS rollTom Sepez
Original Review URL: https://codereview.chromium.org/1011803003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1015543002
2015-03-16Merge to XFA: Fix a bug that JPX images can't be shownJUN FANG
In the process of opj_end_decompress, it will return fail when the end of coding stream is reached. However it returns true in the same scenario implemented in openJPEG. So the final solution is from openJPEG. Return true when the end of coding stream is reached. BUG=452671 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/990683002
2015-03-16Merge to XFA: Fix potential integer overflow in fpdf_render_image.cppJUN FANG
BUG=382661 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1007643002
2015-03-11XFA: bound memcpy length in _png_load_bmp_attribute()Tom Sepez
BUG=466338 R=thestig@chromium.org Review URL: https://codereview.chromium.org/997273002
2015-03-11Merge to XFA: Kill remaining sprintfsTom Sepez
There is fx_codec_png.cpp that has a sprintf under XFA that was not present in master. Original Review URL: https://codereview.chromium.org/999543002 R=thestig@chromium.org Review URL: https://codereview.chromium.org/995993002
2015-03-09Remove the calling 'FPDF_HasXFAField' in LoadXFADocJUN FANG
BUG=NA R=tsepez@chromium.org Review URL: https://codereview.chromium.org/983253004
2015-03-06Merge to XFA: Make conversions for CPDF_Link explicit.Tom Sepez
Original Review URL: https://codereview.chromium.org/985503005 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/985153002
2015-03-06Merge to XFA: Make conversion between CPDF_Dest and its object explicit.Tom Sepez
Original Review URL: https://codereview.chromium.org/984703004 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/984143002
2015-03-06Merge to XFA: Add gmock to .gitignoreTom Sepez
Original Review URL: https://codereview.chromium.org/985833002 TBR=halyavin@chromium.org Review URL: https://codereview.chromium.org/985713004
2015-03-05Merge to XFA: Make conversion between CPDF_Action and its dictionary explicit.Tom Sepez
Original Review URL: https://codereview.chromium.org/984773002 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/984783002
2015-03-05Check whether a pdf has XFA fields before loading XFA fieldsJUN FANG
BUG=452793 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/973673002
2015-03-03Fix pdfium_embeddertests on XFA.Tom Sepez
Required to avoid a DCHECK() due to recent changes in V8 initialization. This mirrors the changes introduced at b045ed21 to pdfium_test.cpp in pdfium_embeddertest.cpp R=jam@chromium.org Review URL: https://codereview.chromium.org/969243002