summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-03-09Support clang-cl build on Windows.Oliver Chang
R=thakis@chromium.org, tsepez@chromium.org BUG= Review URL: https://codereview.chromium.org/1774123005 .
2016-03-09Fix non-xfa builds.Dan Sinclair
Fixup some includes so we can still build non-xfa. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1781643002 .
2016-03-09Review and cleanup lint warnings.Dan Sinclair
This CL goes through the remaining list of list warnings and records why they are currently blacklisted, or fixes and enables them. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1773733002 .
2016-03-08Fix build at 310438fb97a2chromium/2672Tom Sepez
Missing include in fsdk_mgr.h TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1774303002 .
2016-03-08Split off CPDF_Document into its own .cpp/.h files.Tom Sepez
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1780503002 .
2016-03-08Re-land "Split CPDF_SyntaxParser into its own named .cpp/.h files."Tom Sepez
This reverts commit 06fae28d307fe051f0c7e890344cd487c2260910. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1775023003 .
2016-03-08Missing return, broken win build.Dan Sinclair
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1775913003 .
2016-03-08Revert "Split CPDF_SyntaxParser into its own named .cpp/.h files."Tom Sepez
This reverts commit d50095fb151688e119a7097aabce11e4b3d36244. Reason for revert: build broken. TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1774293002 .
2016-03-08Split CPDF_SyntaxParser into its own named .cpp/.h files.Tom Sepez
BUG= R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1774753002 .
2016-03-08Reland "Fix chromium-style errors."Dan Sinclair
This reverts commit 594912241cd7d409b5f58a48ccffdc1904d844b2. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1769273002 .
2016-03-08Move xfa/src/fxgraphics/src up one level.Dan Sinclair
This Cl moves the xfa/src/fxgraphics/src code up to the, previously empty, xfa/src/fxgraphics directory and removes xfa/src/fxgraphics/src. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1775733004 .
2016-03-08Remove xfa/src/fxjse/src and move code up a level.Dan Sinclair
This CL removes the xfa/src/fxjse/src and moves all of the .h and .cpp files up to the, previously empty, xfa/src/fxjse directory. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1776643002 .
2016-03-08Remove xfa/src/fxfa/src/common and xfa/src/fxfa/srcDan Sinclair
This Cl moves the code in xfa/src/fxfa/src/common to the diretory which contains the respective implementations and removes the xfa/src/fxfa/src/common directory. It them moves all of the code in xfa/src/fxfa/src up one level and removes the xfa/src/fxfa/src directory. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770073003 .
2016-03-08Fix build breakage at 69af2a34f211Tom Sepez
Fix typo in fx_fnt.h TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1777643002 .
2016-03-08FX_FONTDESCRIPTOR must be POD.Tom Sepez
Since it is malloc'd, memset, and such, and clang-cl notices this. Also delete unused function found by clang-cl. BUG=pdfium:429 R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1777573003 .
2016-03-08Update cast to fix lint warning.Dan Sinclair
The current cast confused runtime/casting. Update to use static_cast and enable the lint warning. BUG=pdfium:426 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770253003 .
2016-03-08Remove xfa/src/fwl/src and move code up a level.Dan Sinclair
This Cl moves the xfa/src/fwl/src code up to the previously empty parent directory and removes xfa/src/fwl/src. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770953004 .
2016-03-08Revert "Force GN build onto XFA (at next roll)."Tom Sepez
This reverts commit 051348757b75bd527d9a8bfffeaf5231b7c24449. Reason for revert: equivalent .gyp CL failed. TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1775983002 .
2016-03-08CXFA_TextParseContext::m_eDisplay is too smallTom Sepez
enum FDE_CSSDISPLAY contains about 20 values, which won't fit into 4 bits. Avoid packing and burn the memory, since I worry about the m_dwMatchedDelcs geting truncated, too. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1771193002 .
2016-03-08Move fx_agg_driver files up one levelDan Sinclair
The agg driver files are split into src/ and include/ directories. This CL moves the source files up one level and removes the src/ and include/ directories. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1773593007 .
2016-03-08Remove extraneous xfa/src/fwl/src include/ directories.Dan Sinclair
This CL collapses the xfa/src/fwl/src/core/include and xfa/src/fwl/src/basewidget/include up one level. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770273002 .
2016-03-07Completely de-virtualize CPDF_SyntaxParser.Tom Sepez
It isn't sub-classed. Making GetNextChar() non-virtual may save a virtual fn call per character if the compilers aren't able to do so themselves. Make members private, not protected. BUG= R=ochang@chromium.org Review URL: https://codereview.chromium.org/1772973002 .
2016-03-07Suppress C4201 for Windows build.Oliver Chang
warning C4201: nonstandard extension used : nameless struct/union R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1767263002 .
2016-03-07Revert "Fix chromium-style errors."Dan Sinclair
This reverts commit c582c0ddfea8ba01c8449ed7841cdb33c12e0a98. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1769263002 .
2016-03-07Fix chromium-style errors.Dan Sinclair
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1772543003 .
2016-03-07Force GN build onto XFA (at next roll).Tom Sepez
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1763913002 .
2016-03-07Fix a regression caused by 7cf13c9Wei Li
BUG=591137 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1769183002 .
2016-03-07Remove _FX_WINAPI_PARTITION_APP_Dan Sinclair
This does not appear to ever be defined, removed. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1773753002 .
2016-03-07Reland "Add option to GYP to use chromium clang plugins."Dan Sinclair
This reverts commit 5ad8474335798295a9c502999324635845d28ff7. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1772713002 .
2016-03-07Fix linux XFA build.Dan Sinclair
This patch is from jinming_wang@foxitsoftware.com. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1770103002 .
2016-03-07Remove deprecated declarationsjinming_wang
Remove deprecated declarations BUG=pdfium:356 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1769833002 .
2016-03-04Add unit tests for FPDFBookmark_Find()Wei Li
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1761233002 .
2016-03-04Turn on -Werror for standalone builds.Tom Sepez
This required suppressing the non-virtual-dtor warning, since ICU isn't clean. Getting -Werror in exchange for that seems worthwhile. Chromium's builds are controlled by its own files, which already -Werror. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1765893003 .
2016-03-04Revert "Add option to GYP to use chromium clang plugins."chromium/2671chromium/2670chromium/2669chromium/2668Tom Sepez
This reverts commit 44beca7313284a60c21b4973d42f993b8c248ec9. Reason: broken build on chromium bots. R=ochang@chromium.org TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1766823002 .
2016-03-04Re-land "Only place primitive objects on the V8 global template."Tom Sepez
This reverts commit 1a35d55dd6b0d1ea1918e2d6a6c25faf599ba168. Prevent handles from being destructed after v8 is gone. BUG=pdfium:419 R=ochang@chromium.org Review URL: https://codereview.chromium.org/1761073006 .
2016-03-04Try again to suppress mac warnings.Tom Sepez
TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1766043002 .
2016-03-04Remove V8_DEPRECATION_WARNINGS for mac/xfaTom Sepez
TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1768693002 .
2016-03-04Revert "Only place primitive objects on the V8 global template."Tom Sepez
This reverts commit 3e44a7bd2b60ace1ee8bc8f48c709056f65c3dc1. R=ochang@chromium.org TBR=ochang@chromium.org Review URL: https://codereview.chromium.org/1767793002 .
2016-03-04Only place primitive objects on the V8 global template.Tom Sepez
Kill some crummy comments along the way. BUG=pdfium:419 R=jochen@chromium.org Review URL: https://codereview.chromium.org/1759893002 .
2016-03-04Try again to suppress mac deprecation warnings.Tom Sepez
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1770473002 .
2016-03-04Suppress same windows warnings in xfa.gypTom Sepez
See https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/178070/steps/compile%20%28with%20patch%29/logs/stdio R=ochang@chromium.org Review URL: https://codereview.chromium.org/1770453002 .
2016-03-04Small change to enable skia-backed version of pdfium.Cary Clark
This only directs paths to use Skia. Text and bitmaps still use antigrain. Clipping is disabled -- still figuring out pdfium's model for saving and restoring clips. Deleting the Skia canvas is disabled -- there's some build problem where the pdfium and skia libraries are built with slightly different options that I haven't tracked down. This is also why for the moment SkDebugf is defined locally. With this patch and pdf_use_skia=1 a modestly complicated PDF draws (mostly) correctly with pdfium_test. R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair BUG= Review URL: https://codereview.chromium.org/1761453002 .
2016-03-04Fix deprecated ObjectTemplate::New() and TryCatch() warnings.Tom Sepez
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1762643003 .
2016-03-03Combine StrToInt methods.Dan Sinclair
This Cl combines the two StrToInt implementations. In doing so I had to add some more overrides to toDecimalDigit() and add a isDecimalDigit(). BUG=pdfium:423 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1757283002 .
2016-03-03Add option to GYP to use chromium clang plugins.Dan Sinclair
This CL will enable the chromium-style checks when building. It is currently disabled by default as there are a lot of warnings. I only added this to GYP because there is no standalone GN build, so I have no way to test. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1760213002 .
2016-03-03Fixup chromium-style warnings in fpdf_objects.hDan Sinclair
This CL fixes up chromium-style warnings in fpdf_object.h Specifically, the warnings fixed were: * Complex constructor has an inlined body. * Complex destructor has an inline body. * virtual methods with non-empty bodies shouldn't be declared inline. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1764793002 .
2016-03-03Suppress deprecation warnings for XFA.chromium/2667Tom Sepez
Temporary measure until FX fixes these (or I do). This is blocking rolling XFA into chrome. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1764503003 .
2016-03-03Remove other remaining use of std::list::size() from loop body.Tom Sepez
R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1761993002 .
2016-03-03Fix infinite loop for bookmark searchWei Li
BUG=pdfium:420 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1757373002 .
2016-03-03Add JS tests for global const equality.Tom Sepez
Add these tests before fixing bug 419. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1761923002 .