Age | Commit message (Collapse) | Author |
|
Original Review URL: https://codereview.chromium.org/1181943008.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1187273006.
|
|
Original Review URL: https://codereview.chromium.org/1152743007.
BUG=pdfium:166
R=brucedawson@chromium.org, thestig@chromium.org
TBR=brucedawson@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1186423003.
|
|
Original review URL: https://codereview.chromium.org/1185903002.
BUG=pdfium:170
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1182083004.
|
|
Really?
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1183193004.
|
|
Original Review URL: https://codereview.chromium.org/1182903002.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1191553005.
|
|
CPDF_DocPageData::GetFontFileStreamAcc().
The input cannot be null. Same for CPDF_Document::LoadFontFile().
Also set the contract for CPDF_Document::LoadFont() and adjust callers
accordingly.
Also remove unused CPDF_Document::FindFont().
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1184673002.
(cherry picked from commit 1972b16849fedfda675eacd5c8594b54dbd1264d)
Review URL: https://codereview.chromium.org/1181393002.
|
|
Review URL: https://codereview.chromium.org/1180333002.
|
|
Review URL: https://codereview.chromium.org/1185843005.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1181803002.
(cherry picked from commit f25db681003f0247e97bfef22be56a8aa02b7595)
Review URL: https://codereview.chromium.org/1182993002.
|
|
Also remove commented out code and trailing whitespaces.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1179653005.
(cherry picked from commit eda202769e5c79eba1d2fb5090f6e9cf176e2d4a)
Review URL: https://codereview.chromium.org/1187733002.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1173223002.
(cherry picked from commit 2b5e0d5b20654d116045484868c9e015ed698124)
Review URL: https://codereview.chromium.org/1186673004.
|
|
Original Review URL: https://codereview.chromium.org/1178393002.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1184803002.
|
|
If the font is 'tricky', it needs to be hinted by default according to the description in freetype.
BUG=490814
TBR=jun_fang@foxitsoftware.com
Original Review URL: https://codereview.chromium.org/1170313003.
Review URL: https://codereview.chromium.org/1175243008.
|
|
Only manual merge was core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp
follwed by scripts.
Original Review URL: https://codereview.chromium.org/1179693003.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1179953002.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1144333008.
(cherry picked from commit f726c92cb2cf5739fd5b21e825e5bf510040c62f)
Review URL: https://codereview.chromium.org/1180653004.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1143133008.
(cherry picked from commit 77713645f64214b8d5e79f62a92bb03452ce232e)
Review URL: https://codereview.chromium.org/1179693004.
|
|
Also simplify CPDF_DocPageData::ReleaseIccProfile() since its first
argument is always null.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1149273004.
(cherry picked from commit a8a718c974210a919f2af0b099d540143cf330c6)
Review URL: https://codereview.chromium.org/1180613004.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1162123004.
(cherry picked from commit b3aa96cbee31e81d0a72a61027467a2713654499)
Review URL: https://codereview.chromium.org/1181573005.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1154963003.
(cherry picked from commit 22f429fc4875027b10ab071102c9ac8a88abf825)
Review URL: https://codereview.chromium.org/1179783002.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1151133004.
(cherry picked from commit 3c949d5d2b0d680839766ea99c86b263230b263d)
Review URL: https://codereview.chromium.org/1174173005.
|
|
Nearly automatic merge + re-run script on new files.
Original Review URL: https://codereview.chromium.org/1180593004.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1174303002.
|
|
returns 0.
Remove callers and related code that all just pass zeros around.
Also remove CFFL_IFormFiller::GetKeyDown().
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1149623012.
(cherry picked from commit 35c3163d55bebea8095474181f807ddfb2f4f806)
Review URL: https://codereview.chromium.org/1175083003.
|
|
BUG=495300
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1178513002.
(cherry picked from commit 7b2897c47245f04c806cfa8cee09458e31ba3777)
Review URL: https://codereview.chromium.org/1177003002.
|
|
Original Review URL: https://codereview.chromium.org/1171733003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1178613002.
|
|
Near-automatic merge, plus re-running scripts to update
additional usage.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1172793002
|
|
New manual edits in the following to fix compilation:
fx_bmp.h, fx_gif.h, fx_graphics.h
Original Review URL: https://codereview.chromium.org/1169963003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1170103004
|
|
CPDF_DIBSource::LoadJpxBitmap().
Leaks can happen in several places. For this particular bug, it happens
when there is a colorspace component count mismatch.
BUG=497191
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1153633009
(cherry picked from commit 2a824f1c0ed786aed0dd15a0ea60dc90999e2b2c)
Review URL: https://codereview.chromium.org/1168833002
|
|
Remove dead code in CPDF_Annot as well.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1157773012
(cherry picked from commit b7eb193dcec1594952cbc1dca356a40f66724159)
Review URL: https://codereview.chromium.org/1157323005
|
|
Original Review URL: https://codereview.chromium.org/1162203007
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1154023005
|
|
Original Review URL: https://codereview.chromium.org/1149623011
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1152523007
|
|
Also sort includes missing from previous patch (some xfa IWYU
prevents full sorting).
Original Review URL: https://codereview.chromium.org/1149213008
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1157103009
|
|
Original Review URL: https://codereview.chromium.org/1147353006
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1152693005
|
|
Original Review URL: https://codereview.chromium.org/1168503003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1153033009
|
|
Original Review URL: https://codereview.chromium.org/1165863003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1163113002
|
|
Original Review URL: https://codereview.chromium.org/1153213004
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1158483004
|
|
Original Review URL: https://codereview.chromium.org/1158053003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1156203004
|
|
A second case of casting willy-nilly between unrelated structures
to provide information hiding. Bad Idea. Remove dozens of casts
in the process.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1155273002
|
|
testing/tools/run_corpus_tests.py assumes a debug build and will
fail cryptically if only a release build is available.
Arguably there shouldn't be a default because having one could lead
to accidentally running a stale version, but that is probably too
much of a change.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1150823003
Review URL: https://codereview.chromium.org/1158883005
|
|
Original change by bungeman@chromium.org
A reference to nonstd_unique_ptr.h was added with
https://codereview.chromium.org/1091283002 but a comma is missing
after it. This causes this string to be concatenated with the next,
leading to broken sources. This went unnoticed by the build due to
the fact that the affected sources are both headers, but they should
be properly separated.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1156663006
Review URL: https://codereview.chromium.org/1156483006
|
|
Original Review URL: https://codereview.chromium.org/1160443004
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1162013003
|
|
There are better ways to provide information hiding than casting
willy-nilly from an unrelated structure. Kill dozens of casts in
the process.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1146153005
|
|
Original Review URL: https://codereview.chromium.org/1162453003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1154613005
|
|
Move interface comments from the implementation header to the
interface header.
Replace Create / Release functions with static methods.
Replace dubious Release() methods with deletion via virtual dtor, also
for IXFA_App and IXFA_FontMgr while we're at it.
Untabify and fix (theoretically) illegal _CAP include guard definitions
for fpdfxfa/ headers.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1153553003
|
|
BUG=459215
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1160663002
|
|
Original Review URL: https://codereview.chromium.org/1126243007
BUG=488302
TBR=eroman@chromium.org
Review URL: https://codereview.chromium.org/1153543003
|
|
Original Review URL: https://codereview.chromium.org/1148353002
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1150103002
|
|
This issue is trigged by the conversion from unsigned int to signed int.
A large unsigned int is converted to int. It's represented as a negative
int which is used in the condition of while later.
BUG=482639
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1146913003
|
|
1. New size should be larger than old size in JBig2_Realloc.
2. Arguments are integers but parameters are size_t in JBIG2_memset.
After integer overflows, it will be presented as a huge
unsigned number on 64 bits system.
BUG=483981
R=brucedawson@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1148643002
|
|
Original Review URL: https://codereview.chromium.org/1139993003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1144973004
|
|
Original Review URL: https://codereview.chromium.org/1142713005
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1143663008
|