Age | Commit message (Collapse) | Author |
|
The only one that is ever used is FXDIB_PALETTE_loc, so remove
the option entirely. In turn, this allows deleting about 2KB
of unused constant tables.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1809943007 .
|
|
Re-enable the following warnings:
4245: signed/unsigned conversion mismatch;
4310: cast may truncate data;
4389: operator on signed/unsigned mismatch;
4701: use potentially uninitialized local variable;
4706: assignment within conditional expression
Clean up the code to avoid those warnings.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1801383002 .
|
|
When both text objects have no items, directly return TRUE;
The last if statement moved inside loop to make the intent more
obvious and free from warning (msvc warns using potentially
uninitialized var itemPer)
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1815453002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1824643002 .
|
|
This CL splits the file into individual classes and moves them into
core/fpdfapi/fpdf_page as needed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1811053002 .
|
|
This CL moves the .h files and renames the .cpp files to match.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1809193002 .
|
|
R=nodir@chromium.org
Review URL: https://codereview.chromium.org/1817683002 .
|
|
BUG=591789
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1814223003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1820573002 .
|
|
Add CQ configuration file to infra/config directory.
R=tandrii@chromium.org
Review URL: https://codereview.chromium.org/1819513002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1808853007 .
|
|
Saves a few bytes here and there because the tables need
only 16 bits but wchar is 32 bits (except on windows).
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1815313003 .
|
|
When building with clang-cl and not passing /FIintrin.h, the
__attribute__ defined to nothing, which confuses the compiler
(see bug).
Since nothing seems to require the __attribute__ redefinition,
just remove it.
Reported upstream here: https://github.com/uclouvain/openjpeg/issues/727
BUG=592745
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810373002 .
|
|
Either by using the smallest possible data type, or
By accurately calcuating the bounds, or
Moving to array of pointers for varying length rows.
Notes:
The 929 is reassuring since PDF417 barcode uses GF(929).
FX_WCHAR is 4 bytes on unix (2 on windows).
Binary looks to be about 240k smaller on linux/64
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1807373002 .
|
|
-Wno-sign-compare also for GCC.
-Wno-error=strict-overflow to ignore the following warning.
In file included from
../../third_party/pdfium/core/include/fpdfapi/cpdf_object.h:10:0,
from
../../third_party/pdfium/core/include/fpdfapi/cpdf_stream.h:10,
from
../../third_party/pdfium/core/include/fpdfapi/fpdf_resource.h:12,
from
../../third_party/pdfium/core/fpdfapi/fpdf_font/font_int.h:13,
from
../../third_party/pdfium/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp:7:
../../third_party/pdfium/core/include/fxcrt/fx_string.h: In function
'CFX_ByteString {anonymous}::CMap_GetString(const CFX_ByteStringC&)':
../../third_party/pdfium/core/include/fxcrt/fx_string.h:111:19: warning:
assuming signed overflow does not occur when assuming that (X - c) > X is always
false [-Wstrict-overflow]
if (count < 0 || count > m_Length - index) {
BUG=589724
TEST=build with GCC
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1785943002 .
|
|
BUG=pdfium:401
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1758553003 .
|
|
Add missing stdarg.h file so mac can build with skia.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1813633002 .
|
|
This CL fixes up build issues with pdfium_use_skia=1 on windows.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810063002 .
|
|
More Skia driver cleanup.
Fix the GN build for Skia.
Remove unused functions from header.
Remove agg setup that is not required.
Change path construction to use the SkCanvas matrix to position the path
rather than converting the points directly.
Draw stroked paths using Skia rather than generated the filled path.
Pin the minimum stroke width to 1 px in device space to mimic PDF's stroke
dropout control.
Factor out flipped and non-flipped matrices.
Add some debugging code.
Set the bitmap filter quality to high. This helps a lot with 1 bit sources.
R=dsinclair@chromium.org, dsinclair, tsepez
Review URL: https://codereview.chromium.org/1806843002 .
|
|
This Cl moves and splits apart the fx_graphics.h file into individual classes.
The .cpp files are renamed to match the .h files. pre.h was removed at the
same time and its contents moved to the correct places as needed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810563002 .
|
|
This CL adds the necessary pieces so you can add pdf_use_skia=1 to GYP_DEFINES
and do a standalone build.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/1812563002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1806683003 .
|
|
This CL splits the fpdf_page.h header into the individual classes and moves
them to the correct core/fpdfapi locations.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1805663002 .
|
|
Fix warnings in win32_int.h
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1809473002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1797423002 .
|
|
Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents. In
print preview, chromium first inserts blank pages and then
replaces them later on, causing the associated bug.
BUG=594111
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1804163002 .
|
|
This CL moves the fxjse.h header and splits the cfxjse_arguments.h into its
own file.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1807623002 .
|
|
Using a list is more appropriate, since we wish to delete
from the middle.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1780093003 .
|
|
This Cl moves a bunch of the files from core/include/fpdfapi to their correct
location outside the core/include tree.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1805603002 .
|
|
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1800793002 .
|
|
Fix an incorrect unit test result.
This reverts commit 2df269c52741c12d63300cee806e96ae5d0b038f.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1803043002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1783933003 .
|
|
This reverts commit 48b934135171b55b1ffc510226317fdddef5f5b8.
Broke unit tests.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1800153002 .
|
|
sycc422_to_rgb was incorrect. This patch adds a similar check to the one
in sycc420, and fixes an issue with the previous sycc_420_size_is_valid
function where truncation from division wasn't accounted for.
BUG=591785
R=jun_fang@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1785323003 .
|
|
Make .h/.cpp filenames match.
Add header for unicodenormalization.cpp
Remove dead code.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1796303002 .
|
|
Re-enable the warning by naming the unnamed structs. Also clean up
fx_graphics files.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1784323006 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1799913002 .
|
|
This is a first-cut at supporting bitmaps.
Also added a --skp option to pdfium_test to generate
a Skia picture file. The picture file can be loaded
in Skia's SampleApp, debugger, or skiaserver to
examine the generated picture.
(This also includes fixes suggested in the prior Skia CL.
My apologies for fat-fingers abandoning that one.)
R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair
Review URL: https://codereview.chromium.org/1776313002 .
|
|
This CL moves the two files and breaks fpdf_text.h apart into individual pieces.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1801973002 .
|
|
This CL adds the needed DEPS files to make checkdeps pass correctly. The
checkdeps PRESUBMIT method has been copied from Chromium and is enabled on
CL upload.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1801923002 .
|
|
This CL moves the xfa/src files up to the xfa/ directory and fixes the includes,
include guards, and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1803723002 .
|
|
This CL moves the files in fpdfsdk/src/ up one level to fpdfsdk/ and fixes
up the include paths, include guards and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1799773002 .
|
|
Alterntive to part of https://codereview.chromium.org/1785943002/
BUG=589724
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1802553004 .
|
|
This CL moves the core/src/ files up to core/ and fixes up the include guards,
includes and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1800523005 .
|
|
Mainly change the code to avoid the warnings; in a few cases we have
to use explicit casts.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1783023002 .
|
|
TBR=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1784243007 .
|
|
Enabling of XFA-Forms in crrev.com/1775173002 broke VS 2015 builds
because of a conflict between the lfind declaration in libtiff\tiffiop.h
and the one that ships with VS 2015. Defining HAVE_SEARCH_H for VS 2015
builds fixes this problem
BUG=440500,593996
R=thakis@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1781043005 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1776913007 .
|
|
Also remove unnecessary casts.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1783933002 .
|
|
Fixes 32-bit clang-cl build.
These intrinsics require addresses with 16-byte alignment, which doesn't
cause issues for 64-bit builds because of allocator alignment. MSVC
doesn't recognise the __SSE__, __SSE2__ defines, which is why this problem
never surfaced before.
R=tsepez@chromium.org
BUG=pdfium:433
Review URL: https://codereview.chromium.org/1783813003 .
|