Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
BUG=pdfium:241
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1422193002 .
(cherry picked from commit 24b2eab6351920dd60210b6dcd350c9921e7b3b5)
Review URL: https://codereview.chromium.org/1421343004 .
|
|
Clean merge.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1412823005 .
(cherry picked from commit 044c06f11fb5e62f0984f960be2717ab9bcb540d)
Review URL: https://codereview.chromium.org/1413693010 .
|
|
warning.
BUG=547906
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1420503012 .
(cherry picked from commit f7a8b34f520f1d4892f009700972ab2995ed2681)
Review URL: https://codereview.chromium.org/1415453004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1420613006 .
|
|
Also fix a potential object leak.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1414963005 .
(cherry picked from commit f7992b39cec908e549fb995acae477a9efba538b)
Review URL: https://codereview.chromium.org/1421253005 .
|
|
Makes the files in this CL identical to master, since there are
no XFA specifics.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1425663003 .
|
|
As seen in FPDFViewEmbeddertest.Crasher_451830.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1385803002 .
(cherry picked from commit a568ff2dddd3ef44f224d21b31afff8eb14b6d31)
Review URL: https://codereview.chromium.org/1420303005 .
|
|
This reverts commit 7e155865c90cc1115cc7193b7646a341d8f9093e.
Add type cast definitions for CPDF_Reference.
This Cl adds ToReference, CPDF_Object::AsReference and CPDF_Object::IsReference
and updates the src to use them as needed.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1418923005 .
(cherry picked from commit 6ee3484bcb413f4cce303e237fe15e2bdaf51ade)
Review URL: https://codereview.chromium.org/1410073007 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1421313002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411203007 .
(cherry picked from commit 9b2741829b8a8c511ef0f2f313ff53d77ac96307)
Review URL: https://codereview.chromium.org/1408263005 .
|
|
Missing merge from master.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1405133009 .
|
|
std::vector.
Clean merge.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411043003 .
(cherry picked from commit bef190fcacb7dde4fedc1360e3019ab9968db16a)
Review URL: https://codereview.chromium.org/1418223004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1423693005 .
|
|
Also fx_quartz_device.cpp
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1424613002 .
|
|
Cloning a CPDF_Stream actually happens via CPDF_Object::Clone().
Transitively, remove:
- GetStreamFilter()
-- all the filters.
Also remove CXFA_FileRead.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1288543002 .
(cherry picked from commit c9a05f1c90860a97dbe4b8014bc4584bfa3a4580)
Review URL: https://codereview.chromium.org/1297463002 .
|
|
Includes one array bounds fix.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1412583003 .
|
|
Fix a few other master formatting diffs (no-{}, newlines).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1405133008 .
|
|
Driven off of https://codereview.chromium.org/1398383002/
Then make the other files as similar as possible. Note that this
required changes to xfa/ code, and required adding some Set() methods.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411833003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1412453005 .
|
|
This limit mirrors FX_MAX_PAGE_LEVEL in fpdf_parser_document.cpp
Clean merge.
TBR=thestig@chromium.org
BUG=544880
Review URL: https://codereview.chromium.org/1421743003 .
(cherry picked from commit 3bfb1dcf56f8470b693ad1126e24e65f9d17926c)
Review URL: https://codereview.chromium.org/1418173003 .
|
|
Thanks Stack Overflow!
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1421623002 .
(cherry picked from commit 61fe6edb3f789feefa4bd0c8475b9645fae0d09e)
Review URL: https://codereview.chromium.org/1420543004 .
|
|
This Cl adds ToStream, CPDF_Object::AsStream and CPDF_Object::IsStream and
updates the src to use them as needed.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1402413004 .
(cherry picked from commit 338805f1366dcdf9a5b48cf591541cf98d7490f1)
Review URL: https://codereview.chromium.org/1422513004 .
|
|
This Cl adds ToArray, CPDF_Object::AsArray and CPDF_Object::IsArray and
updates the src to use them as needed.
BUG=pdfium:201
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417893003 .
(cherry picked from commit c2bfc000e502c42c9a3017038fd9104c7997d126)
Review URL: https://codereview.chromium.org/1419643005 .
|
|
This Cl syncs the AUTHORS, and README.md and build scripts in XFA to match master where possible.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415423002 .
|
|
Also fixes a potential memory leak.
R=tsepez@chromium.org, thestig@chromium.org
BUG=pdfium:156
Review URL: https://codereview.chromium.org/1409973003 .
(cherry picked from commit de49cf173d12fe7a462168e2bf6c44971d7d28f8)
Review URL: https://codereview.chromium.org/1420103002 .
|
|
This method isn't used anywhere and the implementation doesn't really do
anything.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1405163003 .
(cherry picked from commit 162f227af9c5e28885a36e6ca06a09c12c6223e0)
Review URL: https://codereview.chromium.org/1416283002 .
|
|
Context: DEPS was originally added to pdfium to allow its recipe to
automatically check out its dependencies. The recipe used absolute
paths, and so the checkout directory's name ('pdfium') had to be
prefixed to the directory checkout of every dependency, as gclient in
the recipe worked one level above the pdfium checkout itself.
After change fe4537269fc7133320a5131638757f2ffa6bd854, the recipe no
longer worked. To fix this, I'm making DEPS use relative paths.
BUG=375773
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/724113003
(cherry picked from commit 39c6b4c50bb06336c2b592a407efa862ff6ed8ae)
Review URL: https://codereview.chromium.org/1421703002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1412733011 .
(cherry picked from commit 5a5b6fb3759daf1201ffc9702f626f4b243922d0)
Review URL: https://codereview.chromium.org/1414463006 .
|
|
Also adds support for ASan and sanitizer coverage.
BUG=pdfium:1,pdfium:171
R=thestig@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/5478df43a8970257e9644ae6f57a6fe7513029c6
Review URL: https://codereview.chromium.org/1406843002 .
(cherry picked from commit 3b2ab45f0a883046a7c457e8435b5a9b2c1c4156)
Review URL: https://codereview.chromium.org/1412193010 .
|
|
This will break existing checkouts based on the instructions provided.
Instead of having a single pdfium directory, checkouts will now compromise of:
("repo" can be named anything)
repo/.gclient
repo/pdfium/.git
repo/pdfium/others...
To convert an existing checkout, do something like:
mkdir repo
mv pdfium repo
rm repo/pdfium/.gclient_entries # will be regenerated, with a warning
mv repo/pdfium/.gclient repo
edit repo/.gclient and change "name: '.'" to "name: 'pdfium'"
Instructions for getting a new checkout are in README.md in this CL.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1406383003 .
Review URL: https://codereview.chromium.org/1422633002 .
|
|
- remove unused local variable rtArrow in CFWL_WidgetTP::DrawArrow
- remove ~ in class IFX_FontMgr
BUG=none
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1416673005 .
|
|
Abstracts away that master returns CPDF_Documents directly,
but XFA wraps them with a CPDFXFA_Document.
Tidy dead code along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1415803002 .
|
|
None of the methods in this file are used and it is not included anywhere. Removing.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1417783004 .
(cherry picked from commit 704da531215c4f81279eb763192de398f7d03748)
Review URL: https://codereview.chromium.org/1413943004 .
|
|
This Cl adds ToName, CPDF_Object::AsName and CPDF_Object::IsName and
updates the src to use them as needed.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417823005 .
(cherry picked from commit 1c77edb7b34e03787605b7965784cea38ef9f1d7)
Review URL: https://codereview.chromium.org/1417033004 .
|
|
This Cl adds ToString, CPDF_Object::AsString and CPDF_Object::IsString and
updates the src to use them as needed.
BUG=pdfium:201
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1417933002 .
(cherry picked from commit 53d3ab125ef583be8cfac907b308a6551b93067a)
Review URL: https://codereview.chromium.org/1408323006 .
|
|
This Cl adds ToNumber, CPDF_Object::AsNumber and CPDF_Object::IsNumber and
updates the src to use them as needed.
BUG=pdfium:201
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1410673005 .
(cherry picked from commit 83bf02dfb860a66d756434d194118dae572d04d3)
Review URL: https://codereview.chromium.org/1422583002 .
|
|
This Removes the ctor that took a pointer to the data to store and copied it
into the union memory. Instead, the call sites look at the type and pass the
correct value.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1422473002 .
(cherry picked from commit 8430a5d04883fac4666d0c321fc679bcaf99cb71)
Review URL: https://codereview.chromium.org/1417113002 .
|
|
The unittests had a case where we added an abort() call to
the code, but left the case. And one of the expected results
was not updated with the code.
The fpdfview.cpp got broken by a recent change, and was not
caught due to all the void* returns. Also, the tests now
clean up the page automatically.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1403373006 .
|
|
- add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf
TBR=thestig@chromium.org
BUG=pdfium:236
Review URL: https://codereview.chromium.org/1410333007 .
(cherry picked from commit 0223be82e0afcfee7c501ad2754230353bff79ff)
Review URL: https://codereview.chromium.org/1414913003 .
|
|
Review URL: https://codereview.chromium.org/1412123004 .
(cherry picked from commit b5dd65f31408dc8c15d202cbb3e8d9ec2afd4520)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1415433006 .
|
|
This CL adds ToBoolean, CPDF_Object::AsBoolean and CPDF_Object::IsBoolean and
updates the src to use them as needed.
BUG=pdfium:201
TBR=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417623005 .
(cherry picked from commit ce4f95d61f5aa5fb9a5fc6cb8487999a9cf46458)
Review URL: https://codereview.chromium.org/1419663004 .
|
|
This reverts commit 937840e1722d1f2b77d80575d6e710d760662c9c.
Add type cast definitions for CPDF_Dictionary.
This CL adds ToCPDFDictionary type definitions and updates one file to use
instead of straight casts. I had to fix two places where we'd casted off the
constness of the original pointer.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1420583003 .
(cherry picked from commit 39869b641511c882d78e17548293cdb458c36f38)
Review URL: https://codereview.chromium.org/1410343003 .
|
|
This does some minor copy editing and formatting of the documentation in the
fpdfview.h header.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411863004 .
(cherry picked from commit 19169dae5bf92813b7419793f61dfca8b4fb9124)
Review URL: https://codereview.chromium.org/1420593002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1409323003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411963002 .
(cherry picked from commit 8b8dfd7934d669b2c74a0502f82387e5df0f573b)
Review URL: https://codereview.chromium.org/1415513004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410733004 .
(cherry picked from commit 0f2736742f5f9841447a4bd505dcadda22e2f574)
Review URL: https://codereview.chromium.org/1409853003 .
|