summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-12-14Merge to XFA: Fix a memory leak in FPDFPageFuncEmbeddertest.Lei Zhang
TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1514283002 . (cherry picked from commit 1407c979a3ba8599546468d461f5403f317bddd3) Review URL: https://codereview.chromium.org/1525013002 .
2015-12-14Merge to XFA: Properly land "Fix hint table loading issues."Oliver Chang
R=thestig@chromium.org TBR=thestig@chromium.org BUG=566179 Original Review URL: https://codereview.chromium.org/1524983002 . (cherry picked from commit 1eb7477b3e7c5cb7c54ca364810ab9a24acad4f9) Review URL: https://codereview.chromium.org/1525793003 .
2015-12-14Merge to XFA: Fix hint table loading issues.Oliver Chang
BUG=566179 TBR=thestig@chromium.org Original Review URL: https://codereview.chromium.org/1523523002 . (cherry picked from commit be8408f43bcfd69a74007a340a4c034004146c60) Review URL: https://codereview.chromium.org/1518403003 .
2015-12-11Fix a crasher in CXFA_FFDocView::SetFocus()Jun Fang
When some layout items are released, applications should be notified. It usually happens when there are layout changes. BUG=pdfium:303 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1502133002 .
2015-12-11Merge to XFA: Fix memory leaks involving InsertIndirectObject()Jun Fang
BUG=447331 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1514093002 . Review URL: https://codereview.chromium.org/1515403003 .
2015-12-11Merge to XFA: Fix a regression for parsing '/' - commit a568ff2d was too ↵Lei Zhang
strict. BUG=pdfium:326 TBR=dml@google.com Review URL: https://codereview.chromium.org/1521543002 . (cherry picked from commit ebc7695c60fc3e4afbfa6d9db162a71b190bf685) Review URL: https://codereview.chromium.org/1519323002 .
2015-12-11XFA: avoid multiplications in FX_AllocsTom Sepez
In some cases, we can use the safe FX_Alloc2D, in others there's an extra multiplication by the size of the type. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1519233002 .
2015-12-11Merge to XFA: openjpeg: fix incrementing of "l_tcp->m_nb_mcc_records" in ↵Oliver Chang
opj_j2k_read_mcc TBR=tsepez@chromium.org BUG=554129 Original Review URL: https://codereview.chromium.org/1488303004 . (cherry picked from commit e2eb04f0352d621bc8837217078c23d67044bf38) Review URL: https://codereview.chromium.org/1524553002 .
2015-12-11Fix size calculation in BC_QRCodeWriter.cppTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1505353009 .
2015-12-11XFA: Missing license in make_expected.shTom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1513393004 .
2015-12-11Don't pass bogus testing flags to V8Jochen Eisinger
BUG=none R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1512283002 .
2015-12-10Fix compiling warnings on Linux (part2)Jun Fang
BUG=pdfium:261 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1500313002 .
2015-12-10Fix crashing in CFWL_CheckBox::Initialize()Jun Fang
BUG=pdfium:324 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1507683010 .
2015-12-10Merge to XFA: Fix integer and bounds issues in sycc4{22,44}_to_rgb.Oliver Chang
Also clean up while we're here. BUG=557223 TBR=tsepez@chromium.org Original Review URL: https://codereview.chromium.org/1512833008 . (cherry picked from commit 08750d0400f1635ac33c3234cb11b192f31a1eeb) Review URL: https://codereview.chromium.org/1521473003 .
2015-12-10Convert last batch of casts in fwl.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1512423003 .
2015-12-10Merge to XFA: Replace several more CFX_MapPtrToPtr with std::set or std::mapTom Sepez
Original Review URL: https://codereview.chromium.org/1520643002 . (cherry picked from commit 7db2a535f163e7ce5995da12161ebd0214f0f75a) Original Review URL: https://codereview.chromium.org/1511413008 . (cherry picked from commit 168cfb7ee0f2abbd2bddb7e7d8b430a6d8c6c120) TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1515613006 .
2015-12-10Merge to XFA: Remove CFX_AffineMatrix/CPDF_MatrixTom Sepez
Review URL: https://codereview.chromium.org/1513363002 . (cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0) R=thestig@chromium.org Review URL: https://codereview.chromium.org/1519693002 .
2015-12-10Replace more static casts in FWL (part 3)Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1508883003 .
2015-12-10Fix BUILD.gn to load the correct V8 snapshot configurationJochen Eisinger
BUG=pdfium:299 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1520443002 . (cherry picked from commit 94edf0c37d1ee6a03697375b9e227071ff2ee69d) Review URL: https://codereview.chromium.org/1517653003 .
2015-12-10Merge to XFA: Cleanup CPDF_DIBSource::LoadColorInfo() and ValidateDictParam().Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1507043004 . (cherry picked from commit d9324d8f7345d4546c06c4a9d6cd497b0f7f3ad2) Review URL: https://codereview.chromium.org/1512203003 .
2015-12-09Merge to XFA: Prevent infinite looping in CPDF_Parser::LoadAllCrossRefV5().Lei Zhang
BUG=pdfium:298 TBR=weili@chromium.org Review URL: https://codereview.chromium.org/1496703005 . (cherry picked from commit 93181f9a20db7ac706bb9405750303db93762a5b) Review URL: https://codereview.chromium.org/1514783002 .
2015-12-09Fix heap-use-after-free in CXFA_PDFFontMgr::~CXFA_PDFFontMgr()Jun Fang
BUG=pdfium:306 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1506423002 .
2015-12-09Fix heap-use-after-free in FT_Stream_ReleaseFrameJun Fang
BUG=452793,561478 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1512873002 .
2015-12-09Merge to XFA: Get rid of most uses of CFX_PtrArray.Tom Sepez
Original Review URL: https://codereview.chromium.org/1518593002 . (cherry picked from commit 035359cd8ddb555fa33b6133db4fd405e4660712) R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1513103002 .
2015-12-09Fix errors in BEGIN_FWL_MESSAGE_DEF macrosTom Sepez
The proper way to "wide-stringify" a parameter is by L###arg, not L"## arg ##", which does no replacement. Also remove dubious CloneToEvent() method, and make the proper event in the one place it is called. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1510493005 .
2015-12-09FWL refcounts never incremented (part 2).Tom Sepez
Re-introduce create methods that actually create the corresponding impl so we don't have ifaces without impls. Remove per-subclass Initialize() methods. Remove unused ctors. BUG=pdfium:282 R=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/1453473002 .
2015-12-09Merge to XFA: Remove static initializer from BigIntegerUtils.ccTom Sepez
Original Review URL: https://codereview.chromium.org/1510353003 . (cherry picked from commit 0c92bed7ade20fe193dce0a481dad48e1be41622) TBR=dpranke@chromium.org BUG=559766 Review URL: https://codereview.chromium.org/1505993008 .
2015-12-09XFA: Fix win8 gn build under chromium checkout (non-xfa)Tom Sepez
The no nominmax config was lost when moving from master. Fix a few other small differences along the way, and fully conditionalize the build of tiff. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1514633002 .
2015-12-09XFA: Revert UTF16LE_Encode changesOliver Chang
Revert "Fix embedder test failures introduced by commit c70b19aad245" This reverts commit 8d89e65897d8b6cf7899e7a82d9d381c3ad327cb. Revert "Fix invalid buffer length set in CFX_WideString::UTF16LE_Encode()" This reverts commit c70b19aad245fb1ed39bf8c264d991555f4c5a58. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1516643002 .
2015-12-09Re-land "Rename CFWL_Thread classes to ThreadImp"Tom Sepez
This reverts commit 5e4f290e939ded90a518ff8eab1db59930655e11. BUG= R=thestig@chromium.org Review URL: https://codereview.chromium.org/1502063005 .
2015-12-08XFA: Hide xfa targets in gyp (similar to GN)Tom Sepez
Allows "all" to include pdfium:* once again, since targets that don't exist except under xfa are hidden. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1502343007 .
2015-12-08XFA: Fix GN build under chromium checkout when no targets specifiedTom Sepez
Hide the existence of the xfa libraries from GN when the feature is not enabled. GN may try to build them otherwise when trying to build "everything" even though nothing depends on them. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1508243002 .
2015-12-08Move default value of pdf_enable_xfa to standalone.gypiTom Sepez
This allows standalone pdfium builds to build with XFA, but makes a chromium checkout revert to non-xfa even on this branch. GN implies a chromium checkout at the moment, so disable XFA there, too. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1508003003 .
2015-12-08Fix non-xfa build on xfa branch.Tom Sepez
Broken at 487d1a9/a0217b6. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1504413002 .
2015-12-08FWL refcounts never incremented (part 1)Tom Sepez
BUG=pdfium:282 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1509203002 .
2015-12-08Merge to XFA: Fix rendering with built-in CID fontsJun Fang
The root cause is that FXFONT_SUBST_EXACT is wrongly set even no any subset font was found. It causes m_bCIDIsGID to be wrongly set as TRUE in CPDF_CIDFont::_Load(). BUG=534945 R=thestig@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1502083002 . Review URL: https://codereview.chromium.org/1504263002 .
2015-12-07Revert "Rename CFWL_Thread classes to ThreadImp"Tom Sepez
This reverts commit 6fa20c60c6ed551af55bfc879668eaac5c237805. Reason for revert: broke tests TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1507893002 .
2015-12-07Rename CFWL_Thread classes to ThreadImpTom Sepez
This matches the 3-level parallel hierarchy convention used elsewhere in FWL. Remove dead code along the way. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1503503003 .
2015-12-07Remove C-Style casts in severl other fwl_...imp.cpp filesTom Sepez
Uncovered bad casts in a couple of places, replaced with correct objects. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1503583003 .
2015-12-06Merge to XFA: fix for stream object readingWei Li
Loosen a check for earlier version of PDF files. When the bytes with specified length are followed by 'endstream' keyword, even if there is no EOL marker before the keyword, it signals the end of stream. BUG=551258 TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1499433002 . (cherry picked from commit 0ff66089c87ab6e3adaaff0ec69728ce7a8d8299) Review URL: https://codereview.chromium.org/1504723002 .
2015-12-04Merge to XFA: Fix an incorrect check in CPDF_DataAvail::CheckHintTables.Oliver Chang
R=tsepez@chromium.org TBR=tsepez@chromium.org BUG=566179 Original Review URL: https://codereview.chromium.org/1504513002 . (cherry picked from commit 2d16308298f236ae81aa11a53f2d4e25b502dfac) Review URL: https://codereview.chromium.org/1501123002 .
2015-12-04Remove C-Style casts in fwl_{barcode,caret,checkbox,combobox}imp.cppTom Sepez
In the process, found two CFWL_ classes that didn't inherit from the virtual inteface they were allegedly supporting. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1499853003 .
2015-12-04Remove unused Thread class and static members.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1500023003 .
2015-12-04Tidy fwl_widgetimp.cpp.Tom Sepez
Remove some dead code. Add missing consts. Convert some integer expressions to bools for return. Remove expression (with bad cast) that can't happen. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1496323004 .
2015-12-04Fix dubious casting in fwl_widgetimp.cpp.Tom Sepez
Remove dead code along the way. BUG=pdfium:300 R=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/1490093006 .
2015-12-02Fix XFA build under chromium checkoutTom Sepez
Add () to suppress gcc-style error about assignment in conditionals. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1491403002 .
2015-12-02Remove _FWL_RETURN_IF_ macrosTom Sepez
These hide early returns from the casual reader, hide the inversion of the condition under test from the reader, prevent the folding of conditions into a single statement, and take up more characters than the if() itself. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1494683002 .
2015-12-02Add MakeWidgetImpProperties() helper method.Tom Sepez
Remove duplicate code from 10 places. R=ochang@chromium.org Review URL: https://codereview.chromium.org/1486283002 .
2015-12-02Merge to XFA: Increase default timeout in valgrind_test.py for running ↵Qin Zhao
corpus tests with Dr. Memory TBR=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1486413005 . (cherry picked from commit be3ad4b56b38221b40e2a1f0ee56e371738a752a) Review URL: https://codereview.chromium.org/1495443005 .
2015-12-02Fix overlapped focus widgetJun Fang
BUG=pdfium:294 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1487573002 .