summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-11-25Manual fixups to PDF_ENABLE_XFA in core/Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1477663003 .
2015-11-25XFA: Needless include in pdfppo.cppTom Sepez
R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1477983002 .
2015-11-25XFA: More underlying typesTom Sepez
Precursor to https://codereview.chromium.org/1477583002/ Also: whitespace in fxjs_v8.h Merge where possible. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1472363003 .
2015-11-25Inflict PPDF_ENABLE_XFA ifdefs on XFA core/Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1471323004 .
2015-11-25Merge to XFA: CFXJS_ObjDefinition's lifetime must match isolate.Tom Sepez
Review URL: https://codereview.chromium.org/1468423004 . (cherry picked from commit 628f7053cc646c58c61add247c75bc65ac135327) BUG=561184 TBR=jochen@chromium.org Review URL: https://codereview.chromium.org/1473943002 .
2015-11-25Merge to XFA: Suppress invalid-heap-arg error in pdfium_unittestsQin Zhao
Visual Studio sometimes uses new instead of new[] for array allocation, which causes Dr. Memory report invalid-heap-arg errors. Suppress such errors since it is not developers' problems. TBR=tsepez@chromium.org BUG=pdfium:287 Review URL: https://codereview.chromium.org/1473913002 . (cherry picked from commit 1fb4bc47e216c9caebdf7bc8479d45285ee7693b) Review URL: https://codereview.chromium.org/1475023003 .
2015-11-25Merge to XFA: Fix two memory leaks from pdfium_unittestsQin Zhao
- remove redundant alloc in fx_codec_jpx_unittest.cpp - free memory allocated by HexDecode calls in fpdf_parser_decode_unittest.cpp BUG=PDFium:239 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1467183006 . (cherry picked from commit 6c2d736011c09266015d3e2a0b9c08aeba1bbf31) Review URL: https://codereview.chromium.org/1477833002 .
2015-11-25Fix a crasher in rendering rich text in XFA filesJun Fang
Increase ref number of pStyle when it's being used. In this way, it won't be released when it's being used. BUG=pdfium:267 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1468123003 .
2015-11-25Fix embedder test failures introduced by commit c70b19aad245Jun Fang
BUG=pdfium:275 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1443603002. Review URL: https://codereview.chromium.org/1477693002 .
2015-11-25Fix invalid buffer length set in CFX_WideString::UTF16LE_Encode()Jun Fang
BUG=pdfium:275 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1443603002 .
2015-11-25Fix a issue that FFI_GetCurrentPageIndex always returns -1Jun Fang
The incorrect page index may cause a crasher in the following procedure. BUG=pdfium:285 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1466423004 .
2015-11-25Refactor CXFA_FFPageView::GetWidgetByPosJun Fang
BUG=pdfium:276 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1438333005 .
2015-11-24XFA: DYNIMIC is spelled DYNAMICTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1473053003 .
2015-11-24Make xfa samples/ look more like masterTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1476683002 .
2015-11-24XFA: more underlying type changes to match masterTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1474663004 .
2015-11-24Merge to XFA: Update pdfium_tests.py to run pdfium tests with Dr. Memory on ↵Qin Zhao
buildbots - update pdfium_tests.py to setup Dr. Memory so it can be used directly without pdfium_tests.bat on buildbots R=thestig@chromium.org BUG=PDFium:238 Review URL: https://codereview.chromium.org/1478453002 . (cherry picked from commit abea9d857e8e197d0095940f882b0db6a785d825) Review URL: https://codereview.chromium.org/1467183005 .
2015-11-24Merge to XFA: Fix a NULL pointer crash in the CJBig2_Image copy constructor.Lei Zhang
Also change the copy ctor to take a const ref. BUG=560520 TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1472113002 . (cherry picked from commit d03bc01003ae2603dafdc07b901ffef0a509a2b9) Review URL: https://codereview.chromium.org/1478473002 .
2015-11-24XFA: add underlying document type commentTom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1469413002 .
2015-11-24Fix build broken at 50d12ad.Tom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1477483002 .
2015-11-24Introduce "underlying types" to abstract XFA differences.Tom Sepez
See the comment in fsdk_define.h. Also tidy up a bit, and remove dead DeletePages(). This should help us match master more closely (given corresponding changes on the master side). R=thestig@chromium.org Review URL: https://codereview.chromium.org/1473503002 .
2015-11-24Fix wrong page count returned in FPDF_GetPageCount() for dynamic XFA filesTom Sepez
In FPDF_GetPageCount(), 'document' is converted to a non-XFA document pointer (CPDF_Document*). So it only returns non-XFA or static XFA page count. If XFA files include dynamic XFA fields on some pages, the returned value doesn't reflect these pages. BUG=pdfium:278 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1442753005 .
2015-11-23Merge to XFA: Adjust Dr. Memory suppressionQin Zhao
- widening suppression for DrM-i#471 TBR=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1467373003 . (cherry picked from commit 3b1bd5cbbcc1a606275fe98e813a37531572f374) Review URL: https://codereview.chromium.org/1465373002 .
2015-11-23Merge to XFA: Enable Dr. Memory to run javascript, pixel, and corpus testsQin Zhao
- add DrMemoryWrapper in common.py to adjust Dr. Memory wrapper - add --wrapper option to run_*_tests.py for Dr. Mempry wrapper - update run_*_tests.py to handle Dr. Memory wrapper - add TestPDFiumTest in pdfium_tests.py to support run_*_tests.py - remove ValgrindTool in valgrind_tests.py R=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1464453003 . (cherry picked from commit 36476923ae5eb8e9283e605f3c85ee8811c86014) Review URL: https://codereview.chromium.org/1465333002 .
2015-11-23Make CXFA_ContainerLayoutItem inherit from IXFA_LayoutPage.Tom Sepez
IFXA_LayoutPage now a pure virtual interface, with its code moving to CXFA_ContainerLayoutItem's implementaton of it. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1466103002 .
2015-11-23Merge to XFA: Add constant CPDFSDK_InterForm::kNumFieldTypesTom Sepez
Bumping this one line from 6 to 7 in XFA saves a bunch of diffs. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1458363005 . (cherry picked from commit 7711b60efc62db14748711727560367d948745f1) BUG= Review URL: https://codereview.chromium.org/1470563002 .
2015-11-23Merge to XFA: Replace |CPWL_ComboBox::operator CPWL_Edit()|.Tom Sepez
Original Review URL: https://codereview.chromium.org/1467653002 . (cherry picked from commit 54bc568bb41c5c258e95c24ef9d7355dcdc20f9e) R=thestig@chromium.org Review URL: https://codereview.chromium.org/1466743003 .
2015-11-20Merge to XFA: Roll DEPS for V8 to cf7614d.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1466033002 . (cherry picked from commit faab0f0add8317a7f95a8477e77bae716a10e977) Review URL: https://codereview.chromium.org/1470553002 .
2015-11-20Make XFA core/ look like master (part N).Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1463173003 .
2015-11-20Mising JS refactoring in XFA.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1463973002 .
2015-11-20XFA: Fix a few fxjse warnings.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1463703002 .
2015-11-20Merge to XFA: Initialize V8 before starting embedder testsTom Sepez
Pull Jochen's fix before it is forgotten. Original Review URL: https://codereview.chromium.org/1462313002 . (cherry picked from commit 3ccd36892fe826e8f2ed8dde0819756ae3546733) TBR=jochen@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1470443002 .
2015-11-20Make XFA public more closely match master.Tom Sepez
There will be significant differences, but these are the minor ones. I removed a comment that doesn't seem to add a lot of value. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1465723002 .
2015-11-20Fix CFWL_WidgetImpDelegate hierarchy.Tom Sepez
Instead of casting to the unrelated IFWL_WidgetDelegate class and hoping that its vtables line up, make CFWL_WidgetImpDelegate inherit from it. We can then remove a lot of casting, even during delete given that it has a virtual dtor. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1458173002 .
2015-11-20Fix Mac compilation at 5500da04e3acTom Sepez
TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1460293002 .
2015-11-20Merge to XFA: Remove CFX_Matrix::Reset()Tom Sepez
Original Review URL: https://codereview.chromium.org/1459243002 . (cherry picked from commit 6fc00fafcbac1fd5edd767fe2d4a8e4a9ef52806) R=thestig@chromium.org Review URL: https://codereview.chromium.org/1461703008 .
2015-11-20Merge to XFA: Change |CCodec_ScanlineDecoder::m_Pitch| to FX_DWORDOliver Chang
This matches the type of the corresponding |CFX_DIBSource::m_Pitch|, where integer overflow is checked for FX_DWORD. This change is propagated to many other places. Also, check for integer overflow in |CCodec_RLScanlineDecoder::Create| during the calculation of |m_Pitch| since it aligns to 4 bytes while overflow was was previously checked without this alignment. TBR=tsepez@chromium.org BUG=555784 Review URL: https://codereview.chromium.org/1460033002 . (cherry picked from commit e7950df70a2fd658f466751b29483436cb31e829) Review URL: https://codereview.chromium.org/1461363002 .
2015-11-20Update XFA fpdfsdk to match masterTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1465663002 .
2015-11-20Reduce diffs with master in coreTom Sepez
This week's version. Mostly whitespace, but takes the master version of core/src/fxge/ge/fx_ge_text.cpp verbatim. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1462923004 .
2015-11-19Merge to XFA: Cache object numbers in CPDF_Parser::ParseIndirectObject().Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1458633004 . (cherry picked from commit 0c8e6c1f39f20985a3efb17292e46c476194183a) Review URL: https://codereview.chromium.org/1461693005 .
2015-11-19Merge to XFA: Add more overrides.Lei Zhang
Using Chromium's clang + build options, there's more override warnings. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1453643002 . (cherry picked from commit 126ba519bdd489ec6c285d1410dcae773e8ef673) Review URL: https://codereview.chromium.org/1458373002 .
2015-11-19Merge to XFA: Add a missing setjmp() to CCodec_JpegDecoder::v_GetNextLine().Oliver Chang
If jpeg_read_scanlines() ends up calling the error callback, we longjmp into some undefined state. BUG=558840 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1463563003 . (cherry picked from commit 06e33aec03f13c76d9eff5c09cb03e142b0c5ef1) Review URL: https://codereview.chromium.org/1462253004 .
2015-11-18Kill dead IFWL_*::Initialize() variants dead.Tom Sepez
Remove default argument in remaining variants. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1453373006 .
2015-11-18Make IFWL_Target::m_pImpl a private member.Tom Sepez
Remove pointless subclass dtors since CFWL_TargetImpl has a virtual dtor, and can be deleted by the base class. Kept pointless subclass ctors for the moment to hopefully combine with Initialize someday, though they need not do anything since the base class ctor nulls out m_pImpl. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1460883002 .
2015-11-18Merge to XFA: Add Dr. Memory suppression file for pdfium testsQin Zhao
- add suppressions.txt in tools/drmemory/ - update pdfium_tests.py to read suppression file R=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1454193002 . (cherry picked from commit 76b0104270b0a7f3ce7d40ddde2b6d6c8cb944db) Review URL: https://codereview.chromium.org/1455293003 .
2015-11-18Merge to XFA: Add Dr. Memory toolQin Zhao
This CL adds DrMemory-Windows-sfx.exe into tools/drmemory. It also adds a set of scripts from chromium/src/tools/valgrind for running Dr. Memory. Now we can run pdfium tests with Dr. Memory: $ .\tools\drmemory\scripts\pdfium_tests.bat -b out\Debug -t pdfium_unittests More update on scripts is required, but this should be a good start. Changes from chromium/src/tools/valgrind - rename chrome_tests.py to pdfium_tests.py - update pdfium_tests.bat - remove chrome tests in pdfium_tests.py - remove memcheck code in valgrind_test.py R=thestig@chromium.org BUG=pdfium:238 Review URL: https://codereview.chromium.org/1452293002 . (cherry picked from commit 4dcf313c46c176e5afa1328f5f07fce4e614366d) Review URL: https://codereview.chromium.org/1452373004 .
2015-11-18Fold IFWL_TargetData into IFWL_TargetTom Sepez
IFWL_TargetData was a sibling class to which we illegally cast other IFWL_ classes just to get access to a member, to which they already had access in many cases. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1452403002 .
2015-11-18Merge to XFA: Fix ASan gn build (chromium).Oliver Chang
TBR=thestig@chromium.org] BUG=556808 Review URL: https://codereview.chromium.org/1452013004 . (cherry picked from commit 97f900e93e6a96b164b33bfe1228f383d9a5ecd3) Review URL: https://codereview.chromium.org/1456973003 .
2015-11-17Make CPDF_InterForm::AddStandardFont take a non-const document pointer.Lei Zhang
Instead of taking a const pointer, and then casting away the const-ness. Also remove similar, but dead CPDF_InterForm methods. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1456763003 . Review URL: https://codereview.chromium.org/1456823002 . Review URL: https://codereview.chromium.org/1452843005 . (cherry picked from commit 9c62cadff466f26307bd06ed1e9df2c1b5f25a32) (cherry picked from commit 447946588d6bbd4d5bc34477a09dd983285c507e) (cherry picked from commit b2a4c976841863e89804a2643eebccf881c57584) Review URL: https://codereview.chromium.org/1457703002 .
2015-11-17Merge to XFA: Add more fxcrt string sanity tests.Lei Zhang
Sadly I've gotten these to fail with Chromium debug builds. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1447163004 . (cherry picked from commit 191333dbc8889a60ff43a10176cc0ae87dc11d89) Review URL: https://codereview.chromium.org/1453403002 .
2015-11-17Rename additional IFWL imp classesTom Sepez
Follow-on from https://codereview.chromium.org/1446393002/ R=thestig@chromium.org Review URL: https://codereview.chromium.org/1457663002 .
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-24 17:35:59 +0000