Age | Commit message (Collapse) | Author |
|
BUG=pdfium:498
Review-Url: https://codereview.chromium.org/2004703002
|
|
BUG=pdfium:234
Review-Url: https://codereview.chromium.org/2001783003
|
|
The error handling in GetItemStyles() of list box is wrong. -1 is
0xFFFFFFFF in uint32_t, which suggests all the style bits on. This was
discovered by a signed/unsigned mismatch warning.
BUG=pdfium:29
Review-Url: https://codereview.chromium.org/2005583002
|
|
Review-Url: https://codereview.chromium.org/1999553002
|
|
The mixed use of enum and uint32_t causes warnings. And it is more
meaningful to use enum for char type variables.
BUG=pdfium:29
Review-Url: https://codereview.chromium.org/2001733002
|
|
Review-Url: https://codereview.chromium.org/2000883002
|
|
Part of the fix to the issues in bug 613623. These are all real bugs
arising from non-use of L""-style literals band-aided over with
casts. Remove the casts, and fix the literals or replace with empty
string constructors.
BUG=613623, 427616
Review-Url: https://codereview.chromium.org/1999933002
|
|
This is part of efforts to bring XFA to chromium_code standard.
The warnings are from unreachable code, or using potentially
uninitialized variables, or using assignment within a condition.
This change list only contains easy to fix cases. More cleanups
will follow.
BUG=pdfium:29
Review-Url: https://codereview.chromium.org/1998873002
|
|
The current switch statement will never execute any branch other than
falling to default. The intention should be checking on the specific
state bits.
BUG=613623, 427616
Review-Url: https://codereview.chromium.org/2002643003
|
|
BUG=
Review-Url: https://codereview.chromium.org/1999883002
|
|
Review-Url: https://codereview.chromium.org/2002673002
|
|
Althought this may change behaviour, I'm going to make the assumption
that the intent expressed by the current code is what is desired, and
that this is simply a case of not being able to count bits properly.
BUG=613620,427616
Review-Url: https://codereview.chromium.org/1996303003
|
|
Review-Url: https://codereview.chromium.org/2001743002
|
|
Review-Url: https://codereview.chromium.org/1998303002
|
|
Review-Url: https://codereview.chromium.org/2005473002
|
|
Review-Url: https://codereview.chromium.org/1990153003
|
|
BUG=chromium:613160
Review-Url: https://codereview.chromium.org/2001663002
|
|
Get rid of some LPC typedefs while we're at it.
Review-Url: https://codereview.chromium.org/1990363003
|
|
Review-Url: https://codereview.chromium.org/1989203007
|
|
This CL moves the fgas Sax parser into the fde/xml directory. This places
the parse with the other XML parser in the system.
Review-Url: https://codereview.chromium.org/1990003002
|
|
This CL shuffles code around in the fgas/ headers, removes unused functions
and adds anonymous namepaces for static methods and data.
Review-Url: https://codereview.chromium.org/1992033002
|
|
Remove some unused impls.
Review-Url: https://codereview.chromium.org/1994323002
|
|
Review-Url: https://codereview.chromium.org/1996533004
|
|
Review-Url: https://codereview.chromium.org/1993313005
|
|
BUG=
Review-Url: https://codereview.chromium.org/2000443002
|
|
It's never called. But looking at the comments in fpdf_formfill.h for
the Release callback, it seems like it should always be called as part
of the dtor.
BUG=
Review-Url: https://codereview.chromium.org/1995753004
|
|
Also fix a divide by zero in CPDF_SampledFunc.
Do some cleanups too.
BUG=596530,613032
Review-Url: https://codereview.chromium.org/1990843004
|
|
And also in CFX_PtrList.
BUG=596528
Review-Url: https://codereview.chromium.org/1991123002
|
|
... by using STL containers in more places.
Remove dead / duplicate code as well.
BUG=603904
Review-Url: https://codereview.chromium.org/1998583002
|
|
This CL changes the check to use std::binary_search instead of the custom
lookup method. The tag validation has been split out to a separate method
with unit tests added.
Review-Url: https://codereview.chromium.org/1996623002
|
|
Sevearal typedefs are only used once or twice. Expand and remove the typedef.
Review-Url: https://codereview.chromium.org/1995033002
|
|
Instead of the existing method, use the CheckedNumeric class to check for
overflow during conversion.
BUG=chromium:596526
Review-Url: https://codereview.chromium.org/1992023003
|
|
BUG=603903
Review-Url: https://codereview.chromium.org/1994113002
|
|
Purely code removal.
Review-Url: https://codereview.chromium.org/1991143003
|
|
Review-Url: https://codereview.chromium.org/1998453002
|
|
BUG=603895
Review-Url: https://codereview.chromium.org/1992893003
|
|
Use unique_ptrs.
Review-Url: https://codereview.chromium.org/1990033002
|
|
This removes the last vestiges of antigrain from
a Skia-specific build.
R=dsinclair@chromium.org,tsepez@chromium.org,thestig@chromium.org,reed@google.com
Review-Url: https://codereview.chromium.org/1998623002
|
|
Review-Url: https://codereview.chromium.org/1990583002
|
|
Review-Url: https://codereview.chromium.org/1988393002
|
|
Review-Url: https://codereview.chromium.org/1987223003
|
|
Cleanup virtual overrides along the way. Add final to other
class deriving from pure virtual interface.
Review-Url: https://codereview.chromium.org/1988373002
|
|
Review-Url: https://codereview.chromium.org/1988263002
|
|
This CL cleans up several uses of XFA_HASHCODE. The defines have been converted
into an enum.
For the SavePackage call the type is now used as the param instead of a string.
The callers pass in the correct type instead of doing an internal conversion.
The GetXFAObject accepting a string was removed as it was unused. The other
variant was changed to accept the XFA_HashCode type instead of uint32_t.
GetPackageData was removed as it is unused.
Review-Url: https://codereview.chromium.org/1989313002
|
|
Review-Url: https://codereview.chromium.org/1991993002
|
|
Review-Url: https://codereview.chromium.org/1994733002
|
|
Review-Url: https://codereview.chromium.org/1990793004
|
|
Review-Url: https://codereview.chromium.org/1991913002
|
|
This CL splits the xfa/fee files into individual class files and moves them
into the xfa/fde directory where they belong.
Review-Url: https://codereview.chromium.org/1994693002
|
|
Allows use of CFX_RetainPtrs in place of explicit refcounting.
Review-Url: https://codereview.chromium.org/1985253002
|