summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-06-17Merge to XFA: Separate agg-authored code from fx-authored code.Tom Sepez
Original Review URL: https://codereview.chromium.org/1152743007. BUG=pdfium:166 R=brucedawson@chromium.org, thestig@chromium.org TBR=brucedawson@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1186423003.
2015-06-16Merge to XF: Add constructor for CPDF_ColorSpace.Tom Sepez
Original review URL: https://codereview.chromium.org/1185903002. BUG=pdfium:170 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1182083004.
2015-06-16XFA: Write new as "new" rather than using several macros.Tom Sepez
Really? R=thestig@chromium.org Review URL: https://codereview.chromium.org/1183193004.
2015-06-15Merge to XFA: Provide a constructor for CPDF_CountedObject.Tom Sepez
Original Review URL: https://codereview.chromium.org/1182903002. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1191553005.
2015-06-13Merge to XFA: Remove unneeded checks in ↵Lei Zhang
CPDF_DocPageData::GetFontFileStreamAcc(). The input cannot be null. Same for CPDF_Document::LoadFontFile(). Also set the contract for CPDF_Document::LoadFont() and adjust callers accordingly. Also remove unused CPDF_Document::FindFont(). R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1184673002. (cherry picked from commit 1972b16849fedfda675eacd5c8594b54dbd1264d) Review URL: https://codereview.chromium.org/1181393002.
2015-06-13Remove trailing whitespaces in core, XFA edition.Lei Zhang
Review URL: https://codereview.chromium.org/1180333002.
2015-06-13Remove trailing whitespaces in fpdfsdk, XFA edition.Lei Zhang
Review URL: https://codereview.chromium.org/1185843005.
2015-06-13Merge to XFA: Remove unused reflow code.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1181803002. (cherry picked from commit f25db681003f0247e97bfef22be56a8aa02b7595) Review URL: https://codereview.chromium.org/1182993002.
2015-06-13Merge to XFA: Cleanup: Get this rid of "this->" in fpdfsdk/Lei Zhang
Also remove commented out code and trailing whitespaces. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1179653005. (cherry picked from commit eda202769e5c79eba1d2fb5090f6e9cf176e2d4a) Review URL: https://codereview.chromium.org/1187733002.
2015-06-13Merge to XFA: Cleanup: Remove uses of "this->" in core/Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1173223002. (cherry picked from commit 2b5e0d5b20654d116045484868c9e015ed698124) Review URL: https://codereview.chromium.org/1186673004.
2015-06-12Merge to XFA: Corpus tests check for unexpected successes.Tom Sepez
Original Review URL: https://codereview.chromium.org/1178393002. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1184803002.
2015-06-11Merge to XFA: Correct unexpected hinting fontsTom Sepez
If the font is 'tricky', it needs to be hinted by default according to the description in freetype. BUG=490814 TBR=jun_fang@foxitsoftware.com Original Review URL: https://codereview.chromium.org/1170313003. Review URL: https://codereview.chromium.org/1175243008.
2015-06-11Merge to XFA: Kill FXSYS_mem{cpy,cmp,set.move}{32,8}.Tom Sepez
Only manual merge was core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp follwed by scripts. Original Review URL: https://codereview.chromium.org/1179693003. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1179953002.
2015-06-10Merge to XFA: Convert CPDF_FontFileMap to std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1144333008. (cherry picked from commit f726c92cb2cf5739fd5b21e825e5bf510040c62f) Review URL: https://codereview.chromium.org/1180653004.
2015-06-10Merge to XFA: Convert CPDF_IccProfileMap to use std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1143133008. (cherry picked from commit 77713645f64214b8d5e79f62a92bb03452ce232e) Review URL: https://codereview.chromium.org/1179693004.
2015-06-10Merge to XFA: Convert CPDF_ImageMap to std::map.Lei Zhang
Also simplify CPDF_DocPageData::ReleaseIccProfile() since its first argument is always null. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1149273004. (cherry picked from commit a8a718c974210a919f2af0b099d540143cf330c6) Review URL: https://codereview.chromium.org/1180613004.
2015-06-10Merge to XFA: Convert CPDF_PatternMap to std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1162123004. (cherry picked from commit b3aa96cbee31e81d0a72a61027467a2713654499) Review URL: https://codereview.chromium.org/1181573005.
2015-06-10Merge to XFA: Convert CPDF_ColorSpaceMap to std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1154963003. (cherry picked from commit 22f429fc4875027b10ab071102c9ac8a88abf825) Review URL: https://codereview.chromium.org/1179783002.
2015-06-10Merge to XFA: Convert CPDF_FontMap to std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1151133004. (cherry picked from commit 3c949d5d2b0d680839766ea99c86b263230b263d) Review URL: https://codereview.chromium.org/1174173005.
2015-06-10Merge to XFA: Remove FX_BSTR and FX_WSTR typedefs.Tom Sepez
Nearly automatic merge + re-run script on new files. Original Review URL: https://codereview.chromium.org/1180593004. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1174303002.
2015-06-10Merge to XFA: Cleanup: Remove CFFL_IFormFiller::GetCommitKey() that always ↵Lei Zhang
returns 0. Remove callers and related code that all just pass zeros around. Also remove CFFL_IFormFiller::GetKeyDown(). R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1149623012. (cherry picked from commit 35c3163d55bebea8095474181f807ddfb2f4f806) Review URL: https://codereview.chromium.org/1175083003.
2015-06-10Merge to XFA: Cache the CPDF_Annot's subtype, since it should never changes.Lei Zhang
BUG=495300 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1178513002. (cherry picked from commit 7b2897c47245f04c806cfa8cee09458e31ba3777) Review URL: https://codereview.chromium.org/1177003002.
2015-06-10Merge to XFA: Remove typdefs for pointer types in fx_system.h.Tom Sepez
Original Review URL: https://codereview.chromium.org/1171733003 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1178613002.
2015-06-09Merge to XFA: Use stdint.h types throughout PDFium.Tom Sepez
Near-automatic merge, plus re-running scripts to update additional usage. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1172793002
2015-06-09Merge to XFA: Remove more cruft from fx_system.hTom Sepez
New manual edits in the following to fix compilation: fx_bmp.h, fx_gif.h, fx_graphics.h Original Review URL: https://codereview.chromium.org/1169963003 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1170103004
2015-06-08Merge to XFA: Fix potentially massive memory leak in ↵Lei Zhang
CPDF_DIBSource::LoadJpxBitmap(). Leaks can happen in several places. For this particular bug, it happens when there is a colorspace component count mismatch. BUG=497191 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1153633009 (cherry picked from commit 2a824f1c0ed786aed0dd15a0ea60dc90999e2b2c) Review URL: https://codereview.chromium.org/1168833002
2015-06-05Merge to XFA: Cleanup: Make CPDF_Annot::m_pAnnotDict private.Lei Zhang
Remove dead code in CPDF_Annot as well. R=tsepez@chromium.org TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1157773012 (cherry picked from commit b7eb193dcec1594952cbc1dca356a40f66724159) Review URL: https://codereview.chromium.org/1157323005
2015-06-05Merge to XFA: Add move constructor for FX string types.Tom Sepez
Original Review URL: https://codereview.chromium.org/1162203007 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1154023005
2015-06-05Merge to XFA: Standalone checkout gets buildtools.Tom Sepez
Original Review URL: https://codereview.chromium.org/1149623011 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1152523007
2015-06-05Merge to XFA: Fix bad include path in fpdfview.cppTom Sepez
Also sort includes missing from previous patch (some xfa IWYU prevents full sorting). Original Review URL: https://codereview.chromium.org/1149213008 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1157103009
2015-06-04Merge to XFA: Move fx_safe_types.h to include/ directory.Tom Sepez
Original Review URL: https://codereview.chromium.org/1147353006 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1152693005
2015-06-03Merge to XFA: Kill unused IPDF_ classes.Tom Sepez
Original Review URL: https://codereview.chromium.org/1168503003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1153033009
2015-06-03Merge to XFA: Fix fx_basic_memmgr_unittest.cpp under stricter GN rulesTom Sepez
Original Review URL: https://codereview.chromium.org/1165863003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1163113002
2015-06-02Merge to XFA: Automated test case for 487928.Tom Sepez
Original Review URL: https://codereview.chromium.org/1153213004 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1158483004
2015-06-02Merge to XFA: kill IPDF_DocParser().Tom Sepez
Original Review URL: https://codereview.chromium.org/1158053003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1156203004
2015-06-02Replace XFA_HWIDGET with IXFA_Widget*Tom Sepez
A second case of casting willy-nilly between unrelated structures to provide information hiding. Bad Idea. Remove dozens of casts in the process. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1155273002
2015-06-01Get test running scripts to detect and report common error, XFA.Bruce Dawson
testing/tools/run_corpus_tests.py assumes a debug build and will fail cryptically if only a release build is available. Arguably there shouldn't be a default because having one could lead to accidentally running a stale version, but that is probably too much of a change. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1150823003 Review URL: https://codereview.chromium.org/1158883005
2015-06-01Add missing comma to third_party.gyp, integrated to XFABruce Dawson
Original change by bungeman@chromium.org A reference to nonstd_unique_ptr.h was added with https://codereview.chromium.org/1091283002 but a comma is missing after it. This causes this string to be concatenated with the next, leading to broken sources. This went unnoticed by the build due to the fact that the affected sources are both headers, but they should be properly separated. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1156663006 Review URL: https://codereview.chromium.org/1156483006
2015-05-28Merge to XFA: Fix ALL the include guards.Tom Sepez
Original Review URL: https://codereview.chromium.org/1160443004 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1162013003
2015-05-27Replace XFA_HDOC with IXFA_Doc*Tom Sepez
There are better ways to provide information hiding than casting willy-nilly from an unrelated structure. Kill dozens of casts in the process. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1146153005
2015-05-27Merge to XFA: Remove rendundant ../include from paths.Tom Sepez
Original Review URL: https://codereview.chromium.org/1162453003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1154613005
2015-05-27Make CPDFXFA_App / IXFA_AppProvider sanerTom Sepez
Move interface comments from the implementation header to the interface header. Replace Create / Release functions with static methods. Replace dubious Release() methods with deletion via virtual dtor, also for IXFA_App and IXFA_FontMgr while we're at it. Untabify and fix (theoretically) illegal _CAP include guard definitions for fpdfxfa/ headers. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1153553003
2015-05-26Merge to XFA: Upgrade openjpeg to r3002JUN FANG
BUG=459215 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1160663002
2015-05-21Merge to XFA: Update copy of safe_math_impl.h to take a fix from upstream.Tom Sepez
Original Review URL: https://codereview.chromium.org/1126243007 BUG=488302 TBR=eroman@chromium.org Review URL: https://codereview.chromium.org/1153543003
2015-05-21Merge to XFA: Fix four annoying warnings.Tom Sepez
Original Review URL: https://codereview.chromium.org/1148353002 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1150103002
2015-05-21Merge to XFA: Fix an endless loop in CJBig2_HuffmanTable::parseFromCodedBufferJUN FANG
This issue is trigged by the conversion from unsigned int to signed int. A large unsigned int is converted to int. It's represented as a negative int which is used in the condition of while later. BUG=482639 R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1146913003
2015-05-20Merge to XFA: Integer overflow in CJBig2_Image::expandJUN FANG
1. New size should be larger than old size in JBig2_Realloc. 2. Arguments are integers but parameters are size_t in JBIG2_memset. After integer overflows, it will be presented as a huge unsigned number on 64 bits system. BUG=483981 R=brucedawson@chromium.org, tsepez@chromium.org Review URL: https://codereview.chromium.org/1148643002
2015-05-20Merge to XFA: Tidy public fpdfview.h and fpdf_flatten.h.Tom Sepez
Original Review URL: https://codereview.chromium.org/1139993003 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1144973004
2015-05-20Merge to XFA: Remove FX_Alloc() null checks now that it can't return NULL.Tom Sepez
Original Review URL: https://codereview.chromium.org/1142713005 R=thestig@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1143663008
2015-05-20Fix compilation on xfa branch and turn on v8 deprecation warningsJochen Eisinger
R=vogelheim@chromium.org BUG= Review URL: https://codereview.chromium.org/1142293003
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-24 00:58:37 +0000