Age | Commit message (Collapse) | Author |
|
mac. Now the minimal version is 10.10.
This reverts commit ad8dfc5fe0b5d726632b71919426c1efeb33c567.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735653002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730893003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1731483004 .
|
|
These are in third_party libraries so should be fixed upstream. Silencing the
warning in our build.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1734663002 .
|
|
Two files become completely empty and are deleted.
Oddly, they never appeared in gyp/gn files.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1724303002 .
|
|
This header just includes other headers, remove file and callsites.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1734683002 .
|
|
This Cl changes the definition of FX_WORD and FX_DWORD to use the stdint
types. This will allow changing the uses on a directory basis to the
stdint types.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1727203002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733693002 .
|
|
Renaming these files will allow them to be picked up by git cl format and the
linter.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733653002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1724193005 .
|
|
This CL enables several of the diabled whitelist/* lint checks.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730553002 .
|
|
Also remove another CFX_ArrayTemplate usage.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1730753002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730713002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1725033002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1725673002 .
|
|
BUG=
R=thakis@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1680943003 .
|
|
This is a wrapper which does (a) * (b) / (c). Inline the operations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1726893002 .
|
|
This is just a wrapper for (a) / (b). Inline the divide.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1727793002 .
|
|
R=tsepez@chromium.org
BUG=587227
Review URL: https://codereview.chromium.org/1726843002 .
|
|
This define just multiples the two parameters together. Inline the *'s.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1729613003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1726803002 .
|
|
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1722913002 .
|
|
They're technically not allowed because they are reserved
for the preprocessor.
Also get rid of LPC* typedefs along the way.
Also provide a header for a data file containing many
instance of these found along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1722873002 .
|
|
This CL cleans up the code enabled and disabled by _FDE_BLOCK_BUFFER.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1724793002 .
|
|
We never define _FDEPLUS so all the #ifndef checks can be removed as they will
always be true.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1723693005 .
|
|
We need to pull in the fgas_base.h file before looking at the _FX_OS_ checks
otherwise they become true and windows XFA build fails.
TBR=tsepez@chromium.org
BUG=pdfium:65
Review URL: https://codereview.chromium.org/1725843002 .
|
|
This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU
errors that have been fixed to make things compile again.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1722803002 .
|
|
BUG=pdfium:401
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1713833003 .
|
|
Most of these are from the XFA branch.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1720043003 .
|
|
This CL changes the possible lint flags to a blacklist which can be burned
down.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1725573003 .
|
|
BUG=pdfium:402
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719803002 .
|
|
Use virtual functions to replace type based logic; remove unused
functions; disable default copy constructor/assign operator.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1720003003 .
|
|
BUG=pdfium:408
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719863002 .
|
|
BUG=pdfium:407
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717243002 .
|
|
BUG=pdfium:406
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1720743003 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1721983002 .
|
|
- NDEBUG is more widely used in Chromium
- _DEBUG is not defined on Mac in Chromium
- Leaving _DEBUG in for standalone debug builds for the benefit of
third party libraries / Windows.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1721073004 .
|
|
BUG=pdfium:409
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1715363002 .
|
|
Also remove unused variable in CFWL_FormImpDelegate::OnProcessMessage().
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717383003 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1723693002 .
|
|
Move FX_DOUBLE to fx_system.h to keep it with the others
until we remove it.
Having one memset/cpy wrapper is dubious, two are worse.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1724523002 .
|
|
Also fix -Wunused warnings as a result of this change.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717063002 .
|
|
We wouldn't want to imply that any of this is
thread-safe ...
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1724483002 .
|
|
These are not included in the gyp or gn files so they won't be built.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717403002 .
|
|
This Cl updates the includes in the XFA directory to be relative to the
pdfium/ directory instead of the current directory.
This does not sort the includes as that is a larger IWYU task that will be
handled separately.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1723533002 .
|
|
This update fixes all include guards so cpplint build/header_guard completes
without error.
A presubmit check is added to make sure the guards stay clean.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1719083002 .
|
|
Stop short of removing it since it looks like it may be used
in some very hot paths.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1719543002 .
|
|
Merge it into CFX_FileBufferArchive, since both are in the
same header file and it is the only subclass.
Also, bTakeOver is always false, and the buf size is always
32K.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1712353002 .
|
|
R=tsepez@chromium.org
BUG=588200
Review URL: https://codereview.chromium.org/1718453003 .
|
|
Otherwise ASSERT() is useless.
BUG=pdfium:136
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1712053003 .
|