Age | Commit message (Collapse) | Author |
|
The calendar always sets today to 2011/01/01. This Cl removes the various
DataProviders needed to plumb this value and just sets it where needed.
Review-Url: https://codereview.chromium.org/2524993002
|
|
Propagates unique_ptr's back to callers.
Review-Url: https://codereview.chromium.org/2518333003
|
|
We are always cloning when the bitmap size is bounded by some constant,
and we are always cloning the mask. Instead, just assign pointers.
BUG=pdfium:633
Review-Url: https://codereview.chromium.org/2518063005
|
|
These methods should be in all implementations, make them pure virtual to
make that required.
Review-Url: https://codereview.chromium.org/2525703004
|
|
Review-Url: https://codereview.chromium.org/2525833002
|
|
PDF can specify a negative font size
to change the y-axis for text. Add
support in the Skia driver for that.
The cached form for text and paths
had fallen out of sync with the uncached
code used by skiapaths, so sync that
up so that the mainline skia setting
has those bug fixes as well.
This does not fix the underlying bug in
528103, but gets Skia on parity with
native PDFium text rendering. The bold
text is still drawn in the wrong place.
R=dsinclair@chromium.org
BUG=528103
Review-Url: https://codereview.chromium.org/2528663002
|
|
BUG=pdfium:479
Review-Url: https://codereview.chromium.org/2521843003
|
|
This class is not an interface but a concrete implementation. Rename to match.
Review-Url: https://codereview.chromium.org/2521303002
|
|
These twho files are not interfaces. Renamed to be CFWL to signify they are
concrete implementations.
Review-Url: https://codereview.chromium.org/2526513002
|
|
BUG=667074
Review-Url: https://codereview.chromium.org/2520253003
|
|
Review-Url: https://codereview.chromium.org/2526543003
|
|
Deletion of said object is still inflicted on the callers. But
that's an issue for another day.
Review-Url: https://codereview.chromium.org/2523743004
|
|
Transparencies and bitmap patterns need to be
unpremultiplied after Skia renders them so
that PDFium can use its own compositing.
Also added some linear (i.e. axial) gradient
support, although its unclear if any of the
test corpus uses this feature.
R=dsinclair@chromium.org
Review-Url: https://codereview.chromium.org/2520073003
|
|
fx_codec_icc.cpp specify default number of color components as 3 for
unknown profiles. However, lcms may know such profile with different
number of components. The inconsistency may lead to array access
violation.
This CL uses cmsChannelsOf() from lcms to ensure consistency. And
rejects unexpected number according to PDF spec.
BUG=chromium:667694
Review-Url: https://codereview.chromium.org/2522933002
|
|
Add cpdf_streamparser.h and cpdf_contentparser.h since there are
already corresponding .cpp files with the same name.
Review-Url: https://codereview.chromium.org/2521123003
|
|
This CL renames some methods in IFWL which have the same name as the CFWL
methods but the CFWL methods are not proxy methods.
Review-Url: https://codereview.chromium.org/2520413002
|
|
This method mostly returns L"". In the one case where it returns
something different the value is substituted into the callsite.
The IFWL_Tooltip class was using the caption, but it is not currently
being used. Removed as well.
Review-Url: https://codereview.chromium.org/2522663002
|
|
The only value being set from the enum was the All Mask. This was always set
through the default value in the methods. This Cl removes the mask code completely
and updates surrounding code as needed.
Review-Url: https://codereview.chromium.org/2515243003
|
|
Review-Url: https://codereview.chromium.org/2520953004
|
|
Just a routine roll.
TBR=jochen@chromium.org
Review-Url: https://codereview.chromium.org/2518933003
|
|
Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_Widget::DataProvider
directly.
Review-Url: https://codereview.chromium.org/2520063002
|
|
Do the same in CPDF_TextObject.
Discover CPDF_PageObject::Clone() is unnecessary and remove it.
Review-Url: https://codereview.chromium.org/2517163003
|
|
Return these from underlying methods as appropriate.
Review-Url: https://codereview.chromium.org/2520133002
|
|
BUG=chromium:667012
Review-Url: https://codereview.chromium.org/2508203007
|
|
Removed some unused method, named files properly, cleaned up a bit.
Review-Url: https://codereview.chromium.org/2524493002
|
|
It's always set to 0.
Review-Url: https://codereview.chromium.org/2520123002
|
|
Review-Url: https://codereview.chromium.org/2514263003
|
|
Review-Url: https://codereview.chromium.org/2521693003
|
|
Review-Url: https://codereview.chromium.org/2514173002
|
|
The check for include sorting was missing the cpp extension so was not running
against any cpp files on upload.
Review-Url: https://codereview.chromium.org/2522673002
|
|
Review-Url: https://codereview.chromium.org/2520493002
|
|
Review-Url: https://codereview.chromium.org/2520073002
|
|
The Customized Layout flag in FWL is always false. Removed the flag and updated
the code as needed.
Review-Url: https://codereview.chromium.org/2520023002
|
|
Review-Url: https://codereview.chromium.org/2517153003
|
|
The SetThemeColor and SetThemeData methods are always called with a parameter
of 0. This Cl removes the parameter and updates the code as needed.
Review-Url: https://codereview.chromium.org/2521683002
|
|
The FWL_GetThemeColor method is always called with 0 which will return 0. This
CL removes the calls and replaces the callsites with 0 as needed.
Review-Url: https://codereview.chromium.org/2523453002
|
|
FWL_GetThemeLayout is only called in one place with 0 as the parameter. This
can never be true, so replace it with false at the callsite.
Review-Url: https://codereview.chromium.org/2521673002
|
|
The theme ID is never set, so it's always 0. This CL removes the Set/Get methods
and updates the code to use 0 in place of m_dwThemeId.
Review-Url: https://codereview.chromium.org/2519113002
|
|
The -build/include setting was masking out build/include_what_you_use. This CL
restores them, fixes any build errors, and adds NOLINT as needed. As well,
the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd.
lint cleanups
Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f
Reviewed-on: https://pdfium-review.googlesource.com/2030
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Commit 137a344a changed its behavior.
BUG=chromium:667012
Review-Url: https://codereview.chromium.org/2513273003
|
|
Split classes in FWL to be single class per file. In the case of data providers
which added no new methods, removed and used the IFWL_DataProvider directly.
Review-Url: https://codereview.chromium.org/2506253004
|
|
The FWL_WGTSTYLE_Icon flag is never set. This CL removes it and the supporting
Icon code from IFWL_Form.
Review-Url: https://codereview.chromium.org/2516433003
|
|
This CL removes the flag which never appears to be set and the supporting code
for captions in IFWL_Form as they are never used.
Review-Url: https://codereview.chromium.org/2507283003
|
|
This flag does not appear to be applied to the styles, so the supporting code
will never be executed.
Review-Url: https://codereview.chromium.org/2502233005
|
|
Moved CPDF_ImageLoader, CPDF_ImageLoaderHandle, and CPDF_TransferFunc
Review-Url: https://codereview.chromium.org/2518553002
|
|
The m_InfoStart variable has values set but never read. Removed.
Review-Url: https://codereview.chromium.org/2513673002
|
|
The m_eResizeType variable is set but never read. Removed.
Review-Url: https://codereview.chromium.org/2508263002
|
|
Review-Url: https://codereview.chromium.org/2513313002
|
|
It passes on Linux bots.
Review-Url: https://codereview.chromium.org/2516133003
|
|
This adds text to the _SUPPORT_SKIA_PATHS_
variant.
The output of the test corpus has more
differences, but no feature changes or
dropouts that I can see.
The text is a bit lighter. Bungeman thinks
this is because of our support of SRGB
color, although the fonts also look different
so maybe there's more to the story.
The output looks compatible with the
variations I see in Adobe Reader and Firefox
on the same platform.
There's probably more text tuning to do.
Additionally, this turns off the caching
feature for this variation. Caching can't
work because the drawing alternates between
Skia and PDFium's native blits, so any
state caching won't know about changes
and drawing performed by the other.
R=dsinclair@chromium.org, bungeman@chromium.org
Review-Url: https://codereview.chromium.org/2520483002
|