summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-07-14Add a few include rules for XFA-specific files.Tom Sepez
Checkdeps is still pretty noisy on XFA. There is some confusion about finding include files since not all are relative. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1241763003 .
2015-07-14Merge to XFA: Tighten up DEPS include rules.Tom Sepez
Original Review URL: https://codereview.chromium.org/1233583004 . TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1234923006 .
2015-07-13Merge to XFA: Fix an integer overflow issue in openJpegJUN FANG
Fixing this issue for an urgent request. It should be fixed in OpenJPEG side. BUG=506763 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1231933008 .
2015-07-13Merge to XFA: Fix a crashier due to incorrect type conversionJUN FANG
BUG=issue179 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1217093006 .
2015-07-04Cherry-pick to XFA: Remove a superfluous qualifier. No behavior change.Nico Weber
BUG=505296 R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1221673007.
2015-07-02Cherry-pick to XFA: Add parentheses around && within ||.Nico Weber
BUG=504699 R=raymes@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1213433005.
2015-07-01Merge to XFA: "Redo range check in CPDF_SampledFunc::v_Call().""Tom Sepez
Original Review URL: https://codereview.chromium.org/1214403002. (cherry picked from commit 0b0f2130e403aaa558a04ffa664e6f4f0f38d1b1) BUG=471990 TBR=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1218273002.
2015-07-01Cherry-pick to XFA: Fix a clang warning about a dangling else.Tom Sepez
BUG=none R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1223433002.
2015-07-01Cherry-pick to XFA: Fix some clang warnings with -Wmissing-braces in pdfium.Nico Weber
Clang warns if there are missing braces around a subobject initializer. The most common idiom that triggers this is: STRUCT s = {0}; if the first field of STRUCT is itself a struct. This can be more simply written as: STRUCT s = {}; which also prevents the warning from firing. Other instances of the warning have been fixed by adding braces where appropriate. R=brucedawson@chromium.org Review URL: https://codereview.chromium.org/1213523004.
2015-06-19Merge to XFA: Replace some CFX_MapPtrTemplates with std::map.Lei Zhang
There are more CFX_MapPtrTemplate usage on the XFA branch, so it is not removed. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1181593003. (cherry picked from commit e8d3691c82d1be805ffdce3329d00313af7ce0ab) Review URL: https://codereview.chromium.org/1198663004.
2015-06-19Merge to XFA: Cleanup: Do not check pointers before deleting them.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1192743004. (cherry picked from commit cfac954abcab7caf47d3fa3d641c553cba998271) Review URL: https://codereview.chromium.org/1196783003.
2015-06-19Merge to XFA: Cleanup: Remove dead CPDF_InlineImages code.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1192413007. (cherry picked from commit 59d60a587180cb6bbd49d4e739fb6ccd2b15d4d2) Review URL: https://codereview.chromium.org/1192753008.
2015-06-19Merge to XFA: Small cleanup of CPDF_TextObject and other CPDF_PageObject ↵Lei Zhang
subclasses. - Add overrides - Remove empty overrides - Remove dead friends - Cleanup bad formatting R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1199563002. (cherry picked from commit df558514bf5cb5750d5a7000a843f45f4170d5a4) Review URL: https://codereview.chromium.org/1198713002.
2015-06-19Merge to XFA: Make CPDF_PageModuleDef and CPDF_RenderModuleDef pure virtual.Lei Zhang
Get rid of the dummy implementations, which are never used when the modules have been initialized. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1177383003. (cherry picked from commit 5fef754bc09e971f1bf1ba79da98c0a7ee1e1c8d) Review URL: https://codereview.chromium.org/1189413006.
2015-06-19Merge to XFA: Do some IWYU cleanups.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1176333002. (cherry picked from commit 0ef0de55657db8a83372ad8eb22d84c5893afc4c) Review URL: https://codereview.chromium.org/1195943005.
2015-06-19Merge to XFA: Remove some dead code.Lei Zhang
Review URL: https://codereview.chromium.org/1186673005. (cherry picked from commit 38f5c338fdc2daf79668cf7567298d9f62e4ba23) Review URL: https://codereview.chromium.org/1198683002.
2015-06-19Merge to XFA: Fix -Winconsistent-missing-override warnings.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1187463003. (cherry picked from commit 8bd09648445aef8a9ae38d9f61618bd2013ac3f0) Review URL: https://codereview.chromium.org/1194173002.
2015-06-19Fix -Wnon-virtual-dtor warnings on the XFA branch.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1183483003.
2015-06-19Merge to XF: Disintermediation.Tom Sepez
(cherry picked from commit 012ada613a1462f109eb59790f8e5ee91aacdb7e) Review URL: https://codereview.chromium.org/1199553002. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1197893002.
2015-06-19Merge to XFA: Move zlib to third_party/Tom Sepez
(cherry picked from commit 959eb05140a8f5af7724a2da4cf5d04e2e50f4a6) Original Review URL: https://codereview.chromium.org/1197693003. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1197863002.
2015-06-18Merge to XFA: Move libopenjpeg to third_party/Tom Sepez
Original Review URL: https://codereview.chromium.org/1185373010. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1193773002.
2015-06-18Fix XFA builds under chromium checkoutsTom Sepez
This pulls in from origin/master: 94dd28e Update GN build files w/ cpu_arch -> current_cpu changes. 1e580a1 Fix multiply defined macro in zlib.h Add a missing file to BUILD.gn dropped at 1ed8a21. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1189133006.
2015-06-18Merge to XFA: Fix CPDF_ICCBasedCS::GetDefaultValue heap-buffer-overflow.Tom Sepez
Original Review URL: https://codereview.chromium.org/1179773007. BUG=501889 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1180843012.
2015-06-18Replace some Release() calls with virtual destructors.Tom Sepez
Required fixing xfa-specific code. Original Review URL: https://codereview.chromium.org/1192013002. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1176413004.
2015-06-17Merge to XFA: Run GYP after gclient sync.Tom Sepez
TBR=thestig@chromium.org Original Review URL: https://codereview.chromium.org/1193563002. Review URL: https://codereview.chromium.org/1193623003.
2015-06-17Merge to XFA: Move libjpeg to third_party/Tom Sepez
Original Review URL: https://codereview.chromium.org/1186113005. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1175193007.
2015-06-17Merge to XFA: Move lcms2 into third_partyTom Sepez
Original Review URL: https://codereview.chromium.org/1181943008. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1187273006.
2015-06-17Merge to XFA: Separate agg-authored code from fx-authored code.Tom Sepez
Original Review URL: https://codereview.chromium.org/1152743007. BUG=pdfium:166 R=brucedawson@chromium.org, thestig@chromium.org TBR=brucedawson@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1186423003.
2015-06-16Merge to XF: Add constructor for CPDF_ColorSpace.Tom Sepez
Original review URL: https://codereview.chromium.org/1185903002. BUG=pdfium:170 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1182083004.
2015-06-16XFA: Write new as "new" rather than using several macros.Tom Sepez
Really? R=thestig@chromium.org Review URL: https://codereview.chromium.org/1183193004.
2015-06-15Merge to XFA: Provide a constructor for CPDF_CountedObject.Tom Sepez
Original Review URL: https://codereview.chromium.org/1182903002. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1191553005.
2015-06-13Merge to XFA: Remove unneeded checks in ↵Lei Zhang
CPDF_DocPageData::GetFontFileStreamAcc(). The input cannot be null. Same for CPDF_Document::LoadFontFile(). Also set the contract for CPDF_Document::LoadFont() and adjust callers accordingly. Also remove unused CPDF_Document::FindFont(). R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1184673002. (cherry picked from commit 1972b16849fedfda675eacd5c8594b54dbd1264d) Review URL: https://codereview.chromium.org/1181393002.
2015-06-13Remove trailing whitespaces in core, XFA edition.Lei Zhang
Review URL: https://codereview.chromium.org/1180333002.
2015-06-13Remove trailing whitespaces in fpdfsdk, XFA edition.Lei Zhang
Review URL: https://codereview.chromium.org/1185843005.
2015-06-13Merge to XFA: Remove unused reflow code.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1181803002. (cherry picked from commit f25db681003f0247e97bfef22be56a8aa02b7595) Review URL: https://codereview.chromium.org/1182993002.
2015-06-13Merge to XFA: Cleanup: Get this rid of "this->" in fpdfsdk/Lei Zhang
Also remove commented out code and trailing whitespaces. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1179653005. (cherry picked from commit eda202769e5c79eba1d2fb5090f6e9cf176e2d4a) Review URL: https://codereview.chromium.org/1187733002.
2015-06-13Merge to XFA: Cleanup: Remove uses of "this->" in core/Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1173223002. (cherry picked from commit 2b5e0d5b20654d116045484868c9e015ed698124) Review URL: https://codereview.chromium.org/1186673004.
2015-06-12Merge to XFA: Corpus tests check for unexpected successes.Tom Sepez
Original Review URL: https://codereview.chromium.org/1178393002. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1184803002.
2015-06-11Merge to XFA: Correct unexpected hinting fontsTom Sepez
If the font is 'tricky', it needs to be hinted by default according to the description in freetype. BUG=490814 TBR=jun_fang@foxitsoftware.com Original Review URL: https://codereview.chromium.org/1170313003. Review URL: https://codereview.chromium.org/1175243008.
2015-06-11Merge to XFA: Kill FXSYS_mem{cpy,cmp,set.move}{32,8}.Tom Sepez
Only manual merge was core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp follwed by scripts. Original Review URL: https://codereview.chromium.org/1179693003. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1179953002.
2015-06-10Merge to XFA: Convert CPDF_FontFileMap to std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1144333008. (cherry picked from commit f726c92cb2cf5739fd5b21e825e5bf510040c62f) Review URL: https://codereview.chromium.org/1180653004.
2015-06-10Merge to XFA: Convert CPDF_IccProfileMap to use std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1143133008. (cherry picked from commit 77713645f64214b8d5e79f62a92bb03452ce232e) Review URL: https://codereview.chromium.org/1179693004.
2015-06-10Merge to XFA: Convert CPDF_ImageMap to std::map.Lei Zhang
Also simplify CPDF_DocPageData::ReleaseIccProfile() since its first argument is always null. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1149273004. (cherry picked from commit a8a718c974210a919f2af0b099d540143cf330c6) Review URL: https://codereview.chromium.org/1180613004.
2015-06-10Merge to XFA: Convert CPDF_PatternMap to std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1162123004. (cherry picked from commit b3aa96cbee31e81d0a72a61027467a2713654499) Review URL: https://codereview.chromium.org/1181573005.
2015-06-10Merge to XFA: Convert CPDF_ColorSpaceMap to std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1154963003. (cherry picked from commit 22f429fc4875027b10ab071102c9ac8a88abf825) Review URL: https://codereview.chromium.org/1179783002.
2015-06-10Merge to XFA: Convert CPDF_FontMap to std::map.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1151133004. (cherry picked from commit 3c949d5d2b0d680839766ea99c86b263230b263d) Review URL: https://codereview.chromium.org/1174173005.
2015-06-10Merge to XFA: Remove FX_BSTR and FX_WSTR typedefs.Tom Sepez
Nearly automatic merge + re-run script on new files. Original Review URL: https://codereview.chromium.org/1180593004. TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1174303002.
2015-06-10Merge to XFA: Cleanup: Remove CFFL_IFormFiller::GetCommitKey() that always ↵Lei Zhang
returns 0. Remove callers and related code that all just pass zeros around. Also remove CFFL_IFormFiller::GetKeyDown(). R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1149623012. (cherry picked from commit 35c3163d55bebea8095474181f807ddfb2f4f806) Review URL: https://codereview.chromium.org/1175083003.
2015-06-10Merge to XFA: Cache the CPDF_Annot's subtype, since it should never changes.Lei Zhang
BUG=495300 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1178513002. (cherry picked from commit 7b2897c47245f04c806cfa8cee09458e31ba3777) Review URL: https://codereview.chromium.org/1177003002.
2015-06-10Merge to XFA: Remove typdefs for pointer types in fx_system.h.Tom Sepez
Original Review URL: https://codereview.chromium.org/1171733003 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1178613002.