Age | Commit message (Collapse) | Author |
|
The GetFontData() behavior in FPDF_SYSFONTINFO seems reasonable.
Also do some code cleanup.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425023003 .
(cherry picked from commit e0c16d7461ca8317433d93835e4c36a84157cbef)
Review URL: https://codereview.chromium.org/1438943002 .
|
|
CPDF_DIBSource::DownSampleScanline32Bit
Previously, if |m_bpc| was < 8 (e.g. 4), this function may still try to
access the source components as if |m_bpc| == 8. Even when it fell into
the codepath that tried to do the right thing in this case, it was
wrong.
BUG=554151
TBR=tsepez@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/9b99615806e358fdb396d1cb162ee2e69c2a20ec
Review URL: https://codereview.chromium.org/1433423002 .
(cherry picked from commit e21fe98d5b5da7da01503b985b07b90c8e811689)
Review URL: https://codereview.chromium.org/1441563002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437713003 .
(cherry picked from commit f20a34c0f2dfca49f735a0f11147254c26831e7c)
Review URL: https://codereview.chromium.org/1437863005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1432863004 .
(cherry picked from commit 56e3da27d8bed8a6c03274b7b946e3f6d6ac11f4)
Review URL: https://codereview.chromium.org/1436843003 .
|
|
Added FIXMEs to the spots where danger lurks.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1438553003 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1419763005 .
(cherry picked from commit 211cab5b58151f09fbeafe2b18da77b63664c39d)
Review URL: https://codereview.chromium.org/1407413016 .
|
|
Original Review URL: https://codereview.chromium.org/1424933013 .
(cherry picked from commit 7d4c74d1b96d82681d49519c129262a1568e87d4)
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1407063012 .
|
|
The PDF-side native objects require that the current v8 context
has been set-up to point at the state (via CJS_Runtime) for the
getters, setters, and methods to operate against. XFA doesn't
supply a context with that state, so at the first opportunity for
a PDF-side object to be leaked to XFA, set up the context to mimic
the PDF side.
Changed FXJS_GetRuntimeFromIsolate() to FXJS_GetRuntimeFromV8Context()
for consistency with the newly added method.
BUG=pdfium:266
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1412103010 .
|
|
Original Review URL: https://codereview.chromium.org/1432073003 .
(cherry picked from commit 46960a43145ab978ca3c90cb6133bb3d5600ad1d)
BUG=pdfium:273
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1424473008 .
|
|
There's a re-interpretation followed by a pointer-adjusting static cast
required here, not just a blatant re-interpretation.
BUG=pdfium:271
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1431313005 .
|
|
R=tsepez@chromium.org
TBR=tsepez@chromium.org
BUG=554115
Review URL: https://codereview.chromium.org/1435473004 .
(cherry picked from commit 46d2e278f62454ed2392630b6d18d33d380a20eb)
Review URL: https://codereview.chromium.org/1436673003 .
|
|
Instead, set the libjpeg to use via GYP/GN.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1433803002 .
(cherry picked from commit 16f26fb7621c8ee554f4d7c5b4c1972eb0ed7065)
Review URL: https://codereview.chromium.org/1409323010 .
|
|
BUG=pdfium:272
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1414043014 .
|
|
- Remove CPDF_Stream::Create() and checks that it might fail.
- Remove m_pCryptoHandler that's always a nullptr.
- Remove m_FileOffset that's always 0.
- Rename file version of InitStream() to InitStreamFromFile().
- Use IsMemoryBased() in more places.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1415163009 .
(cherry picked from commit e6e16954f0cdc324849fca9da883be8f131b3834)
Review URL: https://codereview.chromium.org/1418493006 .
|
|
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1436573003 .
(cherry picked from commit c813e21d261c24867234107f2e2ca72e15cb2534)
Review URL: https://codereview.chromium.org/1406933007 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437603002 .
(cherry picked from commit 21e079dd982f57daa9d5af0d9e48d58189ce35da)
Review URL: https://codereview.chromium.org/1421303006 .
|
|
Move some functions into an anonymous namespace.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1431253002 .
(cherry picked from commit b5d6497946c1117e6f54506eb85b47e0a7e0234c)
Review URL: https://codereview.chromium.org/1416113011 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1427633010 .
(cherry picked from commit 9fb27cb9797937499c9678bc74cf7846cbf5d2b8)
Review URL: https://codereview.chromium.org/1438573002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1430213002 .
(cherry picked from commit 8deeacd23872ecc132a0a678e344a018b5114a3a)
Review URL: https://codereview.chromium.org/1416113010 .
|
|
pdfium_test
BUG=446715
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410073009 .
Review URL: https://codereview.chromium.org/1413103007 .
|
|
BUG=446715
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1353093003 .
Conflicts:
core/include/fpdfapi/fpdf_parser.h
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
samples/pdfium_test.cc
testing/embedder_test.cpp
testing/embedder_test.h
Review URL: https://codereview.chromium.org/1412083010 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1408063016 .
(cherry picked from commit 6d9979dc685e3b67b0a6d9946376e026d75d3e47)
Review URL: https://codereview.chromium.org/1418503020 .
|
|
-Wunused-variable triggers for PODs, but not for CFX_WideString.
R=thakis@chromium.org
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1412423013 .
(cherry picked from commit 3388f907ecac9e7662bca3bbfdf35721ded19f26)
Review URL: https://codereview.chromium.org/1433703003 .
|
|
Do some IWYU to fix build errors due to files that have no #includes but
just happened to work previously because the #includes were in the right
order.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1407423004 .
(cherry picked from commit 9e7cd8ffb81c564e1102f6c6459ec0942a0b11ea)
Review URL: https://codereview.chromium.org/1425163004 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1420693004 .
(cherry picked from commit 37e4a11e58257b757bec2700bc53facc59d0b845)
Review URL: https://codereview.chromium.org/1423583005 .
|
|
The merge https://codereview.chromium.org/1411403012/ broken build since there are one more embedder test in XFA branch. Fix this test in this CL.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1415163008 .
|
|
so tests can be run from any directory.
Previously the tests which read test files assume the current directory is under pdfium. Running from any other directory will break the build.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1408003014 .
(cherry picked from commit c0e93a9a942fe7d99800502a61d2fbb58cf9276f)
Conflicts:
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
fpdfsdk/src/fpdfdoc_embeddertest.cpp
testing/embedder_test.cpp
testing/embedder_test.h
Review URL: https://codereview.chromium.org/1411403012 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1426403008 .
(cherry picked from commit 94a4956f7aadc10fe6dd8451e965bd7447985b76)
Review URL: https://codereview.chromium.org/1410683013 .
|
|
BUG=pdfium:268
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425293010 .
(cherry picked from commit a8f5b7b5e7501bdcfba585fc8af76c4a0fab22cb)
Review URL: https://codereview.chromium.org/1418823008 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1419533016 .
(cherry picked from commit 2ce28d26ad16e11828b19f602fcc0ff625a23345)
Review URL: https://codereview.chromium.org/1414963007 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1413253003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415803007 .
(cherry picked from commit 5899671184d01b74989d181363066379ef3e4051)
Review URL: https://codereview.chromium.org/1431593007 .
|
|
Original Review URL: https://codereview.chromium.org/1424933012 .
(cherry picked from commit b2dd2c96f6271a1520c36d707b626a34c72f7fb6)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411333006 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
- And fix XFA's lack of #includes.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
(cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c)
Review URL: https://codereview.chromium.org/1434543003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417703011 .
|
|
Forgot to do so in commit 461b634b8b45bf022412b364fac37f6ad3cafb69.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1431073003 .
|
|
This makes pdfium_test always link with the bundled freetype, which will
fix many failing corpus tests.
This merges snippets of 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1423063006 .
|
|
Also, reorder the freetype srcs.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1431863006 .
(cherry picked from commit f1a7cd8c489e75abff7a2e952ea52f92142a5b88)
Review URL: https://codereview.chromium.org/1411983006 .
|
|
Original Review URL: https://codereview.chromium.org/1413733004 .
(cherry picked from commit 93f191bb011508a8d4e66746135e8ba8e9583870)
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1435493002 .
|
|
BUG=pdfium:29
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1411583005 .
Review URL: https://codereview.chromium.org/1431563002 .
Review URL: https://codereview.chromium.org/1419943006 .
Review URL: https://codereview.chromium.org/1415483003 .
Review URL: https://codereview.chromium.org/1414073005 .
Review URL: https://codereview.chromium.org/1415883010 .
(cherry picked from commit 9f4def68601ec75b85b92077c521b9423b4f7f00)
(cherry picked from commit 23e20f2d3ce5b416e1c7f7f1c2d68c90ddf2d4ad)
(cherry picked from commit a6e2a4eca1be4daf14fae4e2427a6ca76269db43)
(cherry picked from commit bfba4cb7f22fc19a5e71559f09f2cde19fbb6a79)
(cherry picked from commit 81edc51ef8242205c5a1192bc33bf16d8c96120b)
(cherry picked from commit 1630dffdc1d554d8f2319e83cdbd7b12f480362d)
Review URL: https://codereview.chromium.org/1421963005 .
|
|
Also adds a README.pdfium and 0000-include.patch that
details the local modifications made.
Also rolls testing/corpus to 45f88c6914fcac26ad930bb0ebbfa468c21db0a5
which includes regenerated corpus expectations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1413673003 .
(cherry picked from commit 87ee069d05ca06f60d6cfacd9e426739d8f2053d)
Review URL: https://codereview.chromium.org/1416993005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1433543005 .
(cherry picked from commit ba2d95fb6d7b6eb3b27ca8e6eb41d9aae1a8b691)
Review URL: https://codereview.chromium.org/1410903009 .
|
|
This tests whether RebuildCrossRef could handle well-formatted pdf file.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1409013005 .
(cherry picked from commit 4544797e8998a31e7bc3f5439a5982f7f66dff26)
Review URL: https://codereview.chromium.org/1413343004 .
|
|
Mostly unused variables, unused private members, or
initialization order. Added a few missing initializers
for pointer members along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1414903004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1409993013 .
|
|
BUG=pdfium:221
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1315803003 .
|
|
And simplify code.
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1411663013 .
(cherry picked from commit ff5adbc0dfa71270a9979f0c3e1d27923c16218a)
Review URL: https://codereview.chromium.org/1414793016 .
|
|
This regressed in commit 794c9b6.
BUG=551248
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1424743006 .
(cherry picked from commit 8cadf995e9a0fec8da19f69edac9d10fccca7eed)
(cherry picked from commit 955930dce7e4b5c764cdd34b134baea4207de523)
Review URL: https://codereview.chromium.org/1416663008 .
|
|
This is just a straight-forward, partial merge. It does not
actually make checkdeps succeed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1419373005 .
(cherry picked from commit 79f5a32175293620abe456554e10efb7c3f4e7c6)
Review URL: https://codereview.chromium.org/1409153007 .
|
|
Also cleans up some places in the relevant functions since we're here.
BUG=551460
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1421783004 .
Clean merge.
(cherry picked from commit 4f85605cbc652a17bc833f883186e0a68af6006d)
Review URL: https://codereview.chromium.org/1405383009 .
|