Age | Commit message (Collapse) | Author |
|
This Cl adds ToNumber, CPDF_Object::AsNumber and CPDF_Object::IsNumber and
updates the src to use them as needed.
BUG=pdfium:201
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1410673005 .
(cherry picked from commit 83bf02dfb860a66d756434d194118dae572d04d3)
Review URL: https://codereview.chromium.org/1422583002 .
|
|
This Removes the ctor that took a pointer to the data to store and copied it
into the union memory. Instead, the call sites look at the type and pass the
correct value.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1422473002 .
(cherry picked from commit 8430a5d04883fac4666d0c321fc679bcaf99cb71)
Review URL: https://codereview.chromium.org/1417113002 .
|
|
The unittests had a case where we added an abort() call to
the code, but left the case. And one of the expected results
was not updated with the code.
The fpdfview.cpp got broken by a recent change, and was not
caught due to all the void* returns. Also, the tests now
clean up the page automatically.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1403373006 .
|
|
- add FPDFAvail_Destroy(pdf_avail) on the early return path in RenderPdf
TBR=thestig@chromium.org
BUG=pdfium:236
Review URL: https://codereview.chromium.org/1410333007 .
(cherry picked from commit 0223be82e0afcfee7c501ad2754230353bff79ff)
Review URL: https://codereview.chromium.org/1414913003 .
|
|
Review URL: https://codereview.chromium.org/1412123004 .
(cherry picked from commit b5dd65f31408dc8c15d202cbb3e8d9ec2afd4520)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1415433006 .
|
|
This CL adds ToBoolean, CPDF_Object::AsBoolean and CPDF_Object::IsBoolean and
updates the src to use them as needed.
BUG=pdfium:201
TBR=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1417623005 .
(cherry picked from commit ce4f95d61f5aa5fb9a5fc6cb8487999a9cf46458)
Review URL: https://codereview.chromium.org/1419663004 .
|
|
This reverts commit 937840e1722d1f2b77d80575d6e710d760662c9c.
Add type cast definitions for CPDF_Dictionary.
This CL adds ToCPDFDictionary type definitions and updates one file to use
instead of straight casts. I had to fix two places where we'd casted off the
constness of the original pointer.
BUG=pdfium:201
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1420583003 .
(cherry picked from commit 39869b641511c882d78e17548293cdb458c36f38)
Review URL: https://codereview.chromium.org/1410343003 .
|
|
This does some minor copy editing and formatting of the documentation in the
fpdfview.h header.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411863004 .
(cherry picked from commit 19169dae5bf92813b7419793f61dfca8b4fb9124)
Review URL: https://codereview.chromium.org/1420593002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1409323003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1411963002 .
(cherry picked from commit 8b8dfd7934d669b2c74a0502f82387e5df0f573b)
Review URL: https://codereview.chromium.org/1415513004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410733004 .
(cherry picked from commit 0f2736742f5f9841447a4bd505dcadda22e2f574)
Review URL: https://codereview.chromium.org/1409853003 .
|
|
The CPDFDocumentFromFPDFDocument() helper function now completely
abstracts the difference between xfa and master for a number of
files, so they can stop including the xfa headers.
The JS header was a stray.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1415803003 .
|
|
Hand-application of diffs from https://codereview.chromium.org/1233453014/.
This was an oversight, and was too old (pre-reformat) to apply cleanly.
Checked against origin/master, only diffs are xfa related.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1416793002 .
|
|
Original Review URL: https://codereview.chromium.org/1416713002 .
(cherry picked from commit 6d34d056a7188b7ae9800fe3ceb68645e0442879)
Conflicts:
BUILD.gn
samples/BUILD.gn
samples/pdfium_test.cc
samples/samples.gyp
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1413593003 .
|
|
Review URL: https://codereview.chromium.org/1417483004 .
(cherry picked from commit ad0f4d9b371c1862a78046c2e3dea5d515043070)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1418543003 .
|
|
BUG=pdfium:205
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1409743004 .
(cherry picked from commit 9ddafc82bddb984ae46ee0df801ba20b446d5158)
Review URL: https://codereview.chromium.org/1411423002 .
|
|
Get rid of cond ? TRUE : FALSE.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1405723003 .
(cherry picked from commit aff4635dad81bc319266d9d84b81552580cd2b65)
Review URL: https://codereview.chromium.org/1412793003 .
|
|
Also reduce nesting in if statements, remove CFX_SmartPointer, and
use more unique_ptrs.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1393303004 .
(cherry picked from commit 6101a5f98b27888f1736ae74982ed4d409d83be0)
Review URL: https://codereview.chromium.org/1413223002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1401493002 .
(cherry picked from commit 894d1cd3f56b1c8c33c5a60ebfec14384e5002d0)
Review URL: https://codereview.chromium.org/1413213002 .
|
|
Original patch by Evangelos Foutras.
Orignal Review URL: https://codereview.chromium.org/1409243004 .
(cherry picked from commit 1b5084321ed924ad3fcc437c3effc81baafd18ac)
BUG=505226
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1418493002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1406363002 .
(cherry picked from commit 316e482630d5f5d9084edd9725f98a0d89a5bbdf)
Review URL: https://codereview.chromium.org/1406303006 .
|
|
Also remove some gotos and move code into an anonymous namespace.
And then do the partial revert to avoid size_t going negative.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1356373003 .
Review URL: https://codereview.chromium.org/1400723002 .
(cherry picked from commit d03ba8d1a5928e8f3f6bd7da063b53b0bc40abfd)
(cherry picked from commit a398ca611d1925182ff6a4e8b2b43c277c364dc0)
Review URL: https://codereview.chromium.org/1406373002 .
|
|
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410043003 .
(cherry picked from commit 3d7d1d2f29e5fb099367a40822684d31f684fd62)
Review URL: https://codereview.chromium.org/1415453002 .
|
|
Take extern tables portion only of fx_bidi change.
Take itoa fixes and corresponding unit test.
Merge typo in skia font mgr.
Kill some null checks after new.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1409223002 .
|
|
Original Review URL: https://codereview.chromium.org/1406543004 .
(cherry picked from commit 943ea142b6a7e6edc91fe3c307013129e6eb0ef3)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411623002 .
|
|
This CL updates the documentation link to the Chromium PDF plugin to
point to Gitiles instead of the SVN repo.
Merge clean.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1407313002 .
(cherry picked from commit 8969a70de3ed74bf0e2ae133378f5e7a4d1fd4c0)
Review URL: https://codereview.chromium.org/1412723002 .
|
|
Original Review URL: https://codereview.chromium.org/1411493002 .
(cherry picked from commit 8316a8a0274558f7a0f515e04bb13a7cca5762b2)
BUG=pdfium:217
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1405243004 .
|
|
This CL adds some more context to the README on the various test suites and
community mailing lists which are available.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1412453004 .
(cherry picked from commit 51cf5bc00dfa3033523355e3e74f3a47f7e46682)
This merge had conflicts.
Review URL: https://codereview.chromium.org/1413523002 .
|
|
PDF specs say that end of line markers shall follow the
keyword "stream". But a white space before end of line
markers follows this keyword in the test pdf files.
BUG=543018
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1401923005 .
|
|
This CL moves the conditionals inside the target_defaults configuration. This
causes the -fPIC to get picked up and allows component=shared_library to build
correctly.
Merged clean.
BUG=pdfium:218
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1407903002 .
(cherry picked from commit 26268af2c1242dd173aea6dcbf763a36e734faf3)
Review URL: https://codereview.chromium.org/1412563002 .
|
|
R=tsepez@chromium.org, thestig@chromium.org
BUG=pdfium:212
Review URL: https://codereview.chromium.org/1405203002 .
(cherry picked from commit fb3c41e5324671bce0b0ec025f4e94ae0b20906e)
Review URL: https://codereview.chromium.org/1406103002 .
|
|
Propagate the return value of GetRBG to the callers instead of forcing the
return of TRUE.
BUG=pdfium:44
TBR=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1398633008 .
(cherry picked from commit b456ba7f62fa416f456ef78750c18fd2bdf837be)
Review URL: https://codereview.chromium.org/1411443003 .
|
|
Manual merges everywhere.
Original Review URL: https://codereview.chromium.org/1395493007 .
(cherry picked from commit bb51c4fb6bc6095984c303c95e5336f83e66bc67)
Original Review URL: https://codereview.chromium.org/1396283006 .
(cherry picked from commit 86adb658843658969041a13bf6cf0cc950ffe8ed)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1395353004 .
|
|
This contains a missed merge of the Document:delay fixes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1398703009 .
|
|
Original Review URL: https://codereview.chromium.org/1404723002 .
(cherry picked from commit 7d54a9f70f977ce9b72959ef55dc6300713ccafe)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1404193002 .
|
|
These files should change in XFA in order to reduce the number of
"noise diffs" between master and XFA as seen in
https://codereview.chromium.org/1399273003/
These include: blank lines and missed merges:
3c012fe else-after-returns (partial)
fb07e28 Tidy up CPDFDOC_Environment (partial, consts missing).
624b166 Allow FPDFBookmark_GetFirstChild to return the top level bookmark
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1403063003 .
|
|
Original Review URL: https://codereview.chromium.org/1389163007 .
(cherry picked from commit 848a13b6777cbff8cc4aea3ab3d69eaa0b82ae6c)
Merge conflics in:
fpdfsdk/src/javascript/JS_Runtime.cpp
fpdfsdk/src/javascript/JS_Runtime_Stub.cpp
fpdfsdk/src/jsapi/fxjs_v8.cpp
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1394993006 .
|
|
Original Review URL: https://codereview.chromium.org/1399983003 .
(cherry picked from commit 6eeffab789800e2afa1b9d10de70c9116db32355)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1399893003 .
|
|
Original Review URL: https://codereview.chromium.org/1395733006 .
(cherry picked from commit f1c713663192368d26031a4caed1f9705f4510af)
Conflicts:
BUILD.gn
fpdfsdk/src/fpdfview.cpp
fpdfsdk/src/javascript/JS_Runtime.cpp
pdfium.gyp
samples/BUILD.gn
samples/samples.gyp
BUG=pdfium:211
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1393833006 .
|
|
BUG=457480,497355
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1338973005 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1399833002 .
|
|
We did this with the other codecs in master, but these two are
XFA-only, and did not get the same treatment.
Remove some fx_ prefixes in the third-party file names.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1392373004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1401253002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1394483005 .
|
|
- Use std::vector<JBig2ArithCtx> instead of storing pointers to arrays.
- Make CJBig2_SymbolDict's members private with accessors.
- Use std::vector<JBig2ArithCtx> in related places.
- Steal Chromium's vector_as_array() and use it as an adaptor as needed.
BUG=514891
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1388203003 .
(cherry picked from commit 3acb1ef909a22368507ed13817c4988c818e3aee)
Review URL: https://codereview.chromium.org/1401533004 .
|
|
TBR=dml@google.com
Review URL: https://codereview.chromium.org/1390863002 .
(cherry picked from commit fb0334733cf4a541636128f77f9fe8067a8c70f6)
Review URL: https://codereview.chromium.org/1395213003 .
|
|
- Use the number of cores as the default -j value
- Fall back to old code for -j 1
TBR=nparker@chromium.org
Review URL: https://codereview.chromium.org/1398793003 .
(cherry picked from commit fd751f28cecce61ab36038799043639d570e0b26)
Review URL: https://codereview.chromium.org/1395253002 .
|
|
BUG=497357
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1395493003 .
|
|
It's a bug existing in the conversion from YUV420 to RGB.
For YUV 420 format, four pixels have 4 Y but only one U and
one V. In some cases, there are odd columns or lines in
some images. The pixels on last line or column may have Y
but no U or V data. For this case, We shall extend U or V
using the data on previous column or line.
BUG=497357
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1342683002 .
|
|
Just get rid of the malloc altogether and use CJBig2_List instead.
BUG=540873
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1394933002 .
(cherry picked from commit 06f255ca4040f3d73cf09f1dbd63a3b167f6a4c1)
Review URL: https://codereview.chromium.org/1400663003 .
|