Age | Commit message (Collapse) | Author |
|
We'd skip a test as the two strings would get joined, add the missing
comma so all tests are run correctly.
Found by: etienneb@
R=etienneb@chromium.org
Review URL: https://codereview.chromium.org/1826193002 .
|
|
Use FreeType instead of Direct Write on Windows. Since PDFium
currently uses the graphics engine to draw but not to measure,
the graphics engine needs to always use FreeType to get
consistent metrics.
Add a translation from PDF's blend modes to Skia's xfer modes.
Turn on subpixel positioning for text to get more precise
glyph placement.
Pass the alpha through to get proper bitmap transparency.
Address earlier nits.
R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair
Review URL: https://codereview.chromium.org/1812263002 .
|
|
This CL re-writes the documentation in the public/fpdf_dataavail.h to clean up spelling, grammar and formatting.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1825433002 .
|
|
This CL moves all of the pdfwindow headers to live beside their source files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1823153002 .
|
|
This CL splits apart the core/include/fpdfapi/fpdf_resource.h file and places
the classes into individual files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1824033002 .
|
|
This file should not exist and causes issues with gclient.
|
|
This CL moves and splits the FWL files from the core and basewidget directories
into the non-include folders.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1827923002 .
|
|
This CL moves the fxcrt code into the core/fxcrt directory. The only exception
was fx_bidi.h which was moved into core/fxcrt as it is not used outside of
core/.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1825953002 .
|
|
Update Skia to a version that supports building Windows
with FreeType as a font backend.
This also breaks the current version of PDFium when
pdf_use_skia=1 ; the SkDashPathEffect interface is different.
Staging the DEPS change separate from the changes that use it
will help me keep my sanity.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1832483002 .
|
|
After moving EmbeddedUnicodeFromCharcode the
IsValidEmbeddedCharcodeFromUnicodeCharset method is no longer used on windows.
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1827823002 .
|
|
EmbeddedCharcodeFromUnicode is not used on windows anymore and clang complains.
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1828673002 .
|
|
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1821423002 .
|
|
Pull the gn binary from google source. This is needed inorder to get git cl
format to work correctly on mac. Added other platforms for completness.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1826663002 .
|
|
Patch by cherycherian.
patch from issue 1810153003 at patchset 1 (http://crrev.com/1810153003#ps1)
FormCalc expressions containing double-dot operators in SOM expressions
were failing since XFA_ResolveNodes_AnyChild was always stripping the
leading character.
Roll testing/corpus to d671154 to pick up the test.
BUG=pdfium:434
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1821413002 .
|
|
One initializer was lost in that conversion.
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1824173002 .
|
|
Fix a couple issues with OnXFAAAction():
-- radio button widget should not call ProcessEvent() twice;
-- UpdateDocView should be called before returning;
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1809073004 .
|
|
Add a few missing consts and remove a few extra externs.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1817283002 .
|
|
It isn't buying us anthing, and it looks strange in
a struct when other uint types are already present.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1821043003 .
|
|
Remove some tables from .h file (risk of duplication).
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1814233005 .
|
|
This CL splits apart the larger header into individual class headers in the
xfa/fxbarcode directory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1816133002 .
|
|
The only one that is ever used is FXDIB_PALETTE_loc, so remove
the option entirely. In turn, this allows deleting about 2KB
of unused constant tables.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1809943007 .
|
|
Re-enable the following warnings:
4245: signed/unsigned conversion mismatch;
4310: cast may truncate data;
4389: operator on signed/unsigned mismatch;
4701: use potentially uninitialized local variable;
4706: assignment within conditional expression
Clean up the code to avoid those warnings.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1801383002 .
|
|
When both text objects have no items, directly return TRUE;
The last if statement moved inside loop to make the intent more
obvious and free from warning (msvc warns using potentially
uninitialized var itemPer)
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1815453002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1824643002 .
|
|
This CL splits the file into individual classes and moves them into
core/fpdfapi/fpdf_page as needed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1811053002 .
|
|
This CL moves the .h files and renames the .cpp files to match.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1809193002 .
|
|
R=nodir@chromium.org
Review URL: https://codereview.chromium.org/1817683002 .
|
|
BUG=591789
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1814223003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1820573002 .
|
|
Add CQ configuration file to infra/config directory.
R=tandrii@chromium.org
Review URL: https://codereview.chromium.org/1819513002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1808853007 .
|
|
Saves a few bytes here and there because the tables need
only 16 bits but wchar is 32 bits (except on windows).
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1815313003 .
|
|
When building with clang-cl and not passing /FIintrin.h, the
__attribute__ defined to nothing, which confuses the compiler
(see bug).
Since nothing seems to require the __attribute__ redefinition,
just remove it.
Reported upstream here: https://github.com/uclouvain/openjpeg/issues/727
BUG=592745
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810373002 .
|
|
Either by using the smallest possible data type, or
By accurately calcuating the bounds, or
Moving to array of pointers for varying length rows.
Notes:
The 929 is reassuring since PDF417 barcode uses GF(929).
FX_WCHAR is 4 bytes on unix (2 on windows).
Binary looks to be about 240k smaller on linux/64
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1807373002 .
|
|
-Wno-sign-compare also for GCC.
-Wno-error=strict-overflow to ignore the following warning.
In file included from
../../third_party/pdfium/core/include/fpdfapi/cpdf_object.h:10:0,
from
../../third_party/pdfium/core/include/fpdfapi/cpdf_stream.h:10,
from
../../third_party/pdfium/core/include/fpdfapi/fpdf_resource.h:12,
from
../../third_party/pdfium/core/fpdfapi/fpdf_font/font_int.h:13,
from
../../third_party/pdfium/core/fpdfapi/fpdf_font/fpdf_font_cid.cpp:7:
../../third_party/pdfium/core/include/fxcrt/fx_string.h: In function
'CFX_ByteString {anonymous}::CMap_GetString(const CFX_ByteStringC&)':
../../third_party/pdfium/core/include/fxcrt/fx_string.h:111:19: warning:
assuming signed overflow does not occur when assuming that (X - c) > X is always
false [-Wstrict-overflow]
if (count < 0 || count > m_Length - index) {
BUG=589724
TEST=build with GCC
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1785943002 .
|
|
BUG=pdfium:401
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1758553003 .
|
|
Add missing stdarg.h file so mac can build with skia.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1813633002 .
|
|
This CL fixes up build issues with pdfium_use_skia=1 on windows.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810063002 .
|
|
More Skia driver cleanup.
Fix the GN build for Skia.
Remove unused functions from header.
Remove agg setup that is not required.
Change path construction to use the SkCanvas matrix to position the path
rather than converting the points directly.
Draw stroked paths using Skia rather than generated the filled path.
Pin the minimum stroke width to 1 px in device space to mimic PDF's stroke
dropout control.
Factor out flipped and non-flipped matrices.
Add some debugging code.
Set the bitmap filter quality to high. This helps a lot with 1 bit sources.
R=dsinclair@chromium.org, dsinclair, tsepez
Review URL: https://codereview.chromium.org/1806843002 .
|
|
This Cl moves and splits apart the fx_graphics.h file into individual classes.
The .cpp files are renamed to match the .h files. pre.h was removed at the
same time and its contents moved to the correct places as needed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1810563002 .
|
|
This CL adds the necessary pieces so you can add pdf_use_skia=1 to GYP_DEFINES
and do a standalone build.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/1812563002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1806683003 .
|
|
This CL splits the fpdf_page.h header into the individual classes and moves
them to the correct core/fpdfapi locations.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1805663002 .
|
|
Fix warnings in win32_int.h
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1809473002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1797423002 .
|
|
Currently, it is only deleting the CPDF_ resources, which
are wrapped by XFA objects in an XFA build. Hence, if a page
is deleted and then re-inserted, we get the old contents. In
print preview, chromium first inserts blank pages and then
replaces them later on, causing the associated bug.
BUG=594111
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1804163002 .
|
|
This CL moves the fxjse.h header and splits the cfxjse_arguments.h into its
own file.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1807623002 .
|
|
Using a list is more appropriate, since we wish to delete
from the middle.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1780093003 .
|
|
This Cl moves a bunch of the files from core/include/fpdfapi to their correct
location outside the core/include tree.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1805603002 .
|
|
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1800793002 .
|