Age | Commit message (Collapse) | Author |
|
No need to make a WideStringC here at all.
Review-Url: https://codereview.chromium.org/1984743003
|
|
There were two defines, BBS_ and PBS_ for the various border styles in the
system. They were the same, except PBS_ had an extra SHADOW define which was
never used.
This CL combines both of those into a single BorderStyle enum class and updates
the code as needed.
Also, removes ADDBIT, GETBIT unused defines. Updates barcode code to use
the util.h defines instead of redefinition. fsdk_baseannot names starting with _ were cleaned up and some #defines moved to constants.
Review-Url: https://codereview.chromium.org/1980973002
|
|
Add a note about the need for pdfium_is_standalone and fix some spelling
mistakes along the way.
Review-Url: https://codereview.chromium.org/1979243002
|
|
Add missing helper function to CFX_ByteTextBuf to avoid the
anti-pattern CFX_ByteString(sBuf.AsStringC()), using the name
"Make" to indicate there's an allocation going on in this case.
Change some method arguments to take pre-existing ByteStrings where
possible.
Review-Url: https://codereview.chromium.org/1977093002
|
|
BUG=
Review-Url: https://codereview.chromium.org/1979723003
|
|
ChromeOS still compile pdfium with GCC. Fix the code to be ready
to have workable GCC standalone build. The build file change will
be in a follow-up CL.
One warning is about maybe using uninitialized variable, the other is
about enum and non-enum in a conditional statement.
Review-Url: https://codereview.chromium.org/1981593002
|
|
Review-Url: https://codereview.chromium.org/1973883005
|
|
Review-Url: https://codereview.chromium.org/1874773002
|
|
On Linux, at least.
BUG=pdfium:11
Review-Url: https://codereview.chromium.org/1971023007
|
|
Review-Url: https://codereview.chromium.org/1979463002
|
|
PDFium uses fxge to denote the graphics engine used
for general rendering. When pdf_use_skia=1 is set,
use Skia as the default engine instead of antigrain.
R=tsepez@chromium.org,dsinclair@chromium.org
Review-Url: https://codereview.chromium.org/1975143002
|
|
These were left over from after I broke a big "things that never return
NULL" CL up into smaller ones.
Review-Url: https://codereview.chromium.org/1960043003
|
|
Review-Url: https://codereview.chromium.org/1978453004
|
|
Most of the time, we want to operate on chars as if they
were unsigned, but there are a few places where we need
the default (questionably signed) values. Consolidate
the casting in a single place rather than forcing callers
to get a char* ptr.
BUG=pdfium:493
Review-Url: https://codereview.chromium.org/1972053003
|
|
Previous CLs have removed or marked explicit the constructors
which allowed bad constructs to compile. I now get an error:
candidate constructor not viable: expects an l-value for 1st argument
when called as indicated in the comment.
Review-Url: https://codereview.chromium.org/1975983002
|
|
Review-Url: https://codereview.chromium.org/1973913002
|
|
BUG=611352
R=thestig@chromium.org
Review-Url: https://codereview.chromium.org/1977613002
|
|
Review-Url: https://codereview.chromium.org/1969353002
|
|
Building a set on top of a map and ignoring the mapped
value seems wasteful.
Review-Url: https://codereview.chromium.org/1942903003
|
|
R=tsepez@chromium.org,thestig@chromium.org
Review-Url: https://codereview.chromium.org/1975823002
|
|
TBR=tsepez@chromium.org
Review-Url: https://codereview.chromium.org/1976443002
|
|
Review-Url: https://codereview.chromium.org/1968273002
|
|
files. (patchset #1 id:1 of https://codereview.chromium.org/1946693002/ )"
This reverts commit a031357eaab7c934ac03717968cf78ff556c819b.
The reason to revert it is that some malformed or maliciously crafted PDF
files may cause crashes.
BUG=610973
Review-Url: https://codereview.chromium.org/1971013002
|
|
BUG=pdfium:493
Review-Url: https://codereview.chromium.org/1968233002
|
|
BUG=pdfium:493
Review-Url: https://codereview.chromium.org/1967223002
|
|
BUG=611198
Review-Url: https://codereview.chromium.org/1963233005
|
|
In particular, we seek to make more use of the .Mid()
(substr) method to make these.
Precursor to removing c_str() calls.
BUG=pdfium:493
Review-Url: https://codereview.chromium.org/1966293002
|
|
- CPVT_Size is the same as CFX_SizeF
- CPVT_FloatRange is unused.
Review-Url: https://codereview.chromium.org/1961333002
|
|
Same goes for CFX_Edit::GetIterator().
Review-Url: https://codereview.chromium.org/1967963002
|
|
- Remove dead code in CPDF_Color.
- Encapsulate member variables.
- Added accessors as need.
- Remove unused CPDF_ColorSpace::GetMaxIndex().
- Remove redundent CPDF_StreamContentParser::GetNumber16().
Review-Url: https://codereview.chromium.org/1965243002
|
|
Cache the linearized result rather than recalculating it.
BUG=608778
Review-Url: https://codereview.chromium.org/1968743002
|
|
Remove unused member and return value along the way.
Review-Url: https://codereview.chromium.org/1940033002
|
|
Fix some bit rot with the Skia build; update the gypi
to current and switch a deprecated call for the current
one.
R=tsepez@chromium.org
Review-Url: https://codereview.chromium.org/1958263002
|
|
Searching for the anti-pattern:
void Release() { delete this; }
We must be explicit on the ownership model.
Add unique_ptrs as a result.
Review-Url: https://codereview.chromium.org/1960673003
|
|
- No caller checks the CPDF_VariableText::SetProvider() return value.
- IFX_Edit::SetVTProvider() is unused.
- CFX_ListItem::SetCaret() is useless.
- CFX_List::SetItemCaret() is also useless.
- CPVT_GenerateAP::GenerateEditAP() has a param that's always NULL.
Review-Url: https://codereview.chromium.org/1960183003
|
|
Remove several obsolete warnings from GYP build;
Move disabled warning flags closer to the target instead of the
whole package for GYP build;
Use macro undefine instead of disabled warning for libtiff for GN
build.
Review-Url: https://codereview.chromium.org/1962863002
|
|
BUG=pdfium:488
Review-Url: https://codereview.chromium.org/1936383002
|
|
The Skia variant generates a couple of warnings on the linux build.
One of the warning silenced is an unused variable. Once PDFs are
identified that exercise this variable, the dummy code will be
replaced.
R=tsepez@chromium.org
Review-Url: https://codereview.chromium.org/1962683002
|
|
Review-Url: https://codereview.chromium.org/1954593004
|
|
Chromium defines WIN32_LEAN_AND_MEAN on Windows. Third party library
libtiff also defines it. So we undefine it before compiling libtiff
code for GYP build.
Also, remove _CRT_SECURE_NO_WARNINGS macro since it is redefined in
zlib library as well. Our code no longer needs it.
After fixing the above, re-enable warning flag 4005 which alerts about
"macro redefinition".
For GN build, we disable warning 4005 for compiling libtiff
code before we can figure out another way to do this.
Review-Url: https://codereview.chromium.org/1954773002
|
|
This fixes a build issue where MEMORY_TOOL_REPLACES_ALLOCATOR may already be
set.
Review-Url: https://codereview.chromium.org/1951383002
|
|
This Cl updates all the CLASSHASH defines to use an enum class. A few defines
where unabled and were either updated or removed if the number no longer exists
in the code base.
Review-Url: https://codereview.chromium.org/1946213003
|
|
TBR=tsepez@chromium.org,dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1949383002 .
|
|
ASSERT(statement) will not execute statement in release builds. So
need to move statements outside ASSERT().
TBR=tsepez@chromium.org,dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1949613004 .
|
|
The reason to disable 'treating warnings as errors' earilier is due to
c4267 warnings, which we already disabled uniformly in pdfium.gyp.
Re-enable this now so that we can have the same level of compilation
warnings/errors on 32 bit and 64 bit builds.
Also fix two c4390 warnings on Windows release builds. Their warning
messages are "empty controlled statement found; is this the intent?"
Review-Url: https://codereview.chromium.org/1949303002
|
|
This Cl updates FWL_ERR to be an FWL_Error enum class. It removes FX_ERR and
replaces it with FWL_Error as well as the values were the same.
There were many places where we either returned other values for FWL_ERR
results.
This Cl is the same as: https://codereview.chromium.org/1943413002/ but I seem
to have messed up the base URL in that one.
TBR=tsepez@chromium.org
Review-Url: https://codereview.chromium.org/1952693003
|
|
Review-Url: https://codereview.chromium.org/1951873003
|
|
Review-Url: https://codereview.chromium.org/1952853002
|
|
data_binding.pdf is much closer now that events are sent.
It still diffs due to some bg color issues, not that the
box is unchecked.
Review-Url: https://codereview.chromium.org/1952823002
|
|
This CL removes:
* IFWL_AdapterNative
* IFWL_Adapter{Widget|Thread}Mgr
* IFWL_WidgetMgrDelegate
* CFWL_SDAdapter{Widget|Thread}Mgr
Methods which just returned have also been removed.
Review-Url: https://codereview.chromium.org/1928963004
|