Age | Commit message (Collapse) | Author |
|
Change-Id: I8ad38892eda7c820189924d53dacbb4c5a720e8b
Reviewed-on: https://pdfium-review.googlesource.com/c/43458
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Tidy ctor while at it.
Change-Id: I33c0751bc37e1aa840033439b4826c76d1597d4c
Reviewed-on: https://pdfium-review.googlesource.com/c/43456
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
We always call CRYPT_SHA*Start() with &ctx, so it can't be null.
Found by inspecting code coverage report.
Change-Id: Ibdca16e6a1f2d60514270fe386bf555668ec3586
Reviewed-on: https://pdfium-review.googlesource.com/c/43452
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Remove unused method, make ctor/dtor out-of-line.
Change-Id: I77bb7c1da8e9d369085072639ca388247f2b9225
Reviewed-on: https://pdfium-review.googlesource.com/c/43455
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Bug: pdfium:1172
Change-Id: I8399a0add43dcb1f3269101d6ea212cfc33d3ca7
Reviewed-on: https://pdfium-review.googlesource.com/c/43454
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
We always pass it as 16. In turn, remove some unused code
to handle the non-16 cases.
Noticed while looking at coverage report.
Change-Id: I93f5f0342537284ce6a2b36a8b477425da3cc872
Reviewed-on: https://pdfium-review.googlesource.com/c/43450
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
- Fix buffer leak if TryRealloc fails.
- Make m_SrcSize always represent the usable bytes in the buffer, even
when read the last partial block from the file.
- Remove redundant comparisons and use std::min().
- Better naming.
Change-Id: Ie7dd79bac21b2f2422f299563a2dd28ed358e3e2
Reviewed-on: https://pdfium-review.googlesource.com/42130
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
This is a reland of 9d784c291714b703b16185e69860a3797de85b6c
https://chromium-review.googlesource.com/c/chromium/src/+/1244367
was submitted changing the test that broke with this CL to not depend
on PDF OpenActions anymore.
Original change's description:
> Make potentially dangerous Actions require a user click.
>
> URI and SubmitForm actions are only handled if the event was
> ButtonUp or ButtonDown.
>
> Bug: 851821
> Change-Id: If6eb0ff44f6d62ac6df50b552c0bdc582885ab5d
> Reviewed-on: https://pdfium-review.googlesource.com/42731
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Bug: 851821
Change-Id: Iaf9c399059590f0f1a050ac450e08ee60a8d5a38
Reviewed-on: https://pdfium-review.googlesource.com/43410
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
Change-Id: I116745419311b4cd37ce69c85f6ce6972d5325f4
Reviewed-on: https://pdfium-review.googlesource.com/43351
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Change-Id: I85d2094f77866d18c0dce060755583ea289bb9ea
Reviewed-on: https://pdfium-review.googlesource.com/43350
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Use it in a couple of places. Make the similar code in the two places
even more so.
Change-Id: I3fc6a567088217e24506cdf7ab927b94cb5a4d52
Reviewed-on: https://pdfium-review.googlesource.com/43330
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Break the methods down to their basic functionality, and built up from
there.
Change-Id: I691abaf08375425b59f2382cf95577c3917aca9d
Reviewed-on: https://pdfium-review.googlesource.com/42972
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I2d30ceb5e475290c0842fe4add7ffb965dc77572
Reviewed-on: https://pdfium-review.googlesource.com/c/43316
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Rename the internal one LoadFontInternal. Remove unused out parameter.
Change-Id: Ia108bc4fc29ef0ad7732eacad9bb924a8e424c2e
Reviewed-on: https://pdfium-review.googlesource.com/c/43317
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
It has no member variables.
Change-Id: I25b333e201d76e90d25e3f526cf23bccd2b4687a
Reviewed-on: https://pdfium-review.googlesource.com/c/43315
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Do IWYU elsewhere, and unindent CFGAS_DefaultFontManager::GetFont().
Change-Id: Idb06c4ae75ce2d72b231cc4c84f61e5ca8a80cc5
Reviewed-on: https://pdfium-review.googlesource.com/c/43314
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Fix IWYU issues in affected files.
Change-Id: I92c145348549d2d0f0e066e134e649b3b958e068
Reviewed-on: https://pdfium-review.googlesource.com/c/43313
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Extract some dividends from having landed the previous CL.
Change-Id: I9ade77c801b51762cab801716b9fd2bc4c634036
Reviewed-on: https://pdfium-review.googlesource.com/c/41990
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
This path has only been present under XFA, and has resulted in
several bugs, including the referenced one. There is a breakage in some
XFA functionality, but I'm not confident we can do this without
re-engineering all of fpdfsdk widget ownership.
Bug: 891210
Change-Id: I5aa158fa5359b1c8338046eefb25fb25df9ace48
Reviewed-on: https://pdfium-review.googlesource.com/c/43311
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
Use std::unique_ptr and MaybeOwned, instead of manual memory management.
Change-Id: I5f08abd869245fb55b7e868621369ff3ea34146f
Reviewed-on: https://pdfium-review.googlesource.com/43211
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
|
|
Callers only ever pass in nullptr for the bitmap parameter.
Change-Id: Iefeb72a1268521a38b3d5ab4b03163b67bf35796
Reviewed-on: https://pdfium-review.googlesource.com/43210
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I4a47a3d7c7a66de08217dc33d5f6f324e3e6a41c
Reviewed-on: https://pdfium-review.googlesource.com/43312
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
It occasionally times out on the bots.
Change-Id: Ie33d77c0e07f932c374c2ca670f982faeed29659
Reviewed-on: https://pdfium-review.googlesource.com/c/43310
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
BUG=chromium:890322
Change-Id: I11050b84cf440f8d6bb00c661360de4e389dc031
Reviewed-on: https://pdfium-review.googlesource.com/c/43290
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This adds a test case where a simple red square BMP image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of BMPs is working.
Displaying BMPs is currently broken, https://crbug.com/pdfium/1168, so
this test is currently suppressed.
BUG=pdfium:1163
Change-Id: I3ef006a7aa16717ad9cdbca1d423613f17246a5e
Reviewed-on: https://pdfium-review.googlesource.com/43132
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
This adds a test case where a simple red square TIFF, using Deflate
compression, image is embedded into an XFA document. This exercises
that <image> tags work correctly and that end to end rendering of
Deflate TIFFs is working.
Change-Id: Ibe1b9f2a367ca3ceba6e08461f392e659459f7b8
Reviewed-on: https://pdfium-review.googlesource.com/43250
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square TIFF, using PackBits
compression, image is embedded into an XFA document. This exercises
that <image> tags work correctly and that end to end rendering of
PackBits TIFFs is working.
Change-Id: I01723a4ac8192b357b5a8480e7709ac6a0dce945
Reviewed-on: https://pdfium-review.googlesource.com/43270
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square TIFF, using LZW
compression, image is embedded into an XFA document. This exercises
that <image> tags work correctly and that end to end rendering of LZW
TIFFs is working.
Change-Id: Iecaef68e7eb4b1e822737f3faf4837699261e28b
Reviewed-on: https://pdfium-review.googlesource.com/43230
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square PNG image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of PNGs is working.
Change-Id: I8b04c5b0e85f7163e22dcf98593e6c88d5395ebb
Reviewed-on: https://pdfium-review.googlesource.com/43130
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square TIFF image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of TIFFs is working.
Change-Id: Ida61ed4bd49a58c432bde017832fa80187dc58d6
Reviewed-on: https://pdfium-review.googlesource.com/43134
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
|
|
CPDFXFA_Context should always have a valid doc.
Change-Id: Ifb547281f1e4f2741e2d741438b9a3ece71f9e99
Reviewed-on: https://pdfium-review.googlesource.com/43212
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
- Sync bits.h and compiler_specific.h.
- Delete macros.h.
Change-Id: Idf586cd2ea61bc87ed86829d94ae0d4c5a04eae4
Reviewed-on: https://pdfium-review.googlesource.com/43170
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
Change-Id: I90898b292d081419d803df1aa1af1d15e23a6108
Reviewed-on: https://pdfium-review.googlesource.com/43150
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
Change-Id: I996c9b32d767960a5388e44e13180e1f6577ce38
Reviewed-on: https://pdfium-review.googlesource.com/43190
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
And remove some unnecessary casts.
Change-Id: Ifbc78e7b399ce668c92122c8c45d5995b599c971
Reviewed-on: https://pdfium-review.googlesource.com/43193
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
Change-Id: If8c45af624ed6df7b6d7416bb4e195f4097b0574
Reviewed-on: https://pdfium-review.googlesource.com/43191
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
Change-Id: Ib8caef1f46478e9bf1c0e717997accb71000124a
Reviewed-on: https://pdfium-review.googlesource.com/43192
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
This adds a test case where a simple red square JPG image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of JPGs is working.
Change-Id: Ife2f334c4c2a77a551d7c0b6f31c36f6cf42fcee
Reviewed-on: https://pdfium-review.googlesource.com/43133
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
This adds a test case where a simple red square GIF image is embedded
into an XFA document. This exercises that <image> tags work correctly
and that end to end rendering of GIFs is working.
Displaying GIFs is currently broken, https://crbug.com/pdfium/1167, so
this test is currently suppressed.
BUG=pdfium:904
Change-Id: I400a2a287c24726bc811dacfabe30ddc77f38b9c
Reviewed-on: https://pdfium-review.googlesource.com/43131
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: If13cc70d3d047f255f5d289f35a8533811523146
Reviewed-on: https://pdfium-review.googlesource.com/43110
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
Change-Id: I547288c19c714a8222af89e0499d6786dad917c7
Reviewed-on: https://pdfium-review.googlesource.com/42457
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Change-Id: I186e39c60a2e87983f05a3407b668e15160c2372
Reviewed-on: https://pdfium-review.googlesource.com/42456
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/dfddc2d97596..abd997aa7cf2
$ git log dfddc2d97..abd997aa7 --date=short --no-merges --format='%ad %ae %s'
2018-09-21 wl Improve documentation of `FT_LOAD_NO_RECURSE'.
2018-09-21 bungeman Improve auto-hinter handling of bitmap fonts (#54681).
2018-09-21 wl [raster] Fix disappearing vertical lines (#54589).
2018-09-21 wl [base] Some comments.
2018-09-20 apodtele * src/base/ftobjs.c (ft_glyphslot_reset_bimap): Tiny rounding tweak.
2018-09-20 apodtele [pcf] Replace charmap implementation.
2018-09-20 wl [base] Remove unused function `FT_GlyphLoader_CopyPoints'.
2018-09-19 apodtele [pcf] Prepare to replace charmap implementation.
2018-09-18 apodtele Remove unused fields.
Created with:
roll-dep third_party/freetype/src
BUG=pdfium:1159
TBR=npm@chromium.org
Change-Id: I535f75ac4a7fdeb3ba3266f57d5fbda39493a6aa
Reviewed-on: https://pdfium-review.googlesource.com/43030
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This reverts commit 214982c4d02a720c3b1b3de121cddc62189b8848.
Reason for revert: Turns out it is reachable.
Original change's description:
> Remove unreachable code in CPDF_DIBBase.
>
> The colorspace is always available when creating image decoders that use
> colorspaces.
>
> Change-Id: I20ac75edcd614ccc1e83de262c128776e9d03eed
> Reviewed-on: https://pdfium-review.googlesource.com/42872
> Commit-Queue: Ryan Harrison <rharrison@chromium.org>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
TBR=thestig@chromium.org,rharrison@chromium.org
BUG=chromium:888743
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I45903543f0e4bf2785660fb8c1e45c34febb6ecf
Reviewed-on: https://pdfium-review.googlesource.com/43050
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Because I nearly botched this trivial calculation in the previous CL.
Change-Id: I7438f9d3476d93b7899c2d7d761234769f53f9e3
Reviewed-on: https://pdfium-review.googlesource.com/43010
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Another step before trying to fix the memory issue. Forces common
APIs on the bunch of decoders, though some methods are unused.
Requires adding some arguments/return values to get to a common
API which are not used in all cases (yet?). Required converting
some args to spans. Required proxying a GetJumpMark() call through
the public module API to the private context.
Bug: pdfium:1082
Change-Id: I0c0b7415141ff2a6f4f44777ca3d05521f08130d
Reviewed-on: https://pdfium-review.googlesource.com/41950
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Use std::vector<float> for dash array.
Use compiler-generated default operations.
Squeeze some enums.
Fix obvious logic botch in DashChanged().
Change-Id: If1d809cc46a3cf2db98a09a3f5a49d22138c0640
Reviewed-on: https://pdfium-review.googlesource.com/42613
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
|
|
This reverts commit 9d784c291714b703b16185e69860a3797de85b6c.
Reason for revert: Roll into chromium is stuck, this is a potential
culprit.
Original change's description:
> Make potentially dangerous Actions require a user click.
>
> URI and SubmitForm actions are only handled if the event was
> ButtonUp or ButtonDown.
>
> Bug: 851821
> Change-Id: If6eb0ff44f6d62ac6df50b552c0bdc582885ab5d
> Reviewed-on: https://pdfium-review.googlesource.com/42731
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Ryan Harrison <rharrison@chromium.org>
TBR=tsepez@chromium.org,hnakashima@chromium.org,rharrison@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Bug: 851821
Change-Id: I6f1bc0a02f65a24fbd49d53526b985f8a4ea0b4f
Reviewed-on: https://pdfium-review.googlesource.com/42990
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
Fix some nits too.
Change-Id: I7d088f28b3b6898fcfbafb9c0e6eac6442ff1515
Reviewed-on: https://pdfium-review.googlesource.com/42910
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/build.git/+log/f53effa79190..dfca77bb0d1a
Created with:
roll-dep build
TBR=hnakashima@chromium.org
Change-Id: I5cfba813f404ab7a3ac69f8b66ba0f991e195cb0
Reviewed-on: https://pdfium-review.googlesource.com/42971
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|