summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-01-15Remove ifdefs for _FX_MANAGED_CODE_.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1589223002 .
2016-01-15Make the bug 361 test case work in Acrobat.Lei Zhang
BUG=pdfium:361 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1586983005 .
2016-01-14Revert "Cleanup CJS_PublicMethods::ParseNumber"Tom Sepez
This reverts commit 4cd5b80e70e5fc50d8bd805cfa3c7b54878a0a35. Reason for revert: broke tests on windows TBR=tombergan@chromium.org TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1573243016 .
2016-01-14Cleanup CJS_PublicMethods::ParseNumberTom Sepez
Original patch by tombergan. The old version of this function was basically strtod with a few quirks: 1. It always interpreted ',' as '.' independent of locale. I kept this behavior, to be conservative. 2. It interpreted the first non-number character as a decimal point, unless there was a prior decimal point, in which case all characters up to that point are ignored. This would parse "123z4" as "123.4" and "123xy6" as "6". I did not keep this behavior -- in the new code, these examples all fail to parse. The new ParseNumber was inlined into ConvertStringToNumber, which returns true on success and (false, 0) on failure. BUG=pdfium:361 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1582013002 .
2016-01-14Disable use of missing arm neon function in libpngSam Clegg
This was causing pdfium_diff to fail to link on ARM/linux due to missing neon-specifc symbols. Ideally we could add the missing symbols (and update the latest version of libpng), but that can happen in a separate CL. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1581193007 .
2016-01-14Loose checking for trailer's size fieldWei Li
Although trailer's size value is required by spec, other readers such as Acrobat or libpoppler can handle without it. Loose up the check to be more tolerant. BUG=pdfium:213 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1582193002 .
2016-01-14Additional test cases for bug_361Tom Sepez
These cover some corner cases discussed from the CL at https://codereview.chromium.org/1582013002/ R=thestig@chromium.org, tombergan@chromium.org Review URL: https://codereview.chromium.org/1582383002 .
2016-01-14Correct the way to count pages and to avoid infinite loopWei Li
BUG=pdfium:360 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1585823003 .
2016-01-14openjpeg: Fix potential bad precno value in opj_pi_next* functions.Oliver Chang
R=thestig@chromium.org BUG=571479 Review URL: https://codereview.chromium.org/1585243003 .
2016-01-13Fix another invalidated iterator issue while traversing CPDF_Dictionary.Oliver Chang
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1582903004 .
2016-01-13Use _GLIBCXX_DEBUG in standalone Debug builds on Linux.Lei Zhang
R=ochang@chromium.org Review URL: https://codereview.chromium.org/1588643003 .
2016-01-13Fix some iterator invalidation issues while traversing CPDF_Dictionary.Oliver Chang
Also fixes a potential issue in CPDF_Dictionary::ReplaceKey. R=thestig@chromium.org BUG=577030 Review URL: https://codereview.chromium.org/1582963003 .
2016-01-13Do not use invalidated std::map::iterators in PDF_ReplaceAbbr().Lei Zhang
Avoid invalidating iterators by deferring the std::map operations. Also remove unused PDF_ReplaceFull(). BUG=577030 R=ochang@chromium.org Review URL: https://codereview.chromium.org/1581963004 .
2016-01-13test cast for bug_361Tom Sepez
R=thestig@chromium.org, tombergan@chromium.org Review URL: https://codereview.chromium.org/1588733003 .
2016-01-13Fix out of bound access in CPDF_Parser::ParseIndirectObject().Lei Zhang
This regressed in commit f6dafc9. BUG=576915 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1582763002 .
2016-01-13Use the compiler to type check DocAvailStatus return values.Lei Zhang
R=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1575363007 .
2016-01-12Roll DEPS for V8 to ee1671b.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1579353002 .
2016-01-12Use std::map in CPDF_IndirectObjectsTom Sepez
Rename to CPDF_IndirectObjectHolder R=thestig@chromium.org Review URL: https://codereview.chromium.org/1576113003 .
2016-01-11Fix an infinite loop parsing in CPDF_SyntaxParser::GetObject()Wei Li
CPDF_SyntaxParser::GetObject() may enter into an infinite loop when a signature dictionary doesn't have 'Contents' field. Add a check to avoid that. BUG=pdfium:344 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1575833004 .
2016-01-11Roll DEPS for V8 to d95511c.Lei Zhang
R=jochen@chromium.org Review URL: https://codereview.chromium.org/1544943002 .
2016-01-11Fix an uninitalized read in FPDFText_GetFontSize().Lei Zhang
BUG=pdfium:346 R=jun_fang@foxitsoftware.com Review URL: https://codereview.chromium.org/1578543002 .
2016-01-11Tidy up shading patternsTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1570873005 .
2016-01-11Use std::map as CPDF_Dictionary's underlying store.Oliver Chang
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr so it's not completely removed just yet. Adds begin()/end() to CPDF_Dictionary and removes the GetStartPos()/GetNextElement() functions to traverse the dictionary. Callers are changed accordingly. AddValue() is also removed. R=tsepez@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/1541703003 .
2016-01-08Switch most min/max macros to std::min/max.Lei Zhang
Fix lint errors along the way. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1567343002 .
2016-01-08IWYU in core/src/fpdfapi/fpdf_page/pageint.h.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1572733002 .
2016-01-08Use unique_ptr in fpdf_page/.Tom Sepez
Make m_InternalStage an enum. Use safe types to detect overflow. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1568373003 .
2016-01-08Remove a bunch of dead code.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1567333003 .
2016-01-08Fix infinite loop caused by parsing same indirect objectsWei Li
BUG=pdfium:343 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1569343002 .
2016-01-08IWYU fix after commit c5a8933.Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1570973002 .
2016-01-08Endless tidying in pageint.hTom Sepez
Remove unused enum. Don't begin struct names with underscore. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1570133004 .
2016-01-08Clean up misc nits found while fixing bugs.Lei Zhang
Some bits regressed in commit 338805f. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1544963002 .
2016-01-07Disentangle fpdfsave_embeddertest's FPDF_FILEWRITE, use gmock matchers.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1561303002 .
2016-01-07Make m_pStockMap a real map.Tom Sepez
Remove unused m_pContrastRamps. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1564783003 .
2016-01-07Cleanup includes, comments, and unused codeWei Li
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1563673002 .
2016-01-07Fix a GetFileContents() call that should have been in commit aa326bd6.chromium/2619chromium/2618chromium/2617chromium/2616Lei Zhang
TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1568763003 .
2016-01-06Return const-ref object in a few CPWL_Wnd getters.Lei Zhang
Also remove a bunch of dead code. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1565803003 .
2016-01-06Invalidate IPWL_FocusHandler and IPWL_Provider on destruction.Lei Zhang
BUG=572871 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1564773003 .
2016-01-06Return unique_ptrs from test_support functionsTom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1563513002 .
2016-01-06Add fpdf_edit basic creation embedder test.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1554133003 .
2016-01-06Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref.Lei Zhang
Change the internal version to GetNextWordInternal(). R=weili@chromium.org Review URL: https://codereview.chromium.org/1558083002 .
2016-01-05Revert "Mark pdfium chromium_code."Nico Weber
This reverts most of https://codereview.chromium.org/1557923004/ Doesn't build on the chromeos bots yet. BUG=pdfium:29 TBR=thestig Review URL: https://codereview.chromium.org/1561013002 .
2016-01-05Mark pdfium chromium_code.Nico Weber
Now that Chromium's build/common.gypi no longer does weird things with -Wsign-compare, this should work. BUG=pdfium:29 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1557923004 .
2016-01-05Document::DoAnnotDelay and m_DelayAnnotData member unused.Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1565613002 .
2016-01-05Replace CPDF_SortObjNumArray with a std::set.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1566553002 .
2016-01-05Remove header files that only have includes.Lei Zhang
Also do some cleanups in affected files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1552583002 .
2016-01-05Fix a few uses of default arguments.Lei Zhang
R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1555293002 .
2016-01-05Replace IconTree class with std::list.Tom Sepez
Remove some O(n^2) behaviour when iterating across the thing. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1566433003 .
2016-01-05Fix an infinite loop in CPDF_Parser::RebuildCrossRef().Lei Zhang
BUG=pdfium:325 R=weili@chromium.org Review URL: https://codereview.chromium.org/1543043003 .
2016-01-05Make more CPDF_Parser method const.Lei Zhang
R=weili@chromium.org Review URL: https://codereview.chromium.org/1549103002 .
2016-01-05Add embedder test for fpdfsave.cpp and bug 342Tom Sepez
R=thestig@chromium.org Review URL: https://codereview.chromium.org/1556033002 .
generated by cgit v1.2.3 (git 2.25.1) at 2024-06-02 19:59:02 +0000