| Age | Commit message (Collapse) | Author |
|---|
|
BUG=none
TEST=none
R=jam@chromium.org
Review URL: https://codereview.chromium.org/605273004
|
|
The function is looking ahead N characters at both its "format" and "value"
strings without validating that accesses are in bounds. Add those validations.
There are also duplicate checks in the else-branches which re-test the inverse
of the if-branch. These are removed for simplicity.
I also tidied some stray whitespace in the function while I was at it.
BUG=393831
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/395303004
|
|
It remains to call the PumpMessageLoop() method at a regular interval,
however, since nothing posts to the loop yet, that shouldn't be a
problem.
BUG=25
R=jam@chromium.org
Review URL: https://codereview.chromium.org/374123002
|
|
BUG=387822
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/367383002
|
|
This patch adds the 'b' (binary mode) flag to the fopen calls.
Before the fix the PPM images written with --write_images were corrupted
under Windows because on this platform in text mode all occurrences of
the byte 0xa (line feed) are replaced with the bytes 0x0d (carriage
return) and 0x0a (line feed).
On UNIX platforms the 'b' flag is supported but ignored, because no
translation of the line feed character takes place.
BUG=18
R=jam@chromium.org
Original patch by Michael Doppler <m.doppler@gmail.com>
Review URL: https://codereview.chromium.org/343303004
|
|
MSVC lexes L#macro_arg as a single wide string literal token, but
Clang and other C/C++ compliant lexers do not. There was already
a workaround to use implicit string concatenation for GCC, but there's
a simpler solution of token pasting the L onto the stringized macro
argument with 'L###macro_arg'. This works with Clang, GCC, and MSVC.
R=jun_fang@foxitsoftware.com, jam@chromium.org
BUG=82385
Original patch by Reid Kleckner <rnk@chromium.org>
Review URL: https://codereview.chromium.org/345643002
|
|
BUG=381031
Original patch by Chris Palmer <palmer@chromium.org>
Review URL: https://codereview.chromium.org/322453002
|
|
The GYP target is now called "pdfium" rather than "fpdfsdk".
Original pach by Brett Wilson <brettw@chromium.org>
|
|
https://code.google.com/p/pdfium/issues/detail?id=9
https://code.google.com/p/pdfium/issues/detail?id=10
BUG=
R=bo_xu@foxitsoftware.com
Review URL: https://codereview.chromium.org/312273002
|
|
CID=115579
Original patch by Finnur Thorarinsson <finnur@chromium.org>
|
|
|
|
Original patch by Andrey Khalyavin <halyavin@chromium.org>
|
|
Original patch by Lucas Nihlen <luken@chromium.org>
|
|
automatically converted to the native platform's format on checkout but
are committed as "LF".
BUG=375516
Original patch from Julien Tinnes <jln@chromium.org>
|
|
|
|
|
|
|
|
|
|
|
