Age | Commit message (Collapse) | Author |
|
This CL moves the two files and breaks fpdf_text.h apart into individual pieces.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1801973002 .
|
|
This CL moves the xfa/src files up to the xfa/ directory and fixes the includes,
include guards, and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1803723002 .
|
|
This CL moves the files in fpdfsdk/src/ up one level to fpdfsdk/ and fixes
up the include paths, include guards and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1799773002 .
|
|
This CL moves the core/src/ files up to core/ and fixes up the include guards,
includes and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1800523005 .
|
|
TBR=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1784243007 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1776913007 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1778173002 .
|
|
CPDF_CryptoHandler was always a pure-virtual class, now it
is named as IPDF_ to indicate this.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1782673002 .
|
|
This CL renames xfa/src/fdp to xfa/src/fde to better match all of the content
(nothing mentions fdp other then the directory name). The inner src/ and
include/ folders are collapsed up a level and xfa/src/fdp/src/fde is moved
up to xfa/src/fde.
Some of the header moves conflicted with existing headers. In that case, the
existing header had the content moved into the .cpp file and we replaced the
existing header with the one from include/.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1784543002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1781593003 .
|
|
This CL moves the code from xfa/src/fgas/src up one level. It then takes the
headers in xfa/src/fgas/include and moves them to their correct folder. The
src/ and include/ directories are then removed.
In some cases, when moving from include/ there was another header with the
same name. Those headers were either folded together, or the content of the
conflicting folder moved to an anonymous namespace in the cpp file as they were
not used anywhere else.
Files with duplicate names as core/src/crt were renamed to be fgas_ instead of
fx_. (e.g. fgas_system.h, fgas_memory.h, fgas_stream.h)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1776303002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1773103003 .
|
|
This CL moves xfa/src/fee/src/fee up to xfa/src/fee and moves the
xfa/src/fee/include files up to xfa/src/fee.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1778633003 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1780503002 .
|
|
This reverts commit 06fae28d307fe051f0c7e890344cd487c2260910.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1775023003 .
|
|
This reverts commit d50095fb151688e119a7097aabce11e4b3d36244.
Reason for revert: build broken.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1774293002 .
|
|
BUG=
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1774753002 .
|
|
This reverts commit 594912241cd7d409b5f58a48ccffdc1904d844b2.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1769273002 .
|
|
This Cl moves the xfa/src/fxgraphics/src code up to the, previously empty,
xfa/src/fxgraphics directory and removes xfa/src/fxgraphics/src.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1775733004 .
|
|
This CL removes the xfa/src/fxjse/src and moves all of the .h and .cpp files
up to the, previously empty, xfa/src/fxjse directory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1776643002 .
|
|
This Cl moves the code in xfa/src/fxfa/src/common to the diretory which
contains the respective implementations and removes the xfa/src/fxfa/src/common
directory. It them moves all of the code in xfa/src/fxfa/src up one level and
removes the xfa/src/fxfa/src
directory.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770073003 .
|
|
This Cl moves the xfa/src/fwl/src code up to the previously empty parent
directory and removes xfa/src/fwl/src.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770953004 .
|
|
The agg driver files are split into src/ and include/ directories. This CL
moves the source files up one level and removes the src/ and include/
directories.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1773593007 .
|
|
This CL collapses the xfa/src/fwl/src/core/include and
xfa/src/fwl/src/basewidget/include up one level.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1770273002 .
|
|
warning C4201: nonstandard extension used : nameless struct/union
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1767263002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1761233002 .
|
|
This only directs paths to use Skia. Text and bitmaps
still use antigrain.
Clipping is disabled -- still figuring out pdfium's model
for saving and restoring clips.
Deleting the Skia canvas is disabled -- there's some build problem
where the pdfium and skia libraries are built with slightly
different options that I haven't tracked down. This is also why
for the moment SkDebugf is defined locally.
With this patch and pdf_use_skia=1 a modestly complicated PDF draws
(mostly) correctly with pdfium_test.
R=dsinclair@chromium.org, tsepez@chromium.org, dsinclair
BUG=
Review URL: https://codereview.chromium.org/1761453002 .
|
|
Currently, there is a check that an object number is <= 0x1000000. If that
check fails, we end up putting the parser into a bad state and fail to load
documents. The object does not need to be in the XRef table, or referenced
from the document, just be in the document.
This Cl removes the size check and updates the various atoi calls to use a
uint32_t instead of an int32_t so we don't end up getting strange values when
converting from a string.
BUG=455199
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1755273002 .
|
|
Part of the work required to ship XFA with chrome.
BUG=pdfium:396
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1763493002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1748803002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1745023003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1746053003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1749703002 .
|
|
This does not appear to ever be defined. There are a few methods which end up
being empty after this change, removed those and their callers as well.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1736133002 .
|
|
The fde_memory.h include wasn't needed. This CL converts the
FDE_NewWith and FDE_DeleteWith calls to their FXTARGET_
counterparts.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736053002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740863002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735353002 .
|
|
And other nearby dead code.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1740613002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735833003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730893003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733693002 .
|
|
Renaming these files will allow them to be picked up by git cl format and the
linter.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733653002 .
|
|
They're technically not allowed because they are reserved
for the preprocessor.
Also get rid of LPC* typedefs along the way.
Also provide a header for a data file containing many
instance of these found along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1722873002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1721983002 .
|
|
Change implicit conversion to accessor function, remove unused function
and unused parameter, add a couple checks for null pointers, and some
cleanup.
BUG=pdfium:247
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1703183002 .
|
|
Remove unused member functions and simplify calls to find tag parameters.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1681403007 .
|
|
- NormalizeString() has 1 caller:
- CTextBaseLine::WriteOutput(), which has only 1 caller:
- CTextPage::WriteOutput(), which has only 1 caller:
- PDF_GetPageText_Unicode(), which has only 1 caller:
- PDF_GetPageText(), which has no callers.
Removing this also makes CheckRotate(), NormalizeCompositeChar(),
and CTextPage unused.
Removing those makes CTextBaseline() unused.
Removing that makes txtproc.h unused.
PDF_GetTextStream_Unicode also unused.
... and so on until entire files can be removed.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1689843002 .
|
|
The routines that would return them always return NULL. Some
path, however, didn't previously check for NULL. Those must
have been bugs; treat such cases as unreachable.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1679103002 .
|
|
Also, use full path to include "text_int.h", as there are
two of them; I suspect that fpdf_text_search was including
the wrong one as the compiler didn't complain about a
signature mismatch I had overlooked.
In fact, rename the fxge file to avoid collision completely.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1679743003 .
|
|
Original Review URL: https://codereview.chromium.org/1652533002 .
(cherry picked from commit 1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1652543003 .
|