Age | Commit message (Collapse) | Author |
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1749703002 .
|
|
This does not appear to ever be defined. There are a few methods which end up
being empty after this change, removed those and their callers as well.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1736133002 .
|
|
The fde_memory.h include wasn't needed. This CL converts the
FDE_NewWith and FDE_DeleteWith calls to their FXTARGET_
counterparts.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736053002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740863002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735353002 .
|
|
And other nearby dead code.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1740613002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1735833003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1730893003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733693002 .
|
|
Renaming these files will allow them to be picked up by git cl format and the
linter.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733653002 .
|
|
They're technically not allowed because they are reserved
for the preprocessor.
Also get rid of LPC* typedefs along the way.
Also provide a header for a data file containing many
instance of these found along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1722873002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1721983002 .
|
|
Change implicit conversion to accessor function, remove unused function
and unused parameter, add a couple checks for null pointers, and some
cleanup.
BUG=pdfium:247
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1703183002 .
|
|
Remove unused member functions and simplify calls to find tag parameters.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1681403007 .
|
|
- NormalizeString() has 1 caller:
- CTextBaseLine::WriteOutput(), which has only 1 caller:
- CTextPage::WriteOutput(), which has only 1 caller:
- PDF_GetPageText_Unicode(), which has only 1 caller:
- PDF_GetPageText(), which has no callers.
Removing this also makes CheckRotate(), NormalizeCompositeChar(),
and CTextPage unused.
Removing those makes CTextBaseline() unused.
Removing that makes txtproc.h unused.
PDF_GetTextStream_Unicode also unused.
... and so on until entire files can be removed.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1689843002 .
|
|
The routines that would return them always return NULL. Some
path, however, didn't previously check for NULL. Those must
have been bugs; treat such cases as unreachable.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1679103002 .
|
|
Also, use full path to include "text_int.h", as there are
two of them; I suspect that fpdf_text_search was including
the wrong one as the compiler didn't complain about a
signature mismatch I had overlooked.
In fact, rename the fxge file to avoid collision completely.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1679743003 .
|
|
Original Review URL: https://codereview.chromium.org/1652533002 .
(cherry picked from commit 1bce5f62f3292a6baf35491bf4c9b4fde2fb73e3)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1652543003 .
|
|
This is a regression from commit 90853cb.
BUG=pdfium:365
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1617043004 .
(cherry picked from commit 7671d304ca4d3aec658c0ac8d5eea4c64e23b144)
Review URL: https://codereview.chromium.org/1628643002 .
|
|
Original Review URL: https://codereview.chromium.org/1580573002 .
(cherry picked from commit a505d9d3e13485e090e50d5d83f882fb707d3f48)
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1610163003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1581823002 .
|
|
Also remove useless files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570743002 .
|
|
Original Review URL: https://codereview.chromium.org/1554133003 .
(cherry picked from commit d368261cc8d604286e29ca6358700e6bb051dcaa)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1567643002 .
|
|
Also do some cleanups in affected files.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1552583002 .
(cherry picked from commit d794d34b5deb6ad691c19af758090f9ce46015a3)
Review URL: https://codereview.chromium.org/1566583002 .
|
|
Original Review URL: https://codereview.chromium.org/1556033002 .
(cherry picked from commit 603533fb0e5968923d67c1d8f2e00a640f41b5e5)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1563483003 .
|
|
Original Review URL: https://codereview.chromium.org/1557173002 .
(cherry picked from commit 14fdb1d40741912e430db4318a9033764429659f)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1556983003 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
BUG=515137,564736
TBR=ochang@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1533233002 .
Review URL: https://codereview.chromium.org/1544493003 .
(cherry picked from commit b426e3edde040089b70d1a223c83b90957aa571d)
(cherry picked from commit bd35d484a4027775f19ff93e9143e0b270133d42)
Review URL: https://codereview.chromium.org/1546443002 .
|
|
An email address contains user name part and host name part.
User name allows dash or underscore, but not leading/ending/double
period. Host name doesn't allow leading/ending/double
period either.
BUG=489107
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1530763005 .
(cherry picked from commit cc70b7b55c9edcd0ff038f59080699060fbbede1)
Review URL: https://codereview.chromium.org/1532303002 .
|
|
BUG=pdfium:299
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520443002 .
(cherry picked from commit 94edf0c37d1ee6a03697375b9e227071ff2ee69d)
Review URL: https://codereview.chromium.org/1517653003 .
|
|
The no nominmax config was lost when moving from master.
Fix a few other small differences along the way, and fully
conditionalize the build of tiff.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1514633002 .
|
|
Hide the existence of the xfa libraries from GN when the feature
is not enabled. GN may try to build them otherwise when trying to
build "everything" even though nothing depends on them.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508243002 .
|
|
This allows standalone pdfium builds to build with XFA, but
makes a chromium checkout revert to non-xfa even on this
branch. GN implies a chromium checkout at the moment, so
disable XFA there, too.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508003003 .
|
|
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1449873003 .
(cherry picked from commit 3f148915d12f54a946a0c0bf526162b79c39d650)
Review URL: https://codereview.chromium.org/1452673002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1438253004 .
(cherry picked from commit 8bfd2fbe8a95f0b7a43f1bd29e70f61bd73e499c)
Review URL: https://codereview.chromium.org/1441963002 .
|
|
Accidentally reverted this while rebasing another CL.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1441473004 .
(cherry picked from commit 4274ea205ca2219f6a4cfc54025284c1aa3b14b8)
Review URL: https://codereview.chromium.org/1438173003 .
|
|
CPDF_DIBSource::DownSampleScanline32Bit
Previously, if |m_bpc| was < 8 (e.g. 4), this function may still try to
access the source components as if |m_bpc| == 8. Even when it fell into
the codepath that tried to do the right thing in this case, it was
wrong.
BUG=554151
TBR=tsepez@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/9b99615806e358fdb396d1cb162ee2e69c2a20ec
Review URL: https://codereview.chromium.org/1433423002 .
(cherry picked from commit e21fe98d5b5da7da01503b985b07b90c8e811689)
Review URL: https://codereview.chromium.org/1441563002 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1419763005 .
(cherry picked from commit 211cab5b58151f09fbeafe2b18da77b63664c39d)
Review URL: https://codereview.chromium.org/1407413016 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437603002 .
(cherry picked from commit 21e079dd982f57daa9d5af0d9e48d58189ce35da)
Review URL: https://codereview.chromium.org/1421303006 .
|
|
BUG=446715
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1353093003 .
Conflicts:
core/include/fpdfapi/fpdf_parser.h
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
samples/pdfium_test.cc
testing/embedder_test.cpp
testing/embedder_test.h
Review URL: https://codereview.chromium.org/1412083010 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1420693004 .
(cherry picked from commit 37e4a11e58257b757bec2700bc53facc59d0b845)
Review URL: https://codereview.chromium.org/1423583005 .
|
|
so tests can be run from any directory.
Previously the tests which read test files assume the current directory is under pdfium. Running from any other directory will break the build.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1408003014 .
(cherry picked from commit c0e93a9a942fe7d99800502a61d2fbb58cf9276f)
Conflicts:
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
fpdfsdk/src/fpdfdoc_embeddertest.cpp
testing/embedder_test.cpp
testing/embedder_test.h
Review URL: https://codereview.chromium.org/1411403012 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
- And fix XFA's lack of #includes.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
(cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c)
Review URL: https://codereview.chromium.org/1434543003 .
|
|
BUG=pdfium:29
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1411583005 .
Review URL: https://codereview.chromium.org/1431563002 .
Review URL: https://codereview.chromium.org/1419943006 .
Review URL: https://codereview.chromium.org/1415483003 .
Review URL: https://codereview.chromium.org/1414073005 .
Review URL: https://codereview.chromium.org/1415883010 .
(cherry picked from commit 9f4def68601ec75b85b92077c521b9423b4f7f00)
(cherry picked from commit 23e20f2d3ce5b416e1c7f7f1c2d68c90ddf2d4ad)
(cherry picked from commit a6e2a4eca1be4daf14fae4e2427a6ca76269db43)
(cherry picked from commit bfba4cb7f22fc19a5e71559f09f2cde19fbb6a79)
(cherry picked from commit 81edc51ef8242205c5a1192bc33bf16d8c96120b)
(cherry picked from commit 1630dffdc1d554d8f2319e83cdbd7b12f480362d)
Review URL: https://codereview.chromium.org/1421963005 .
|
|
Also adds a README.pdfium and 0000-include.patch that
details the local modifications made.
Also rolls testing/corpus to 45f88c6914fcac26ad930bb0ebbfa468c21db0a5
which includes regenerated corpus expectations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1413673003 .
(cherry picked from commit 87ee069d05ca06f60d6cfacd9e426739d8f2053d)
Review URL: https://codereview.chromium.org/1416993005 .
|
|
Also cleans up some places in the relevant functions since we're here.
BUG=551460
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1421783004 .
Clean merge.
(cherry picked from commit 4f85605cbc652a17bc833f883186e0a68af6006d)
Review URL: https://codereview.chromium.org/1405383009 .
|
|
This CL adds tests for the ReadHexString method of the syntax parser.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1433503002 .
(cherry picked from commit 71ad9a0028a183605fba734c48b4756d6caa7754)
Review URL: https://codereview.chromium.org/1424923007 .
|
|
This CL adds a unit test for the ReadHexString method.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1408213008 .
(cherry picked from commit c89c6195373b63e99b9cd432c5a181bfb3ad8dbe)
Review URL: https://codereview.chromium.org/1417713003 .
|
|
This CL adds tests for the CMap_GetCode and CMap_GetCodeRange methods. To do
so, it moves the methods to be static private members of CPDF_CMapParser and
makes the test class a friend.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1414013005 .
(cherry picked from commit afca65ac019d2ad4cb8ac8f585809cc1a519ac2b)
Review URL: https://codereview.chromium.org/1429943002 .
|
|
I moved the declaration to be public, instead of having it implicit in one
file and defined in a seperate cpp file.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410873009 .
(cherry picked from commit e948a4ee08b78e27da37bc12244fa1b66d927dc7)
Review URL: https://codereview.chromium.org/1432513002 .
|