Age | Commit message (Collapse) | Author |
|
Also adds support for ASan and sanitizer coverage.
BUG=pdfium:1,pdfium:171
R=thakis@chromium.org, thestig@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/5478df43a8970257e9644ae6f57a6fe7513029c6
Review URL: https://codereview.chromium.org/1406843002 .
|
|
This will break existing checkouts based on the instructions provided.
Instead of having a single pdfium directory, checkouts will now compromise of:
("repo" can be named anything)
repo/.gclient
repo/pdfium/.git
repo/pdfium/others...
To convert an existing checkout, do something like:
mkdir repo
mv pdfium repo
rm repo/pdfium/.gclient_entries # will be regenerated, with a warning
mv repo/pdfium/.gclient repo
edit repo/.gclient and change "name: '.'" to "name: 'pdfium'"
Instructions for getting a new checkout are in README.md in this CL.
R=thestig@chromium.org, tsepez@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/1406383003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1415953003 .
|
|
This reverts commit 5478df43a8970257e9644ae6f57a6fe7513029c6.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1413193002 .
|
|
Also adds support for ASan and sanitizer coverage.
BUG=pdfium:1,pdfium:171
R=thakis@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1406843002 .
|
|
Adds the following new violations:
ERROR in core/include/fpdfapi/fpdf_parser.h
Illegal include: "public/fpdfview.h"
ERROR in core/include/fpdfapi/fpdf_render.h
Illegal include: "public/fpdf_progressive.h"
ERROR in core/src/fpdfapi/fpdf_parser/fpdf_parser_decode_embeddertest.cpp
Illegal include: "public/fpdfview.h"
BUG=pdfium:217
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411493002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1407643002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1391733002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1380663003 .
|
|
Also changes DEPS to specify a specific v8 version, this will
require us to manually update this version from time to time,
but also solves a longstanding problem where going back to an
older version (say for bisecting) wouldn't always work.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1372963003 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1297453002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1266833003 .
|
|
But use platform freetype for library itself according to the rules
for the platform.
This should greatly reduce per-platform diffs in the corpus tests, but
requires that the corpus be rolled at the same time.
When this rolls into chromium, its src/BUILD.gn will need to be updated
to say third_party:fx_freetype instead of third_party:freetype.
R=jam@chromium.org
Review URL: https://codereview.chromium.org/1267493005 .
|
|
Allows the following command to return only legitimate
warnings:
buildtools/checkdeps/checkdeps.py --resolve-dotdot
The remaining warnings consist of:
- fx_parser_filters.cpp, due to inclusion of
third_party/zlib_v128/zlib.h, showing the lack
of a header and some prototypes in that .cpp file.
- third_party/*, due to inclusion of fx_system.h and
the like, indicating adulterated libraries that should
be restored to their pristine state.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1233583004 .
|
|
Makes the behaviour consistent with chromium.
Also fix some indentation.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1193563002.
|
|
If the font is 'tricky', it needs to be hinted by default according to the description in freetype.
BUG=490814
R=tsepez@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/7a2fcd8d1256c267380b40f2d2d8e98c3b181cee
Review URL: https://codereview.chromium.org/1170313003.
|
|
This will pull in the checkdeps utility for standalone builds.
Write some include rules, too.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1149623011
|
|
This will undoubtedly RED the tree due to differences in platforms
and environments. A subsequent CL will add suppressions to get back
to GREEN.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1153393004
|
|
This allows PDFium to work with current V8, so unpin v8 in the
pdfium DEPS file.
(I also re-ordered one field in CJS_Runtime, just to put two bools
together (may pack tighter), and to put all the v8 stuff together).
BUG=pdfium:146
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1118043002
|
|
This will undoubtedly red up the tree, as we don't have trybots. A follow-up
CL will add the suppressions required for each platform at the moment.
The new suppressions in this CL are for cases where we didn't generate an
expected result file (due to the issue in fx/FRC_3.5_part1/Introduction.txt).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1111213005
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1108913004
|
|
This regressed in commit 3f41851 due to shadow variables.
BUG=478164
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1101443004
|
|
Also update build files to deal with the new revision. The main issue
is the external startup files for v8. The default is not to use them
(simpler for standalone users to deploy), but can be built either way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1059023003
|
|
Rolls DEPS to pull in the first windows-specific .png files, and
unsupresses the corresponding tests.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1072613003
|
|
Review URL: https://codereview.chromium.org/1050693002
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1023383003
|
|
Failures from last roll need diagnosis.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1023913002
|
|
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1020093002
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1021003002
|
|
There are two reasons for doing this. The first is that adding files
to this repository doesn't trigger a rebuild on the bot, so the next
unrelated pdfium change will be the one to hit any issues with the
unversioned corpus.
The second is that we may need a specific version of the expected output
files (.pngs) to go with a specific pdfium build.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1019783003
|
|
Add a run_corpus_tests.py script to run pdfium_test against
the corpus tree.
Note that this differs from the run_pixel_tests.py script,
since pre-processing is not required. I'll work on unifying
these in a subsequent CL.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1010833003
|
|
For chromium checkouts, the top-level gmock is used instead.
Verify build with a simple test that ensures neither mock
method is fired.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/955513009
|
|
In order for the standalone pdfium build to succeed,
DEPS is updated to pull in gtest, and a stub gtest.gyp
file is provided (which is unused under a chromium
checkout).
R=brucedawson@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/835233002
|
|
Context: DEPS was originally added to pdfium to allow its recipe to
automatically check out its dependencies. The recipe used absolute
paths, and so the checkout directory's name ('pdfium') had to be
prefixed to the directory checkout of every dependency, as gclient in
the recipe worked one level above the pdfium checkout itself.
After change fe4537269fc7133320a5131638757f2ffa6bd854, the recipe no
longer worked. To fix this, I'm making DEPS use relative paths.
BUG=375773
R=jam@chromium.org
Review URL: https://codereview.chromium.org/724113003
|
|
This makes gclient config and gclient sync work.
BUG=423896
TBR=aneeshm@chromium.org
Review URL: https://codereview.chromium.org/656353002
|
|
Added a DEPS file so that bot_update and gclient can automatically check
out dependencies (GYP, V8, ICU, and on Windows, Cygwin).
BUG=375773
R=jam@chromium.org, nodir@chromium.org
Review URL: https://codereview.chromium.org/416663002
|