Age | Commit message (Collapse) | Author |
|
Review-Url: https://codereview.chromium.org/1922773002
|
|
Also roll:
buildtools to adb8bf4e.
skia to 3ee255f2.
v8 to 3d96d7ee.
And make tweaks to get it all working.
Review-Url: https://codereview.chromium.org/2283883002
|
|
Move trace_events DEPS from v8/base/ to base/
Review-Url: https://codereview.chromium.org/2292553003
|
|
Each annotation has its contents, and users should be able to see the
contents. In this patch, PDFium creates a Popup annotation for each
annotation and stores the author and the content. When a user mouse
hover on the annotation, PDFium draws the corresponding Popup annotation
and displays the content.
Also, roll DEPS for testing/corpus to 5867fa6.
BUG=62625
Review-Url: https://codereview.chromium.org/2273893002
|
|
BUG=pdfium:559
Review-Url: https://codereview.chromium.org/2286653002
|
|
TBR=caryclark@google.com
Review-Url: https://codereview.chromium.org/2287443002
|
|
TBR=jshin@chromium.org
Review-Url: https://codereview.chromium.org/2283723002
|
|
TBR=thakis@chromium.org
Review-Url: https://codereview.chromium.org/2282693002
|
|
This patch generates a default AP stream for text annotation. The AP stream
only draws a symbol, which represents the presence of text annotation at the
point.
Also, roll DEPS for testing/corpus to afbac94 to test text annotations.
BUG=62625
Review-Url: https://codereview.chromium.org/2270493002
|
|
Now that PDFium supports drawing of more annotation
types, it should also respect the "hidden" flag that
annotations might feature.
For instance, in IE/Acroread if an annotation is flagged as
"hidden" it does not get drawn.
CL adds a check for the specific "hidden" flag, not drawing
annotation that are flagged with it, in order to match IE + acrobat
reader behavior.
The "flags" definition can be seen by looking at "/F {value}"
syntax in a PDF file source, where {value} is an predefined
integer value.
Test: PDF files being added in [1].
[1] https://codereview.chromium.org/2239713003/
BUG=62625
Review-Url: https://codereview.chromium.org/2239853002
|
|
Update the Skia DEPS revision
to a version that can handle
PDFium's use of SkComposeShader.
R=dsinclair@chromium.org
Review-Url: https://codereview.chromium.org/2249103002
|
|
This patch generates a default AP stream for ink annotation so that ink
annotations without AP stream can be displayed.
Also, roll DEPS for testing/corpus to 4119f8e to test ink annotations.
BUG=62625
Review-Url: https://codereview.chromium.org/2232553002
|
|
This patch generates a default AP stream for circle annotation so that
circle annotations without AP stream can be displayed.
Also, roll DEPS for testing/corpus to 71d1f22 to test circle annotations.
BUG=62625
Review-Url: https://codereview.chromium.org/2228093002
|
|
This patch generates a default AP stream for square annotation so that square
annotations without AP stream can be displayed.
Also, roll DEPS for testing/corpus to 7f07c22 to test square annotations.
BUG=62625
Review-Url: https://codereview.chromium.org/2219683002
|
|
This patch generates a default AP stream for squiggly annotation so that
squiggly annotations without AP stream can be displayed.
Also, roll DEPS for testing/corpus to a89e4fb to test squiggly annotations.
BUG=62625
Review-Url: https://codereview.chromium.org/2206773004
|
|
Review-Url: https://codereview.chromium.org/2210563002
|
|
This patch generates a default AP stream for strike out annotation so that
strike out annotations without AP stream can be displayed.
Also, roll DEPS for testing/corpus to ddc1938 to test strike out annotations.
BUG=62625
Review-Url: https://codereview.chromium.org/2206083002
|
|
This patch generates a default AP stream for underline annotation so that
underline annotations without AP stream can be displayed.
Also, roll DEPS for testing/corpus to cae29d1 to test underline annotations.
BUG=62625
Review-Url: https://codereview.chromium.org/2205543002
|
|
BUG=62625
Review-Url: https://codereview.chromium.org/2202063002
|
|
This patch generates a default AP stream for highlight annotation so that
highlight annotations without AP stream can be displayed.
BUG=62625
Review-Url: https://codereview.chromium.org/2193983002
|
|
This permits PDFium to build on the Mac with Skia as the backend. It builds on Linux and Windows as well.
R=dsinclair@chromium.org,bungeman@google.com
Review-Url: https://codereview.chromium.org/1995003002
|
|
Review-Url: https://codereview.chromium.org/2140403002
|
|
BUG=pdfium:38
Review-Url: https://codereview.chromium.org/2137703002
|
|
BUG=chromium:625823
R=haraken@chromium.org,thestig@chromium.org
Review-Url: https://codereview.chromium.org/2128793002
|
|
Also roll DEPS for ICU to ffa4b670 and add a needed GYP variable.
BUG=
R=thestig@chromium.org
Review-Url: https://codereview.chromium.org/2127553004
|
|
Roll DEPS for buildtools to db6179b2.
Roll DEPS for catapult to 327256cb.
Roll DEPS for gyp to c61b0b35.
TBR=dsinclair@chromium.org
NOTREECHECKS=true
Review-Url: https://codereview.chromium.org/2114223002
|
|
TBR=dsinclair@chromium.org
Review-Url: https://codereview.chromium.org/2114173003
|
|
TBR=thakis@chromium.org
Review-Url: https://codereview.chromium.org/2122433002
|
|
This pulls in the android NDK and catapult, rolls chromium/src/build/,
and pulls in two .gni updates. It also fixes a few miscellaneous compile
failures in android-specific code.
BUG=pdfium:38
Review-Url: https://codereview.chromium.org/2059553002
|
|
R=machenbach@chromium.org,thestig@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2053603002
|
|
Update Skia to the last revision that passed the Chrome DEPS roll.
This will help green the Skia tree so that future changes to Skia
that break PDFium can be detected.
R=rmistry@google.com,dsinclair@chromium.org
Review-Url: https://codereview.chromium.org/2042403004
|
|
Need the tools/memory directory in order for asan to find the blacklist during
compilation.
Review-Url: https://codereview.chromium.org/2028603003
|
|
R=thestig@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2019383002
|
|
data_binding.pdf is much closer now that events are sent.
It still diffs due to some bg color issues, not that the
box is unchecked.
Review-Url: https://codereview.chromium.org/1952823002
|
|
This Cl makes GN execute correctly for builds with pdf_use_skia=true enabled.
BUG=pdfium:487
Review-Url: https://codereview.chromium.org/1932683003
|
|
GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.
Compared to our own copies, utilities in build directory
are either same or newer.
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py have some minor updates.
Review-Url: https://codereview.chromium.org/1933843002
|
|
compilation (patchset #1 id:1 of https://codereview.chromium.org/1922373003/ )
Reason for revert:
I fixed Clang build config, and updated drm binary. Should work this time.
Original issue's description:
> Revert of Use visual studio toolchain from depot_tools for PDFium compilation (patchset #3 id:40001 of https://codereview.chromium.org/1897523002/ )
>
> Reason for revert:
> Clang build is broken. drm build has some problem. Will revert this change for now.
>
> Original issue's description:
> > Use visual studio toolchain from depot_tools for PDFium compilation
> >
> > Change to use visual studio toolchain from depot_tools by default.
> > Setting DEPOT_TOOLS_WIN_TOOLCHAIN=0 allows compilation using system
> > toolchain as before.
> >
> > Using toolchain from depot_tools unifies the compilation
> > environment, and brings the benefits of automated update, bug fixes
> > etc.
> >
> > Committed: https://pdfium.googlesource.com/pdfium/+/590f2d9e057a0d5b17a9706affd3c6115265021b
>
> TBR=brucedawson@chromium.org,thestig@chromium.org,tsepez@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://pdfium.googlesource.com/pdfium/+/df96690d4e3799536b981e3673d64018fa5fd037
TBR=brucedawson@chromium.org,thestig@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1927373002
|
|
compilation (patchset #3 id:40001 of https://codereview.chromium.org/1897523002/ )
Reason for revert:
Clang build is broken. drm build has some problem. Will revert this change for now.
Original issue's description:
> Use visual studio toolchain from depot_tools for PDFium compilation
>
> Change to use visual studio toolchain from depot_tools by default.
> Setting DEPOT_TOOLS_WIN_TOOLCHAIN=0 allows compilation using system
> toolchain as before.
>
> Using toolchain from depot_tools unifies the compilation
> environment, and brings the benefits of automated update, bug fixes
> etc.
>
> Committed: https://pdfium.googlesource.com/pdfium/+/590f2d9e057a0d5b17a9706affd3c6115265021b
TBR=brucedawson@chromium.org,thestig@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1922373003
|
|
Change to use visual studio toolchain from depot_tools by default.
Setting DEPOT_TOOLS_WIN_TOOLCHAIN=0 allows compilation using system
toolchain as before.
Using toolchain from depot_tools unifies the compilation
environment, and brings the benefits of automated update, bug fixes
etc.
Review-Url: https://codereview.chromium.org/1897523002
|
|
Chrome has enabled the -Wvarargs warning that was added to clang, this fails
with PDFium XFA builds due to two warnings:
../../xfa/fxfa/fm2js/xfa_lexer.cpp:539:16: error: passing an object that
undergoes default argument promotion to 'va_start' has undefined behavior
[-Werror,-Wvarargs]
va_start(ap, msg);
^
../../xfa/fxfa/fm2js/xfa_lexer.cpp:535:40: note: parameter of type
'XFA_FM_ERRMSG' is declared here
void CXFA_FMLexer::Error(XFA_FM_ERRMSG msg, ...) {
The issue is that XFA_FM_ERRMSG is an enum and we violate the promotion rules
for passing the value to va_start.
I removed the enum and named the flags explicitly then pass in the string as
the argument.
BUG=chromium:606726
Review URL: https://codereview.chromium.org/1921323002
|
|
Contents:
https://chromium.googlesource.com/v8/v8/+log/47bcec78..0ff89ea75
BUG=chromium:606547
Review URL: https://codereview.chromium.org/1920863003
|
|
Some unknown software generates cross reference table with the
claimed object numbers are all off by one. Add a simple verification
function to detect this scenario, thus have a chance to rebuild
the correct cross reference table.
To avoid unnecessary checks and potiential performance hit, we only
check for the very first non free entry.
BUG=602650
Review URL: https://codereview.chromium.org/1910063004
|
|
There are 4 types of meshes that attempt to convert the shading object into
a stream. According to spec (section 8.7.4.1 table 76), the shading object can
be a stream or a dictionary.
All of this shading code assumes it can load the mesh from a stream. The
original code just early exited if it was not a stream. We skip the call
if it is not a stream.
BUG=pdfium:481
Review URL: https://codereview.chromium.org/1908903003
|
|
The GN information got accidentally dup'd in the DEPS file.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1899193006
|
|
The issue with //testing/multiprocess_func_list has been fixed in upstream
//build. This Cl upgrades //build to ToT.
In order to do so clang must also be updated. The Wno-undefined-var-template
is only passed if the pinned clang revision isn't 266460, which is the
currently pinned clang revision in chromium. This is there so that the bot
that builds with trunk clang gets this flag, but pinned clang doesn't.
We accidentally pickup the flag since our pinned clang is different from the
Chrome version. So, we must always roll //build and clang together when
changing deps or bad things may happen as there is an implicit dependency
due to compile flags.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1911483002
|
|
This CL setups up a standalone GN build. You'll need to set gn args similar to:
use_goma = true
clang_use_chrome_plugins = false
pdf_enable_xfa = true
pdf_enable_v8 = true
pdf_is_standalone = true
The third_party/pymock files are needed to make git cl upload work correctly.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1904563002
|
|
This CL moves the build/ files to build_gyp/ in anticipation of pulling in
Chromiums build/ directory.
The gyp_pdfium files have been duplicated into both places. Once the bots
are updated we'll remove the build/ versions.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1900913003
|
|
Test still need modification to process input events. For now,
we just suppress anything that diffs.
Review URL: https://codereview.chromium.org/1894083003
|
|
Roll Clang revision to the same one as v8
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1900603004
|
|
Reason: a wrong patch got submitted.
This reverts commit 07af99b822588c5d6bab7cbf548c756346352184.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1895263002
|