Age | Commit message (Collapse) | Author |
|
Bug: chromium:738919
Change-Id: I2ea99a47f45e2e68650bd1fa9ad7554d8df79874
Reviewed-on: https://pdfium-review.googlesource.com/7351
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
|
|
This picks up the right test expectations for Oneof3.pdf.
BUG=pdfium:781
TBR=npm@chromium.org
Change-Id: Ic95fca31c98874b1d09226eff9ca7335a921fb65
Reviewed-on: https://pdfium-review.googlesource.com/7191
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
The new embedder test shows Oneof() works, whereas the corpus test does
not. It turns out the corpus test was bad, and trying to fix it exposed
a different bug. So roll DEPS for the testing corpus anyway to get
improved tests, but keep the suppression for now.
BUG=pdfium:781
Change-Id: I3cc6b9a414384c917f205eff064c5dd2175d09fe
Reviewed-on: https://pdfium-review.googlesource.com/6973
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
|
|
https://pdfium-review.googlesource.com/c/7033/ contains the changes
in the corpus tests expected pngs. They are imperceptible and due to
a difference in float rounding when writing the appearance stream.
Bug: pdfium:731
Change-Id: I815ca5b9ddd02382b74285a32bfde8bd3e8eeaae
Reviewed-on: https://pdfium-review.googlesource.com/7010
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: Ief7bd0f2d0f4edbcb7331b0e78c01b86a9dc0621
Reviewed-on: https://pdfium-review.googlesource.com/7031
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
This CL adds a presubmit check for png files so that they are in the form
_expected{,_mac,_win}.pdf.BLA.png and updates the corpus test repository hash.
Change-Id: I5397a091b77a339eba7d370b291b7a6e61754744
Reviewed-on: https://pdfium-review.googlesource.com/6951
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
|
|
Bug: pdfium:781
Change-Id: I51c5ed9e582376f11f75f7512f36c33720e71bac
Reviewed-on: https://pdfium-review.googlesource.com/6890
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
|
|
This CL uses the following algorithm for improving substitute font spacing (we
are assuming the text layout is horizontal):
* Calculate PDFWidth, the width that the PDF says the glyph should have.
* Calculate FTWidth, the width calculated by freetype for the glyph, using the
substitute font that we'll use to render it. Note that some embedded fonts have
PDFWidth == FTWidth + 1, so we consider that to be matching widths.
* If PDFWidth > FTWidth + 1 , move the x coordinate by the difference / 2 so
that the glyph is rendered in a more centered spot and the text looks better.
* If PDFWidth < FTWidth, transform the glyph horizontally by PDFWidth / FTWidth
so that the glyph gets compressed and does not overlap with surrounding glyphs.
Bug: chromium:431507
Change-Id: Ia378344253fabe44d93af4daab98bb3b7bca22de
Reviewed-on: https://pdfium-review.googlesource.com/6630
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
|
|
Just a routine roll.
TBR=jochen@chromium.org
Change-Id: Idecd349cf952b9fa381751eebde60a3bff3d103e
Reviewed-on: https://pdfium-review.googlesource.com/6234
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
The version of Skia we are using does not pass the new DEPS file
validation. This CL syncs to the latest Skia in order to fix the DEPS
issue.
TBR=tsepez@chromium.org
Bug: chromium:727394, chromium:570091
Change-Id: Id475ff5c98e1bc75ee76fdfc44df972ef1d53cc8
Reviewed-on: https://pdfium-review.googlesource.com/6076
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
Roll build/ to f671d3b and replace "//build/config/sanitizers:deps"
with "//build/config:exe_and_shlib_deps"
Bug=chromium:723069
R=thestig@chromium.org
Change-Id: Ib890f22a13769a594ce248637aeabc5ac3062ab2
Reviewed-on: https://pdfium-review.googlesource.com/5670
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Update ftoption.h with new (unused by us) setting:
AF_CONFIG_OPTION_TT_SIZE_METRICS
Change-Id: Ia8004e1ab1e72778319d23e7dfa8cbdcbebfdd34
Reviewed-on: https://pdfium-review.googlesource.com/5555
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
AKA roll clang 299960:300839.
TBR=thakis@chromium.org
Change-Id: Ifa8c30681897b62f182382eecd3bfdb77d7081ee
Reviewed-on: https://pdfium-review.googlesource.com/4993
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This follows Chromium's FreeType DEPS roll. Potentially addresses Clang
on Windows LLP64 build failure.
Roll testing corpus to 5379e0a with updated expectations.
BUG=pdfium:705
Change-Id: Ie494b68a52f953436accf8fd1961244f70a92cab
Reviewed-on: https://pdfium-review.googlesource.com/4632
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
BUG=pdfium:559,pdfium:695
Change-Id: I534d8b78ae39946e9b423f29ec3884794b3083fc
Reviewed-on: https://pdfium-review.googlesource.com/4256
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
TBR=dpranke@chromium.org
Change-Id: Id82a2f6de4caca2e946d88fe44a4bf55444fb46e
Reviewed-on: https://pdfium-review.googlesource.com/4255
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
AKA roll clang 298539:299960.
TBR=thakis@chromium.org
Change-Id: Ie5602589fe8924703e07ae0592c94c065647b0b7
Reviewed-on: https://pdfium-review.googlesource.com/4254
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Only fillable fields should show highlights. Push button should
not do that. Doing so results in lighter color or extra layer of
light color.
BUG=chromium:638626
Change-Id: I6b4d129e1f60bf44ff5a297d4b9db823d6be8079
Reviewed-on: https://pdfium-review.googlesource.com/3790
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
|
|
Check out libjpeg-turbo via DEPS.
Also checkout yasm via DEPS and copy some yasm build files from
Chromium.
BUG=chromium:541704,pdfium:389
Change-Id: Ic7af415f002a3ca2acd9223ed3474dedf3930b32
Reviewed-on: https://pdfium-review.googlesource.com/3470
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
v8_enable_inspector was removed recently. Clean up remnants.
BUG=645890
TEST=none
Change-Id: I501d33bfaa1bf0a03f83b9ed3b4b183301d38d63
Reviewed-on: https://pdfium-review.googlesource.com/3871
Reviewed-by: Nicolás Peña <npm@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
|
|
Pick up updated baselines for bug_511_jbig_null_crash.pdf, and updated
PRESUBMIT.py.
BUG=pdfium:511
TBR=tsepez@chromium.org
Change-Id: I881b218b02751f3a52e6f6ff44b59108aafdf282
Reviewed-on: https://pdfium-review.googlesource.com/3710
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
BUG=chromium:541704
Change-Id: I313d8853450ff5940b3baa4054ff441b342c46b7
Reviewed-on: https://pdfium-review.googlesource.com/3350
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
|
|
BUG=pdfium:688
Change-Id: I7787b29d0fedc48f1360ab041d43829d0e805462
Change-Id: I7787b29d0fedc48f1360ab041d43829d0e805462
Reviewed-on: https://pdfium-review.googlesource.com/3331
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Nicolás Peña <npm@chromium.org>
|
|
Roll DEPS for testing corpus to 2c5a026 to verify.
This regressed in commit c8017b2.
BUG=pdfium:692
Change-Id: Ic09ed53db8b3cc81abb2bdea863b8cf32f614197
Reviewed-on: https://pdfium-review.googlesource.com/3510
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
|
|
Pick up updated baselines for bug_434.pdf, and remove suppressions.
BUG=pdfium:434
TBR=tsepez@chromium.org
Change-Id: I4b1f75dfd40d88d968363d11854064517f58d2e7
Reviewed-on: https://pdfium-review.googlesource.com/3511
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Add user provided test case for colorspaces.
BUG=chromium:691967
TBR=dsinclair@chromium.org
Change-Id: I8131a591ab24ca7217fee09879e623fc21bb1667
Reviewed-on: https://pdfium-review.googlesource.com/3471
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This reverts commit b0baff546bdcd911c80007829d9af5f05d0c04b0.
Reason for revert: https://codereview.chromium.org/2775913002/ needs to be reverted, so reverting all dependent patch sets
Original change's description:
> Remove download_binaries.py from DEPS
>
> This step is no longer necessary after https://codereview.chromium.org/2775913002/
>
> Bug: 705072
> Change-Id: I3b293fabad8a6e6044098da1251a206417f3aed7
> Reviewed-on: https://pdfium-review.googlesource.com/3217
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Commit-Queue: dsinclair <dsinclair@chromium.org>
>
R=thestig@chromium.org
Change-Id: I0d30177fd848595f6ec997efd4515b02bb539925
Reviewed-on: https://pdfium-review.googlesource.com/3452
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
build_revision: a634e44
buildtools_revision: e6b510a
clang_revision: c55112f
TBR=thakis@chromium.org
Change-Id: I0b69740c2c744a7b4e2c7c7963e4fbdaf2cc0a82
Reviewed-on: https://pdfium-review.googlesource.com/3332
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
BUG=pdfium:601
Change-Id: I07756cd208cd2221802ff2d331f316b6618a41e0
Reviewed-on: https://pdfium-review.googlesource.com/3120
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
This step is no longer necessary after https://codereview.chromium.org/2775913002/
Bug: 705072
Change-Id: I3b293fabad8a6e6044098da1251a206417f3aed7
Reviewed-on: https://pdfium-review.googlesource.com/3217
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
Pull latest v8.
Change-Id: I6aa1a80d27c6cd0e748d256dbfd813112efa352c
Reviewed-on: https://pdfium-review.googlesource.com/3162
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
BUG=pdfium:559
Change-Id: Id0a01bcc2de597ce2b2e3d60dd5c737af75c93ab
Reviewed-on: https://pdfium-review.googlesource.com/2958
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Change-Id: I190d27e79d62b9cae21b08ddfc1e422bbb37ab30
Reviewed-on: https://pdfium-review.googlesource.com/2969
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
TBR=jochen@chromium.org
Change-Id: I6d5c5c6732a3f2fa2f99c4fd0178f6862a0435d0
Reviewed-on: https://pdfium-review.googlesource.com/3010
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
AKA roll clang 295762:296321.
Change-Id: I46be95f4bd50a205b880c62ce4a8e3a7d4508e68
Reviewed-on: https://pdfium-review.googlesource.com/2957
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
AKA roll clang 287685:295762.
Change-Id: Ie74172a1986908eeca2f913f7c4500cc51095e1b
Reviewed-on: https://pdfium-review.googlesource.com/2870
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
|
|
Unlanded attempt:
https://pdfium-review.googlesource.com/c/2410/
BUG=690088
Change-Id: I0bd3396426bd9faadb8c8dba2c2b7a7b9b52b178
Reviewed-on: https://pdfium-review.googlesource.com/2576
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Nicolás Peña <npm@chromium.org>
|
|
https://skia.googlesource.com/skia.git/+log/f44703a87f532..90e3cd78991
A file was split out to reduce dependencies, added to BUILD.gn.
Change-Id: If3675ddc3b06fcb3fe5cad1165d6fe6d4168a152
Reviewed-on: https://pdfium-review.googlesource.com/2590
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Cary Clark <caryclark@google.com>
Reviewed-by: Cary Clark <caryclark@google.com>
|
|
Change-Id: Ib319cad12707cf2a7211c64b0f950e5f0dd2b094
Reviewed-on: https://pdfium-review.googlesource.com/2493
Commit-Queue: Nicolás Peña <npm@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
When the results of the test runner were converted to return a tuple the
following code which checked the results for true/false were not updated
to extract the success value from the tuple. This caused the code to think
that the results always passed even when they failed.
This CL fixes the two tests which were broken (both just minor image result
differences) which slipped in during this breakage.
Change-Id: I01b56dd7b05013c2c12c83543746cf59b145e561
Reviewed-on: https://pdfium-review.googlesource.com/2456
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
The canvas clip op changed to a
enum class to safeguard against a
regular enum used as a bool in an
overloaded interface.
R=reed@google.com, dsinclair@chromium.org
Review-Url: https://codereview.chromium.org/2568193002
|
|
This Cl updates ICU to match what is in the Chromium DEPS file.
Review-Url: https://codereview.chromium.org/2568113002
|
|
Skia has changed its clipping API
from one enum to another.
Fix PDFium to match.
R=dsinclair@chromium.org,reed@google.com,herb@google.com
Review-Url: https://codereview.chromium.org/2559123004
|
|
Originally the key "T" was checked which was not correct since that
key is optional. Now change to check "FT" as well as its parent's
key since this key is also inheritable.
BUG=chromium:440132
Review-Url: https://codereview.chromium.org/2554223002
|
|
Review-Url: https://codereview.chromium.org/2528613003
|
|
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/327256cb1c38..86352b966b02
BUG=pdfium:415
Review-Url: https://codereview.chromium.org/2524093004
|
|
https://chromium.googlesource.com/chromium/src/build.git/+log/dc8cb2c8bcc3..acf607f7d345
R=thestig@chromium.org,dsinclair@chromium.org
BUG=pdfium:415
Review-Url: https://codereview.chromium.org/2527613003
|
|
Just a routine roll.
TBR=jochen@chromium.org
Review-Url: https://codereview.chromium.org/2518933003
|
|
This updates test expectations for IPA fonts.
TBR=npm@chromium.org
Review-Url: https://codereview.chromium.org/2519753002
|
|
This picks up many Mac expectation files, though not all Macs render
them the same way. This also adds a new "jetman_std" test case.
All the failures on Mac are suppressed.
BUG=pdfium:626
TBR=npm@chromium.org
NOTRY=true
Review-Url: https://codereview.chromium.org/2516133002
|