Age | Commit message (Collapse) | Author |
|
GYP and GN builds share some common utilities. GYP has three utilities
in its own directory which are also synced in build directory now.
We will use utilities from build directory instead of keeping our own
copies.
Compared to our own copies, utilities in build directory
are either same or newer.
find_depot_tools.py is identical;
vs_toolchain.py and find_sdk.py have some minor updates.
Review-Url: https://codereview.chromium.org/1933843002
|
|
compilation (patchset #1 id:1 of https://codereview.chromium.org/1922373003/ )
Reason for revert:
I fixed Clang build config, and updated drm binary. Should work this time.
Original issue's description:
> Revert of Use visual studio toolchain from depot_tools for PDFium compilation (patchset #3 id:40001 of https://codereview.chromium.org/1897523002/ )
>
> Reason for revert:
> Clang build is broken. drm build has some problem. Will revert this change for now.
>
> Original issue's description:
> > Use visual studio toolchain from depot_tools for PDFium compilation
> >
> > Change to use visual studio toolchain from depot_tools by default.
> > Setting DEPOT_TOOLS_WIN_TOOLCHAIN=0 allows compilation using system
> > toolchain as before.
> >
> > Using toolchain from depot_tools unifies the compilation
> > environment, and brings the benefits of automated update, bug fixes
> > etc.
> >
> > Committed: https://pdfium.googlesource.com/pdfium/+/590f2d9e057a0d5b17a9706affd3c6115265021b
>
> TBR=brucedawson@chromium.org,thestig@chromium.org,tsepez@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://pdfium.googlesource.com/pdfium/+/df96690d4e3799536b981e3673d64018fa5fd037
TBR=brucedawson@chromium.org,thestig@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1927373002
|
|
compilation (patchset #3 id:40001 of https://codereview.chromium.org/1897523002/ )
Reason for revert:
Clang build is broken. drm build has some problem. Will revert this change for now.
Original issue's description:
> Use visual studio toolchain from depot_tools for PDFium compilation
>
> Change to use visual studio toolchain from depot_tools by default.
> Setting DEPOT_TOOLS_WIN_TOOLCHAIN=0 allows compilation using system
> toolchain as before.
>
> Using toolchain from depot_tools unifies the compilation
> environment, and brings the benefits of automated update, bug fixes
> etc.
>
> Committed: https://pdfium.googlesource.com/pdfium/+/590f2d9e057a0d5b17a9706affd3c6115265021b
TBR=brucedawson@chromium.org,thestig@chromium.org,tsepez@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Review-Url: https://codereview.chromium.org/1922373003
|
|
Change to use visual studio toolchain from depot_tools by default.
Setting DEPOT_TOOLS_WIN_TOOLCHAIN=0 allows compilation using system
toolchain as before.
Using toolchain from depot_tools unifies the compilation
environment, and brings the benefits of automated update, bug fixes
etc.
Review-Url: https://codereview.chromium.org/1897523002
|
|
Chrome has enabled the -Wvarargs warning that was added to clang, this fails
with PDFium XFA builds due to two warnings:
../../xfa/fxfa/fm2js/xfa_lexer.cpp:539:16: error: passing an object that
undergoes default argument promotion to 'va_start' has undefined behavior
[-Werror,-Wvarargs]
va_start(ap, msg);
^
../../xfa/fxfa/fm2js/xfa_lexer.cpp:535:40: note: parameter of type
'XFA_FM_ERRMSG' is declared here
void CXFA_FMLexer::Error(XFA_FM_ERRMSG msg, ...) {
The issue is that XFA_FM_ERRMSG is an enum and we violate the promotion rules
for passing the value to va_start.
I removed the enum and named the flags explicitly then pass in the string as
the argument.
BUG=chromium:606726
Review URL: https://codereview.chromium.org/1921323002
|
|
Contents:
https://chromium.googlesource.com/v8/v8/+log/47bcec78..0ff89ea75
BUG=chromium:606547
Review URL: https://codereview.chromium.org/1920863003
|
|
Some unknown software generates cross reference table with the
claimed object numbers are all off by one. Add a simple verification
function to detect this scenario, thus have a chance to rebuild
the correct cross reference table.
To avoid unnecessary checks and potiential performance hit, we only
check for the very first non free entry.
BUG=602650
Review URL: https://codereview.chromium.org/1910063004
|
|
There are 4 types of meshes that attempt to convert the shading object into
a stream. According to spec (section 8.7.4.1 table 76), the shading object can
be a stream or a dictionary.
All of this shading code assumes it can load the mesh from a stream. The
original code just early exited if it was not a stream. We skip the call
if it is not a stream.
BUG=pdfium:481
Review URL: https://codereview.chromium.org/1908903003
|
|
The GN information got accidentally dup'd in the DEPS file.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1899193006
|
|
The issue with //testing/multiprocess_func_list has been fixed in upstream
//build. This Cl upgrades //build to ToT.
In order to do so clang must also be updated. The Wno-undefined-var-template
is only passed if the pinned clang revision isn't 266460, which is the
currently pinned clang revision in chromium. This is there so that the bot
that builds with trunk clang gets this flag, but pinned clang doesn't.
We accidentally pickup the flag since our pinned clang is different from the
Chrome version. So, we must always roll //build and clang together when
changing deps or bad things may happen as there is an implicit dependency
due to compile flags.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1911483002
|
|
This CL setups up a standalone GN build. You'll need to set gn args similar to:
use_goma = true
clang_use_chrome_plugins = false
pdf_enable_xfa = true
pdf_enable_v8 = true
pdf_is_standalone = true
The third_party/pymock files are needed to make git cl upload work correctly.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1904563002
|
|
This CL moves the build/ files to build_gyp/ in anticipation of pulling in
Chromiums build/ directory.
The gyp_pdfium files have been duplicated into both places. Once the bots
are updated we'll remove the build/ versions.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1900913003
|
|
Test still need modification to process input events. For now,
we just suppress anything that diffs.
Review URL: https://codereview.chromium.org/1894083003
|
|
Roll Clang revision to the same one as v8
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1900603004
|
|
Reason: a wrong patch got submitted.
This reverts commit 07af99b822588c5d6bab7cbf548c756346352184.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1895263002
|
|
Roll Clang revision to the same one as v8
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1900603004 .
|
|
Recent change of Clang (https://codereview.chromium.org/1879753002)
invokes GetVSVersion() which imports vs_toolchain which PDFium has
not used yet. This breaks our bots. Now we pinned Clang to last good
version.
We can either change back to use Tot Clang after we have toolchain
utility, or we can roll Clang periodically.
Review URL: https://codereview.chromium.org/1900823002
|
|
Review URL: https://codereview.chromium.org/1882673002
|
|
Regular, but overdue roll.
Review URL: https://codereview.chromium.org/1879923002
|
|
Added test case.
Several bugs going on here:
JS_LocalTime() ignoring argument and returning current time
and not factoring in the time zone adjustment.
Use of FXSYS_floor() silently casts result to float,
losing precision required to extract minutes and seconds.
Pre-existing wcsftime escapes not stripped.
BUG=pdfium:413
Review URL: https://codereview.chromium.org/1833053002
|
|
Update Skia to a version that supports building Windows
with FreeType as a font backend.
This also breaks the current version of PDFium when
pdf_use_skia=1 ; the SkDashPathEffect interface is different.
Staging the DEPS change separate from the changes that use it
will help me keep my sanity.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1832483002 .
|
|
Pull the gn binary from google source. This is needed inorder to get git cl
format to work correctly on mac. Added other platforms for completness.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1826663002 .
|
|
Patch by cherycherian.
patch from issue 1810153003 at patchset 1 (http://crrev.com/1810153003#ps1)
FormCalc expressions containing double-dot operators in SOM expressions
were failing since XFA_ResolveNodes_AnyChild was always stripping the
leading character.
Roll testing/corpus to d671154 to pick up the test.
BUG=pdfium:434
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1821413002 .
|
|
This CL adds the necessary pieces so you can add pdf_use_skia=1 to GYP_DEFINES
and do a standalone build.
R=caryclark@google.com
Review URL: https://codereview.chromium.org/1812563002 .
|
|
The downsampler was not sampling correctly from 16-bit images, resulting
in using the RRG bytes (of the RRGGBB 16-bit pixel) for RGB in the 8-bit
output.
Original code review: https://codereview.chromium.org/1663983002/
Original author: ballbach@google.com
BUG=583804
R=ballbach@google.com
Review URL: https://codereview.chromium.org/1671833002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1665933003 .
|
|
BUG=581960
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1648283003 .
(cherry picked from commit b0b6373e685e0591fb47fe6cb90e767728241e7f)
Review URL: https://codereview.chromium.org/1650553003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1579353002 .
(cherry picked from commit 4bfa89e8197182854b067d35809df09540cd3f52)
Review URL: https://codereview.chromium.org/1579903003 .
|
|
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1544943002 .
(cherry picked from commit 494ea0af63620c6839f724111d0b955cbe93e1c3)
Review URL: https://codereview.chromium.org/1572403002 .
|
|
This reverts commit 054fc955c153eb5c581fd14946848b8b2a77136a.
Additionally, this rolls DEPS for the testing corpus to update test
expectations.
BUG=pdfium:336
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1555833002 .
(cherry picked from commit 5594538fcc96c38db34f336223140cf703e3cca0)
Review URL: https://codereview.chromium.org/1553013002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1549063002 .
(cherry picked from commit d4192c7774dac4b2fb30facb3deb3453e03c88fc)
Review URL: https://codereview.chromium.org/1542303003 .
|
|
BUG=pdfium:335
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1549013002 .
(cherry picked from commit 4070ccbe6070a267af859485a660a196da90c584)
Review URL: https://codereview.chromium.org/1549023002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1466033002 .
(cherry picked from commit faab0f0add8317a7f95a8477e77bae716a10e977)
Review URL: https://codereview.chromium.org/1470553002 .
|
|
This reverts commit 034477eb3a56690d339776d900100794a0f37853.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1432213005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1437043002 .
(cherry picked from commit 44a4de0b4bd5148396b2b0de1353dafee6a4c418)
Review URL: https://codereview.chromium.org/1433303003 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
- And fix XFA's lack of #includes.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
(cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c)
Review URL: https://codereview.chromium.org/1434543003 .
|
|
Also adds a README.pdfium and 0000-include.patch that
details the local modifications made.
Also rolls testing/corpus to 45f88c6914fcac26ad930bb0ebbfa468c21db0a5
which includes regenerated corpus expectations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1413673003 .
(cherry picked from commit 87ee069d05ca06f60d6cfacd9e426739d8f2053d)
Review URL: https://codereview.chromium.org/1416993005 .
|
|
This is just a straight-forward, partial merge. It does not
actually make checkdeps succeed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1419373005 .
(cherry picked from commit 79f5a32175293620abe456554e10efb7c3f4e7c6)
Review URL: https://codereview.chromium.org/1409153007 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1421353007 .
(cherry picked from commit 4c4dd28fb1d3ba27d29571297cdf523e2f8e724c)
Review URL: https://codereview.chromium.org/1427273002 .
|
|
TBR=dsinclair@chomium.org
Review URL: https://codereview.chromium.org/1426943002 .
|
|
Context: DEPS was originally added to pdfium to allow its recipe to
automatically check out its dependencies. The recipe used absolute
paths, and so the checkout directory's name ('pdfium') had to be
prefixed to the directory checkout of every dependency, as gclient in
the recipe worked one level above the pdfium checkout itself.
After change fe4537269fc7133320a5131638757f2ffa6bd854, the recipe no
longer worked. To fix this, I'm making DEPS use relative paths.
BUG=375773
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/724113003
(cherry picked from commit 39c6b4c50bb06336c2b592a407efa862ff6ed8ae)
Review URL: https://codereview.chromium.org/1421703002 .
|
|
Also adds support for ASan and sanitizer coverage.
BUG=pdfium:1,pdfium:171
R=thestig@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/5478df43a8970257e9644ae6f57a6fe7513029c6
Review URL: https://codereview.chromium.org/1406843002 .
(cherry picked from commit 3b2ab45f0a883046a7c457e8435b5a9b2c1c4156)
Review URL: https://codereview.chromium.org/1412193010 .
|
|
This will break existing checkouts based on the instructions provided.
Instead of having a single pdfium directory, checkouts will now compromise of:
("repo" can be named anything)
repo/.gclient
repo/pdfium/.git
repo/pdfium/others...
To convert an existing checkout, do something like:
mkdir repo
mv pdfium repo
rm repo/pdfium/.gclient_entries # will be regenerated, with a warning
mv repo/pdfium/.gclient repo
edit repo/.gclient and change "name: '.'" to "name: 'pdfium'"
Instructions for getting a new checkout are in README.md in this CL.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1406383003 .
Review URL: https://codereview.chromium.org/1422633002 .
|
|
Original Review URL: https://codereview.chromium.org/1411493002 .
(cherry picked from commit 8316a8a0274558f7a0f515e04bb13a7cca5762b2)
BUG=pdfium:217
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1405243004 .
|
|
(cherry picked from commit d6d9dc6b9a45368abdf43477592ee9f6cdb6102e)
(cherry picked from commit cfff2f65aaec70247d020188bc68a0dc4fb34c3e)
Original Review URL: https://codereview.chromium.org/1372963003 .
Original Review URL: https://codereview.chromium.org/1367813003 .
TBR=jochen@chromium.org
Review URL: https://codereview.chromium.org/1370133007 .
|
|
Original Review URL: https://codereview.chromium.org/1297453002 .
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1290243003 .
|
|
Original Review URL: https://codereview.chromium.org/1233583004 .
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1234923006 .
|
|
TBR=thestig@chromium.org
Original Review URL: https://codereview.chromium.org/1193563002.
Review URL: https://codereview.chromium.org/1193623003.
|
|
If the font is 'tricky', it needs to be hinted by default according to the description in freetype.
BUG=490814
TBR=jun_fang@foxitsoftware.com
Original Review URL: https://codereview.chromium.org/1170313003.
Review URL: https://codereview.chromium.org/1175243008.
|
|
Original Review URL: https://codereview.chromium.org/1149623011
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1152523007
|