Age | Commit message (Collapse) | Author |
|
Most of the CPU time when moving around XFA forms is spent rendering
these gradients.
Bug: chromium:592748
Change-Id: I08c68c60996755a2be25243dfd2143b6cbb13af9
Reviewed-on: https://pdfium-review.googlesource.com/28090
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
This CL rolls the build/ and subsequently clang/ directories in order to
pull the libxcursor1-dbg fix into PDFium.
Build: https://chromium.googlesource.com/chromium/src/build/+log/c7a79acbd202c85ddafbacdcde0f7926a53ae792..7bee8be1e0ed713aa9ddeb422a459fced9412c9f
Clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a695c30c8618b948d714a2a8161ee6a2ab98d0ce..7e6931239f20219e3c993b7f8d864217bdbe925e
BUG: chromium:814331
Change-Id: Ifb97ae08a702f63742be7658a7e8227d7f56a179
Reviewed-on: https://pdfium-review.googlesource.com/27611
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/4a03f17449ae..713d68ee9f47
$ git log 4a03f1744..713d68ee9 --date=short --no-merges --format='%ad %ae %s'
2018-02-17 wl [sfnt] Prefer `CBDT'/`CBLC' over `glyf' table (#53154).
2018-02-17 wl Split off ChangeLog.28.
2018-02-17 wl s/sub-pixel/subpixel/.
Created with:
roll-dep pdfium/third_party/freetype/src
BUG=pdfium:1016
Change-Id: Ib7846b5234cc1cf5a85cf557cc37f74144b592c6
Reviewed-on: https://pdfium-review.googlesource.com/27491
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
This is PDFium's copy of https://crrev.com/533804
Change-Id: I6e0c3e0fbb36fa9da9cb2e4e18c413c92824c46a
Reviewed-on: https://pdfium-review.googlesource.com/27490
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
AKA roll Clang 321529:324578
https://chromium.googlesource.com/chromium/src/tools/clang/+log/ac1e5f78..a695c30c
Also roll build to c7a79acb to match.
https://chromium.googlesource.com/chromium/src/build/+log/b1bf4b84..c7a79acb
Which then requires the sysroot hooks to be updated.
Change-Id: Ibc6475e62d969ade564f1a063a89d348aca1eb67
Reviewed-on: https://pdfium-review.googlesource.com/27010
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/036bdc0c9a4f..4a03f17449ae
$ git log 036bdc0c9..4a03f1744 --date=short --no-merges --format='%ad %ae %s'
2018-02-06 wl [truetype] Integer overflow issues.
2018-02-04 apodtele [unix] Use -fvisibility=hidden.
Created with:
roll-dep pdfium/third_party/freetype/src
R=dsinclair@chromium.org,npm@chromium.org,thestig@chromium.org
Bug: pdfium:1009
Change-Id: I0dfa484bc680b5afb4ebc8bf62f6269f7df83d51
Reviewed-on: https://pdfium-review.googlesource.com/26810
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
|
|
https://chromium.googlesource.com/v8/v8/+log/ee5d9a0c..6353d168
TBR=dsinclair@chromium.org
Change-Id: I46e14078fb7d3aa78723fd499d7c8280b3ae7161
Reviewed-on: https://pdfium-review.googlesource.com/26490
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This makes the caret appear (again?), blink, and fixes its positioning
to be a little spaced from the last character.
Known issue: when the edit is empty, the caret is not necessarily
aligned with where the text will be.
Bug: chromium:592750
Change-Id: I950b0ea236db8855c6ed50f48ec1935d97e6ccf8
Reviewed-on: https://pdfium-review.googlesource.com/25451
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
Roll DEPS for android_ndk to e951c37287c7d8cd915bf8d4149fd4a06d808b55.
https://chromium.googlesource.com/android_ndk/+log/d5752321..e951c372
Roll DEPS for build to b1bf4b84cb5db309fda657ebd19a6c3d2ebdcb66.
https://chromium.googlesource.com/chromium/src/build/+log/097c79ba..b1bf4b84
Roll DEPS for buildtools to f115f4786771afdfacb18a2299541b23e21f4792.
https://chromium.googlesource.com/chromium/buildtools/+log/b36c7b60..f115f478
The android_ndk version needs to be updated to r16.
android_ndk and build cannot be rolled separately. build depends on the
buildtools changes.
This enables pdfium to be built with emscripten.
Bug: chromium:804907
Change-Id: If442e92f2f608ae20b476b9b077111e2596187cf
Reviewed-on: https://pdfium-review.googlesource.com/24890
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/2c048a8a622e..036bdc0c9a4f
$ git log 2c048a8a6..036bdc0c9 --date=short --no-merges --format='%ad %ae %s'
2018-01-28 wl [truetype] Minor typo.
2018-01-27 wl [truetype] Better protection against invalid VF data.
2018-01-27 wl * src/truetype/ttinterp.c (Ins_GETVARIATION): Avoid NULL reference.
2018-01-27 wl * src/truetype/ttgxvar.c (tt_set_mm_blend): Minor.
2018-01-27 wl [truetype] Better trace VF instances.
2018-01-27 wl Fix comment.
2018-01-27 wl [truetype] Beautify tracing of VF axis records.
2018-01-26 wl [truetype] Fix multiple calls of `FT_Get_MM_Var' (#52955).
2018-01-23 apodtele [apinames] Anonymous version map for GNU linker.
2018-01-21 apodtele [unix] Call libtool to clean up.
2018-01-18 apodtele * src/base/ftver.rc: Fix mingw-w64 compilation.
2018-01-18 apodtele [build] Enable VERSIONINFO resource for Cygwin/MinGW.
2018-01-18 apodtele [build] Move VERSIONINFO resource.
2018-01-12 apodtele [build] Expand dllexport/dllimport to Cygwin/MinGW.
2018-01-12 apodtele [build] Improve and document MSVC build.
2018-01-10 ssrobins * CMakeLists.txt [win32]: Suppress warnings for POSIX functions.
2018-01-10 ewaldhew [psaux] Correctly handle Flex features (#52846).
2018-01-09 apodtele * builds/windows/vc2010/freetype.sln: Synchronize with the project.
2018-01-08 wl * Version 2.9 released. =======================
2018-01-08 wl Next release will be 2.9.
2018-01-07 wl Add check for librt, needed for `ftbench' (#52824).
2018-01-07 ewaldhew [psaux] Fix Type 1 glyphs with too many stem hints.
2018-01-06 wl Add `FT_Done_MM_Var'.
2018-01-06 wl Minor doc fixes.
2018-01-03 wl [truetype] Round offsets of glyph components only if hinting is on.
2018-01-03 wl * src/truetype/ttgxvar.c (ft_var_to_design): Remove dead code.
2018-01-02 apodtele Move internal LCD-related declarations.
2018-01-02 apodtele * include/freetype/config/ftconfig.h (FT_EXPORT, FT_EXPORT_DEF) [_MSC_VER]: Limit Visual C++ attributes.
2018-01-03 wl [truetype] Make blend/design coordinate round-tripping work.
2018-01-02 wl Update copyright year.
2017-12-31 wl Update `CHANGES' file with demo program news.
2017-12-31 wl * src/sfnt/ttcmap.c (tt_cmap2_char_next): Fix endless loop.
2017-12-31 wl Synchronize other Windows project files.
2017-12-31 wl Update Visual C 2010 project files.
2017-12-30 wl Updated `CHANGES' file.
2017-12-30 wl * builds/vms/ftconfig.h: Synchronize with unix `ftconfig.in' file.
2017-12-28 wl * builds/unix/ftconfig.in: Synchronize with main `ftconfig.h' file.
2017-12-27 wl Fix compiler warnings.
2017-12-27 wl Fixes for `make multi'.
2017-12-27 wl Provide support for intra-module callback functions.
2017-12-27 wl Add missing ChangeLog entry, copyright notices, whitespace, formatting.
2017-12-25 ewaldhew Move PostScript drivers' property handlers to `base'
2017-12-20 wl Speed up FT_Set_Var_{Design,Blend}_Coordinates if curr == new.
2017-12-18 wl Update incorrect ChangeLog entry.
2017-12-18 wl [sfnt] Fix charmap type 2 iterator (#52646).
2017-12-18 matthias.clasen [truetype] Minor code beautification.
2017-12-18 wl * src/*/*: Only use `ft_' and `FT_' variants of stdc library stuff.
2017-12-18 wl * src/truetype/ttgxvar.c (tt_face_vary_cvt): Add size guard (#52688).
2017-12-18 wl [truetype] Fix previous commit.
2017-12-18 wl [truetype] Don't apply HVAR and VVAR deltas twice (#52683).
2017-12-17 jfkthame [truetype] Correctly handle variation font phantom points (#52683).
2017-12-17 jfkthame Fix incorrect advance width scaling (#52683).
2017-12-16 apodtele * builds/windows/vc2010/freetype.vcxproj: AfterBuild copy. * objs/.gitignore: Ignore almost everything.
Created with:
roll-dep pdfium/third_party/freetype/src
R=dsinclair@chromium.org,npm@chromium.org,thestig@chromium.org
Bug: pdfium:995
Change-Id: I70cdf674d66390d4600a5438640b51f6b39c4d84
Reviewed-on: https://pdfium-review.googlesource.com/24370
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Update test expectations after V8 enabled --harmony-function-tostring
by default.
https://chromium.googlesource.com/v8/v8/+log/0c287882..ee5d9a0c
TBR=dsinclair@chromium.org
Change-Id: I4eabc6b2ed854153dcbfb75f527e209f57e86a2a
Reviewed-on: https://pdfium-review.googlesource.com/24110
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Update the hook to match the hook of the same name in Chromium. This is
needed to support win-cross builds for standalone PDFium.
Change-Id: Ib8a44aedc2e33a15880c51f4e7ee53a4fc7f5682
Reviewed-on: https://pdfium-review.googlesource.com/21971
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Just a routine roll.
https://chromium.googlesource.com/v8/v8/+log/ff3d8321..0c287882
TBR=dsinclair@chromium.org
Change-Id: I55ab495aa2882595dfd7ac54c76ce7d255e5a9d6
Reviewed-on: https://pdfium-review.googlesource.com/22511
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This relands commit 7829b7048d5cf13a4f1a806fed57f2440d1b5dec.
This uses a new version of clang with a fix for the LSan issue that
caused the previous revert.
Original change's description:
> [CFI] Enable type generalization for LCMS
>
> Control Flow Integrity [1] indirect call checking verifies that function
> pointers only call valid functions with a matching type signature. This
> condition can be too strict, a common form of 'abstraction' relies on
> function pointers being cast to generalize argument pointer types to
> void*.
>
> In LCMS these failures occur because of casts of function pointers called
> as both _cmsInterpFn16 (cmsInterpFunction.Lerp16) and _cmsOPTeval16Fn (as
> an argument to _cmsPipelineSetOptimizationParameters) types making it
> difficult to refactor out easily. Instead, enabling the type
> generalization build config weakens the type checking performed for
> CFI-icall to accomodate this common type of casts.
>
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
>
> Bug: 785442
> Change-Id: Ib42fb1b4e152d5042b170698c2707ebb9e0cc1ee
> Reviewed-on: https://pdfium-review.googlesource.com/19250
> Commit-Queue: dsinclair <dsinclair@chromium.org>
> Reviewed-by: dsinclair <dsinclair@chromium.org>
Bug: 785442
Change-Id: Ice696e4f496fa380f8af053577bde7e46c049590
Reviewed-on: https://pdfium-review.googlesource.com/22265
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
To update to recent revisions, this CL also does the following to DEPS:
- Pulls in depot_tools to third_party/.
- Update hooks for instrumented_libraries to download by default.
- Add checkout_configuration variables so one can skip the download.
The instrumented libraries are large downloads. https://crrev.com/507438
contains notes on how to avoid them.
TBR=dpranke@chromium.org
Change-Id: Ice0f9fcff0d2c8fba5fd3e1ef3e04e94b6bda710
Reviewed-on: https://pdfium-review.googlesource.com/21390
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/build/+log/92d3b8cf..3d168649
Also pull in binutils on Linux, so Android builds can continue working after
upgrading the sysroot to Debian Stretch.
TBR=thomasanderson@chromium.org
Change-Id: I7d08e51ca903ac7fdcdcb971202ec5f3f573f73f
Reviewed-on: https://pdfium-review.googlesource.com/21370
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Routine roll.
https://chromium.googlesource.com/android_ndk/+log/26d93ec0..d5752321
TBR=jbudorick@chromium.org
Change-Id: Icd89e4ede887b8908bf25ad0f83de5ea8eb62ac8
Reviewed-on: https://pdfium-review.googlesource.com/21870
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
AKA roll Clang 315613:317263.
https://chromium.googlesource.com/chromium/src/tools/clang/+log/e7b39c73..8427dae2
TBR=dsinclair@chromium.org
Change-Id: Ifffd284f6767495506f762c0122c75d951cd007c
Reviewed-on: https://pdfium-review.googlesource.com/21350
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
AKA roll Clang 315613:317263.
https://chromium.googlesource.com/chromium/src/tools/clang/+log/0235fed9..e7b39c73
Roll build to match.
https://chromium.googlesource.com/chromium/src/build/+log/159ee37d..92d3b8cf
TBR=dsinclair@chromium.org
Change-Id: I0254937285bca59e6bff59e64fbc69b80ff3f3a8
Reviewed-on: https://pdfium-review.googlesource.com/21330
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/bec14f688925..2c048a8a622e
$ git log bec14f688..2c048a8a6 --date=short --no-merges --format='%ad %ae %s'
2017-12-11 wl Fix compiler warning (#52640).
2017-12-09 azzuro * builds/windows/vc2010/freetype.vcxproj: Adjust output directory.
2017-12-09 wl Fix `make setup dos', second try (#52622).
2017-12-08 wl Documentation fixes for the last few commits.
2017-12-08 wl [docmaker] Fix code section parsing.
2017-12-08 wl New `ftdriver.h' file, covering all driver modules.
2017-12-08 wl Move `ftdriver.h' to `ftdrv.h'.
2017-12-08 wl Fix access to uninitalized memory (#52613).
2017-12-08 wl Fix `make setup dos' (#52622).
2017-12-07 wl .mailmap: Add Ewald.
2017-12-07 wl Use ASCII only in public header files (#50858).
2017-12-07 wl Fix C++ compilation.
2017-12-07 wl Fix `make multi'.
2017-12-07 wl * include/freetype/config/ftheader.h: Some clean-up.
2017-12-06 wl * builds/symbian/bld.inf: Updated.
2017-12-06 wl New header file `ftparams.h' that collects all parameter tags.
2017-12-05 wl Improve tracing messages by using singular and plural forms.
2017-12-04 wl Update or fix links to use the https protocol instead of http.
2017-12-04 wl [truetype] Allow shared points in `cvar' table (#52532).
2017-11-28 wl [truetype] Improving tracing of composite glyphs.
2017-11-27 wl Allow (again) encoding vectors with more than 256 elements (#52464).
2017-11-27 jan.steffens Fix last commit (#52522).
2017-11-24 wl [unix] Install a massaged `ftoption.h' file (#51780).
2017-11-23 wl Minor.
2017-11-23 tor.andersson Silence unused function warnings.
Created with:
roll-dep pdfium/third_party/freetype/src
R=dsinclair@chromium.org,npm@chromium.org,thestig@chromium.org
Bug: pdfium:961
Change-Id: I6ada047f9a06a755c85544fca4e3b0d6c56d3bbc
Reviewed-on: https://pdfium-review.googlesource.com/21010
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
|
|
Routine roll, with update for a removed API call.
https://chromium.googlesource.com/skia/+log/d6c04d9a..40ca2087
Change-Id: I938b214fbb79cea6fed99edb5ca7d90a779bb8e8
Reviewed-on: https://pdfium-review.googlesource.com/20930
Reviewed-by: Cary Clark <caryclark@google.com>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Routine roll.
https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/945bc9fb..91155b5d
TBR=dsinclair@chromium.org
Change-Id: I93a37bde12f44fa769abbef882ea04ebb8e05a8d
Reviewed-on: https://pdfium-review.googlesource.com/20910
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Routine roll.
https://chromium.googlesource.com/chromium/src/build/+log/159ee37d..891d9357
TBR=dsinclair@chromium.org
Change-Id: I45a61315694a7e55ed5a29c86303875a8436c3db
Reviewed-on: https://pdfium-review.googlesource.com/20710
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Routine roll.
https://chromium.googlesource.com/skia/+log/e0e20755..d6c04d9a
TBR=dsinclair@chromium.org
Change-Id: I5ea78647f6fd52f660b446392b6507d8a097f453
Reviewed-on: https://pdfium-review.googlesource.com/20651
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
AKA roll Clang 313786:315613.
https://chromium.googlesource.com/chromium/src/tools/clang/+log/1bc4a898..0235fed9
TBR=dsinclair@chromium.org
Change-Id: I5077a699f51a91aa45868aa309454266cf8a31d6
Reviewed-on: https://pdfium-review.googlesource.com/20695
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Routine roll.
https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/718f6864..945bc9fb
TBR=dsinclair@chromium.org
Change-Id: I723e336ce939c3ede9de3957cda86c4dd1d148e5
Reviewed-on: https://pdfium-review.googlesource.com/20694
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Just a routine roll.
https://chromium.googlesource.com/v8/v8/+log/4931eb42..ff3d8321
TBR=dsinclair@chromium.org
Change-Id: I99063efad0d7a7a9408d499a49c920a0a030e23d
Reviewed-on: https://pdfium-review.googlesource.com/20690
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
This makes MSVS 2017 the default on Windows.
https://chromium.googlesource.com/chromium/src/build/+log/555b75b1..159ee37d
TBR=dsinclair@chromium.org
Change-Id: I2c533ad70c37309bf467b97788d24998bbd7c71a
Reviewed-on: https://pdfium-review.googlesource.com/20693
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This is effectively roll clang 312679:313786. Upgrade build to match.
https://chromium.googlesource.com/chromium/src/tools/clang/+log/4db58540..1bc4a898
https://chromium.googlesource.com/chromium/src/build/+log/fc826e6c..555b75b1
TBR=dsinclair@chromium.org
Change-Id: Ic8a1fa4c565c4ed481ca8e565958b6aee7a89686
Reviewed-on: https://pdfium-review.googlesource.com/20692
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Just a routine roll.
https://chromium.googlesource.com/chromium/buildtools/+log/f90f6a5a..f6d165d9
TBR=dsinclair@chromium.org
Change-Id: Ifaf4fc4ae9768a60de9cb4555e335c3ee56d1d7c
Reviewed-on: https://pdfium-review.googlesource.com/20691
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Routine Roll.
https://chromium.googlesource.com/chromium/deps/icu/+log/08cb9568..e3b480d3
TBR=dsinclair@chromium.org
Change-Id: I509f822f02cec0ac17bf2199a699e1198f274a7f
Reviewed-on: https://pdfium-review.googlesource.com/20670
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
Just a routine roll. Changelogs:
https://chromium.googlesource.com/catapult/+log/0cf3924b..d624b3ce
https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/06294c8a..0e9a47d7
TBR=dsinclair@chromium.org
Change-Id: Ib3349d691a2f6c26ee57951604e8a82607e9a0f6
Reviewed-on: https://pdfium-review.googlesource.com/20650
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|
|
This reverts commit 7829b7048d5cf13a4f1a806fed57f2440d1b5dec.
Reason for revert: Breaking the waterfall build. Looks like it's finding a leak it wasn't before?
https://build.chromium.org/p/client.pdfium/builders/linux_xfa_asan_lsan/builds/2376/steps/embeddertests/logs/stdio
Original change's description:
> [CFI] Enable type generalization for LCMS
>
> Control Flow Integrity [1] indirect call checking verifies that function
> pointers only call valid functions with a matching type signature. This
> condition can be too strict, a common form of 'abstraction' relies on
> function pointers being cast to generalize argument pointer types to
> void*.
>
> In LCMS these failures occur because of casts of function pointers called
> as both _cmsInterpFn16 (cmsInterpFunction.Lerp16) and _cmsOPTeval16Fn (as
> an argument to _cmsPipelineSetOptimizationParameters) types making it
> difficult to refactor out easily. Instead, enabling the type
> generalization build config weakens the type checking performed for
> CFI-icall to accomodate this common type of casts.
>
> [1] https://www.chromium.org/developers/testing/control-flow-integrity
>
> Bug: 785442
> Change-Id: Ib42fb1b4e152d5042b170698c2707ebb9e0cc1ee
> Reviewed-on: https://pdfium-review.googlesource.com/19250
> Commit-Queue: dsinclair <dsinclair@chromium.org>
> Reviewed-by: dsinclair <dsinclair@chromium.org>
TBR=tsepez@chromium.org,dsinclair@chromium.org,vtsyrklevich@chromium.org
Change-Id: Ib9c26eb017733d2bf02035415221475bfbfe55c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 785442
Reviewed-on: https://pdfium-review.googlesource.com/19730
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
Control Flow Integrity [1] indirect call checking verifies that function
pointers only call valid functions with a matching type signature. This
condition can be too strict, a common form of 'abstraction' relies on
function pointers being cast to generalize argument pointer types to
void*.
In LCMS these failures occur because of casts of function pointers called
as both _cmsInterpFn16 (cmsInterpFunction.Lerp16) and _cmsOPTeval16Fn (as
an argument to _cmsPipelineSetOptimizationParameters) types making it
difficult to refactor out easily. Instead, enabling the type
generalization build config weakens the type checking performed for
CFI-icall to accomodate this common type of casts.
[1] https://www.chromium.org/developers/testing/control-flow-integrity
Bug: 785442
Change-Id: Ib42fb1b4e152d5042b170698c2707ebb9e0cc1ee
Reviewed-on: https://pdfium-review.googlesource.com/19250
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/8f5568bfc4fd..bec14f688925
$ git log 8f5568bfc..bec14f688 --date=short --no-merges --format='%ad %ae %s'
2017-11-22 ewaldhew * src/psaux/psft.c (cf2_setGlyphWidth): Check format before setting.
2017-11-22 ewaldhew [psaux] Fix CFF advance widths. (#52466)
2017-11-15 vtsyrklevich * include/freetype/ftrender.h: Fix `FT_Renderer_RenderFunc' type.
2017-11-14 madigens Use Adobe hinting engine for `light' hinting of both CFF and Type 1.
2017-11-09 yuri_levchenko * CMakeLists.txt: Add `DISABLE_FORCE_DEBUG_PREFIX' option.
Created with:
roll-dep pdfium/third_party/freetype/src
R=dsinclair@chromium.org,npm@chromium.org,thestig@chromium.org
Bug: pdfium:941
Change-Id: I00579a3e26d9cabce7032e0b538de95a1029bac7
Reviewed-on: https://pdfium-review.googlesource.com/19310
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/91015cb41d8f..8f5568bfc4fd
$ git log 91015cb41..8f5568bfc --date=short --no-merges --format='%ad %ae %s'
2017-11-06 apodtele * src/base/ftobjs.c (FT_Load_Glyph): Relocate condition.
2017-11-06 apodtele * src/smooth/ftgrays.c (gray_set_cell): Fix uninitialized variables.
2017-10-21 ewaldhew [psaux] Fix PostScript interpreter rewinding in Type 1 mode. (#52251)
2017-11-03 mpsuzuki [truetype] Add more tricky fonts.
2017-11-01 apodtele [smooth] Fix complex rendering at high ppem.
Created with:
roll-dep pdfium/third_party/freetype/src
R=dsinclair@chromium.org,npm@chromium.org,thestig@chromium.org
Bug: pdfium:931
Change-Id: I304839c1a51e49284800de468d0f5f9389db8388
Reviewed-on: https://pdfium-review.googlesource.com/17982
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
|
|
This reverts commit 978ba20ffd0d2b37bf02b9d86828fa701c0c02fa.
Reason for revert: I now have the new expected files for the
chrome test ready in
https://chromium-review.googlesource.com/c/chromium/src/+/742061
Landing this again and will immediately add a manual pdfium roll to
cl 742061 to unblock the deps roller.
Original change's description:
> Revert "Reland "Remove ContrastAdjust().""
>
> This reverts commit d5ec7ab0cd0663184d6056bc6fc87c86ec345342.
>
> Reason for revert: Did not mean to reland, just create the reland CL.
>
> Original change's description:
> > Reland "Remove ContrastAdjust()."
> >
> > Original change's description:
> > > Revert "Remove ContrastAdjust()."
> > >
> > > This reverts commit 53d443f042b590ae2d920def16bc9daf66f8427d.
> > >
> > > Reason for revert: Breaks PDFToPWGRasterBrowserTest
> > >
> > > Original change's description:
> > > > Remove ContrastAdjust().
> > > >
> > > > This post-processing increased the contrast of scaled-down features -
> > > > mainly lines and fonts, relative to the background. The effect does not
> > > > improved readability and in some cases makes the scaled-down version
> > > > look like a different document at a glance. Text that is normal
> > > > weight appears bold when scaled down in these cases.
> > > >
> > > > Change-Id: I2544d45e2bcec25d6742d2a60c1316d8df08cce1
> > > > Reviewed-on: https://pdfium-review.googlesource.com/15471
> > > > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > > > Reviewed-by: dsinclair <dsinclair@chromium.org>
> > >
> > > TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
> > >
> > > # Not skipping CQ checks because original CL landed > 1 day ago.
> > >
> > > Change-Id: I7f61650bc6d917b3c6640da60f3f740ef4498de0
> > > Reviewed-on: https://pdfium-review.googlesource.com/16970
> > > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> >
> > TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
> >
> > Change-Id: I77d4377d30908d1e2d4dc842300a761072a5fbd4
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://pdfium-review.googlesource.com/16990
> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
>
> TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
>
> Change-Id: Ie2e91662a1e82c0a793952aab47c2acbde1596d4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://pdfium-review.googlesource.com/16991
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
Change-Id: Iaae451131043ee69052809680922fdac06a69458
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/16992
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
This reverts commit d5ec7ab0cd0663184d6056bc6fc87c86ec345342.
Reason for revert: Did not mean to reland, just create the reland CL.
Original change's description:
> Reland "Remove ContrastAdjust()."
>
> Original change's description:
> > Revert "Remove ContrastAdjust()."
> >
> > This reverts commit 53d443f042b590ae2d920def16bc9daf66f8427d.
> >
> > Reason for revert: Breaks PDFToPWGRasterBrowserTest
> >
> > Original change's description:
> > > Remove ContrastAdjust().
> > >
> > > This post-processing increased the contrast of scaled-down features -
> > > mainly lines and fonts, relative to the background. The effect does not
> > > improved readability and in some cases makes the scaled-down version
> > > look like a different document at a glance. Text that is normal
> > > weight appears bold when scaled down in these cases.
> > >
> > > Change-Id: I2544d45e2bcec25d6742d2a60c1316d8df08cce1
> > > Reviewed-on: https://pdfium-review.googlesource.com/15471
> > > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > > Reviewed-by: dsinclair <dsinclair@chromium.org>
> >
> > TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Change-Id: I7f61650bc6d917b3c6640da60f3f740ef4498de0
> > Reviewed-on: https://pdfium-review.googlesource.com/16970
> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
>
> TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
>
> Change-Id: I77d4377d30908d1e2d4dc842300a761072a5fbd4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://pdfium-review.googlesource.com/16990
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
Change-Id: Ie2e91662a1e82c0a793952aab47c2acbde1596d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/16991
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
Original change's description:
> Revert "Remove ContrastAdjust()."
>
> This reverts commit 53d443f042b590ae2d920def16bc9daf66f8427d.
>
> Reason for revert: Breaks PDFToPWGRasterBrowserTest
>
> Original change's description:
> > Remove ContrastAdjust().
> >
> > This post-processing increased the contrast of scaled-down features -
> > mainly lines and fonts, relative to the background. The effect does not
> > improved readability and in some cases makes the scaled-down version
> > look like a different document at a glance. Text that is normal
> > weight appears bold when scaled down in these cases.
> >
> > Change-Id: I2544d45e2bcec25d6742d2a60c1316d8df08cce1
> > Reviewed-on: https://pdfium-review.googlesource.com/15471
> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> > Reviewed-by: dsinclair <dsinclair@chromium.org>
>
> TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I7f61650bc6d917b3c6640da60f3f740ef4498de0
> Reviewed-on: https://pdfium-review.googlesource.com/16970
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
Change-Id: I77d4377d30908d1e2d4dc842300a761072a5fbd4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://pdfium-review.googlesource.com/16990
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
This reverts commit 53d443f042b590ae2d920def16bc9daf66f8427d.
Reason for revert: Breaks PDFToPWGRasterBrowserTest
Original change's description:
> Remove ContrastAdjust().
>
> This post-processing increased the contrast of scaled-down features -
> mainly lines and fonts, relative to the background. The effect does not
> improved readability and in some cases makes the scaled-down version
> look like a different document at a glance. Text that is normal
> weight appears bold when scaled down in these cases.
>
> Change-Id: I2544d45e2bcec25d6742d2a60c1316d8df08cce1
> Reviewed-on: https://pdfium-review.googlesource.com/15471
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: dsinclair <dsinclair@chromium.org>
TBR=bungeman@chromium.org,dsinclair@chromium.org,hnakashima@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I7f61650bc6d917b3c6640da60f3f740ef4498de0
Reviewed-on: https://pdfium-review.googlesource.com/16970
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
|
|
This post-processing increased the contrast of scaled-down features -
mainly lines and fonts, relative to the background. The effect does not
improved readability and in some cases makes the scaled-down version
look like a different document at a glance. Text that is normal
weight appears bold when scaled down in these cases.
Change-Id: I2544d45e2bcec25d6742d2a60c1316d8df08cce1
Reviewed-on: https://pdfium-review.googlesource.com/15471
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/ae7dc1f62d82..91015cb41d8f
$ git log ae7dc1f62..91015cb41 --date=short --no-merges --format='%ad %ae %s'
2017-10-21 apodtele [smooth] Improve complex rendering at high ppem.
2017-10-20 apodtele [base] Improve tracing in FT_Load_Glyph, FT_*_Size.
2017-10-18 apodtele [base] Improve tracing in FT_Render_Glyph.
2017-10-16 ewaldhew [cff] Fix segfault on missing `psaux' (#52218)
2017-10-15 apodtele [base, cff] Fix MSVC warnings.
2017-10-14 apodtele [base] Netpbm image tracing.
2017-10-14 apodtele * builds/windows/ftdebug.c (FT_Message): Print to stderr.
2017-10-14 behdad [afshaper] Delay creating `hb_set' objects until needed.
2017-10-12 ewaldhew * devel/ftoption.h: Enable T1_CONFIG_OPTION_OLD_ENGINE by default.
2017-10-12 ewaldhew [type1, cid] Add hinting engine switch.
2017-10-12 ewaldhew Add T1_CONFIG_OPTION_OLD_ENGINE configuration option.
2017-10-12 ewaldhew Extract width parsing from Type 1 parser.
2017-10-12 wl [autofit] Better visualize table tracing in source code.
2017-10-09 wl * src/base/ftoutln.c (FT_Outline_Translate): Fix integer overflow.
2017-10-08 wl * src/base/ftobjs.c (ft_glyphslot_preset_bitmap): Integer overflows.
2017-10-08 wl Document global size metrics needed for native bytecode hinting (#52165).
2017-10-08 wl Prevent creation of an incorrect documentation entry.
2017-10-07 wl [sfnt] Adjust behaviour of PS font names for variation fonts.
2017-10-07 wl [cff, truetype] Adjust behaviour of named instances.
2017-10-07 wl Make `FT_Set_Named_Instance' work.
2017-10-07 wl Make `FT_FACE_FLAG_VARIATION' work.
2017-10-07 wl New function `FT_Set_Named_Instance'.
2017-10-07 wl Add macros for checking whether a font variation is active.
2017-10-07 wl Add framework for setting named instance in MM service.
2017-10-07 wl [type1] Minor code shuffling.
2017-10-05 wl * src/base/ftobjs.c (ft_glyphslot_preset_bitmap): Fix integer overflow.
2017-10-05 wl Fix compiler warnings.
2017-10-04 John.Tytgat [cff] Add support for `FSType'.
2017-10-02 wl CHANGES: Formatting.
2017-10-01 wl [smooth,type1] Formatting, whitespace.
2017-10-01 wl [psaux] Formatting, minor fixes, whitespace, copyright notices.
2017-09-30 wl [base,cff,cid] Whitespace, formatting.
2017-09-30 wl [include] Whitespace.
2017-09-30 apodtele Signedness fixes in bitmap presetting.
2017-09-29 apodtele Bitmap metrics presetting [2/2].
Created with:
roll-dep pdfium/third_party/freetype/src
R=dsinclair@chromium.org,npm@chromium.org,thestig@chromium.org
Bug: pdfium:918
Change-Id: I51ec11a612e54b88ddac40b64428cfaabfaec448
Reviewed-on: https://pdfium-review.googlesource.com/16650
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
|
|
List of changes:
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/7e50824288fa..ae7dc1f62d82
Bug: chromium:754574 pdfium:905
Change-Id: Ic7525eb5a4d5fab19bdc2ec7e625e0fc889c52a2
Reviewed-on: https://pdfium-review.googlesource.com/15370
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
|
|
Change-Id: Ic7a1f8fd415526d198bc32469e9b191eac6df4bf
Reviewed-on: https://pdfium-review.googlesource.com/14250
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
Add third_party/eu-strip, which is now required to build on Android.
Since third_party/eu-strip is small and rarely updated, just check in a
copy.
Change-Id: Iba016d8d69c8426f1dacbeeef36b30ca743c46f0
Reviewed-on: https://pdfium-review.googlesource.com/13411
Commit-Queue: (000 09-08 - 09-18) dsinclair <dsinclair@chromium.org>
Reviewed-by: (000 09-08 - 09-18) dsinclair <dsinclair@chromium.org>
|
|
AKA roll clang 310694:312679
Fix virtual dtor warning in xfa/fde/cfde_texteditengine.h
Bug: pdfium:896
Change-Id: Ib5fb9433b2c138ca46ccb281b8c0a852daeb623e
Reviewed-on: https://pdfium-review.googlesource.com/13850
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
|
|
Also do a long overdue roll for catapult to 0cf3924 which is needed by
the build/ changes.
Change-Id: I3ccaba251f4d68c90fe0fcb3c9637a72e964bfbd
Reviewed-on: https://pdfium-review.googlesource.com/13410
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
|
|
This enables MSVC by default on Windows again, so fix code that fail
to build with MSVC too.
Change-Id: I03fb4e3697ad777a4dca88af462b35526d6c1d4d
Reviewed-on: https://pdfium-review.googlesource.com/13392
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
|
|
This CL rebuilds the text edit engine in a simpler fashion. Instead of
depending on multiple pages, paragraphs and buffer fields there is a
single text edit engine which contains a gap buffer.
This makes the code easier to understand and follow.
Change-Id: I10fe85603fa9ed15a647eaac2d931f113cd0c7b0
Reviewed-on: https://pdfium-review.googlesource.com/11990
Commit-Queue: dsinclair <dsinclair@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Ryan Harrison <rharrison@chromium.org>
|
|
This was pulled in via DEPS to make the Skia build work, but it no
longer appears to be needed.
Change-Id: Ib83aa56cd08f1a0abcc0388ce881ec35c41788be
Reviewed-on: https://pdfium-review.googlesource.com/11333
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
|