Age | Commit message (Collapse) | Author |
|
(patchset #1 id:1 of https://codereview.chromium.org/1887643002/ )
Reason for revert:
pdfium still passes /GS
Original issue's description:
> clang/win: Stop passing -Qunused-arguments in pdfium too.
>
> We stopped passing this in Chromium a while ago.
>
> BUG=504658
>
> Committed: https://pdfium.googlesource.com/pdfium/+/112be9813ed7bf4e082048eda5f4a7d3837d116c
TBR=thestig@chromium.org,dsinclair@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=504658
Review URL: https://codereview.chromium.org/1883823002
|
|
We stopped passing this in Chromium a while ago.
BUG=504658
Review URL: https://codereview.chromium.org/1887643002
|
|
Gyp directory is used by a separate repository. Files in that directory
may be ignored by some commands. Move it back into pdfium repository.
BUG=pdfium:442
Review URL: https://codereview.chromium.org/1835943005
|
|
Fix warnings in win32_int.h
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1809473002 .
|
|
TBR=tsepez@chromium.org,thakis@chromium.org
Review URL: https://codereview.chromium.org/1778893002 .
|
|
R=thakis@chromium.org, tsepez@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1774123005 .
|
|
This required suppressing the non-virtual-dtor warning, since
ICU isn't clean. Getting -Werror in exchange for that seems
worthwhile.
Chromium's builds are controlled by its own files, which already
-Werror.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1765893003 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1734593004 .
|
|
BUG=
R=thakis@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1680943003 .
|
|
Also fix -Wunused warnings as a result of this change.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1717063002 .
|
|
Otherwise ASSERT() is useless.
BUG=pdfium:136
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1712053003 .
|
|
TBR=thakis@chromium.org
BUG=585261
Review URL: https://codereview.chromium.org/1683523002 .
|
|
R=thakis@chromium.org
BUG=585261
Review URL: https://codereview.chromium.org/1679843003 .
|
|
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1588643003 .
(cherry picked from commit 783709f76baf7893b7334209fe89d947acd6369d)
Review URL: https://codereview.chromium.org/1584713004 .
|
|
Matches https://crrev.com/366832
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1546103002 .
(cherry picked from commit 1ff4a733f3a50c121bebcff417743b7d84453cc5)
Review URL: https://codereview.chromium.org/1549973002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1542353002 .
(cherry picked from commit 9fb1413926b55727d8f00dd54fbe144a883d4873)
Review URL: https://codereview.chromium.org/1543343002 .
|
|
version changes.
BUG=pdfium:335
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1549863002 .
(cherry picked from commit da0a931ca1ff3ebc64138491a703e7df47650bb9)
Review URL: https://codereview.chromium.org/1549033002 .
|
|
Also defines ADDRESS_SANITIZER and LEAK_SANITIZER for ASan builds.
TBR=thestig@chromium.org
Original Review URL: https://codereview.chromium.org/1540433004 .
(cherry picked from commit 38cecc343561395cad8a33889f91c1a254ca1f73)
Review URL: https://codereview.chromium.org/1540433005 .
|
|
Also fix a newly introduced override warning.
Also define a host_clang GYP variable.
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1532723003 .
Review URL: https://codereview.chromium.org/1533763002 .
(cherry picked from commit e096ca507db9944aebc47d6c2cc1c6fab39498c5)
(cherry picked from commit 0a9158b99a2002fb82301ebec20dbc23b3fc084c)
Review URL: https://codereview.chromium.org/1535603003 .
|
|
This allows standalone pdfium builds to build with XFA, but
makes a chromium checkout revert to non-xfa even on this
branch. GN implies a chromium checkout at the moment, so
disable XFA there, too.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1508003003 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
- And fix XFA's lack of #includes.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
(cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c)
Review URL: https://codereview.chromium.org/1434543003 .
|
|
TBR=thestig@chromium.org
clean merge.
Review URL: https://codereview.chromium.org/1428093004 .
(cherry picked from commit e35b445bee90390ea09f334cbff4a6220537bbda)
Review URL: https://codereview.chromium.org/1418453007 .
|
|
Also adds support for ASan and sanitizer coverage.
BUG=pdfium:1,pdfium:171
R=thestig@chromium.org
Committed: https://pdfium.googlesource.com/pdfium/+/5478df43a8970257e9644ae6f57a6fe7513029c6
Review URL: https://codereview.chromium.org/1406843002 .
(cherry picked from commit 3b2ab45f0a883046a7c457e8435b5a9b2c1c4156)
Review URL: https://codereview.chromium.org/1412193010 .
|
|
This CL moves the conditionals inside the target_defaults configuration. This
causes the -fPIC to get picked up and allows component=shared_library to build
correctly.
Merged clean.
BUG=pdfium:218
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1407903002 .
(cherry picked from commit 26268af2c1242dd173aea6dcbf763a36e734faf3)
Review URL: https://codereview.chromium.org/1412563002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1394483005 .
|
|
R=vogelheim@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1142293003
|
|
This change disables several warnings that fire frequently
in pdfium and are not practical to fix at this time.
Originally on https://codereview.chromium.org/1096463005
TBR=tsepez@chromium.org
BUG=440500
Review URL: https://codereview.chromium.org/1088943003
|
|
Original Review URL: https://codereview.chromium.org/1059023003
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1072213002
|
|
Only request C++11 when compiling C++ code.
Linux pdfium builds have 215 warnings of this form:
command line option -std=gnu++11 is valid for C++/ObjC++ but not for C
The obvious fix is to not request C++11 for C compilations. The only
complication was the the switch we are using is actually gnu++0x, not
gnu++11.
BUG=https://code.google.com/p/pdfium/issues/detail?id=102
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/839163002
Review URL: https://codereview.chromium.org/839323002
|
|
Includes fixes to XFA specific warnings -- benign truncations.
Bug https://code.google.com/p/pdfium/issues/detail?id=104
was filed to track changing types to avoid some truncations.
Resolve all but two VC++ build warnings in pdfium.
pdfium builds on Win32 have about 85 warnings (250 in the XFA
branch, totaling over 480 lines!), mostly from four lines in
a header file and a warning that should be disabled. This
change resolves all but two of them and turns on
warning-as-errors. Bugs have been filed for the two
remaining warnings:
https://code.google.com/p/pdfium/issues/detail?id=100
the 64-bit warnings:
https://code.google.com/p/pdfium/issues/detail?id=101
and the Linux warnings:
https://code.google.com/p/pdfium/issues/detail?id=102
The fix to the double->float truncation bugs will also
improve code-generation.
R=bo_xu@foxitsoftware.com, tsepez@chromium.org
Review URL: https://codereview.chromium.org/792953005
BUG= https://code.google.com/p/pdfium/issues/detail?id=100
Review URL: https://codereview.chromium.org/834413002
|
|
BUG=423883
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/663633002
|
|
This adds the necessary directives to the standalone gyp file.
R=jschuh@chromium.org, jam@chromium.org
BUG=22
Patch from Michael Doppler <m.doppler@gmail.com>.
Review URL: https://codereview.chromium.org/360273002
|
|
BUG=20
R=jschuh@chromium.org
Review URL: https://codereview.chromium.org/349033008
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/300993002
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/302653009
|
|
BUG=msvs build
R=jam@chromium.org
Review URL: https://codereview.chromium.org/295323004
|
|
needed when linking pdfium_test as part of other projects' gyp files as well where standalone.gypi isn't used.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/302453004
|
|
|
|
I moved pdfium_test from chromium's repo to pdfium's. It's now buildable as a sample following the instructions on the wiki.
|