| Age | Commit message (Collapse) | Author |
|---|
|
These two flags are not properly used. Change to the correct
configuration to make them effective.
Review-Url: https://codereview.chromium.org/1925143002
|
|
Update the default goma directory to the current one.
Review-Url: https://codereview.chromium.org/1924903002
|
|
Chrome has enabled the -Wvarargs warning that was added to clang, this fails
with PDFium XFA builds due to two warnings:
../../xfa/fxfa/fm2js/xfa_lexer.cpp:539:16: error: passing an object that
undergoes default argument promotion to 'va_start' has undefined behavior
[-Werror,-Wvarargs]
va_start(ap, msg);
^
../../xfa/fxfa/fm2js/xfa_lexer.cpp:535:40: note: parameter of type
'XFA_FM_ERRMSG' is declared here
void CXFA_FMLexer::Error(XFA_FM_ERRMSG msg, ...) {
The issue is that XFA_FM_ERRMSG is an enum and we violate the promotion rules
for passing the value to va_start.
I removed the enum and named the flags explicitly then pass in the string as
the argument.
BUG=chromium:606726
Review URL: https://codereview.chromium.org/1921323002
|
|
This CL setups up a standalone GN build. You'll need to set gn args similar to:
use_goma = true
clang_use_chrome_plugins = false
pdf_enable_xfa = true
pdf_enable_v8 = true
pdf_is_standalone = true
The third_party/pymock files are needed to make git cl upload work correctly.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1904563002
|
|
This CL moves the build/ files to build_gyp/ in anticipation of pulling in
Chromiums build/ directory.
The gyp_pdfium files have been duplicated into both places. Once the bots
are updated we'll remove the build/ versions.
BUG=pdfium:106
Review URL: https://codereview.chromium.org/1900913003
|
