pdfium.git - Unnamed repository; edit this file 'description' to name the repository.

Age	Commit message (Collapse)	Author
2016-04-11	Make CFX_{Byte,Wide}String::Remove() no-touch if possible	tsepez
	Don't try to copy the string until we are sure we need to change it. Review URL: https://codereview.chromium.org/1877993002
2016-04-11	Avoid copying in TrimRight() and TrimLeft() if possible.	tsepez
	Make Byte and Wide code identical while at it. Review URL: https://codereview.chromium.org/1877553002
2016-04-08	Rename both As{Byte,Wide}StringC() helpers to AsStringC().	tsepez
	The naming is redundant given the base type, and will stand in the way of consolidating Byte and Wide code. BUG= Review URL: https://codereview.chromium.org/1862123003
2016-04-08	Remove CFX_ByteString::Load() and operator= for CFX_ByteTextBuf	tsepez
	The few places these are called are better served by explicit calls to CFX_ByteString() itself. This helps make Byte and Wide strings more similar. Also prevents fx_string.h from having any knowledge of fx_basic.h's ByteTextBuf class. Review URL: https://codereview.chromium.org/1870043003
2016-04-08	Make CFX_WideString::FromLocal() take a CFX_ByteStringC arg	tsepez
	It doesn't persist the string beyond the duration of the call, hence it should take the StringC variant. Doing so avoids some allocs by changing to the StringC ctor in a few places, at the cost of some explicit .ToByteStringC() calls (which are cheap). Review URL: https://codereview.chromium.org/1862953004
2016-04-06	Make wide strings use StringData template	tsepez
	Shuffled the order of methods in fx_basic_wstring.cpp to match those in fx_basic_bstring.cpp. The way to review this patch is to diff those two files against each other. They are beginning to converge. Re-ordered some parameters in Concat() so that the string comes before its length. It feels wrong otherwise. Review URL: https://codereview.chromium.org/1846793002
2016-04-05	Make StringData a templated class.	tsepez
	First step in making the same changes to CFX_WideString that we just made to CFX_ByteString. Review URL: https://codereview.chromium.org/1844073003
2016-04-05	Rename GetCStr and GetPtr to match CFX_ByteString.	dsinclair
	This CL updates CFX_ByteStringC to use the more common c_str and raw_str instead of GetCStr and GetPtr. Review URL: https://codereview.chromium.org/1857713003
2016-04-01	Re-land "Use CFX_RetainPtr to ref count CFX_ByteString""	tsepez
	This reverts commit b33dfdf68bafa30e90a65fb71ff6b343202e0561. BUG= Review URL: https://codereview.chromium.org/1848993002
2016-04-01	Remove CFX_{Byte,Wide}String::Equal in favor of "==".	tsepez
	Makes the code slightly cleaner. Review URL: https://codereview.chromium.org/1846083002
2016-03-31	Beef up unit test for CFX_ByteString and CFX_WideString.	tsepez
	Needed to validate refactoring which was reverted. Review URL: https://codereview.chromium.org/1847193002
2016-03-31	Revert "Use CFX_RetainPtr to ref count CFX_ByteString"chromium/2700 chromium/2699 chromium/2698 chromium/2697	tsepez
	This reverts commit ac88953dfa7c1a68c69989d61d7bc03c0595064b. Reason for revert: Strings borked. TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1852453004
2016-03-30	Use CFX_RetainPtr to ref count CFX_ByteStringchromium/2696	tsepez
	This moves the reference counts from an ad-hoc mechanism to being automatically tracked. Also: Make StringData::Create() always return non-null. Add better ctors for StringData itself. Consolidate copies into StringData methods. Simplify the concat() code. Rename/reorder some parameter names to be simpler. Review URL: https://codereview.chromium.org/1810823002
2016-03-25	Remove FX_DWORD from core/ and delete definitionchromium/2695 chromium/2694 chromium/2693 chromium/2692	tsepez
	Review URL: https://codereview.chromium.org/1832173003
2016-03-23	Move core/include/fxcrt to core/fxcrt/include.	Dan Sinclair
	This CL moves the fxcrt code into the core/fxcrt directory. The only exception was fx_bidi.h which was moved into core/fxcrt as it is not used outside of core/. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1825953002 .
2016-03-14	Move core/src/ up to core/.	Dan Sinclair
	This CL moves the core/src/ files up to core/ and fixes up the include guards, includes and build files. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1800523005 .