pdfium.git - Unnamed repository; edit this file 'description' to name the repository.

Age	Commit message (Collapse)	Author
2016-04-06	Make wide strings use StringData template	tsepez
	Shuffled the order of methods in fx_basic_wstring.cpp to match those in fx_basic_bstring.cpp. The way to review this patch is to diff those two files against each other. They are beginning to converge. Re-ordered some parameters in Concat() so that the string comes before its length. It feels wrong otherwise. Review URL: https://codereview.chromium.org/1846793002
2016-04-06	Make CFX_WideString::FromUTF8() take a CFX_ByteStringC argument.	tsepez
	Methods that take string arguments and do not persist them should take StringC types as argument rather than discrete ptr/len args. Avoids a number of implicit casts from CFX_ByteString to char. BUG= Review URL: https://codereview.chromium.org/1861183002
2016-04-06	Rename CFX_WideStringC::raw_str() to c_str()	tsepez
	No functional change intended. This difference in naming is standing in the way of consolidating some of the string code between Wide and Byte strings. The Wide code wants to call raw_str() in exactly the same spots that the Byte code calls c_str(). This makes sense, because in both places we get a character type back, and not a uint*_t type. If WideStringC had a raw_str() method, it would have to return uint32_t or similar. R=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1863593004
2016-04-05	Make StringData a templated class.	tsepez
	First step in making the same changes to CFX_WideString that we just made to CFX_ByteString. Review URL: https://codereview.chromium.org/1844073003
2016-04-05	Make down-conversion explicit from CFX_Widetring to CFX_WideStringC.	tsepez
	Companion to https://codereview.chromium.org/1853233002 BUG= Review URL: https://codereview.chromium.org/1857073002
2016-04-05	Rename GetCStr and GetPtr to match CFX_ByteString.	dsinclair
	This CL updates CFX_ByteStringC to use the more common c_str and raw_str instead of GetCStr and GetPtr. Review URL: https://codereview.chromium.org/1857713003
2016-04-04	Make down-conversion explicit from CFX_ByteString to CFX_ByteStringC.	tsepez
	Having this happen implicitly can be dangerous because the lifetime has to be considered; we should have caught the "red bots" in https://codereview.chromium.org/1847333004/#ps60001 at compile time. Review URL: https://codereview.chromium.org/1853233002
2016-04-01	Re-land "Use CFX_RetainPtr to ref count CFX_ByteString""	tsepez
	This reverts commit b33dfdf68bafa30e90a65fb71ff6b343202e0561. BUG= Review URL: https://codereview.chromium.org/1848993002
2016-04-01	Remove CFX_{Byte,Wide}String::Equal in favor of "==".	tsepez
	Makes the code slightly cleaner. Review URL: https://codereview.chromium.org/1846083002
2016-03-31	Revert "Use CFX_RetainPtr to ref count CFX_ByteString"chromium/2700 chromium/2699 chromium/2698 chromium/2697	tsepez
	This reverts commit ac88953dfa7c1a68c69989d61d7bc03c0595064b. Reason for revert: Strings borked. TBR=dsinclair@chromium.org Review URL: https://codereview.chromium.org/1852453004
2016-03-30	Use CFX_RetainPtr to ref count CFX_ByteStringchromium/2696	tsepez
	This moves the reference counts from an ad-hoc mechanism to being automatically tracked. Also: Make StringData::Create() always return non-null. Add better ctors for StringData itself. Consolidate copies into StringData methods. Simplify the concat() code. Rename/reorder some parameter names to be simpler. Review URL: https://codereview.chromium.org/1810823002
2016-03-29	Code change to avoid signed/unsigned mismatch warnings.	Wei Li
	This makes pdfium code on Linux and Mac sign-compare warning free. The warning flag will be re-enabled after checking on windows clang build. BUG=pdfium:29 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1841643002 .
2016-03-25	Remove FX_DWORD from core/ and delete definitionchromium/2695 chromium/2694 chromium/2693 chromium/2692	tsepez
	Review URL: https://codereview.chromium.org/1832173003
2016-03-23	Move core/include/fxcrt to core/fxcrt/include.	Dan Sinclair
	This CL moves the fxcrt code into the core/fxcrt directory. The only exception was fx_bidi.h which was moved into core/fxcrt as it is not used outside of core/. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1825953002 .