Age | Commit message (Collapse) | Author |
|
This CL moves the fxcrt code into the core/fxcrt directory. The only exception
was fx_bidi.h which was moved into core/fxcrt as it is not used outside of
core/.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1825953002 .
|
|
Add a few missing consts and remove a few extra externs.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1817283002 .
|
|
It isn't buying us anthing, and it looks strange in
a struct when other uint types are already present.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1821043003 .
|
|
This CL splits the file into individual classes and moves them into
core/fpdfapi/fpdf_page as needed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1811053002 .
|
|
This CL splits the fpdf_page.h header into the individual classes and moves
them to the correct core/fpdfapi locations.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1805663002 .
|
|
This Cl moves a bunch of the files from core/include/fpdfapi to their correct
location outside the core/include tree.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1805603002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1783933003 .
|
|
This CL moves the files in fpdfsdk/src/ up one level to fpdfsdk/ and fixes
up the include paths, include guards and build files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1799773002 .
|
|
Mainly change the code to avoid the warnings; in a few cases we have
to use explicit casts.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1783023002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1776913007 .
|
|
Also remove unnecessary casts.
BUG=pdfium:29
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1783933002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1778173002 .
|
|
CPDF_CryptoHandler was always a pure-virtual class, now it
is named as IPDF_ to indicate this.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1782673002 .
|
|
Also move ScopedFileStream, since it isn't specific to the
parser, and belongs with the fxcrt object it manipulates.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1780063003 .
|
|
It's not used anywhere in fpdfapi, and can become restricted
to fpdfoc/.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1776713004 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1781593003 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1773103003 .
|
|
This CL goes through the remaining list of list warnings and records why they
are currently blacklisted, or fixes and enables them.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1773733002 .
|
|
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1780503002 .
|
|
This reverts commit 06fae28d307fe051f0c7e890344cd487c2260910.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1775023003 .
|
|
This reverts commit d50095fb151688e119a7097aabce11e4b3d36244.
Reason for revert: build broken.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1774293002 .
|
|
BUG=
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1774753002 .
|
|
This reverts commit 594912241cd7d409b5f58a48ccffdc1904d844b2.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1769273002 .
|
|
It isn't sub-classed. Making GetNextChar() non-virtual
may save a virtual fn call per character if the compilers
aren't able to do so themselves.
Make members private, not protected.
BUG=
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1772973002 .
|
|
This reverts commit c582c0ddfea8ba01c8449ed7841cdb33c12e0a98.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1769263002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1772543003 .
|
|
This CL fixes up chromium-style warnings in fpdf_object.h Specifically, the
warnings fixed were:
* Complex constructor has an inlined body.
* Complex destructor has an inline body.
* virtual methods with non-empty bodies shouldn't be declared inline.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1764793002 .
|
|
Despite what the c++11 spec says, std::list::size() is
still O(n), not O(1).
R=dsinclair@chromium.org, ochang@chromium.org
Review URL: https://codereview.chromium.org/1763443003 .
|
|
Currently, there is a check that an object number is <= 0x1000000. If that
check fails, we end up putting the parser into a bad state and fail to load
documents. The object does not need to be in the XRef table, or referenced
from the document, just be in the document.
This Cl removes the size check and updates the various atoi calls to use a
uint32_t instead of an int32_t so we don't end up getting strange values when
converting from a string.
BUG=455199
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1755273002 .
|
|
This CL fixes and enables:
* readability/namespace
* readability/multiline_string
* readability/multiline_comment
* readability/inheritance
* readability/function
* readability/braces
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1747123002 .
|
|
Put these first, so later on more complicated classes can
have constructors that take these as arguments.
Add better constructors, and call appropriately. Also don't
be afraid to return these from methods since RVO.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1745683002 .
|
|
This CL removes duplicate forward declarations, removes extraneous declarations
and adds a couple of missing declarations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1741003002 .
|
|
Grepping for FX_BOOL and |==| on the same line gives
a very strong clue that the expression won't be out
of range of the |bool| type iteself.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1736323003 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1737593006 .
|
|
This reverts commit 3b8fdd34bdf57ec45291b77008a43249f838efcb.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1743753002 .
|
|
Too many rectangle types. Remove CPDF_Rect #define, and
make an equivalent point type in CFX, but stop short of
consolidating the N different forms of rectangles in CFX.
Also banish PDF_ClipFloat to the one .cpp file that needs it,
since it was in the vicinity of the .h file changes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1740923003 .
|
|
Get rid of types; use virutal functions instead of type based checking;
remove unused functions; change casts; simplify load()/UnicodeFromCharCode()/CharCodeFromUnicode() calling.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1729823004 .
|
|
Use virtual functions to replace type based logic; remove unused
functions; disable default copy constructor/assign operator.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1720003003 .
|
|
The only thing left are a couple of static methods.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711273002 .
|
|
For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead. Also, add As<Type> functions to avoid casting all over the places.
BUG=pdfium:397
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1709393002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1715583002 .
|
|
Not only unused, but ugly-looking.
Fix lint along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1709313002 .
|
|
Currently the states are numbers, use names instead to make the code
clearer where things are transitioning too.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1715483002 .
|
|
Tidy whitespace, add missing consts in a few places. Remove
a few pointless typedefs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1707953002 .
|
|
Exposes an iterator over the object list, but not the object
holder, since pages and forms inherit from object holder, and
we don't want to imply that there's only one thing that might
be iterated over for those classes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1700183002 .
|
|
Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.
Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide. Hence the "Holder" name.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701073002 .
|
|
Remove unused member functions and simplify calls to find tag parameters.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1681403007 .
|
|
Migrating this off of CFX_PrtList depends on first making
this saner. The tricky part is checking whether new
objects have been added to a partially-parsed layer. The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.
Fold together some duplicated blocks along the way.
Remove unused EstimateProgress() method.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1699443002 .
|
|
When there is no dictionary for marked content, it potientially may cause crash. But it is not happening now since 1) we now check for the returned dict parameter 2) the alloc function in pdfium does zero initialization.
BUG=pdfium:67
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1695633004 .
|
|
- NormalizeString() has 1 caller:
- CTextBaseLine::WriteOutput(), which has only 1 caller:
- CTextPage::WriteOutput(), which has only 1 caller:
- PDF_GetPageText_Unicode(), which has only 1 caller:
- PDF_GetPageText(), which has no callers.
Removing this also makes CheckRotate(), NormalizeCompositeChar(),
and CTextPage unused.
Removing those makes CTextBaseline() unused.
Removing that makes txtproc.h unused.
PDF_GetTextStream_Unicode also unused.
... and so on until entire files can be removed.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1689843002 .
|