Age | Commit message (Collapse) | Author |
|
Add default ctor so we don't have to zero these out.
Also, make CFX_VTemplate simpler.
Also, remove the Set() method in favor of assignment.
Also, remove CFX_FloatPoint define.
Also, remove unused (and wrong) CFX_VTemplate methods.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1733523003 .
|
|
This Cl changes the definition of FX_WORD and FX_DWORD to use the stdint
types. This will allow changing the uses on a directory basis to the
stdint types.
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1727203002 .
|
|
This is a wrapper which does (a) * (b) / (c). Inline the operations.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1726893002 .
|
|
This is just a wrapper for (a) / (b). Inline the divide.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1727793002 .
|
|
This define just multiples the two parameters together. Inline the *'s.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1729613003 .
|
|
This CL sorts all the includes in the xfa/ directory. There are a lot of IWYU
errors that have been fixed to make things compile again.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1722803002 .
|
|
- NDEBUG is more widely used in Chromium
- _DEBUG is not defined on Mac in Chromium
- Leaving _DEBUG in for standalone debug builds for the benefit of
third party libraries / Windows.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1721073004 .
|
|
Move FX_DOUBLE to fx_system.h to keep it with the others
until we remove it.
Having one memset/cpy wrapper is dubious, two are worse.
R=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1724523002 .
|
|
Stop short of removing it since it looks like it may be used
in some very hot paths.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1719543002 .
|
|
Merge it into CFX_FileBufferArchive, since both are in the
same header file and it is the only subclass.
Also, bTakeOver is always false, and the buf size is always
32K.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1712353002 .
|
|
This relands the CL at https://codereview.chromium.org/1710403002
Tests passed locally.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1717603003 .
|
|
This reverts commit 78353d5dbc0b0c9b2d6946005439a51efa7d108c.
Reason for revert Failed tests.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1719493002 .
|
|
The only thing left are a couple of static methods.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711273002 .
|
|
Always call ExpandBuf(), and if it returns, we know the
subsequent calculations won't overflow.
Also use std::unique_ptr, and fix unintentional copies thus
detected by its suppressed copy ctor in fsdk_baseform.cpp
Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().
Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.
Also move ByteStringC methods to CFX_ByteTextBuf sub-class.
Also re-order members, may pack tighter on 64-bits.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1710403002 .
|
|
Use/add CFX_{Byte,Wide}String::FromFoo() instead.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711893003 .
|
|
This CL runs the chromium sort-headers.py script over the non-xfa code.
XFA will be done after the includes have been updated to full paths.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711793002 .
|
|
Tidy whitespace, add missing consts in a few places. Remove
a few pointless typedefs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1707953002 .
|
|
This CL runs a script over the source and updates the include files to be
a full path from the pdfium/ directory.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707923002 .
|
|
Fix IWYU and include paths as we go.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701883004 .
|
|
One less Bezier.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1692413002 .
|
|
Bin the min, bin the min, bin the min, bin the min, bin
the min, bin the min, bin the min, bin the min, bin the
min, bin the min, bin the min, bin the min, bin the min.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1693913003 .
|
|
Replace array of heterogenous ints with array of struct.
Create a class for traversing a string.
Flip array when R2L and process with forward iterator always.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1682983002 .
|
|
The m_Operators array represents a heterogeneous instruction
stream, so leave it as a void* for now.
R=thestig@chromium.org, thestig@chromimum.org
Review URL: https://codereview.chromium.org/1676413002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1676913004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1671113002 .
|
|
Removes another case of a void* array where the even elements
mean one thing and the odd elements mean another. And even
the odd elements aren't consistently typed -- leave for later.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1671473002 .
|
|
One trivial edit in fx_basic.h
Includes both fixes for build breakage.
Review URL: https://codereview.chromium.org/1653253002 .
(cherry picked from commit 9b0a59d659d8083802385649ba74370d65c41e36)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1655423002 .
|
|
Unfortunately, it is still used on the xfa/ side, so
exclude it only for non-xfa builds.
Original Review URL: https://codereview.chromium.org/1618273004 .
(cherry picked from commit c64e4007ee4561ec2ed3ce986191caf9b024ef55)
TBR=ochang@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1631863003 .
|
|
unused progressive enum
unused members m_bFileStream, m_dwWordPos
Remove PDFWORD_* types
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634683003 .
|
|
Original Review URL: https://codereview.chromium.org/1580573002 .
(cherry picked from commit a505d9d3e13485e090e50d5d83f882fb707d3f48)
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1610163003 .
|
|
Original Review URL: https://codereview.chromium.org/1580493002 .
(cherry picked from commit 2a312f90dbf5da8b930dee814db786965792961a)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611683002 .
|
|
Original Review URL: https://codereview.chromium.org/1586203006 .
(cherry picked from commit f13d510cf267c27f4c123494de67670ec201cedc)
BUG=pdfium:361
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1603173004 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
(cherry picked from commit 9adfbb0920a258e916003b1ee9515e97879db82a)
Review URL: https://codereview.chromium.org/1577503002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567333003 .
(cherry picked from commit 4a24ad858484ecdf9b49481e63060e4d476cf1c7)
Review URL: https://codereview.chromium.org/1569783007 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1543413002 .
(cherry picked from commit 03f5040cbe03cc93e133cb98ecce6725e2679170)
Review URL: https://codereview.chromium.org/1555193002 .
|
|
TBR=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
(cherry picked from commit d20dfba2ae10e8aeb328328f09da79ff904110a8)
Review URL: https://codereview.chromium.org/1545183002 .
|
|
An email address contains user name part and host name part.
User name allows dash or underscore, but not leading/ending/double
period. Host name doesn't allow leading/ending/double
period either.
BUG=489107
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1530763005 .
(cherry picked from commit cc70b7b55c9edcd0ff038f59080699060fbbede1)
Review URL: https://codereview.chromium.org/1532303002 .
|
|
Orignal Review URL: https://codereview.chromium.org/1534003002 .
(cherry picked from commit fed9dd90c086c854ef13440e6022602eb9f91cfc)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1537463003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
(cherry picked from commit e385244f8cd6ae376f6b3cf1265a0795d5d30eff)
Review URL: https://codereview.chromium.org/1528763003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512763013 .
(cherry picked from commit e3c7c2b54348da4a6939f6672f6c6bff126815a7)
Review URL: https://codereview.chromium.org/1529553003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
(cherry picked from commit 1956a174020686f91cd3b34294e91f4560fe45aa)
Review URL: https://codereview.chromium.org/1526823002 .
|
|
R=thestig@chromium.org
TBR=thestig@chromium.org
BUG=566179
Original Review URL: https://codereview.chromium.org/1524983002 .
(cherry picked from commit 1eb7477b3e7c5cb7c54ca364810ab9a24acad4f9)
Review URL: https://codereview.chromium.org/1525793003 .
|
|
BUG=566179
TBR=thestig@chromium.org
Original Review URL: https://codereview.chromium.org/1523523002 .
(cherry picked from commit be8408f43bcfd69a74007a340a4c034004146c60)
Review URL: https://codereview.chromium.org/1518403003 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477663003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1471323004 .
|
|
Original Review URL: https://codereview.chromium.org/1459243002 .
(cherry picked from commit 6fc00fafcbac1fd5edd767fe2d4a8e4a9ef52806)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1461703008 .
|
|
This week's version. Mostly whitespace, but takes the
master version of core/src/fxge/ge/fx_ge_text.cpp
verbatim.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1462923004 .
|
|
Using Chromium's clang + build options, there's more override warnings.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1453643002 .
(cherry picked from commit 126ba519bdd489ec6c285d1410dcae773e8ef673)
Review URL: https://codereview.chromium.org/1458373002 .
|
|
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1449873003 .
(cherry picked from commit 3f148915d12f54a946a0c0bf526162b79c39d650)
Review URL: https://codereview.chromium.org/1452673002 .
|