Age | Commit message (Collapse) | Author |
|
Also remove one unnecessary member function.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1660523003 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1667433002 .
|
|
(Many more uses in XFA).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1653253002 .
|
|
Use the gennum field in the m_ObjectInfo map instead.
BUG=pdfium:111
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1654303002 .
|
|
Use the type field in the m_ObjectInfo map instead.
BUG=pdfium:111
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1650793002 .
|
|
- Generalise GetBits8()
- Get rid of C-style casts.
- Make CFX_DIBSource::SetDownSampleSize() non const. It's only overriden
once and called in one place and it doesn't make sense for it to be const.
- Get rid of a macro
- Make public member vars of CPDF_DIBSource private
- And others...
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1644403003 .
|
|
- Remove dead code.
- Add more public methods and remove friends.
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1566133002 .
|
|
Mainly use virtual functions to replace functions with switch statements.
Also remove a few unused functions and make some format changes.
BUG=pdfium:63
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634373003 .
|
|
This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1644633003 .
|
|
Original Review URL: https://codereview.chromium.org/1634123004 .
(cherry picked from commit f10ae634e7b198b18942baaf9f111f07cc8ce818)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1640473002 .
|
|
Make the two fundamental "object" types be enums.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1632143002 .
|
|
Replace with std::deque.
Make member naming more consistent.
R=ochang@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1618273004 .
|
|
Review URL: https://codereview.chromium.org/1634683003 .
(cherry picked from commit e24ea22700c9fc534d40cc510d59c453aa9d0ddb)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1632843004 .
|
|
Orignal Review URL: https://codereview.chromium.org/1630973002 .
(cherry picked from commit 0f68785be6af2b15109bb8a8f3bb7ebc040500d5)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1624343004 .
|
|
Original Review URL: https://codereview.chromium.org/1638493002 .
(cherry picked from commit 02056fae83c8136195c8eb2a00c3606f600a8b6a)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1632863002 .
|
|
m_bGetCharCodeOnly and m_bOutputHyphen are never re-assigned.
m_bNormalizeObjs is assigned in a method that is never called.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1618693009 .
|
|
The _CAPS class naming convention violates reserved
identifier rules.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1620523002 .
|
|
Prefer class names to be singular.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1612113003 .
|
|
Remove default args.
Remove unreachable code.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1601093009 .
|
|
Classes should be named after nouns, not verbs.
Also mark methods private, not protected.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611193003 .
|
|
Still used by XFA, so the merge will make this XFA only.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1580573002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1580493002 .
|
|
Fix the bugs by removing ParseNumber() entirely.
For PDFium's JavaScript bindings, we want to get out of the
numeric conversion business and inflict that on V8 as
possible, avoiding platform-specific issue in strtod().
For other uses, there is a FX_atof() which is similarly
buggy, but we can consolidate the use. Add an overloaded
FX_atof() to handle wide strings more simply.
BUG=pdfium:361
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1586203006 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1602323002 .
|
|
There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first.
BUG=pdfium:355
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1585533002 .
|
|
FreeType headers have to be included with macros defined in ftheaders.h.
Not doing so breaks when the FreeType header location changes as was the
case between FreeType 2.6.0 and 2.6.2.
Patch by jshin@chromium.org
BUG=pdfium:362
R=jshin@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1587333002 .
|
|
BUG=pdfium:360
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1585823003 .
|
|
Also fixes a potential issue in CPDF_Dictionary::ReplaceKey.
R=thestig@chromium.org
BUG=577030
Review URL: https://codereview.chromium.org/1582963003 .
|
|
This regressed in commit f6dafc9.
BUG=576915
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1582763002 .
|
|
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1575363007 .
|
|
Rename to CPDF_IndirectObjectHolder
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1576113003 .
|
|
BUG=pdfium:346
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1578543002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1570873005 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567333003 .
|
|
BUG=pdfium:343
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1569343002 .
|
|
Change the internal version to GetNextWordInternal().
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1558083002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1566553002 .
|
|
Also do some cleanups in affected files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1552583002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1555293002 .
|
|
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1549103002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1543413002 .
|
|
BUG=482206
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1551563002 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
|
|
BUG=pdfium:338
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1549043003 .
|
|
This reverts commit 2d63eaaa39bb3d402c658b2a6e0eae50a30f1d89.
Broke the Windows build, though it is likely the code is unused on
Windows too.
Review URL: https://codereview.chromium.org/1540993004 .
|
|
- Simplify remaining encoders.
- Hook up more of the encoding paths so failures get returned.
- Clean up code to not pass by non-const ref, use bools, etc.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1545563003 .
|
|
This improvements memory usage in case PDFs have sparse object numbers.
The map holds a struct that currently has only one member. The struct
will contain more members as other internal data structures get
converted.
BUG=pdfium:111
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1539573003 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540693002 .
|