Age | Commit message (Collapse) | Author |
|
This CL runs a script over the source and updates the include files to be
a full path from the pdfium/ directory.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707923002 .
|
|
Fix IWYU and include paths as we go.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701883004 .
|
|
Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.
Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide. Hence the "Holder" name.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701073002 .
|
|
Remove unused member functions and simplify calls to find tag parameters.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1681403007 .
|
|
Migrating this off of CFX_PrtList depends on first making
this saner. The tricky part is checking whether new
objects have been added to a partially-parsed layer. The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.
Fold together some duplicated blocks along the way.
Remove unused EstimateProgress() method.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1699443002 .
|
|
When there is no dictionary for marked content, it potientially may cause crash. But it is not happening now since 1) we now check for the returned dict parameter 2) the alloc function in pdfium does zero initialization.
BUG=pdfium:67
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1695633004 .
|
|
One less Bezier.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1692413002 .
|
|
Bin the min, bin the min, bin the min, bin the min, bin
the min, bin the min, bin the min, bin the min, bin the
min, bin the min, bin the min, bin the min, bin the min.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1693913003 .
|
|
Replace array of heterogenous ints with array of struct.
Create a class for traversing a string.
Flip array when R2L and process with forward iterator always.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1682983002 .
|
|
- NormalizeString() has 1 caller:
- CTextBaseLine::WriteOutput(), which has only 1 caller:
- CTextPage::WriteOutput(), which has only 1 caller:
- PDF_GetPageText_Unicode(), which has only 1 caller:
- PDF_GetPageText(), which has no callers.
Removing this also makes CheckRotate(), NormalizeCompositeChar(),
and CTextPage unused.
Removing those makes CTextBaseline() unused.
Removing that makes txtproc.h unused.
PDF_GetTextStream_Unicode also unused.
... and so on until entire files can be removed.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1689843002 .
|
|
The m_Operators array represents a heterogeneous instruction
stream, so leave it as a void* for now.
R=thestig@chromium.org, thestig@chromimum.org
Review URL: https://codereview.chromium.org/1676413002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1676913004 .
|
|
Remove CFX_PtrArray filelist.
Promote ScopedFileStream to .h file and use it.
Fix _CAPS names, bool returns, and put in anonymous namespace.
FX_CreateMemoryStream() can't return null, so remove checks.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1672153002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1671113002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1669113002 .
|
|
Removes another case of a void* array where the even elements
mean one thing and the odd elements mean another. And even
the odd elements aren't consistently typed -- leave for later.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1671473002 .
|
|
Original Review URL: https://codereview.chromium.org/1660633003 .
(cherry picked from commit e8ea737bf9ef95b406c74fc3b1120f3fa6c4e227)
Conflicts:
fpdfsdk/include/fsdk_baseform.h
fpdfsdk/src/fsdk_baseform.cpp
TBR=thestig@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1668483004 .
|
|
Also remove one unnecessary member function.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1660523003 .
(cherry picked from commit 6f358daa2e8b1639a1c3a3f07a449f8450197e8b)
Review URL: https://codereview.chromium.org/1667873002 .
|
|
One trivial edit in fx_basic.h
Includes both fixes for build breakage.
Review URL: https://codereview.chromium.org/1653253002 .
(cherry picked from commit 9b0a59d659d8083802385649ba74370d65c41e36)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1655423002 .
|
|
Use the gennum field in the m_ObjectInfo map instead.
BUG=pdfium:111
R=weili@chromium.org
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1654303002 .
(cherry picked from commit a620372c9e1d0ff825bcbe6620fe7e1b63c769c2)
Review URL: https://codereview.chromium.org/1653023004 .
|
|
Use the type field in the m_ObjectInfo map instead.
BUG=pdfium:111
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1650793002 .
(cherry picked from commit 93c196d868535f684007a7d3ed1f7146851a0ab9)
Review URL: https://codereview.chromium.org/1652083004 .
|
|
- Generalise GetBits8()
- Get rid of C-style casts.
- Make CFX_DIBSource::SetDownSampleSize() non const. It's only overriden
once and called in one place and it doesn't make sense for it to be const.
- Get rid of a macro
- Make public member vars of CPDF_DIBSource private
- And others...
TBR=thestig@chromium.org
Original Review URL: https://codereview.chromium.org/1644403003 .
(cherry picked from commit 487935f662ba4711caf1c2c06873b676fd3fba3e)
Review URL: https://codereview.chromium.org/1649243002 .
|
|
Mainly use virtual functions to replace functions with switch statements.
Also remove a few unused functions and make some format changes.
BUG=pdfium:63
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634373003 .
(cherry picked from commit df1ab41e000069dda7bf21527308f3bf41e126ca)
Review URL: https://codereview.chromium.org/1650493003 .
|
|
- Remove dead code.
- Add more public methods and remove friends.
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1566133002 .
(cherry picked from commit 9e8185948f7631515951770ca8778f42cc9fd2fc)
Review URL: https://codereview.chromium.org/1649233002 .
|
|
This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1644633003 .
(cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b)
Review URL: https://codereview.chromium.org/1648233002 .
|
|
kGray and such are much safer.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1638093002 .
|
|
Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634123004 .
|
|
Contains additional XFA-specific changes.
Original Review URL: https://codereview.chromium.org/1632143002 .
(cherry picked from commit 66a9dc9dd65ed2b9c7ede448d046b770140f16d5)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636503006 .
|
|
Unfortunately, it is still used on the xfa/ side, so
exclude it only for non-xfa builds.
Original Review URL: https://codereview.chromium.org/1618273004 .
(cherry picked from commit c64e4007ee4561ec2ed3ce986191caf9b024ef55)
TBR=ochang@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1631863003 .
|
|
unused progressive enum
unused members m_bFileStream, m_dwWordPos
Remove PDFWORD_* types
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634683003 .
|
|
Its members are assigned to, but never used in any calculations
(besides for other members).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1630973002 .
|
|
Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.
Also, PDFPARSE_NOSTREAM is unused.
Then we can remove m_Flags from PARSE_CONTEXT.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1638493002 .
|
|
Original Review URL: https://codereview.chromium.org/1618693009 .
(cherry picked from commit c818b5fc6cca9a7e1a2851b30e8a34f652ab0ea9)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1629593002 .
|
|
Original Review URL: https://codereview.chromium.org/1620523002 .
(cherry picked from commit d5712ac571f3487fe3f74617fdab007a11a09052)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1624553004 .
|
|
Orignal Review URL: https://codereview.chromium.org/1612113003 .
(cherry picked from commit 9ebc84109d7d2f7b81f06f19e5db20888e026c3b)
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1612243002 .
|
|
Original Review URL: https://codereview.chromium.org/1601093009 .
(cherry picked from commit da9355139b5dce270be02af31db326d60f488e8c)
Trivial conflicts/changes in fpdfeditpage.cpp and fpdfxfa_page.cpp.
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1613823003 .
|
|
Original Review URL: https://codereview.chromium.org/1611193003 .
(cherry picked from commit ca6d98f4dfe7d4fc506b72c91f122f471a53c878)
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1613163003 .
|
|
Original Review URL: https://codereview.chromium.org/1580573002 .
(cherry picked from commit a505d9d3e13485e090e50d5d83f882fb707d3f48)
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1610163003 .
|
|
Original Review URL: https://codereview.chromium.org/1580493002 .
(cherry picked from commit 2a312f90dbf5da8b930dee814db786965792961a)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611683002 .
|
|
Original Review URL: https://codereview.chromium.org/1586203006 .
(cherry picked from commit f13d510cf267c27f4c123494de67670ec201cedc)
BUG=pdfium:361
R=ochang@chromium.org
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1603173004 .
|
|
BUG=pdfium:350
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1608593003 .
|
|
TBR=weili@chromium.org
Original Review URL: https://codereview.chromium.org/1602323002 .
(cherry picked from commit b196c7bebad66c9938d2705ccf64961bcdd774e2)
Review URL: https://codereview.chromium.org/1607473008 .
|
|
There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first.
BUG=pdfium:355
TBR=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1585533002 .
(cherry picked from commit 90853cb1dfd1bf3803ec21cfae3e93948137be61)
Review URL: https://codereview.chromium.org/1602103004 .
|
|
FreeType headers have to be included with macros defined in ftheaders.h.
Not doing so breaks when the FreeType header location changes as was the
case between FreeType 2.6.0 and 2.6.2.
Patch by jshin@chromium.org
BUG=pdfium:362
TBR=jshin@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1587333002 .
(cherry picked from commit 56461d66054c53fe3abc88208eaf5d84e80e6551)
Review URL: https://codereview.chromium.org/1585233004 .
|
|
BUG=pdfium:360
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1585823003 .
(cherry picked from commit 5d5d9fe7bd1c9566b9d6570015b7c60894d9fc0c)
Review URL: https://codereview.chromium.org/1583073004 .
|
|
CPDF_Dictionary.
Also fixes a potential issue in CPDF_Dictionary::ReplaceKey.
TBR=thestig@chromium.org
BUG=577030
Original Review URL: https://codereview.chromium.org/1582963003 .
(cherry picked from commit cae57daaa0f7ed4c92e22c4e7ef30392393d1128)
Review URL: https://codereview.chromium.org/1587703003 .
|
|
This regressed in commit f6dafc9.
BUG=576915
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1582763002 .
(cherry picked from commit e02f30bb59b01c159b010fc5c6bb55e677aba8ce)
Review URL: https://codereview.chromium.org/1584663003 .
|
|
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1575363007 .
(cherry picked from commit 2fa5c7a8b6602bb2fe1df7cd09b12de666ca8a0a)
Review URL: https://codereview.chromium.org/1585773002 .
|
|
Review URL: https://codereview.chromium.org/1576113003 .
(cherry picked from commit fce548047a44c7015996874452f3e778bf64cad6)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1579693004 .
|
|
BUG=pdfium:346
TBR=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1578543002 .
(cherry picked from commit 401cd2dbaaa10790077de2fd70e8101b0bdd0f36)
Review URL: https://codereview.chromium.org/1578873002 .
|