Age | Commit message (Collapse) | Author |
|
m_bGetCharCodeOnly and m_bOutputHyphen are never re-assigned.
m_bNormalizeObjs is assigned in a method that is never called.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1618693009 .
|
|
The _CAPS class naming convention violates reserved
identifier rules.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1620523002 .
|
|
Prefer class names to be singular.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1612113003 .
|
|
Remove default args.
Remove unreachable code.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1601093009 .
|
|
Classes should be named after nouns, not verbs.
Also mark methods private, not protected.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611193003 .
|
|
Still used by XFA, so the merge will make this XFA only.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1580573002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1580493002 .
|
|
Fix the bugs by removing ParseNumber() entirely.
For PDFium's JavaScript bindings, we want to get out of the
numeric conversion business and inflict that on V8 as
possible, avoiding platform-specific issue in strtod().
For other uses, there is a FX_atof() which is similarly
buggy, but we can consolidate the use. Add an overloaded
FX_atof() to handle wide strings more simply.
BUG=pdfium:361
R=jochen@chromium.org
Review URL: https://codereview.chromium.org/1586203006 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1602323002 .
|
|
There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first.
BUG=pdfium:355
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1585533002 .
|
|
FreeType headers have to be included with macros defined in ftheaders.h.
Not doing so breaks when the FreeType header location changes as was the
case between FreeType 2.6.0 and 2.6.2.
Patch by jshin@chromium.org
BUG=pdfium:362
R=jshin@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1587333002 .
|
|
BUG=pdfium:360
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1585823003 .
|
|
Also fixes a potential issue in CPDF_Dictionary::ReplaceKey.
R=thestig@chromium.org
BUG=577030
Review URL: https://codereview.chromium.org/1582963003 .
|
|
This regressed in commit f6dafc9.
BUG=576915
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1582763002 .
|
|
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1575363007 .
|
|
Rename to CPDF_IndirectObjectHolder
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1576113003 .
|
|
BUG=pdfium:346
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1578543002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1570873005 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567333003 .
|
|
BUG=pdfium:343
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1569343002 .
|
|
Change the internal version to GetNextWordInternal().
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1558083002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1566553002 .
|
|
Also do some cleanups in affected files.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1552583002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1555293002 .
|
|
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1549103002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1543413002 .
|
|
BUG=482206
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1551563002 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
|
|
BUG=pdfium:338
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1549043003 .
|
|
This reverts commit 2d63eaaa39bb3d402c658b2a6e0eae50a30f1d89.
Broke the Windows build, though it is likely the code is unused on
Windows too.
Review URL: https://codereview.chromium.org/1540993004 .
|
|
- Simplify remaining encoders.
- Hook up more of the encoding paths so failures get returned.
- Clean up code to not pass by non-const ref, use bools, etc.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1545563003 .
|
|
This improvements memory usage in case PDFs have sparse object numbers.
The map holds a struct that currently has only one member. The struct
will contain more members as other internal data structures get
converted.
BUG=pdfium:111
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1539573003 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540693002 .
|
|
Orignal Review URL: https://codereview.chromium.org/1539983002 .
(cherry picked from commit 0fa6fee0e48af8681f0cd50f6a9471ecc0a46c11)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1536123002 .
|
|
Apart from it never being initialized, note that m_status
is never set to 1, so the only path that references this
class can't be reached.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1537103002 .
|
|
An email address contains user name part and host name part.
User name allows dash or underscore, but not leading/ending/double
period. Host name doesn't allow leading/ending/double
period either.
BUG=489107
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1530763005 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1534003002 .
|
|
- Remove unused Clear() method.
- Replace Create() with actual ctors.
- Avoid const casts.
- Protect members.
- Add missing const in adjacent code.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1536623004 .
|
|
While reading free entries in v4 cross reference table, changing the
start_objnum caused crossref table built wrong.
BUG=569795
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1527823003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512763013 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
|
|
TBR=thestig@chromium.org
BUG=566179
Review URL: https://codereview.chromium.org/1524983002 .
|
|
BUG=566179
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1523523002 .
|
|
BUG=447331
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1514093002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1520643002 .
|
|
These are synonyms for CFX_Matrix.
Nothing but sed and manual deletion of 2 #defines in
fpdf_parser.h and fx_coordinates.h
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1513363002 .
|
|
BUG=pdfium:298
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
|