Age | Commit message (Collapse) | Author |
|
Stop short of removing it since it looks like it may be used
in some very hot paths.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1719543002 .
|
|
Merge it into CFX_FileBufferArchive, since both are in the
same header file and it is the only subclass.
Also, bTakeOver is always false, and the buf size is always
32K.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1712353002 .
|
|
This relands the CL at https://codereview.chromium.org/1710403002
Tests passed locally.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1717603003 .
|
|
This reverts commit 78353d5dbc0b0c9b2d6946005439a51efa7d108c.
Reason for revert Failed tests.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1719493002 .
|
|
The only thing left are a couple of static methods.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711273002 .
|
|
Always call ExpandBuf(), and if it returns, we know the
subsequent calculations won't overflow.
Also use std::unique_ptr, and fix unintentional copies thus
detected by its suppressed copy ctor in fsdk_baseform.cpp
Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().
Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.
Also move ByteStringC methods to CFX_ByteTextBuf sub-class.
Also re-order members, may pack tighter on 64-bits.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1710403002 .
|
|
For CPDF_PageObject and its subclasses, remove m_Type and use GetType() instead. Also, add As<Type> functions to avoid casting all over the places.
BUG=pdfium:397
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1709393002 .
|
|
Use/add CFX_{Byte,Wide}String::FromFoo() instead.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711893003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1715583002 .
|
|
Change implicit conversion to accessor function, remove unused function
and unused parameter, add a couple checks for null pointers, and some
cleanup.
BUG=pdfium:247
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1703183002 .
|
|
Not only unused, but ugly-looking.
Fix lint along the way.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1709313002 .
|
|
This CL updates include guards throughout the code base to be in the
chromium style.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707893004 .
|
|
Currently the states are numbers, use names instead to make the code
clearer where things are transitioning too.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1715483002 .
|
|
This CL runs the chromium sort-headers.py script over the non-xfa code.
XFA will be done after the includes have been updated to full paths.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1711793002 .
|
|
Tidy whitespace, add missing consts in a few places. Remove
a few pointless typedefs.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1707953002 .
|
|
Exposes an iterator over the object list, but not the object
holder, since pages and forms inherit from object holder, and
we don't want to imply that there's only one thing that might
be iterated over for those classes.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1700183002 .
|
|
This CL runs a script over the source and updates the include files to be
a full path from the pdfium/ directory.
BUG=pdfium:65
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1707923002 .
|
|
Fix IWYU and include paths as we go.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701883004 .
|
|
Eventually, we're going to expose an iterator over
CPDF_PageObjectList that we don't want to be inherited by
the CPDF_PageObjectHolder sub-classes: page and form.
Also, the operations that the object holder performs dealing
with inquiring about masks and such seem beyond the scope of
what a list would provide. Hence the "Holder" name.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1701073002 .
|
|
Remove unused member functions and simplify calls to find tag parameters.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1681403007 .
|
|
Migrating this off of CFX_PrtList depends on first making
this saner. The tricky part is checking whether new
objects have been added to a partially-parsed layer. The
old code used to do this by keeping track of the last
element in the list, and seeing if it changes. It's far
simpler to keep track of the last element processed, and
just keep looking for more objects after it with each pass.
Fold together some duplicated blocks along the way.
Remove unused EstimateProgress() method.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1699443002 .
|
|
When there is no dictionary for marked content, it potientially may cause crash. But it is not happening now since 1) we now check for the returned dict parameter 2) the alloc function in pdfium does zero initialization.
BUG=pdfium:67
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1695633004 .
|
|
One less Bezier.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1692413002 .
|
|
Bin the min, bin the min, bin the min, bin the min, bin
the min, bin the min, bin the min, bin the min, bin the
min, bin the min, bin the min, bin the min, bin the min.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1693913003 .
|
|
Replace array of heterogenous ints with array of struct.
Create a class for traversing a string.
Flip array when R2L and process with forward iterator always.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1682983002 .
|
|
- NormalizeString() has 1 caller:
- CTextBaseLine::WriteOutput(), which has only 1 caller:
- CTextPage::WriteOutput(), which has only 1 caller:
- PDF_GetPageText_Unicode(), which has only 1 caller:
- PDF_GetPageText(), which has no callers.
Removing this also makes CheckRotate(), NormalizeCompositeChar(),
and CTextPage unused.
Removing those makes CTextBaseline() unused.
Removing that makes txtproc.h unused.
PDF_GetTextStream_Unicode also unused.
... and so on until entire files can be removed.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1689843002 .
|
|
The m_Operators array represents a heterogeneous instruction
stream, so leave it as a void* for now.
R=thestig@chromium.org, thestig@chromimum.org
Review URL: https://codereview.chromium.org/1676413002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1676913004 .
|
|
Remove CFX_PtrArray filelist.
Promote ScopedFileStream to .h file and use it.
Fix _CAPS names, bool returns, and put in anonymous namespace.
FX_CreateMemoryStream() can't return null, so remove checks.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1672153002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1671113002 .
|
|
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1669113002 .
|
|
Removes another case of a void* array where the even elements
mean one thing and the odd elements mean another. And even
the odd elements aren't consistently typed -- leave for later.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1671473002 .
|
|
Original Review URL: https://codereview.chromium.org/1660633003 .
(cherry picked from commit e8ea737bf9ef95b406c74fc3b1120f3fa6c4e227)
Conflicts:
fpdfsdk/include/fsdk_baseform.h
fpdfsdk/src/fsdk_baseform.cpp
TBR=thestig@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1668483004 .
|
|
Also remove one unnecessary member function.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1660523003 .
(cherry picked from commit 6f358daa2e8b1639a1c3a3f07a449f8450197e8b)
Review URL: https://codereview.chromium.org/1667873002 .
|
|
One trivial edit in fx_basic.h
Includes both fixes for build breakage.
Review URL: https://codereview.chromium.org/1653253002 .
(cherry picked from commit 9b0a59d659d8083802385649ba74370d65c41e36)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1655423002 .
|
|
Use the gennum field in the m_ObjectInfo map instead.
BUG=pdfium:111
R=weili@chromium.org
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1654303002 .
(cherry picked from commit a620372c9e1d0ff825bcbe6620fe7e1b63c769c2)
Review URL: https://codereview.chromium.org/1653023004 .
|
|
Use the type field in the m_ObjectInfo map instead.
BUG=pdfium:111
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1650793002 .
(cherry picked from commit 93c196d868535f684007a7d3ed1f7146851a0ab9)
Review URL: https://codereview.chromium.org/1652083004 .
|
|
- Generalise GetBits8()
- Get rid of C-style casts.
- Make CFX_DIBSource::SetDownSampleSize() non const. It's only overriden
once and called in one place and it doesn't make sense for it to be const.
- Get rid of a macro
- Make public member vars of CPDF_DIBSource private
- And others...
TBR=thestig@chromium.org
Original Review URL: https://codereview.chromium.org/1644403003 .
(cherry picked from commit 487935f662ba4711caf1c2c06873b676fd3fba3e)
Review URL: https://codereview.chromium.org/1649243002 .
|
|
Mainly use virtual functions to replace functions with switch statements.
Also remove a few unused functions and make some format changes.
BUG=pdfium:63
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634373003 .
(cherry picked from commit df1ab41e000069dda7bf21527308f3bf41e126ca)
Review URL: https://codereview.chromium.org/1650493003 .
|
|
- Remove dead code.
- Add more public methods and remove friends.
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1566133002 .
(cherry picked from commit 9e8185948f7631515951770ca8778f42cc9fd2fc)
Review URL: https://codereview.chromium.org/1649233002 .
|
|
This is needed by Cl 1634373003 as the name collision with virtual functions
will be shown as warnings on Linux. Also, it is better to use
different names for different cases.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1644633003 .
(cherry picked from commit d45e7a51904164fb22049f0a7a80d2a94c06936b)
Review URL: https://codereview.chromium.org/1648233002 .
|
|
kGray and such are much safer.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1638093002 .
|
|
Introduce CPDF_Parser::Error.
Introduce CPDF_Color::Type.
Unused XFA_DATASETS and XFA_FORMS defines.
Move FPDF_CreateStandardSecurityHandler() prototype to header.
Delete prototype for nonexistent FPDF_CreatePubKeyHandler().
Make PBS_* defines local to .cpp file.
Tidy whitespace.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634123004 .
|
|
Contains additional XFA-specific changes.
Original Review URL: https://codereview.chromium.org/1632143002 .
(cherry picked from commit 66a9dc9dd65ed2b9c7ede448d046b770140f16d5)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1636503006 .
|
|
Unfortunately, it is still used on the xfa/ side, so
exclude it only for non-xfa builds.
Original Review URL: https://codereview.chromium.org/1618273004 .
(cherry picked from commit c64e4007ee4561ec2ed3ce986191caf9b024ef55)
TBR=ochang@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1631863003 .
|
|
unused progressive enum
unused members m_bFileStream, m_dwWordPos
Remove PDFWORD_* types
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1634683003 .
|
|
Its members are assigned to, but never used in any calculations
(besides for other members).
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1630973002 .
|
|
Then CPDF_Object::GetDirectType() becomes unused.
Then GetIndirectType() becomes unused.
Then PDFPARSE_TYPEONLY becomes unused.
Then we can remove hideous casts of ints to ptrs.
Also, PDFPARSE_NOSTREAM is unused.
Then we can remove m_Flags from PARSE_CONTEXT.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1638493002 .
|
|
Original Review URL: https://codereview.chromium.org/1618693009 .
(cherry picked from commit c818b5fc6cca9a7e1a2851b30e8a34f652ab0ea9)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1629593002 .
|
|
Original Review URL: https://codereview.chromium.org/1620523002 .
(cherry picked from commit d5712ac571f3487fe3f74617fdab007a11a09052)
TBR=ochang@chromium.org
Review URL: https://codereview.chromium.org/1624553004 .
|