Age | Commit message (Collapse) | Author |
|
This improvements memory usage in case PDFs have sparse object numbers.
The map holds a struct that currently has only one member. The struct
will contain more members as other internal data structures get
converted.
BUG=pdfium:111
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1539573003 .
(cherry picked from commit f6dafc90ec1a0df8d618efc68c0223f0cdd80ffb)
Review URL: https://codereview.chromium.org/1544913002 .
|
|
instead.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1540693002 .
(cherry picked from commit d866ab0b44a571c884fdd8ba5a5319adaf607559)
Review URL: https://codereview.chromium.org/1541563002 .
|
|
Rename CPDF_ImageCache to CPDF_ImageCacheEntry because it
represents a single entry, not the entire cache itself.
Delete unused ClearRenderCache method, and merge cache entry
clear() into its dtor.
Fix a broken size calculation.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1539983002 .
|
|
Original Review URL: https://codereview.chromium.org/1537103002 .
(cherry picked from commit f0f6a01ee3dcb592e4eeaadaa2ea52c2fce317ba)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1540683002 .
|
|
An email address contains user name part and host name part.
User name allows dash or underscore, but not leading/ending/double
period. Host name doesn't allow leading/ending/double
period either.
BUG=489107
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1530763005 .
(cherry picked from commit cc70b7b55c9edcd0ff038f59080699060fbbede1)
Review URL: https://codereview.chromium.org/1532303002 .
|
|
Orignal Review URL: https://codereview.chromium.org/1534003002 .
(cherry picked from commit fed9dd90c086c854ef13440e6022602eb9f91cfc)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1537463003 .
|
|
Original Review URL: https://codereview.chromium.org/1536623004 .
(cherry picked from commit 761660c4074269ac806d06c9bef70e4e9fb0eb29)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1531423002 .
|
|
While reading free entries in v4 cross reference table, changing the
start_objnum caused crossref table built wrong.
BUG=569795
TBR=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1527823003 .
(cherry picked from commit c89cd979fb8654d85b822909cba9263d5f13760c)
Review URL: https://codereview.chromium.org/1528153003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1520063002 .
(cherry picked from commit e385244f8cd6ae376f6b3cf1265a0795d5d30eff)
Review URL: https://codereview.chromium.org/1528763003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1512763013 .
(cherry picked from commit e3c7c2b54348da4a6939f6672f6c6bff126815a7)
Review URL: https://codereview.chromium.org/1529553003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1521563002 .
(cherry picked from commit 1956a174020686f91cd3b34294e91f4560fe45aa)
Review URL: https://codereview.chromium.org/1526823002 .
|
|
R=thestig@chromium.org
TBR=thestig@chromium.org
BUG=566179
Original Review URL: https://codereview.chromium.org/1524983002 .
(cherry picked from commit 1eb7477b3e7c5cb7c54ca364810ab9a24acad4f9)
Review URL: https://codereview.chromium.org/1525793003 .
|
|
BUG=566179
TBR=thestig@chromium.org
Original Review URL: https://codereview.chromium.org/1523523002 .
(cherry picked from commit be8408f43bcfd69a74007a340a4c034004146c60)
Review URL: https://codereview.chromium.org/1518403003 .
|
|
BUG=447331
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1514093002 .
Review URL: https://codereview.chromium.org/1515403003 .
|
|
Original Review URL: https://codereview.chromium.org/1520643002 .
(cherry picked from commit 7db2a535f163e7ce5995da12161ebd0214f0f75a)
Original Review URL: https://codereview.chromium.org/1511413008 .
(cherry picked from commit 168cfb7ee0f2abbd2bddb7e7d8b430a6d8c6c120)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1515613006 .
|
|
Review URL: https://codereview.chromium.org/1513363002 .
(cherry picked from commit f32c969bce6743fca1e7ff796b54a1692d26d7f0)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1519693002 .
|
|
BUG=pdfium:298
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1496703005 .
(cherry picked from commit 93181f9a20db7ac706bb9405750303db93762a5b)
Review URL: https://codereview.chromium.org/1514783002 .
|
|
Original Review URL: https://codereview.chromium.org/1518593002 .
(cherry picked from commit 035359cd8ddb555fa33b6133db4fd405e4660712)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1513103002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1477663003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1471323004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1463173003 .
|
|
Original Review URL: https://codereview.chromium.org/1459243002 .
(cherry picked from commit 6fc00fafcbac1fd5edd767fe2d4a8e4a9ef52806)
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1461703008 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1465663002 .
|
|
This week's version. Mostly whitespace, but takes the
master version of core/src/fxge/ge/fx_ge_text.cpp
verbatim.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1462923004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1458633004 .
(cherry picked from commit 0c8e6c1f39f20985a3efb17292e46c476194183a)
Review URL: https://codereview.chromium.org/1461693005 .
|
|
Using Chromium's clang + build options, there's more override warnings.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1453643002 .
(cherry picked from commit 126ba519bdd489ec6c285d1410dcae773e8ef673)
Review URL: https://codereview.chromium.org/1458373002 .
|
|
Instead of taking a const pointer, and then casting away the const-ness.
Also remove similar, but dead CPDF_InterForm methods.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1456763003 .
Review URL: https://codereview.chromium.org/1456823002 .
Review URL: https://codereview.chromium.org/1452843005 .
(cherry picked from commit 9c62cadff466f26307bd06ed1e9df2c1b5f25a32)
(cherry picked from commit 447946588d6bbd4d5bc34477a09dd983285c507e)
(cherry picked from commit b2a4c976841863e89804a2643eebccf881c57584)
Review URL: https://codereview.chromium.org/1457703002 .
|
|
This reverts commit 0569ab0b11b723d9bca4ddd642b0cf8828c4bdd1.
This changes the various comparisons of char >= '0' && char <= '9' and
char < '0' || char > '9' to use std::isdigit checks. It also cleans up
a handful of hex to digit conversions to call one common method.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1449873003 .
(cherry picked from commit 3f148915d12f54a946a0c0bf526162b79c39d650)
Review URL: https://codereview.chromium.org/1452673002 .
|
|
That refer to parent directories.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1434223002 .
(cherry picked from commit 22bc4227fbbda5a5e9abad2a2c0a98c04fe7f228)
Review URL: https://codereview.chromium.org/1439223003 .
|
|
During decoding, when an image decoder is encountered, any
subsequent decoders are ignored, but remain in the array. However,
later on CPDF_DIBSource::ValidateDictParam expects the image
decoder to be the last in the array, causing issues.
A check is also added in CPDF_DIBSource::GetScanline to ensure
that the calculated pitch value is <= the (4-aligned) pitch value in the
cached bitmap to prevent future issues.
Also cleans up some NULL usages.
BUG=552046
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1406943005 .
(cherry picked from commit 182d129bcee8f7731b9bbfde0064295ad3b37271)
Review URL: https://codereview.chromium.org/1436153003 .
|
|
The GetFontData() behavior in FPDF_SYSFONTINFO seems reasonable.
Also do some code cleanup.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425023003 .
(cherry picked from commit e0c16d7461ca8317433d93835e4c36a84157cbef)
Review URL: https://codereview.chromium.org/1438943002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1432863004 .
(cherry picked from commit 56e3da27d8bed8a6c03274b7b946e3f6d6ac11f4)
Review URL: https://codereview.chromium.org/1436843003 .
|
|
- Remove CPDF_Stream::Create() and checks that it might fail.
- Remove m_pCryptoHandler that's always a nullptr.
- Remove m_FileOffset that's always 0.
- Rename file version of InitStream() to InitStreamFromFile().
- Use IsMemoryBased() in more places.
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1415163009 .
(cherry picked from commit e6e16954f0cdc324849fca9da883be8f131b3834)
Review URL: https://codereview.chromium.org/1418493006 .
|
|
TBR=dsinclair@chromium.org
Review URL: https://codereview.chromium.org/1436573003 .
(cherry picked from commit c813e21d261c24867234107f2e2ca72e15cb2534)
Review URL: https://codereview.chromium.org/1406933007 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1430213002 .
(cherry picked from commit 8deeacd23872ecc132a0a678e344a018b5114a3a)
Review URL: https://codereview.chromium.org/1416113010 .
|
|
BUG=446715
R=thestig@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1353093003 .
Conflicts:
core/include/fpdfapi/fpdf_parser.h
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_embeddertest.cpp
samples/pdfium_test.cc
testing/embedder_test.cpp
testing/embedder_test.h
Review URL: https://codereview.chromium.org/1412083010 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1408063016 .
(cherry picked from commit 6d9979dc685e3b67b0a6d9946376e026d75d3e47)
Review URL: https://codereview.chromium.org/1418503020 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1420693004 .
(cherry picked from commit 37e4a11e58257b757bec2700bc53facc59d0b845)
Review URL: https://codereview.chromium.org/1423583005 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1426403008 .
(cherry picked from commit 94a4956f7aadc10fe6dd8451e965bd7447985b76)
Review URL: https://codereview.chromium.org/1410683013 .
|
|
- In non-standalone builds, use the provided jpeg library.
- Run gn format over all the GN files.
- Also roll DEPS for buildtools to c2f2598.
- And fix XFA's lack of #includes.
BUG=541704
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425153006 .
(cherry picked from commit 34bb6c58fe60206a08dc0a1f37b7cfe83e8c762c)
Review URL: https://codereview.chromium.org/1434543003 .
|
|
This is just a straight-forward, partial merge. It does not
actually make checkdeps succeed.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1419373005 .
(cherry picked from commit 79f5a32175293620abe456554e10efb7c3f4e7c6)
Review URL: https://codereview.chromium.org/1409153007 .
|
|
Original Review URL: https://codereview.chromium.org/1409243012 .
(cherry picked from commit 0142f017d03df17fac98b586487cae23b6be05a6)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1429183002 .
|
|
Original Review URL: https://codereview.chromium.org/1412243015 .
(cherry picked from commit cbd6bba62777131e39e3c4fd2d0028b472fb94c9)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1416953005 .
|
|
This CL adds tests for the ReadHexString method of the syntax parser.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1433503002 .
(cherry picked from commit 71ad9a0028a183605fba734c48b4756d6caa7754)
Review URL: https://codereview.chromium.org/1424923007 .
|
|
I moved the declaration to be public, instead of having it implicit in one
file and defined in a seperate cpp file.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1410873009 .
(cherry picked from commit e948a4ee08b78e27da37bc12244fa1b66d927dc7)
Review URL: https://codereview.chromium.org/1432513002 .
|
|
- Remove dead code
- Stop using CFX_PtrArray
- Mark more things const
- Fix style nits
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1425093003 .
(cherry picked from commit c88c42f317c0e94c4c7b98949bfe1a495aef07a9)
Review URL: https://codereview.chromium.org/1430803003 .
|
|
(cherry picked from commit 3d59bd9d66d01eb39c30742bce67fa0376cb4ea8)
Review URL: https://codereview.chromium.org/1407903005 .
Conflicts:
core/include/fxcodec/fx_codec_provider.h
core/src/fxcodec/codec/codec_int.h
core/src/fxcodec/codec/fx_codec_jpeg.cpp
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1412713009 .
|
|
Add some consts and overrides along the way.
Group some statics together.
Tidy some unused vars.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1411683005 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1423343002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1419473006 .
|