Age | Commit message (Collapse) | Author |
|
Includes one array bounds fix.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1412583003 .
|
|
Get rid of cond ? TRUE : FALSE.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1405723003 .
(cherry picked from commit aff4635dad81bc319266d9d84b81552580cd2b65)
Review URL: https://codereview.chromium.org/1412793003 .
|
|
Also remove some gotos and move code into an anonymous namespace.
And then do the partial revert to avoid size_t going negative.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1356373003 .
Review URL: https://codereview.chromium.org/1400723002 .
(cherry picked from commit d03ba8d1a5928e8f3f6bd7da063b53b0bc40abfd)
(cherry picked from commit a398ca611d1925182ff6a4e8b2b43c277c364dc0)
Review URL: https://codereview.chromium.org/1406373002 .
|
|
- Use std::vector<JBig2ArithCtx> instead of storing pointers to arrays.
- Make CJBig2_SymbolDict's members private with accessors.
- Use std::vector<JBig2ArithCtx> in related places.
- Steal Chromium's vector_as_array() and use it as an adaptor as needed.
BUG=514891
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1388203003 .
(cherry picked from commit 3acb1ef909a22368507ed13817c4988c818e3aee)
Review URL: https://codereview.chromium.org/1401533004 .
|
|
TBR=dml@google.com
Review URL: https://codereview.chromium.org/1390863002 .
(cherry picked from commit fb0334733cf4a541636128f77f9fe8067a8c70f6)
Review URL: https://codereview.chromium.org/1395213003 .
|
|
Just get rid of the malloc altogether and use CJBig2_List instead.
BUG=540873
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1394933002 .
(cherry picked from commit 06f255ca4040f3d73cf09f1dbd63a3b167f6a4c1)
Review URL: https://codereview.chromium.org/1400663003 .
|
|
- Makes the cache be per-document
- Keys the cache on ObjNum and stream offset instead of keying on a pointer to the data (which can result in false cache hits).
- Makes it so the cache is only used for the globals stream.
- Reenable the cache.
R=dml@google.com
TBR=dml@google.com
BUG=pdfium:207
Review URL: https://codereview.chromium.org/1380243004 .
(cherry picked from commit f1b88e76134808f36f16b9e53a2e9dd89b12c8fd)
Review URL: https://codereview.chromium.org/1394373002 .
|
|
Also mark it private.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1395613003 .
(cherry picked from commit 8793b4a071fad51a770b93838e0752505b020e43)
Review URL: https://codereview.chromium.org/1397853002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1393823002 .
(cherry picked from commit a0f2b67bd659e3f1780edfac56d8754bca685d5f)
Review URL: https://codereview.chromium.org/1390883004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1396533002 .
(cherry picked from commit 80aa8c26887d98f654a9eecf7298663656cfc40f)
Review URL: https://codereview.chromium.org/1396743002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1382613003 .
(cherry picked from commit 8a9ce5778e0789beb7ba15a62c592a353a51bcdd)
Review URL: https://codereview.chromium.org/1397683002 .
|
|
many callers can tolerate CJBig2_ArithIntDecoder::decode() OOB failure.
BUG=539749, pdfium:209
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1384663007 .
(cherry picked from commit 35902e725aa6cc83a317c3b6fdd1926b81b8e44b)
Review URL: https://codereview.chromium.org/1396663003 .
|
|
Also change CJBig2_SymbolDict::DeepCopy() to return a unique_ptr to
prevent a potential leak if the cache size was 0.
BUG=pdfium:207
R=tsepez@chromium.org, jbreiden@google.com
Review URL: https://codereview.chromium.org/1374633004 .
(cherry picked from commit fd12ec5584d9a17f310a2c0c408a438ef3b1ce63)
Review URL: https://codereview.chromium.org/1390673002 .
|
|
Check the image size before attempting to decode.
BUG=538103
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1377493005 .
(cherry picked from commit 9fb70fbded5c0bf4f5313a49fd3496b4d4fa71ca)
Review URL: https://codereview.chromium.org/1379233003 .
|
|
BUG=pdfium:207
Original author: jbreiden@google.com
Original CL: http://codereview.chromium.org/1362133003/
TBR=jbreiden@google.com
Review URL: https://codereview.chromium.org/1382073002 .
(cherry picked from commit 7886d8dcf3bc9ef9b51e733d77bd3243ef32adb8)
Review URL: https://codereview.chromium.org/1379603004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1359013003 .
(cherry picked from commit ce37d7347f1ab4c9fc1f48a137628da641bb4f14)
Review URL: https://codereview.chromium.org/1386473002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1368153003 .
(cherry picked from commit 0fef7dd405ac85660dbeddd2e47620daffa70cb5)
Review URL: https://codereview.chromium.org/1381633003 .
|
|
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1367633005 .
(cherry picked from commit 39cd934a4705f69c30e1bbf13eab347f66999020)
Review URL: https://codereview.chromium.org/1370273002 .
|
|
- Remove dead code
- Use unique_ptr
BUG=pdfium:202
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1365903002 .
(cherry picked from commit 01c1e54a506329b36f87b0e37d3b419b70973342)
Review URL: https://codereview.chromium.org/1371513002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1359233002 .
(cherry picked from commit 630a28442364f03c1d3d9b48873da42755e1fddf)
Review URL: https://codereview.chromium.org/1364083004 .
|
|
R=tsepez@chromium.org
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1332193002 .
(cherry picked from commit da0938f8671958aba0522a69fc687a7bbb01b435)
Review URL: https://codereview.chromium.org/1350453002 .
|
|
- FX_Alloc() can't fail and return.
- Use unique_ptr / remove gotos.
- NULL -> nullptr.
- Combine common code.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1337823003 .
(cherry picked from commit d15cda90f598ce52fa601552577ef7fd8a89fce3)
Review URL: https://codereview.chromium.org/1349463002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1338573002 .
(cherry picked from commit a5fde67ea3c9d20d3f19354ec9e7e1be600d7589)
Review URL: https://codereview.chromium.org/1350463002 .
|
|
Also convert some FX_AllocOrDie() calls to FX_Alloc().
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1332173002 .
(cherry picked from commit 6aca3e209ff6148f1d77b86b8b97d3bdf18e3eba)
Review URL: https://codereview.chromium.org/1344233002 .
|
|
Credit to karl at skomski.com for the initial version of the CL.
BUG=527174
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1305033006 .
(cherry picked from commit 89d8b4681ce98894a1ee1a6cf4bae77e00d28797)
Review URL: https://codereview.chromium.org/1331303002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1326953006 .
(cherry picked from commit 70f4404e9a9e69afdfdd07715aa946f6561ce0cb)
Review URL: https://codereview.chromium.org/1336783002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1327983003 .
(cherry picked from commit 6087a2f18e0c779c1bae62812801cee98fe8a09d)
Review URL: https://codereview.chromium.org/1335793003 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1319713003 .
(cherry picked from commit 800bf5ac07305ccf9c9522c8c76f728a4fd99da5)
Review URL: https://codereview.chromium.org/1332153002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1328643002 .
(cherry picked from commit 9df5d9701ddf75f8050566132694bf435efb3ca0)
Review URL: https://codereview.chromium.org/1319563003 .
|
|
r7830e9e.
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1321883002 .
(cherry picked from commit 5e4a5cc9ad76dc08d62fb1e10bdfb811f3720c43)
Review URL: https://codereview.chromium.org/1308163005 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1293393002 .
(cherry picked from commit 7830e9e38d4155335b7287f8edb2b3a6cece5b01)
Review URL: https://codereview.chromium.org/1303013004 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1284193005 .
(cherry picked from commit 632b807b386878afdb42322f0037f8998306f4a9)
Review URL: https://codereview.chromium.org/1301453002 .
|
|
No behavior change.
Generated by:
find . -name '*.cpp' -o -name '*.h' | \
grep -E -v 'third_party|thirdparties|lpng_v163|tiff_v403' | \
xargs ../../buildtools/mac/clang-format -i
Then manually merged https://codereview.chromium.org/1269223002/
See thread "tabs vs spaces" on pdfium@googlegroups.com for discussion.
BUG=none
|
|
Original Review URL: https://codereview.chromium.org/1257503002
Original Review URL: https://codereview.chromium.org/1253603002
Manual merge for:
core/include/fxge/fx_font.h
core/src/fxcodec/codec/codec_int.h
fpdfsdk/src/javascript/PublicMethods.cpp
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1248153004 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1247213002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1195363002 .
(cherry picked from commit 21bf242a31eff79f754c5e9c3b41c52e33483bb0)
Review URL: https://codereview.chromium.org/1235753006 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1192743004.
(cherry picked from commit cfac954abcab7caf47d3fa3d641c553cba998271)
Review URL: https://codereview.chromium.org/1196783003.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1176333002.
(cherry picked from commit 0ef0de55657db8a83372ad8eb22d84c5893afc4c)
Review URL: https://codereview.chromium.org/1195943005.
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1173223002.
(cherry picked from commit 2b5e0d5b20654d116045484868c9e015ed698124)
Review URL: https://codereview.chromium.org/1186673004.
|
|
Only manual merge was core/src/fpdfapi/fpdf_parser/fpdf_parser_objects.cpp
follwed by scripts.
Original Review URL: https://codereview.chromium.org/1179693003.
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1179953002.
|
|
Original Review URL: https://codereview.chromium.org/1171733003
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1178613002.
|
|
Near-automatic merge, plus re-running scripts to update
additional usage.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1172793002
|
|
Original Review URL: https://codereview.chromium.org/1147353006
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1152693005
|
|
This issue is trigged by the conversion from unsigned int to signed int.
A large unsigned int is converted to int. It's represented as a negative
int which is used in the condition of while later.
BUG=482639
R=brucedawson@chromium.org
Review URL: https://codereview.chromium.org/1146913003
|
|
1. New size should be larger than old size in JBig2_Realloc.
2. Arguments are integers but parameters are size_t in JBIG2_memset.
After integer overflows, it will be presented as a huge
unsigned number on 64 bits system.
BUG=483981
R=brucedawson@chromium.org, tsepez@chromium.org
Review URL: https://codereview.chromium.org/1148643002
|
|
Integer overflow in CJBig2_Image::expand.
It causes the size of reallocated is not
expected.
BUG=483981
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1131023008
|
|
Also fix a few nits and other errors along the way.
Review URL: https://codereview.chromium.org/1098583002
Review URL: https://codereview.chromium.org/1135713004
(cherry picked from commit f0a169e6fd5718995fa6ef8749c8d16cdad84985)
(cherry picked from commit 470408c2ffe71e99cebad0d1d6887f1723f02cef)
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1133453006
|
|
BUG=476107
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1080893002
|
|
Original URL: https://codereview.chromium.org/837093002
(cherry picked from commit f8105c665856863ad95da37fee6c12b98b953e2c)
Review URL: https://codereview.chromium.org/967033002
|
|
Original at URL: https://codereview.chromium.org/810883005
Note that the new code in XFA introduces many more of these, to be handled
separately.
TBR=brucedawson@chromium.org
TBR=thestig@chromium.org
BUG=https://code.google.com/p/pdfium/issues/detail?id=102
Review URL: https://codereview.chromium.org/842223004
|