Age | Commit message (Collapse) | Author |
|
Make the two fundamental "object" types be enums.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1632143002 .
|
|
Replace with std::deque.
Make member naming more consistent.
R=ochang@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1618273004 .
|
|
Review URL: https://codereview.chromium.org/1634683003 .
(cherry picked from commit e24ea22700c9fc534d40cc510d59c453aa9d0ddb)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1632843004 .
|
|
Orignal Review URL: https://codereview.chromium.org/1630973002 .
(cherry picked from commit 0f68785be6af2b15109bb8a8f3bb7ebc040500d5)
R=thestig@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1624343004 .
|
|
Original Review URL: https://codereview.chromium.org/1638493002 .
(cherry picked from commit 02056fae83c8136195c8eb2a00c3606f600a8b6a)
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/1632863002 .
|
|
This is a regression from commit 90853cb.
BUG=pdfium:365
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1617043004 .
|
|
m_bGetCharCodeOnly and m_bOutputHyphen are never re-assigned.
m_bNormalizeObjs is assigned in a method that is never called.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1618693009 .
|
|
The _CAPS class naming convention violates reserved
identifier rules.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1620523002 .
|
|
Prefer class names to be singular.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1612113003 .
|
|
Remove default args.
Remove unreachable code.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1601093009 .
|
|
Classes should be named after nouns, not verbs.
Also mark methods private, not protected.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1611193003 .
|
|
Still used by XFA, so the merge will make this XFA only.
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1580573002 .
|
|
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1580493002 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1602323002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1581393011 .
|
|
There are multiple functions in CPDF_Object class which can cause infinite loop due to recursively calling circular indirect objects. Fix them by deference indirect object first.
BUG=pdfium:355
R=jun_fang@foxitsoftware.com, thestig@chromium.org
Review URL: https://codereview.chromium.org/1585533002 .
|
|
Although trailer's size value is required by spec, other readers such as
Acrobat or libpoppler can handle without it. Loose up the check to be
more tolerant.
BUG=pdfium:213
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1582193002 .
|
|
BUG=pdfium:360
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1585823003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1582903004 .
|
|
Also fixes a potential issue in CPDF_Dictionary::ReplaceKey.
R=thestig@chromium.org
BUG=577030
Review URL: https://codereview.chromium.org/1582963003 .
|
|
Avoid invalidating iterators by deferring the std::map operations.
Also remove unused PDF_ReplaceFull().
BUG=577030
R=ochang@chromium.org
Review URL: https://codereview.chromium.org/1581963004 .
|
|
This regressed in commit f6dafc9.
BUG=576915
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1582763002 .
|
|
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1575363007 .
|
|
Rename to CPDF_IndirectObjectHolder
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1576113003 .
|
|
CPDF_SyntaxParser::GetObject() may enter into an infinite loop when a
signature dictionary doesn't have 'Contents' field. Add a check to
avoid that.
BUG=pdfium:344
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1575833004 .
|
|
BUG=pdfium:346
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1578543002 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1570873005 .
|
|
Replaces CFX_CMapByteStringToPtr. XFA still uses CFX_CMapByteStringToPtr
so it's not completely removed just yet.
Adds begin()/end() to CPDF_Dictionary and removes the
GetStartPos()/GetNextElement() functions to traverse the dictionary.
Callers are changed accordingly. AddValue() is also removed.
R=tsepez@chromium.org, thestig@chromium.org
Review URL: https://codereview.chromium.org/1541703003 .
|
|
Fix lint errors along the way.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567343002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1572733002 .
|
|
Make m_InternalStage an enum.
Use safe types to detect overflow.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1568373003 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1567333003 .
|
|
BUG=pdfium:343
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1569343002 .
|
|
TBR=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1570973002 .
|
|
Remove unused enum.
Don't begin struct names with underscore.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1570133004 .
|
|
Some bits regressed in commit 338805f.
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1544963002 .
|
|
Remove unused m_pContrastRamps.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1564783003 .
|
|
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1563673002 .
|
|
Change the internal version to GetNextWordInternal().
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1558083002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1566553002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1555293002 .
|
|
BUG=pdfium:325
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1543043003 .
|
|
R=weili@chromium.org
Review URL: https://codereview.chromium.org/1549103002 .
|
|
When cross reference sections form a loop, our code will enter an
infinite loop. Add detection and exit code for v4 cross reference loading.
V5 loading was done previously.
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1558093002 .
|
|
R=tsepez@chromium.org
Review URL: https://codereview.chromium.org/1543413002 .
|
|
BUG=482206
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1551563002 .
|
|
cross-reference table
BUG=pdfium:342
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/1550753002 .
|
|
TBR=weili@chromium.org
Review URL: https://codereview.chromium.org/1548963004 .
|
|
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/1547833002 .
|
|
Otherwise CheckLinearizedFirstPage() has no other callers.
BUG=pdfium:330
R=jun_fang@foxitsoftware.com
Review URL: https://codereview.chromium.org/1543193002 .
|